Attention is currently required from: pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email )
Change subject: rtp2trau_hr16: set D bits correctly
......................................................................
Patch Set 1:
(1 comment)
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/37150/comment/94295314_fe5bd3e9
PS1, Line 428: osmo_pbit2ubit(tf->d_bits, data, 112);
> where does this 112 come from?
It is the number of bits in a GSM-HR codec frame. In the opposite direction (osmo_ubit2pbit() call in trau2rtp_hr16()) the existing code already used this raw number 112 prior to my changes, hence I thought it was OK. But if having a raw number like this in here is bad, what should I change it to? I don't see any definitions in Osmocom headers for number of bits in the frame of different codecs - should I put GSM_HR_BYTES*8 in here?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458
Gerrit-Change-Number: 37150
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Jun 2024 15:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37148?usp=email )
Change subject: rtp2trau_hr16: fix UFE bit setting
......................................................................
rtp2trau_hr16: fix UFE bit setting
Per TS 48.061 section 5.1.4.1.1, UFE=1 means UL was good and UFE=0
means UL was bad. In the absence of logic that reports the actual
state of UL, we need to tell the BTS that UL was good (like we do
for FR & EFR) - hence set UFE=1.
Change-Id: Ibeb8db332f2e20806bebb077844a509064b2d89d
---
M src/trau/trau_rtp_conv.c
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c
index 5c87c46..c70736d 100644
--- a/src/trau/trau_rtp_conv.c
+++ b/src/trau/trau_rtp_conv.c
@@ -407,7 +407,7 @@
tf->c_bits[15] = 0; /* C16: SP */
tf->c_bits[16] = 0; /* C17: DTXd shall not be applied */
} else {
- tf->c_bits[11] = 0; /* C12: UFE */
+ tf->c_bits[11] = 1; /* C12: UFE */
tf->c_bits[12] = 1; /* C13: spare */
tf->c_bits[13] = 1; /* C14: spare */
tf->c_bits[14] = 1; /* C15: spare */
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37148?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ibeb8db332f2e20806bebb077844a509064b2d89d
Gerrit-Change-Number: 37148
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: osmith.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37175?usp=email )
Change subject: OBS: fix using --conflict-pkgname
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37175?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I4ddb2e9adc25e7e8e8c9d17236b76d9f2e9c2a9c
Gerrit-Change-Number: 37175
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Jun 2024 14:55:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37172?usp=email )
Change subject: OBS: update_obs_project: add --exclude-package
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37172?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: If02fd38da05113e28ee401d592edfc7528388308
Gerrit-Change-Number: 37172
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Jun 2024 14:54:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37179?usp=email )
Change subject: OBS: get_git_version: debian/changelog as fallback
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37179?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I3a284b50ca62a2faff16702b7108ca391229caf1
Gerrit-Change-Number: 37179
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Jun 2024 14:48:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
