June 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: library/SDP_Templates: Add templates for precondition qos attributes

by pespin

Attention is currently required from: Hoernchen, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37257?usp=email ) Change subject: library/SDP_Templates: Add templates for precondition qos attributes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I656ec1fa77bf3390a690fb0ed385d0be95c0f6b4 Gerrit-Change-Number: 37257 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 25 Jun 2024 09:17:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: trau_rtp_conv: add support for HRv1 in 8k format

by falconia

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: trau_rtp_conv: add support for HRv1 in 8k format ...................................................................... trau_rtp_conv: add support for HRv1 in 8k format GSM 08.61 defines two alternative Abis transport formats for HRv1 codec, using either 16 kbit/s or 8 kbit/s submultiplexing, as chosen by each BSS hardware manufacturer. libosmotrau previously supported TRAU<->RTP conversion only for 16k format - add support for HRv1 in 8k submux format. Change-Id: I8ee01b73360501ca380a8695cbc7070ceaaba1be --- M src/trau/trau_rtp_conv.c 1 file changed, 188 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/87/37287/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8ee01b73360501ca380a8695cbc7070ceaaba1be Gerrit-Change-Number: 37287 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newpatchset

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: trau_rtp_conv: add support for HRv1 in 8k format

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email ) Change subject: trau_rtp_conv: add support for HRv1 in 8k format ...................................................................... Patch Set 1: (1 comment) File src/trau/trau_rtp_conv.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16848): https://gerrit.osmocom.org/c/libosmo-abis/+/37287/comment/2871fdfd_10752fd7 PS1, Line 347: bad_frame: labels should not be indented -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8ee01b73360501ca380a8695cbc7070ceaaba1be Gerrit-Change-Number: 37287 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 25 Jun 2024 03:59:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in libosmo-abis[master]: trau_frame: fix 8k decoding

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37286?usp=email ) Change subject: trau_frame: fix 8k decoding ...................................................................... trau_frame: fix 8k decoding osmo_trau_frame_decode_8k() API was broken for most TRAU frame types: the processing begins with identifying the sync pattern, but the check for the leading 8 zeros in HRv1, AMR-low and AMR-6k7 formats was broken in that it was checking for 16 zero bits instead of 8. While at it, fix global namespace pollution: the bit8_0[] datum used in this logic was defined as global when it should be static. Change-Id: Idabc1283d477473b479f2d76d783ca9aeaf0af5d --- M src/trau/trau_frame.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/86/37286/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 389495c..98e26da 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1360,7 +1360,7 @@ #define TRAU8_FT_AMR_NO_SPEECH_CMR 0x14 /* 1, 0, 1, 0, 0 */ #define TRAU8_FT_AMR_475_515_590 0..7 -const uint8_t bit8_0[16] = { 0, }; +static const uint8_t bit8_0[8] = { 0, }; /*!< check sync pattern for hr/data/oam */ static bool is_hr(const ubit_t *bits) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idabc1283d477473b479f2d76d783ca9aeaf0af5d Gerrit-Change-Number: 37286 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: trau_rtp_conv: add support for HRv1 in 8k format

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email ) Change subject: trau_rtp_conv: add support for HRv1 in 8k format ...................................................................... trau_rtp_conv: add support for HRv1 in 8k format GSM 08.61 defines two alternative Abis transport formats for HRv1 codec, using either 16 kbit/s or 8 kbit/s submultiplexing, as chosen by each BSS hardware manufacturer. libosmotrau previously supported TRAU<->RTP conversion only for 16k format - add support for HRv1 in 8k submux format. Change-Id: I8ee01b73360501ca380a8695cbc7070ceaaba1be --- M src/trau/trau_rtp_conv.c 1 file changed, 188 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/87/37287/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index 91bf228..0dcd1b0 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -249,6 +249,112 @@ return 0; } +static bool hr8_xc_bits_good_parity(const ubit_t *xc_bits) +{ + int i; + unsigned int sum = 0; + + for (i = 0; i < 6; i++) { + if (xc_bits[i]) + sum++; + } + if (sum & 1) + return true; /* odd sum good */ + else + return false; /* even sum bad */ +} + +static void twts002_hr8_set_extra_flags(uint8_t *out, const struct osmo_trau_frame *tf) +{ + if (tf->c_bits[8]) /* DTXd */ + out[0] |= 0x08; + if (tf->xc_bits[4]) /* UFI */ + out[0] |= 0x02; +} + +/*! Generate an RFC 5993 or TW-TS-002 RTP payload for HRv1 + * from a decoded 8k TRAU frame. + * \param[out] out caller-provided output buffer + * \param[in] out_len length of out buffer in bytes + * \param[in] tf input TRAU frame in decoded form + * \param[in] emit_twts002 self-explanatory + * \returns number of bytes generated in 'out'; negative on error. */ +static int trau2rtp_hr8(uint8_t *out, size_t out_len, + const struct osmo_trau_frame *tf, bool emit_twts002) +{ + unsigned xc1_4; + + /* function interface preliminaries */ + if (tf->type != OSMO_TRAU8_SPEECH) + return -EINVAL; + if (out_len < GSM_HR_BYTES_RTP_RFC5993) + return -ENOSPC; + + /* Before considering anything else, if we have bad parity in + * frame classification bits or bad CRC in payload bits, + * we treat this frame as totally invalid: BFI with no data. */ + if (!hr8_xc_bits_good_parity(tf->xc_bits) || + osmo_crc8gen_check_bits(&gsm0860_efr_crc3, tf->d_bits, 44, + tf->crc_bits)) + goto bad_frame; + + /* classify this frame per XC1..XC4 */ + xc1_4 = (tf->xc_bits[0] << 3) | (tf->xc_bits[1] << 2) | + (tf->xc_bits[2] << 1) | (tf->xc_bits[3] << 0); + switch (xc1_4) { + case 0: + /* good speech frame (BFI=0, SID=0) */ + out[0] = FT_GOOD_SPEECH << 4; + if (emit_twts002) + twts002_hr8_set_extra_flags(out, tf); + osmo_ubit2pbit(out + 1, tf->d_bits, 112); + return GSM_HR_BYTES_RTP_RFC5993; + case 1: + /* valid SID frame (BFI=0, SID=2) */ + out[0] = FT_GOOD_SID << 4; + if (emit_twts002) + twts002_hr8_set_extra_flags(out, tf); + osmo_ubit2pbit(out + 1, tf->d_bits, 112); + /* RFC 5993 requires SID frames to be perfect, error-free */ + if (!emit_twts002) + osmo_hr_sid_reset(out + 1); + return GSM_HR_BYTES_RTP_RFC5993; + case 4: + case 5: + /* invalid SID frame (multiple BFI/SID combinations) */ + /* can be represented only in TW-TS-002, not in RFC 5993 */ + if (!emit_twts002) + return 0; + out[0] = FT_INVALID_SID << 4; + twts002_hr8_set_extra_flags(out, tf); + /* XC4 is TAF with this frame type */ + if (tf->xc_bits[3]) + out[0] |= 0x01; + return 1; /* short format per TW-TS-002 */ + case 6: + case 7: + /* bad speech frame (BFI=1, SID=0) */ + if (!emit_twts002) + return 0; + out[0] = FT_BFI_WITH_DATA << 4; + twts002_hr8_set_extra_flags(out, tf); + /* XC4 is TAF with this frame type */ + if (tf->xc_bits[3]) + out[0] |= 0x01; + osmo_ubit2pbit(out + 1, tf->d_bits, 112); + return GSM_HR_BYTES_RTP_RFC5993; + default: + bad_frame: + /* received garbage, emit BFI with no data */ + if (emit_twts002) { + out[0] = FT_NO_DATA << 4; + twts002_hr8_set_extra_flags(out, tf); + return 1; + } else + return 0; + } +} + /*! Generate the 31 bytes RTP payload for GSM-EFR from a decoded TRAU frame. * \param[out] out caller-provided output buffer * \param[in] out_len length of out buffer in bytes @@ -524,6 +630,69 @@ return 0; } +static int rtp2trau_hr8(struct osmo_trau_frame *tf, const uint8_t *data, size_t data_len) +{ + /* accept both TS 101 318 and RFC 5993 payloads */ + switch (data_len) { + case GSM_HR_BYTES: + break; + case GSM_HR_BYTES_RTP_RFC5993: + data++; + data_len--; + break; + case 0: + /* accept no-data input */ + break; + default: + return -EINVAL; + } + + /* FIXME: implement TRAU-UL frame generation if and when + * someone actually needs it in a program that uses + * this library. */ + if (tf->dir != OSMO_TRAU_DIR_DL) + return -ENOTSUP; + + tf->type = OSMO_TRAU8_SPEECH; + + /* C1..C5 */ + tf->c_bits[0] = 0; + tf->c_bits[1] = 0; + tf->c_bits[2] = 0; + tf->c_bits[3] = 1; /* UFE: good uplink */ + tf->c_bits[4] = 0; /* odd parity */ + /* C6..C9: spare bits */ + memset(tf->c_bits + 5, 1, 4); + + /* XC1..XC6 */ + if (osmo_hr_check_sid(data, data_len)) { + tf->xc_bits[0] = 0; + tf->xc_bits[1] = 0; + tf->xc_bits[2] = 0; + tf->xc_bits[3] = 1; + tf->xc_bits[4] = 0; + tf->xc_bits[5] = 0; /* odd parity */ + } else { + tf->xc_bits[0] = 0; + tf->xc_bits[1] = 0; + tf->xc_bits[2] = 0; + tf->xc_bits[3] = 0; + tf->xc_bits[4] = 0; + tf->xc_bits[5] = 1; /* odd parity */ + } + + memset(&tf->t_bits[0], 1, 2); + + if (data_len) + osmo_pbit2ubit(tf->d_bits, data, GSM_HR_BYTES * 8); + else + memset(tf->d_bits, 0, GSM_HR_BYTES * 8); + /* CRC is *not* computed by TRAU frame encoder - we have to do it */ + osmo_crc8gen_set_bits(&gsm0860_efr_crc3, tf->d_bits, 44, tf->crc_bits); + + return 0; +} + /* TS 48.060 Section 5.5.1.1.2 */ static int rtp2trau_efr(struct osmo_trau_frame *tf, const uint8_t *data, size_t data_len) { @@ -801,6 +970,8 @@ return trau2rtp_efr(out, out_len, tf, check_twts001(st)); case OSMO_TRAU16_FT_HR: return trau2rtp_hr16(out, out_len, tf, check_twts002(st)); + case OSMO_TRAU8_SPEECH: + return trau2rtp_hr8(out, out_len, tf, check_twts002(st)); default: return -EINVAL; } @@ -816,6 +987,8 @@ return rtp2trau_efr(tf, rtp, rtp_len); case OSMO_TRAU16_FT_HR: return rtp2trau_hr16(tf, rtp, rtp_len); + case OSMO_TRAU8_SPEECH: + return rtp2trau_hr8(tf, rtp, rtp_len); default: return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8ee01b73360501ca380a8695cbc7070ceaaba1be Gerrit-Change-Number: 37287 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

12 months

1
0
0 0

[S] Change in libosmo-abis[master]: trau_frame.c cosmetic: fix misleading comment

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37284?usp=email ) Change subject: trau_frame.c cosmetic: fix misleading comment ...................................................................... trau_frame.c cosmetic: fix misleading comment The 4 static const ubit_t arrays ft_hr_up_bits[5], ft_hr_down_bits[5], ft_data_hr_up_bits[5] and ft_data_hr_down_bits[5] contain frame type bit patterns that are defined in GSM 08.61 for half-rate speech and data channels with 16 kbit/s Abis transport, and are used as such in the code. However, the comment next to them stated incorrectly that these frame type bit patterns are for 8 kbit/s submultiplexing - fix it. Change-Id: Ic2f818a7f8bab4e82f239464511ab430906d4680 --- M src/trau/trau_frame.c 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/84/37284/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 9c9baa7..0be005a 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -82,7 +82,7 @@ TS48060_AMR_FC_NO_SPEECH = 0x0, }; -/* 16k sub-slots */ +/* GSM 08.60 frame types, 16k sub-slots */ static const ubit_t ft_fr_up_bits[5] = { 0, 0, 0, 1, 0 }; static const ubit_t ft_fr_down_bits[5] = { 1, 1, 1, 0, 0 }; static const ubit_t ft_data_up_bits[5] = { 0, 1, 0, 0, 0 }; @@ -96,7 +96,7 @@ static const ubit_t ft_d145s_bits[5] = { 1, 0, 1, 0, 0 }; static const ubit_t ft_edata_bits[5] = { 1, 1, 1, 1, 1 }; -/* 8k sub-slots */ +/* GSM 08.61 frame types, still on 16k sub-slots */ static const ubit_t ft_hr_up_bits[5] = { 0, 0, 0, 1, 1 }; static const ubit_t ft_hr_down_bits[5] = { 1, 1, 1, 0, 1 }; static const ubit_t ft_data_hr_up_bits[5] = { 0, 1, 0, 0, 1 }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic2f818a7f8bab4e82f239464511ab430906d4680 Gerrit-Change-Number: 37284 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: {de,en}code8_hr: fix totally broken functions

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37285?usp=email ) Change subject: {de,en}code8_hr: fix totally broken functions ...................................................................... {de,en}code8_hr: fix totally broken functions The functions decode8_hr() and encode8_hr() in trau_frame.c (encoding and decoding HRv1 TRAU frames in 8 kbit/s format) are available via osmo_trau_frame_decode_8k() and osmo_trau_frame_encode() public APIs, but they are not currently used anywhere in Osmocom. (OsmoMGW-E1 has no working support for HR codec, and there is no support for HRv1-8k in the TRAU<->RTP layer until next patch in this series.) Study of the code reveals that these functions were totally broken prior to this change: * The movement of Dn bits between trau_bits and fr->d_bits used wrong offsets for some of the bits (and even missed one group of bits entirely in the encoding direction), producing garbled codec frames. * The filling of XCn bits in the encoding direction was likewise garbled by use of wrong offset. * When encoding TRAU-UL frames in this format, bit C5 (odd parity) was set incorrectly. * The order of bits in fr->crc_bits array (Osmocom internal) was opposite the order needed for osmo_crc8gen_check_bits() and osmo_crc8gen_set_bits() functions - contrast with HRv1-16k functions that use sensible bit order for this fr->crc_bits array. Given that this HRv1-8k mode within TRAU frame encoding and decoding API was totally broken and not used anywhere, there are no compatibility concerns with changing aspects of this API such as CRC bit order. Change-Id: I7cf0275f2ff212e001db38d7b090f222f292cdb0 --- M src/trau/trau_frame.c 1 file changed, 49 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/85/37285/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 0be005a..389495c 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -780,15 +780,14 @@ } /* CRC0 .. CRC2 */ - fr->crc_bits[2] = trau_bits[82]; - fr->crc_bits[1] = trau_bits[83]; - fr->crc_bits[0] = trau_bits[84]; + memcpy(fr->crc_bits, trau_bits + 73, 3); /* D45 .. D48 */ - memcpy(fr->d_bits + d_idx, trau_bits + 85, 4); + memcpy(fr->d_bits + d_idx, trau_bits + 76, 4); + d_idx += 4; /* D49 .. D111 */ - for (i = 10; i < 10 + 10; i++) { + for (i = 10; i < 10 + 9; i++) { int offset = i * 8; memcpy(fr->d_bits + d_idx, trau_bits + offset + 1, 7); d_idx += 7; @@ -843,7 +842,7 @@ cbits_out[1] = 0; cbits_out[2] = 0; cbits_out[3] = 1; - cbits_out[4] = 1; + cbits_out[4] = 0; } else { cbits_out[0] = 0; cbits_out[1] = 0; @@ -855,7 +854,7 @@ /* XC1 .. XC2 */ memcpy(trau_bits + 1 * 8 + 6, fr->xc_bits, 2); /* XC3 .. XC6 */ - memcpy(trau_bits + 2 * 8 + 2, fr->xc_bits, 4); + memcpy(trau_bits + 2 * 8 + 2, fr->xc_bits + 2, 4); /* D1 .. D2 */ memcpy(trau_bits + 2 * 8 + 6, fr->d_bits, 2); d_idx += 2; @@ -868,12 +867,14 @@ }; /* CRC0 .. CRC2 */ - trau_bits[82] = fr->crc_bits[2]; - trau_bits[83] = fr->crc_bits[1]; - trau_bits[84] = fr->crc_bits[0]; + memcpy(trau_bits + 73, fr->crc_bits, 3); + + /* D45 .. D48 */ + memcpy(trau_bits + 76, fr->d_bits + d_idx, 4); + d_idx += 4; /* D49 .. D111 */ - for (i = 10; i < 10 + 10; i++) { + for (i = 10; i < 10 + 9; i++) { int offset = i * 8; memcpy(trau_bits + offset + 1, fr->d_bits + d_idx, 7); d_idx += 7; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7cf0275f2ff212e001db38d7b090f222f292cdb0 Gerrit-Change-Number: 37285 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: build config: add --disable-ortp option

by falconia

Attention is currently required from: laforge, neels. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email ) Change subject: build config: add --disable-ortp option ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > hmm, except, do we now need to update the build system to ensure that this option builds successfully? I am not asking Osmocom core team to test builds with this new option. **I** will be making a lot of builds with --disable-ortp, and if it breaks in the future, I will be the one to raise the alert and fix it. > Might reconsider the effort:benefit ratio...? What effort? I am not asking your team to add the new build variant to your CI, just merge the patch (providing the option) so I don't have to keep reapplying it to every new release and every sandbox build I do. With the two +1's from you and @osmith@sysmocom.de I can now merge the patch - but I'll give it another few days for further review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883 Gerrit-Change-Number: 36975 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jun 2024 01:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: build config: add --disable-ortp option

by neels

Attention is currently required from: falconia, laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email ) Change subject: build config: add --disable-ortp option ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > even if premature for osmo-bts, it's not harmful to add this compiler option; makes the build more f […] hmm, except, do we now need to update the build system to ensure that this option builds successfully? Might reconsider the effort:benefit ratio...? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883 Gerrit-Change-Number: 36975 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jun 2024 01:04:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: build config: add --disable-ortp option

by neels

Attention is currently required from: falconia, laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email ) Change subject: build config: add --disable-ortp option ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/36975/comment/9bf8806d_6a2c944d PS2, Line 25: and work with ortp dependency eliminated. (nitpick: very low word-count to information ratio... isn't this already all that needs to be said: ``` Add --disable-ortp option Assist distributions where it is incovenient to install libortp. ``` ) Patchset: PS2: even if premature for osmo-bts, it's not harmful to add this compiler option; makes the build more flexible without adverse effects AFAICT. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883 Gerrit-Change-Number: 36975 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Jun 2024 01:01:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024