June 2024 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-asterisk: pjsip.conf: Avoid advertising support for +g.3gpp.smsip

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37261?usp=email ) Change subject: ttcn3-asterisk: pjsip.conf: Avoid advertising support for +g.3gpp.smsip ...................................................................... ttcn3-asterisk: pjsip.conf: Avoid advertising support for +g.3gpp.smsip Asterisk doesn't so far support SMS over IMS, so avoid announcing it during REGISTER. Related: SYS#6981 Change-Id: I1546b7106d25ebfb1c92c1a27db1f44c51b0413a --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index f3ac374..019a6e5 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -94,7 +94,7 @@ expiration=600000 ims_aka=yes contact_user=volte_ims -contact_header_params=+g.3gpp.icsi-ref="urn\%3Aurn-7\%3A3gpp-service.ims.icsi.mmtel"\;+g.3gpp.smsip\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" +contact_header_params=+g.3gpp.icsi-ref="urn\%3Aurn-7\%3A3gpp-service.ims.icsi.mmtel"\;audio\;+sip.instance="<urn:gsma:imei:35876110-027790-0>" endpoint=volte_ims line=yes manual_register=yes -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1546b7106d25ebfb1c92c1a27db1f44c51b0413a Gerrit-Change-Number: 37261 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

12 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: pjsip.conf: Use reliable provisional responses if pee...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37262?usp=email ) Change subject: ttcn3-asterisk: pjsip.conf: Use reliable provisional responses if peer supports it ...................................................................... ttcn3-asterisk: pjsip.conf: Use reliable provisional responses if peer supports it The default 100rel=yes won't use reliable provisional responses unless the peer "requires" it, while we should instead be using them if the peer "supports" it. Related: SYS#6980 Change-Id: I40764e24f2c80ce48d6634e09797fefe97d99e51 --- M ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf index 019a6e5..8dc4e6c 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/pjsip.conf @@ -110,6 +110,7 @@ rewrite_contact=yes direct_media=no ims_aka=yes +100rel=peer_supported [volte_ims] type=auth -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I40764e24f2c80ce48d6634e09797fefe97d99e51 Gerrit-Change-Number: 37262 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

12 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: Set mp_ims_imei matching pjsip.conf

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37263?usp=email ) Change subject: ttcn3-asterisk: Set mp_ims_imei matching pjsip.conf ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id8bb7886ffcea506348496148e17f71cef1edc90 Gerrit-Change-Number: 37263 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 15:49:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: pjsip.conf: Use reliable provisional responses if pee...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37262?usp=email ) Change subject: ttcn3-asterisk: pjsip.conf: Use reliable provisional responses if peer supports it ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I40764e24f2c80ce48d6634e09797fefe97d99e51 Gerrit-Change-Number: 37262 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 15:49:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: pjsip.conf: Avoid advertising support for +g.3gpp.smsip

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37261?usp=email ) Change subject: ttcn3-asterisk: pjsip.conf: Avoid advertising support for +g.3gpp.smsip ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1546b7106d25ebfb1c92c1a27db1f44c51b0413a Gerrit-Change-Number: 37261 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 15:49:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: mgw: add TC_crcx_iufp_sendrecv and _recvonly

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283?usp=email ) Change subject: mgw: add TC_crcx_iufp_sendrecv and _recvonly ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00fd854f058f7f53e2f579e8481ca2b9253f08e3 Gerrit-Change-Number: 37283 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:10:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in osmo-mgw[master]: do not FAIL on CRCX in sendrecv mode

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37282?usp=email ) Change subject: do not FAIL on CRCX in sendrecv mode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37282?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic089485543c5c97a35c7ae24fe0f622bf57d1976 Gerrit-Change-Number: 37282 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:08:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_test: test a=ptime:20, not 40

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37280?usp=email ) Change subject: mgcp_test: test a=ptime:20, not 40 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia2292198bf6e3b72912afd69607654ca77fd549d Gerrit-Change-Number: 37280 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:07:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_test: add CRCX for IUFP in sendrecv

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37281?usp=email ) Change subject: mgcp_test: add CRCX for IUFP in sendrecv ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icdb1085b8e44ac4cff6c457163349b81e81bf765 Gerrit-Change-Number: 37281 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:07:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

[M] Change in libosmo-abis[master]: trau_rtp_conv: add support for HRv1 in 8k format

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email ) Change subject: trau_rtp_conv: add support for HRv1 in 8k format ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/37287/comment/fb5f8523_89cca9f6 PS2, Line 258: if (xc_bits[i]) : sum++; Can we do `sum += xc_bits[i]` here? Theoretically, this should be better in terms of performance. But we need to be sure that `xc_bits[i]` is either 0 or 1, otherwise the logic is wrong. Alternatively: `sum += (xc_bits[i] > 0)`. https://gerrit.osmocom.org/c/libosmo-abis/+/37287/comment/bf268b54_74af4765 PS2, Line 669: tf->xc_bits[0] = 0; cosmetic: maybe use designated initializers to make it shorter / more readable? ``` if (osmo_hr_check_sid(data, data_len)) tf->xc_bits = { [3] = 1 }; else tf->xc_bits = { [5] = 1 }; ``` Not critical, you can keep it as-is. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8ee01b73360501ca380a8695cbc7070ceaaba1be Gerrit-Change-Number: 37287 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:06:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

12 months

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024