May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: fill in some realistic data into listProf...

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email ) Change subject: SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult ...................................................................... SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult The listProfileInfoResult/profileInfoListOk currently onl has the profileName field populated, let's fill in some basic profile info to be more realistic. Related: SYS#6824 Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/36923/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 87ef86d..98846c5 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -814,15 +814,15 @@ listProfileInfoResult := { profileInfoListOk := { { - iccid := omit, + iccid := '123456789ABCDEFFAAAA'O, isdpAid := omit, - profileState := omit, + profileState := 1, /* enabled */ profileNickname := omit, serviceProviderName := omit, profileName := "testme", iconType := omit, icon := omit, - profileClass := omit, + profileClass := 2, /* operational */ notificationConfigurationInfo := omit, profileOwner := omit, dpProprietaryData := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 Gerrit-Change-Number: 36923 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use associationToken in addEimResult

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email ) Change subject: SGP32Definitions_Templates: use associationToken in addEimResult ...................................................................... SGP32Definitions_Templates: use associationToken in addEimResult When an eIM is added, the eUICC usually computes an associationToken, so it will be the common case that an associationToken is sent back to the eIM. Related: SYS#6824 Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/36922/1 diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 709a58f..87ef86d 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -945,7 +945,7 @@ euiccResult := { { addEimResult := { - addEimResultCode := 0 + associationToken := 123 } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f Gerrit-Change-Number: 36922 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pcsc: don't assume opts.pcsc_shared is present

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36921?usp=email ) Change subject: pcsc: don't assume opts.pcsc_shared is present ...................................................................... pcsc: don't assume opts.pcsc_shared is present Fixes running contrib/sim-rest-server.py: builtins.AttributeError: 'Namespace' object has no attribute 'pcsc_shared' Change-Id: I864f65849c5d43cf7c73e60f1935afdf4273f696 --- M pySim/transport/pcsc.py 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/36921/1 diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index 9198816..8a1e03c 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -57,7 +57,7 @@ raise ReaderError('No matching reader found for regex %s' % opts.pcsc_regex) self._con = self._reader.createConnection() - if not opts.pcsc_shared: + if not getattr(opts, "pcsc_shared", False): self._con = ExclusiveConnectCardConnection(self._con) def __del__(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I864f65849c5d43cf7c73e60f1935afdf4273f696 Gerrit-Change-Number: 36921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: contrib/sim-rest-client: don't crash without args

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36920?usp=email ) Change subject: contrib/sim-rest-client: don't crash without args ...................................................................... contrib/sim-rest-client: don't crash without args When running without an argument, let argparse print a nice usage error: $ ./sim-rest-client.py usage: sim-rest-client.py [-h] [-H HOST] [-p PORT] [-v] [-n SLOT_NR] {auth,info} ... sim-rest-client.py: error: the following arguments are required: {auth,info} Instead of: $ ./sim-rest-client.py Traceback (most recent call last): File "/usr/share/pysim/contrib/./sim-rest-client.py", line 185, in <module> main(sys.argv) File "/usr/share/pysim/contrib/./sim-rest-client.py", line 181, in main args.func(args) ^^^^^^^^^ AttributeError: 'Namespace' object has no attribute 'func' Change-Id: I92998d9b94dcfb9dcfc3da161fe5d8f45f242b78 --- M contrib/sim-rest-client.py 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/20/36920/1 diff --git a/contrib/sim-rest-client.py b/contrib/sim-rest-client.py index 7da2363..a9fabb8 100755 --- a/contrib/sim-rest-client.py +++ b/contrib/sim-rest-client.py @@ -162,6 +162,7 @@ parser.add_argument("-v", "--verbose", help="increase output verbosity", action='count', default=0) parser.add_argument("-n", "--slot-nr", help="SIM slot number", type=int, default=0) subp = parser.add_subparsers() + subp.required = True auth_p = subp.add_parser('auth', help='UMTS AKA Authentication') auth_p.add_argument("-c", "--count", help="Auth count", type=int, default=10) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I92998d9b94dcfb9dcfc3da161fe5d8f45f242b78 Gerrit-Change-Number: 36920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...

by nt2mku

Attention is currently required from: neels, nt2mku. Hello Jenkins Builder, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR or GSM-HR (v1) only and CTM text telephony is not supported, omit octet 3a. Ref: 3GPP TS 24.008, section 10.5.4.5.1. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c M tests/gsm0408/gsm0408_test.c 2 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 5 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is ...

by nt2mku

Attention is currently required from: neels, nt2mku. Hello Jenkins Builder, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ...................................................................... gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR or GSM-HR (v1) only and CTM text telephony is not supported, omit octet 3a. Ref: 3GPP TS 24.008, section 10.5.4.5.1. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 4 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: rsl: parse RSL_IE_OSMO_OSMUX_CID correctly

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36908?usp=email ) Change subject: rsl: parse RSL_IE_OSMO_OSMUX_CID correctly ...................................................................... rsl: parse RSL_IE_OSMO_OSMUX_CID correctly This IE has TLV format, even though the only valid form is a single value octet. To guard against pathological input with L=0 in this IE, we have to check the length explicitly with TLVP_PRES_LEN before accepting TLVP_VAL as if it was TV. Change-Id: I15fa75b6c30d7fa0bf50424d25fc47a088dada0a --- M src/common/rsl.c 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/common/rsl.c b/src/common/rsl.c index fa5f495..40690f0 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -2978,7 +2978,8 @@ struct tlv_parsed tp; struct gsm_lchan *lchan = msg->lchan; struct gsm_bts *bts = lchan->ts->trx->bts; - const uint8_t *payload_type, *speech_mode, *payload_type2, *osmux_cid, *csd_fmt; + const uint8_t *payload_type, *speech_mode, *payload_type2, *csd_fmt; + const uint8_t *osmux_cid = NULL; uint32_t connect_ip = 0; uint16_t connect_port = 0; int rc, inc_ip_port = 0; @@ -3029,7 +3030,9 @@ if (payload_type2) LOGPC(DRSL, LOGL_DEBUG, "payload_type2=%u ", *payload_type2); - osmux_cid = TLVP_VAL(&tp, RSL_IE_OSMO_OSMUX_CID); + /* this IE has TLV format when TV would have been good enough */ + if (TLVP_PRES_LEN(&tp, RSL_IE_OSMO_OSMUX_CID, 1)) + osmux_cid = TLVP_VAL(&tp, RSL_IE_OSMO_OSMUX_CID); if (osmux_cid) LOGPC(DRSL, LOGL_DEBUG, "osmux_cid=%u ", *osmux_cid); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I15fa75b6c30d7fa0bf50424d25fc47a088dada0a Gerrit-Change-Number: 36908 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: commands.py: Resolve possible variable use before assignment

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36899?usp=email ) Change subject: commands.py: Resolve possible variable use before assignment ...................................................................... Patch Set 1: (1 comment) File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/36899/comment/3115adc0_2e0acccc PS1, Line 222: raise ValueError('Cannot determine length of TLV-length') This looks wrong, as the code preceding this becomes dead/no-op. I guess this `raise` should be under another `else`? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id1a892c3446e472699e77f076c2414277e92c98d Gerrit-Change-Number: 36899 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 May 2024 16:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: fix update_exp: s/soft_uart.ok/soft_uart_test.ok

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36909?usp=email ) Change subject: fix update_exp: s/soft_uart.ok/soft_uart_test.ok ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2fb70b684978fa8a591d1d9e3cace919d590d1ef Gerrit-Change-Number: 36909 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 16:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: AMI: Implement AuthReq procedure

by pespin

Attention is currently required from: jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36871?usp=email ) Change subject: asterisk: AMI: Implement AuthReq procedure ...................................................................... Patch Set 3: (1 comment) File asterisk/Asterisk_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36871/comment/43a3b338_84e2… PS1, Line 393: auts := "9a6460bcc3c84a3eac69455a93b6"); > we should have tests covering […] Yes, I still need to coordinate with @andreas@eversberg.eu regarding all the cases. I think for now I'll work on the normal case, and go add also successful normal call tests, and then once everything (all the test infra) is in place start adding variants for the different "unusual" scenarios. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I77aeeb79cbddfc515e1626385f1b176da7319ba0 Gerrit-Change-Number: 36871 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 23 May 2024 16:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024