May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: osmo-trx-ms: bump osmocom-bb submodule commit

by laforge

Attention is currently required from: Hoernchen, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35859?usp=email ) Change subject: osmo-trx-ms: bump osmocom-bb submodule commit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8afdc072e132c82f760aa8eae705e622a7fae963 Gerrit-Change-Number: 35859 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 25 May 2024 06:29:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[XL] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 13: Code-Review+1 (1 comment) File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/4ebc4b77_60038192 PS12, Line 885: "nft-kpi [TABLE_NAME]", > This is a basic disagreement we encounter repeatedly. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2f0a9252715ea4b2fe9c367aa65f771357768ca Gerrit-Change-Number: 36539 Gerrit-PatchSet: 13 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 25 May 2024 06:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: contrib/sim-rest-client: don't crash without args

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36920?usp=email ) Change subject: contrib/sim-rest-client: don't crash without args ...................................................................... contrib/sim-rest-client: don't crash without args When running without an argument, let argparse print a nice usage error: $ ./sim-rest-client.py usage: sim-rest-client.py [-h] [-H HOST] [-p PORT] [-v] [-n SLOT_NR] {auth,info} ... sim-rest-client.py: error: the following arguments are required: {auth,info} Instead of: $ ./sim-rest-client.py Traceback (most recent call last): File "/usr/share/pysim/contrib/./sim-rest-client.py", line 185, in <module> main(sys.argv) File "/usr/share/pysim/contrib/./sim-rest-client.py", line 181, in main args.func(args) ^^^^^^^^^ AttributeError: 'Namespace' object has no attribute 'func' Change-Id: I92998d9b94dcfb9dcfc3da161fe5d8f45f242b78 --- M contrib/sim-rest-client.py 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/sim-rest-client.py b/contrib/sim-rest-client.py index 7da2363..a9fabb8 100755 --- a/contrib/sim-rest-client.py +++ b/contrib/sim-rest-client.py @@ -162,6 +162,7 @@ parser.add_argument("-v", "--verbose", help="increase output verbosity", action='count', default=0) parser.add_argument("-n", "--slot-nr", help="SIM slot number", type=int, default=0) subp = parser.add_subparsers() + subp.required = True auth_p = subp.add_parser('auth', help='UMTS AKA Authentication') auth_p.add_argument("-c", "--count", help="Auth count", type=int, default=10) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I92998d9b94dcfb9dcfc3da161fe5d8f45f242b78 Gerrit-Change-Number: 36920 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: contrib/sim-rest-client: don't crash without args

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36920?usp=email ) Change subject: contrib/sim-rest-client: don't crash without args ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I92998d9b94dcfb9dcfc3da161fe5d8f45f242b78 Gerrit-Change-Number: 36920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 May 2024 20:23:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pcsc: don't assume opts.pcsc_shared is present

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36921?usp=email ) Change subject: pcsc: don't assume opts.pcsc_shared is present ...................................................................... pcsc: don't assume opts.pcsc_shared is present Fixes running contrib/sim-rest-server.py: builtins.AttributeError: 'Namespace' object has no attribute 'pcsc_shared' Change-Id: I864f65849c5d43cf7c73e60f1935afdf4273f696 --- M pySim/transport/pcsc.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py index 9198816..8a1e03c 100644 --- a/pySim/transport/pcsc.py +++ b/pySim/transport/pcsc.py @@ -57,7 +57,7 @@ raise ReaderError('No matching reader found for regex %s' % opts.pcsc_regex) self._con = self._reader.createConnection() - if not opts.pcsc_shared: + if not getattr(opts, "pcsc_shared", False): self._con = ExclusiveConnectCardConnection(self._con) def __del__(self): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I864f65849c5d43cf7c73e60f1935afdf4273f696 Gerrit-Change-Number: 36921 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pcsc: don't assume opts.pcsc_shared is present

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36921?usp=email ) Change subject: pcsc: don't assume opts.pcsc_shared is present ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I864f65849c5d43cf7c73e60f1935afdf4273f696 Gerrit-Change-Number: 36921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 May 2024 20:22:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use associationToken in addEimResult

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email ) Change subject: SGP32Definitions_Templates: use associationToken in addEimResult ...................................................................... SGP32Definitions_Templates: use associationToken in addEimResult When an eIM is added, the eUICC usually computes an associationToken, so it will be the common case that an associationToken is sent back to the eIM. Related: SYS#6824 Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 709a58f..87ef86d 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -945,7 +945,7 @@ euiccResult := { { addEimResult := { - addEimResultCode := 0 + associationToken := 123 } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f Gerrit-Change-Number: 36922 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: fill in some realistic data into listProf...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email ) Change subject: SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult ...................................................................... SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult The listProfileInfoResult/profileInfoListOk currently onl has the profileName field populated, let's fill in some basic profile info to be more realistic. Related: SYS#6824 Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index 87ef86d..98846c5 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -814,15 +814,15 @@ listProfileInfoResult := { profileInfoListOk := { { - iccid := omit, + iccid := '123456789ABCDEFFAAAA'O, isdpAid := omit, - profileState := omit, + profileState := 1, /* enabled */ profileNickname := omit, serviceProviderName := omit, profileName := "testme", iconType := omit, icon := omit, - profileClass := omit, + profileClass := 2, /* operational */ notificationConfigurationInfo := omit, profileOwner := omit, dpProprietaryData := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 Gerrit-Change-Number: 36923 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: fill in some realistic data into listProf...

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email ) Change subject: SGP32Definitions_Templates: fill in some realistic data into listProfileInfoResult ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82bca8a1ec6fe44425c5ae00ad7dcd8772d2b157 Gerrit-Change-Number: 36923 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 May 2024 20:21:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: use associationToken in addEimResult

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email ) Change subject: SGP32Definitions_Templates: use associationToken in addEimResult ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4db69fdbee4c62389a4e61a248a071876b3d09f Gerrit-Change-Number: 36922 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 24 May 2024 20:21:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024