May 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsm0808: add knowledge of TW-TS-003 BSSMAP IE

by pespin

Attention is currently required from: falconia, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email ) Change subject: gsm0808: add knowledge of TW-TS-003 BSSMAP IE ...................................................................... Patch Set 2: (1 comment) File src/gsm/gsm0808.c: https://gerrit.osmocom.org/c/libosmocore/+/36669/comment/c9fefd13_30f1a72d PS1, Line 2316: [GSM0808_IE_THEMWI_RTP_EXTENSIONS] = { TLV_TYPE_TV }, You may want to keep this as TLV to match the Abis IE. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idd6f1838bdc0cd71a2f6357e9b6d8b8fa4f7c46c Gerrit-Change-Number: 36669 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 May 2024 13:59:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: tests/osmo-bts.vty: aligh with recent libosmovty changes

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email ) Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56 Gerrit-Change-Number: 36761 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 May 2024 12:50:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-sgsn[master]: VTY: sync default UMTS UEA config with osmo-msc

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email ) Change subject: VTY: sync default UMTS UEA config with osmo-msc ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > > this patch is actually enabling EUA1 and EUA2 […] I meant disabling UEA0 sorry. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/36702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4eb9451b4267fc1436ed90a55ff200cf36f16bf6 Gerrit-Change-Number: 36702 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 May 2024 12:49:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in libosmo-netif[master]: contrib: remove rpm spec file

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36725?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... Patch Set 2: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc Gerrit-Change-Number: 36725 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 May 2024 12:42:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: Use (and fix) ActionID field in Action Login

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758?usp=email ) Change subject: asterisk: Use (and fix) ActionID field in Action Login ...................................................................... Patch Set 1: (1 comment) File asterisk/AMI_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758/comment/c9c7bd0d_e408… PS1, Line 89: tr_AMI_Field_ActionId(template (present) charstring val := ?) := tr_AMI_Field(AMI_FIELD_ACTION_ID, val); @laforge@gnumonks.org that probably means I can use "pattern @nocase AMI_FIELD_ACTION_ID" here? something like: template (present) AMI_Field tr_AMI_Field_ActionId(template (present) charstring val := ?) := tr_AMI_Field(pattern @nocase AMI_FIELD_ACTION_ID, val); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9080f617c4e7272b9dd67d616069ac9350411f3c Gerrit-Change-Number: 36758 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 09 May 2024 12:40:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email ) Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/91813d64_5044… PS2, Line 26: ": " token in the value. I'd expect TEXT decoder to put all subsequent > pleas do make sure to report each of those to the eclipse TITAN forum. […] Ack, Vadim is going to give a look at those and we'll end up probably reporting them. But I wanted first to focus on getting a bit more through the test infrastructures with all the events being parsed and tests passing. File asterisk/AMI_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/5fd92a3e_d676… PS2, Line 189: welcome_str := "Asterisk Call Manager/9.0.0\r\n" > wouldn't this better be a regex? so that code could match multiple different versions, or ignore ver […] Yes I already though about this possiblity, it can probably be done but I'm so far focusing on getting the whole thing working together. I think we can fix and improve small parts like this afterwards. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d Gerrit-Change-Number: 36755 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 09 May 2024 12:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Misc_Helpers.ttcn: Add some more string handling API helpers

by pespin

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36754?usp=email ) Change subject: Misc_Helpers.ttcn: Add some more string handling API helpers ...................................................................... Patch Set 1: (1 comment) File library/Misc_Helpers.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36754/comment/451a70f7_ca48… PS1, Line 83: function f_str_endswith(charstring str, charstring token) return boolean : { > you are aware that TTCN-3 supports [some] regular expression? I'd expect matching a string start or […] Well for instance python also supports regular expressions (https://docs.python.org/3/howto/regex.html) and it still has too an endswith() method (https://www.w3schools.com/python/ref_string_endswith.asp). So I think the fact that tons of stuff can be done with regular expressions doesn't mean that it's not handy having some common funcionalitites available with specific APIs. Makes it quicker to develop and understand code rather than having to look at regexp (I may confess I'm not an expert by any means regarding regexp). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36754?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d6da125a10807b7a2f3ecad8145a046a322c7d6 Gerrit-Change-Number: 36754 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 May 2024 12:33:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: tests/osmo-bts.vty: aligh with recent libosmovty changes

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email ) Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes ...................................................................... tests/osmo-bts.vty: aligh with recent libosmovty changes A new command was recently added to libosmovty: show fsm-state-graph NAME This is now the longest command, affecting spacing in the output of 'show ?' command. Align spacing to make the test pass again. Change-Id: I80f896e45a88550909c5767169286fc321a36e56 Related: libosmocore.git I09ee0a8c3fc4b1aa991ab5c93c0b654fccd7ea4c --- M tests/osmo-bts.vty 1 file changed, 33 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/61/36761/1 diff --git a/tests/osmo-bts.vty b/tests/osmo-bts.vty index 97629d0..a51ad63 100644 --- a/tests/osmo-bts.vty +++ b/tests/osmo-bts.vty @@ -19,14 +19,14 @@ OsmoBTS> show ? ... - bts Display information about a BTS - trx Display information about a TRX - timeslot Display information about a TS - lchan Display information about a logical channel - timer Show timers - e1_driver Display information about available E1 drivers - e1_line Display information about a E1 line - e1_timeslot Display information about a E1 timeslot + bts Display information about a BTS + trx Display information about a TRX + timeslot Display information about a TS + lchan Display information about a logical channel + timer Show timers + e1_driver Display information about available E1 drivers + e1_line Display information about a E1 line + e1_timeslot Display information about a E1 timeslot ... OsmoBTS> show bts ? [<0-255>] BTS Number @@ -120,14 +120,14 @@ OsmoBTS# show ? ... - bts Display information about a BTS - trx Display information about a TRX - timeslot Display information about a TS - lchan Display information about a logical channel - timer Show timers - e1_driver Display information about available E1 drivers - e1_line Display information about a E1 line - e1_timeslot Display information about a E1 timeslot + bts Display information about a BTS + trx Display information about a TRX + timeslot Display information about a TS + lchan Display information about a logical channel + timer Show timers + e1_driver Display information about available E1 drivers + e1_line Display information about a E1 line + e1_timeslot Display information about a E1 timeslot ... OsmoBTS# show bts ? [<0-255>] BTS Number -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56 Gerrit-Change-Number: 36761 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU transactions

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email ) Change subject: libmsc: add X5 timer for delaying LU transactions ...................................................................... libmsc: add X5 timer for delaying LU transactions Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Related: SYS#6913 --- M include/osmocom/msc/msc_a.h M src/libmsc/msc_a.c M src/libmsc/ran_infra.c 3 files changed, 48 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/60/36760/1 diff --git a/include/osmocom/msc/msc_a.h b/include/osmocom/msc/msc_a.h index 4099d4c..09d0750 100644 --- a/include/osmocom/msc/msc_a.h +++ b/include/osmocom/msc/msc_a.h @@ -144,6 +144,9 @@ struct osmo_use_count use_count; struct osmo_use_count_entry use_count_buf[8]; int32_t max_total_use_count; + + /* Additional delay for Location Updating */ + struct osmo_timer_list lu_delay_timer; }; osmo_static_assert(offsetof(struct msc_a, c) == 0, msc_role_common_first_member_of_msc_a); diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index db1d998..7cb895c 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -155,6 +155,39 @@ } } +static void lu_delay_timer_cb(void *data) +{ + struct msc_a *msc_a = (struct msc_a *)data; + msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); +} + +static void msc_a_put_use_lu(struct msc_a *msc_a) +{ + unsigned long Tval; + + switch (msc_a->c.ran->type) { + case OSMO_RAT_GERAN_A: + Tval = osmo_tdef_get(msc_tdefs_geran, -5, OSMO_TDEF_S, 0); + break; + case OSMO_RAT_UTRAN_IU: + Tval = osmo_tdef_get(msc_tdefs_utran, -5, OSMO_TDEF_S, 0); + break; + default: + Tval = 0; + break; + } + + if (Tval == 0) { + /* no delay, put LU token immediately */ + msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); + return; + } + + LOG_MSC_A(msc_a, LOGL_INFO, "Keeping LU token for +%lu seconds\n", Tval); + osmo_timer_setup(&msc_a->lu_delay_timer, &lu_delay_timer_cb, msc_a); + osmo_timer_schedule(&msc_a->lu_delay_timer, Tval, 0); +} + static void evaluate_acceptance_outcome(struct osmo_fsm_inst *fi, bool conn_accepted) { struct msc_a *msc_a = fi->priv; @@ -180,7 +213,7 @@ osmo_signal_dispatch(SS_SUBSCR, S_SUBSCR_ATTACHED, msc_a_vsub(msc_a)); if (msc_a->complete_layer3_type == COMPLETE_LAYER3_LU) - msc_a_put(msc_a, MSC_A_USE_LOCATION_UPDATING); + msc_a_put_use_lu(msc_a); if (conn_accepted && msc_a->complete_layer3_type == COMPLETE_LAYER3_CM_RE_ESTABLISH_REQ) { /* Trigger new Assignment to recommence the voice call. A little dance here because normally we verify diff --git a/src/libmsc/ran_infra.c b/src/libmsc/ran_infra.c index 6a17840..04c0c62 100644 --- a/src/libmsc/ran_infra.c +++ b/src/libmsc/ran_infra.c @@ -44,6 +44,7 @@ { .T = -2, .default_val = 30, .desc = "RAN connection release sanity timeout" }, \ { .T = -3, .default_val = 10, .desc = "Timeout to find a target BSS after Handover Required" }, \ { .T = -4, .default_val = 10, .desc = "Paging response timeout" }, \ + { .T = -5, .default_val = 0, .desc = "Additional delay for LU transactions" }, \ struct osmo_tdef msc_tdefs_geran[] = { RAN_TDEFS -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Misc_Helpers: f_str_split(): Fix parse with len(delimiter) > 1

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36719?usp=email ) Change subject: Misc_Helpers: f_str_split(): Fix parse with len(delimiter) > 1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ac53635deea82a501f2a8c7a94faf501ddf7afd Gerrit-Change-Number: 36719 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 May 2024 08:58:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024