Attention is currently required from: fixeria, laforge, pespin.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email )
Change subject: gsm0808: add knowledge of TW-TS-003 BSSMAP IE
......................................................................
Patch Set 2:
(1 comment)
File src/gsm/gsm0808.c:
https://gerrit.osmocom.org/c/libosmocore/+/36669/comment/4c1ecbfa_4969098e
PS1, Line 2316: [GSM0808_IE_THEMWI_RTP_EXTENSIONS] = { TLV_TYPE_TV },
> You may want to keep this as TLV to match the Abis IE.
The A interface can't be changed as easily as Abis here: while Abis-IP is essentially a private interface fully inside Osmocom kingdom, the AoIP interface (3GPP specs plus TW-TS-003 extension) connects two different fiefdoms: Osmocom kingdom on BSS side and W. R. of Themyscira on CN side. TW-TS-003 is thus an external ICD, unlike Osmocom-internal definitions like the Abis IE, and TW-TS-003 section 5.2 defines this IE as having TV format. It is true that TW-TS-003 is still a very new spec and can be revised, but revising TW-TS is a more formal/involved process than Gerrit here.
However, to make it easier to merge the most essential part (reserving IEI code point 0xF2 for Themyscira and identifying it by the same symbolic name as in TW=TS-003 spec), I'll resubmit this patch with just protocol/gsm_08_08.h part kept, and drop this TLV decoder addition for now.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36669?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idd6f1838bdc0cd71a2f6357e9b6d8b8fa4f7c46c
Gerrit-Change-Number: 36669
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2024 15:58:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email )
Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I think the proper fix should go into the vty tests python module. […]
Ack, letting @vyanitskiy@sysmocom.de create a ticket about it since he was the one causing the issue this time :P
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56
Gerrit-Change-Number: 36761
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2024 15:25:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email )
Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think the proper fix should go into the vty tests python module. What if I build an old osmo-bts with new libosmocore?
We can merge this as a hotfix, but IMHO the tester should not insist on a fixed number of spaces in the first place.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56
Gerrit-Change-Number: 36761
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2024 15:23:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment