April 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: examples/ipa-stream-client: Fix memleaks in read_cb()

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36573?usp=email ) Change subject: examples/ipa-stream-client: Fix memleaks in read_cb() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36573?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I86fc159d928fc7ebce2f771670c5a198c52f5fc0 Gerrit-Change-Number: 36573 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Apr 2024 21:16:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in libosmo-sccp[master]: xua_asp_fsm: Fix 'Event AS_ASSIGNED not permitted'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36577?usp=email ) Change subject: xua_asp_fsm: Fix 'Event AS_ASSIGNED not permitted' ...................................................................... xua_asp_fsm: Fix 'Event AS_ASSIGNED not permitted' The event case handling (ignore it) was added in a commit some time ago, but it forgot to add it to the allstate_event_mask in the xua_fsm (it was added only in the ipa_fsm, which is the one using it). This bug should in theory be harmless since the only code dispatching the signal is not checking the return code of osmo_fsm_inst_dispatch(). Related: SYS#5914 Fixes: 57444690212b1576eaf0a7156448ba2d27c59050 Change-Id: Iaead46bbc40b923763bc3dbe4d24d8952822de4a --- M src/xua_asp_fsm.c 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index fadcde9..97391bb 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -769,7 +769,8 @@ .allstate_event_mask = S(XUA_ASP_E_SCTP_COMM_DOWN_IND) | S(XUA_ASP_E_SCTP_RESTART_IND) | S(XUA_ASP_E_ASPSM_BEAT) | - S(XUA_ASP_E_ASPSM_BEAT_ACK), + S(XUA_ASP_E_ASPSM_BEAT_ACK) | + S(XUA_ASP_E_AS_ASSIGNED), .allstate_action = xua_asp_allstate, .cleanup = xua_asp_fsm_cleanup, }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iaead46bbc40b923763bc3dbe4d24d8952822de4a Gerrit-Change-Number: 36577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in libosmo-sccp[master]: xua_asp_fsm: Fix 'Event AS_ASSIGNED not permitted'

by laforge

Attention is currently required from: jolly, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36577?usp=email ) Change subject: xua_asp_fsm: Fix 'Event AS_ASSIGNED not permitted' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iaead46bbc40b923763bc3dbe4d24d8952822de4a Gerrit-Change-Number: 36577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Apr 2024 21:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-hnbgw: osmo-hnbgw.cfg: Switch from deprecated 'mgcp' node to 'mgw'

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36569?usp=email ) Change subject: ttcn3-hnbgw: osmo-hnbgw.cfg: Switch from deprecated 'mgcp' node to 'mgw' ...................................................................... ttcn3-hnbgw: osmo-hnbgw.cfg: Switch from deprecated 'mgcp' node to 'mgw' Change-Id: Ie27dcae05fa719cd0eac9faa6e2fb6b63581ac28 --- M ttcn3-hnbgw-test/osmo-hnbgw.cfg 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/ttcn3-hnbgw-test/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/osmo-hnbgw.cfg index e2692dc..c0a00ac 100644 --- a/ttcn3-hnbgw-test/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/osmo-hnbgw.cfg @@ -79,7 +79,7 @@ local-ip 172.18.35.20 local-port 29169 hnbap-allow-tmsi 1 - mgcp + mgw 0 mgw local-ip 172.18.35.20 mgw remote-ip 172.18.35.203 # don't spam RANAP RESET messages for up to eight CN links across all tests -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie27dcae05fa719cd0eac9faa6e2fb6b63581ac28 Gerrit-Change-Number: 36569 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-hnbgw: osmo-hnbgw.cfg: Enable color in log file

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36570?usp=email ) Change subject: ttcn3-hnbgw: osmo-hnbgw.cfg: Enable color in log file ...................................................................... ttcn3-hnbgw: osmo-hnbgw.cfg: Enable color in log file Change-Id: Iffd28619ca075e0cf870e10989cfced6096ca8d7 --- M ttcn3-hnbgw-test/osmo-hnbgw.cfg 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/ttcn3-hnbgw-test/osmo-hnbgw.cfg b/ttcn3-hnbgw-test/osmo-hnbgw.cfg index c0a00ac..fd74b51 100644 --- a/ttcn3-hnbgw-test/osmo-hnbgw.cfg +++ b/ttcn3-hnbgw-test/osmo-hnbgw.cfg @@ -8,7 +8,7 @@ ! log stderr logging filter all 1 - logging color 0 + logging color 1 logging print category-hex 0 logging print category 1 logging print level 1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iffd28619ca075e0cf870e10989cfced6096ca8d7 Gerrit-Change-Number: 36570 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-hnbgw: osmo-hnbgw.cfg: Switch from deprecated 'mgcp' node to 'mgw'

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36569?usp=email ) Change subject: ttcn3-hnbgw: osmo-hnbgw.cfg: Switch from deprecated 'mgcp' node to 'mgw' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie27dcae05fa719cd0eac9faa6e2fb6b63581ac28 Gerrit-Change-Number: 36569 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Apr 2024 21:15:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: Early shutdown upon BSSMAP RESET-ACK timeout

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36578?usp=email ) Change subject: bsc: Early shutdown upon BSSMAP RESET-ACK timeout ...................................................................... bsc: Early shutdown upon BSSMAP RESET-ACK timeout Change-Id: I75e098d387562267d5851bc753e27e40186827ed --- M bsc/BSC_Tests.ttcn 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 1fc42ba..5e4ebbc 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -941,13 +941,15 @@ } [] BSSAP.receive { repeat; } [] T.timeout { - log("BSSMAP: Timeout waiting for RESET-ACK after sending RESET"); /* If we received a RESET after ours was sent, it may be a race condition where the other peer beacame available after we sent it, but we are in a desired state anyway, so go forward. */ if (not reset_received) { - setverdict(fail); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "BSSMAP: Timeout waiting for RESET-ACK after sending RESET"); + } else { + log("BSSMAP: Timeout waiting for RESET-ACK after sending RESET"); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75e098d387562267d5851bc753e27e40186827ed Gerrit-Change-Number: 36578 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: Early shutdown upon BSSMAP RESET-ACK timeout

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36578?usp=email ) Change subject: bsc: Early shutdown upon BSSMAP RESET-ACK timeout ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75e098d387562267d5851bc753e27e40186827ed Gerrit-Change-Number: 36578 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Apr 2024 21:15:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-bsc[master]: lb: Log name of unhandled sigtran primitive

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36579?usp=email ) Change subject: lb: Log name of unhandled sigtran primitive ...................................................................... lb: Log name of unhandled sigtran primitive Change-Id: I2d71fd347af404c025fc6b13e96f1964e685db05 --- M src/osmo-bsc/lb.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 72905b8..511a545 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -209,8 +209,9 @@ break; default: - LOGP(DLCS, LOGL_ERROR, "Unhandled SIGTRAN operation %s on primitive %u\n", - get_value_string(osmo_prim_op_names, oph->operation), oph->primitive); + LOGP(DLCS, LOGL_ERROR, "Unhandled SIGTRAN primitive %s.%s\n", + osmo_scu_prim_type_name(oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation)); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2d71fd347af404c025fc6b13e96f1964e685db05 Gerrit-Change-Number: 36579 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-bsc[master]: lb: Log name of unhandled sigtran primitive

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36579?usp=email ) Change subject: lb: Log name of unhandled sigtran primitive ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2d71fd347af404c025fc6b13e96f1964e685db05 Gerrit-Change-Number: 36579 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Apr 2024 19:36:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024