Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email )
Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Patchset:
PS1:
Maybe this is already done somewhere, but if not: it would probably be a good idea to explicitly turn it into a string somewhere. Otherwise code dealing with it may assume it is a string and then could result in an error elsewhere in the code?
PS1:
> the build failure seems completely unrelated, I created https://osmocom. […]
Fix is in https://gerrit.osmocom.org/c/docker-playground/+/36516, already deployed it to show it works
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f
Gerrit-Change-Number: 36507
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 03 Apr 2024 11:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36508?usp=email )
Change subject: esim.esp2: Allow HTTP methods other than POST
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
the build failure seems completely unrelated, I created https://osmocom.org/issues/6430
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36508?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4b1a0dc7e6662485397c7708933bf16e5ed56e10
Gerrit-Change-Number: 36508
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Apr 2024 10:55:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email )
Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
the build failure seems completely unrelated, I created https://osmocom.org/issues/6430
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f
Gerrit-Change-Number: 36507
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Apr 2024 10:55:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36515?usp=email )
Change subject: kernel-test/kernel-build: update net-next branch
......................................................................
kernel-test/kernel-build: update net-next branch
The branch of net-next is now called main. Update the default
KERNEL_BRANCH to main, as the default KERNEL_URL points to net-next.git.
Related: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/
Change-Id: Ic4b13c3cbc0933db9d520e6d737c45b6b08e8c48
---
M README.md
M scripts/kernel-test/kernel-build.sh
2 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/15/36515/1
diff --git a/README.md b/README.md
index 4c6c40a..6c2c989 100644
--- a/README.md
+++ b/README.md
@@ -105,7 +105,7 @@
* `KERNEL_REMOTE_NAME`: git remote name (to add multiple git
repositories in the same local linux clone, default: net-next)
* `KERNEL_URL`: git remote url (default: net-next.git on kernel.org)
-* `KERNEL_BRANCH` branch to checkout (default: master)
+* `KERNEL_BRANCH` branch to checkout (default: main)
* `KERNEL_SKIP_REBUILD`: set to 1 to not build the kernel again if already
built with `KERNEL_BUILD=1`
* `KERNEL_SKIP_SMOKE_TEST`: don't boot up the kernel in QEMU once before
diff --git a/scripts/kernel-test/kernel-build.sh b/scripts/kernel-test/kernel-build.sh
index 9bd8064..bbf3e43 100755
--- a/scripts/kernel-test/kernel-build.sh
+++ b/scripts/kernel-test/kernel-build.sh
@@ -3,7 +3,7 @@
KERNEL_REMOTE_NAME="${KERNEL_REMOTE_NAME:-net-next}"
KERNEL_URL="${KERNEL_URL:-https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git}"
-KERNEL_BRANCH="${KERNEL_BRANCH:-master}"
+KERNEL_BRANCH="${KERNEL_BRANCH:-main}"
KERNEL_DIR=/cache/linux
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36515?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic4b13c3cbc0933db9d520e6d737c45b6b08e8c48
Gerrit-Change-Number: 36515
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36510?usp=email )
Change subject: scripts/kernel-test: do shallow fetch
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I presume you've tested this manually somehow? I've only very rarely worked with shallow clones and […]
I've tested locally adding two different shallow cloned/fetched remotes to the same git repository with this, and it worked. I'm not sure if it will fall apart once upstream pushes new commits to the same repo, and we run the job again, but it seems unlikely to me. If needed, we can simply revert this.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36510?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I92d90c1451ff6abff2df3b1318b5194880e77f2e
Gerrit-Change-Number: 36510
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 03 Apr 2024 10:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment