lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

February 2024

  • 1 participants
  • 1748 discussions
[S] Change in libosmo-netif[master]: stream_cli: Call read callback even if connection failed
by jolly 20 Feb '24

20 Feb '24
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email ) Change subject: stream_cli: Call read callback even if connection failed ...................................................................... stream_cli: Call read callback even if connection failed If connection fails, osmo_stream_cli_reconnect is called, to start a reconnect-timer. Addtionally the read callback is called, so that the user of the stream client gets a notifcation. Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f Related: OS#5753 --- M src/stream_cli.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/20/36020/1 diff --git a/src/stream_cli.c b/src/stream_cli.c index bc19131..b49a7e8 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -444,7 +444,8 @@ case STREAM_CLI_STATE_CONNECTED: if (res == 0) osmo_stream_cli_reconnect(cli); - else if (cli->iofd_read_cb) + /* Forward message to read callback, also if the connection failed. */ + if (cli->iofd_read_cb) cli->iofd_read_cb(cli, msg); break; default: -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f Gerrit-Change-Number: 36020 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange
1 0
0 0
[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by pespin 20 Feb '24

20 Feb '24
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Sorry, I thought it was legitimate since the interface added the option - I will wait next time The policy is to always wait for 2 positive votes, unless really straight forward patches where a reviewer may give +2 directly. If you get two +1, you are free to convert them to +2 and merge yourself. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 11:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: matanp <matan1008(a)gmail.com> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by matanp 20 Feb '24

20 Feb '24
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > @matan1008@gmail. […] Sorry, I thought it was legitimate since the interface added the option - I will wait next time -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 11:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by pespin 20 Feb '24

20 Feb '24
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: @matan1008@gmail.com Please next time better wait to get a second review vote, specially with this commit which contains lots of options. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 10:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by matanp 20 Feb '24

20 Feb '24
matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... ctrl: Add lchan show This new command shows information about a logical channel using net.btsN.trxM.tsI.lchanL.show.full Change-Id: I5432800eae452b6df71a151a7649f228704ed0da --- M src/osmo-bsc/bts_trx_ts_lchan_ctrl.c 1 file changed, 89 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified matanp: Looks good to me, approved diff --git a/src/osmo-bsc/bts_trx_ts_lchan_ctrl.c b/src/osmo-bsc/bts_trx_ts_lchan_ctrl.c index 2303373..6ddbe1e 100644 --- a/src/osmo-bsc/bts_trx_ts_lchan_ctrl.c +++ b/src/osmo-bsc/bts_trx_ts_lchan_ctrl.c @@ -22,6 +22,7 @@ #include <osmocom/bsc/bts.h> #include <osmocom/bsc/system_information.h> #include <osmocom/bsc/abis_rsl.h> +#include <osmocom/bsc/lchan_fsm.h> static int verify_lchan_ms_power(struct ctrl_cmd *cmd, const char *value, void *_data) { @@ -67,11 +68,87 @@ CTRL_CMD_DEFINE(lchan_ms_power, "ms-power"); +/* Return full information about a logical channel. + * format: bts.<0-255>.trx.<0-255>.ts.<0-8>.lchan.<0-8>.show.full + * result format: <bts>,<trx>,<ts>,<lchan>,<type>,<connection>,<state>,<last error>,<bs power>,<ms power>,<interference dbm>, + * <interference band>,<channel mode>,<imsi>,<tmsi>,<ipa bound ip>,<ipa bound port>,<ipa bound conn id>,<ipa conn ip>, + * <ipa conn port>,<ipa conn sppech mode> + */ +static int get_lchan_show_full(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_lchan *lchan = cmd->node; + struct in_addr ia; + char *interference = ",", *tmsi = "", *ipa_bound = ",,", *ipa_conn = ",,"; + + if (lchan->interf_dbm != INTERF_DBM_UNKNOWN) { + interference = talloc_asprintf(cmd, "%d,%u", lchan->interf_dbm, lchan->interf_band); + if (!interference) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + if (lchan->conn && lchan->conn->bsub && lchan->conn->bsub->tmsi != GSM_RESERVED_TMSI) { + tmsi = talloc_asprintf(cmd, "0x%08x", lchan->conn->bsub->tmsi); + if (!tmsi) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + if (is_ipa_abisip_bts(lchan->ts->trx->bts) && lchan->abis_ip.bound_ip) { + ia.s_addr = htonl(lchan->abis_ip.bound_ip); + ipa_bound = talloc_asprintf(cmd, "%s,%u,%u", inet_ntoa(ia), lchan->abis_ip.bound_port, + lchan->abis_ip.conn_id); + if (!ipa_bound) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + if (is_ipa_abisip_bts(lchan->ts->trx->bts) && lchan->abis_ip.connect_ip) { + ia.s_addr = htonl(lchan->abis_ip.connect_ip); + ipa_conn = talloc_asprintf(cmd, "%s,%u,0x%02x", inet_ntoa(ia), lchan->abis_ip.connect_port, + lchan->abis_ip.speech_mode); + if (!ipa_conn) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + } + + cmd->reply = talloc_asprintf(cmd, "%u,%u,%u,%u,%s,%u,%s,%s,%u,%u,%s,%s,%s,%s,%s,%s", + lchan->ts->trx->bts->nr, + lchan->ts->trx->nr, + lchan->ts->nr, + lchan->nr, + gsm_chan_t_name(lchan->type), + lchan->conn ? 1 : 0, lchan_state_name(lchan), + lchan->fi && lchan->fi->state == LCHAN_ST_BORKEN ? lchan->last_error : "", + lchan->ts->trx->nominal_power - lchan->ts->trx->max_power_red - lchan->bs_power_db, + ms_pwr_dbm(lchan->ts->trx->bts->band, lchan->ms_power), + interference, + gsm48_chan_mode_name(lchan->current_ch_mode_rate.chan_mode), + lchan->conn && lchan->conn->bsub && strlen(lchan->conn->bsub->imsi) ? lchan->conn->bsub->imsi : "", + tmsi, + ipa_bound, + ipa_conn + ); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + return CTRL_CMD_REPLY; +} +CTRL_CMD_DEFINE_RO(lchan_show_full, "show full"); + + int bsc_bts_trx_ts_lchan_ctrl_cmds_install(void) { int rc = 0; rc |= ctrl_cmd_install(CTRL_NODE_LCHAN, &cmd_lchan_ms_power); + rc |= ctrl_cmd_install(CTRL_NODE_LCHAN, &cmd_lchan_show_full); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by matanp 20 Feb '24

20 Feb '24
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 10:50:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by pespin 20 Feb '24

20 Feb '24
Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 20 Feb 2024 10:42:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by matanp 20 Feb '24

20 Feb '24
Attention is currently required from: pespin. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/0c8e0647_c4ac6671 PS1, Line 84: interference = talloc_asprintf(cmd, "%ddBm(%u)", lchan->interf_dbm, lchan->interf_band); > I don't see the point of adding the units here, plus parenthesis etc. making parsing more complex. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 10:41:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[M] Change in osmo-bsc[master]: ctrl: Add lchan show
by matanp 20 Feb '24

20 Feb '24
Attention is currently required from: matanp. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ctrl: Add lchan show ...................................................................... ctrl: Add lchan show This new command shows information about a logical channel using net.btsN.trxM.tsI.lchanL.show.full Change-Id: I5432800eae452b6df71a151a7649f228704ed0da --- M src/osmo-bsc/bts_trx_ts_lchan_ctrl.c 1 file changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/36019/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newpatchset
1 0
0 0
[S] Change in libosmocore[master]: osmo_io_uring: Run check of osmo_io with io_uring also
by pespin 20 Feb '24

20 Feb '24
Attention is currently required from: daniel, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email ) Change subject: osmo_io_uring: Run check of osmo_io with io_uring also ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > older distributions don't have the osmo_io backend (e.g. debian 10). […] I think we already run some tests conditionally in some places. See "if ENABLE_MSGFILE" in the same file. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 Gerrit-Change-Number: 35984 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 10:31:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 58
  • 59
  • 60
  • 61
  • 62
  • 63
  • 64
  • ...
  • 175
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.