jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email )
Change subject: stream_cli: Call read callback even if connection failed
......................................................................
stream_cli: Call read callback even if connection failed
If connection fails, osmo_stream_cli_reconnect is called, to start a
reconnect-timer. Addtionally the read callback is called, so that the
user of the stream client gets a notifcation.
Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f
Related: OS#5753
---
M src/stream_cli.c
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/20/36020/1
diff --git a/src/stream_cli.c b/src/stream_cli.c
index bc19131..b49a7e8 100644
--- a/src/stream_cli.c
+++ b/src/stream_cli.c
@@ -444,7 +444,8 @@
case STREAM_CLI_STATE_CONNECTED:
if (res == 0)
osmo_stream_cli_reconnect(cli);
- else if (cli->iofd_read_cb)
+ /* Forward message to read callback, also if the connection failed. */
+ if (cli->iofd_read_cb)
cli->iofd_read_cb(cli, msg);
break;
default:
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36020?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f
Gerrit-Change-Number: 36020
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newchange
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email )
Change subject: ctrl: Add lchan show
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> Sorry, I thought it was legitimate since the interface added the option - I will wait next time
The policy is to always wait for 2 positive votes, unless really straight forward patches where a reviewer may give +2 directly.
If you get two +1, you are free to convert them to +2 and merge yourself.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da
Gerrit-Change-Number: 36019
Gerrit-PatchSet: 4
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 11:03:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: comment
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email )
Change subject: ctrl: Add lchan show
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> @matan1008@gmail. […]
Sorry, I thought it was legitimate since the interface added the option - I will wait next time
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da
Gerrit-Change-Number: 36019
Gerrit-PatchSet: 4
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 11:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email )
Change subject: ctrl: Add lchan show
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
@matan1008@gmail.com Please next time better wait to get a second review vote, specially with this commit which contains lots of options.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da
Gerrit-Change-Number: 36019
Gerrit-PatchSet: 4
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 10:52:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email )
Change subject: ctrl: Add lchan show
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/0c8e0647_c4ac6671
PS1, Line 84: interference = talloc_asprintf(cmd, "%ddBm(%u)", lchan->interf_dbm, lchan->interf_band);
> I don't see the point of adding the units here, plus parenthesis etc. making parsing more complex. […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da
Gerrit-Change-Number: 36019
Gerrit-PatchSet: 4
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 10:41:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: matanp.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: ctrl: Add lchan show
......................................................................
ctrl: Add lchan show
This new command shows information about a logical channel using
net.btsN.trxM.tsI.lchanL.show.full
Change-Id: I5432800eae452b6df71a151a7649f228704ed0da
---
M src/osmo-bsc/bts_trx_ts_lchan_ctrl.c
1 file changed, 89 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/36019/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da
Gerrit-Change-Number: 36019
Gerrit-PatchSet: 4
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: daniel, jolly, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email )
Change subject: osmo_io_uring: Run check of osmo_io with io_uring also
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> older distributions don't have the osmo_io backend (e.g. debian 10). […]
I think we already run some tests conditionally in some places. See "if ENABLE_MSGFILE" in the same file.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6
Gerrit-Change-Number: 35984
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Feb 2024 10:31:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment