[M] Change in osmo-bsc[master]: ctrl: Add lchan show
Attention is currently required from: pespin. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email ) Change subject: ctrl: Add lchan show ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/36019/comment/0c8e0647_c4ac6671 PS1, Line 84: interference = talloc_asprintf(cmd, "%ddBm(%u)", lchan->interf_dbm, lchan->interf_band);
I don't see the point of adding the units here, plus parenthesis etc. making parsing more complex. […] Ack
-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5432800eae452b6df71a151a7649f228704ed0da Gerrit-Change-Number: 36019 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 10:41:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
matanp