February 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sccp[master]: VTY: rename 'sctp-role' to 'transport-role', add an alias

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email ) Change subject: VTY: rename 'sctp-role' to 'transport-role', add an alias ...................................................................... Patch Set 4: (1 comment) File tests/vty/ss7_asp_test.vty: https://gerrit.osmocom.org/c/libosmo-sccp/+/35978/comment/2fdc9008_e2cb2b5a PS2, Line 425: role sg : transport-role ser > This is one of the reasons why I've always been advocating for the 'only save those parameters which […] I am one of those people who don't like omitting default values in the output of `show running-config` / `write file` commands. Because of that, you need additional sources of information (like the VTY reference or source code) when editing a config file. And it's not always clearly stated in the VTY reference PDFs what's the default value for a certain command, so this is when I go check the source code. It's not a big deal for me, but definitely not that easy for a regular user without programming skills. In any case, I don't think it's worth discussing this problem here in such a scope limited place. If you have a better idea of how could this be implemented, please let me know. I am not going to defend the current approach. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iab6c898181d79a5ed2bea767ee90e55bc3af16a5 Gerrit-Change-Number: 35978 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Feb 2024 19:40:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: SCTP support

by laforge

Attention is currently required from: arehbein, fixeria, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email ) Change subject: osmo_io: SCTP support ...................................................................... Patch Set 7: (1 comment) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/35068/comment/9b4e3afc_1811364c PS3, Line 17: // FIXME: This must avoid clashing with the existing definitions in libosmo-netif!!! > did this clash disappear magically? I explicitly requested somewhere (review comment or redmine issue) to test build all osmocom software to see if the clash ever appears in practice. It seems it hasnt? Would be good to get explicit confirmation from jolly. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I89eb519b22d21011d61a7855b2364bc3c295df82 Gerrit-Change-Number: 35068 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 19:10:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Move notify_connected function to backend

by laforge

Attention is currently required from: daniel, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email ) Change subject: osmo_io: Move notify_connected function to backend ...................................................................... Patch Set 2: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I905ec85210570aff8addadfc9603335d04eb057a Gerrit-Change-Number: 35909 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 19:08:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libosmo-sccp[master]: VTY: rename 'sctp-role' to 'transport-role', add an alias

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email ) Change subject: VTY: rename 'sctp-role' to 'transport-role', add an alias ...................................................................... Patch Set 4: (1 comment) File tests/vty/ss7_asp_test.vty: https://gerrit.osmocom.org/c/libosmo-sccp/+/35978/comment/875df367_7eddba69 PS2, Line 425: role sg : transport-role ser > In general, the same problem can occur even if we keep the old commands unchanged: we oftentimes add […] This is one of the reasons why I've always been advocating for the 'only save those parameters which differ from the default' strategy. This way any new command would not change the 'save' output as long as the compiled-in default value is used. As far as I recall, some other developers don't share that view and believe it's best to save even default values - at the cost of the problems you described. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iab6c898181d79a5ed2bea767ee90e55bc3af16a5 Gerrit-Change-Number: 35978 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 19:06:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmo-sccp[master]: xua_asp_send_xlm_prim(): use LOGPFSML() to print more context

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36008?usp=email ) Change subject: xua_asp_send_xlm_prim(): use LOGPFSML() to print more context ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I28f3f89a8158bbedc224922a6ec151b1bbd6c7c0 Gerrit-Change-Number: 36008 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 19:04:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmo-sccp[master]: cosmetic: xua_cli_connect_cb(): fix typo in a comment

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36007?usp=email ) Change subject: cosmetic: xua_cli_connect_cb(): fix typo in a comment ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8fb57dc60c34ed3db2ea5394c3c452604217de91 Gerrit-Change-Number: 36007 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 19:03:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[L] Change in libosmo-sccp[master]: Implement M3UA-over-TCP (in addition to SCTP)

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email ) Change subject: Implement M3UA-over-TCP (in addition to SCTP) ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > If you didn't do that because then it would signal a deprecatio nwarning, you can add OSMO_DEPRECATE […] I tend to agree with pespin. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d Gerrit-Change-Number: 35796 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 19:03:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: debian: Fixes in systemd service

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36022?usp=email ) Change subject: debian: Fixes in systemd service ...................................................................... debian: Fixes in systemd service Update the osmo-epdg.service file to point to proper directories. Patch installed config file so that the libdir points to the dir where libraries were installed. Change-Id: Icd640d517b33a840d73aaabef9c594541848357a --- D contrib/osmo-epdg.service M contrib/systemd/osmo-epdg.service A debian/osmo-epdg.dirs M debian/osmo-epdg.install M debian/rules 5 files changed, 28 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/22/36022/1 diff --git a/contrib/osmo-epdg.service b/contrib/osmo-epdg.service deleted file mode 100644 index bfa8293..0000000 --- a/contrib/osmo-epdg.service +++ /dev/null @@ -1,15 +0,0 @@ -[Unit] -Description=Osmocom ePDG (Evolved Packet Data Gateway) -After=network-online.target -Wants=network-online.target - -[Service] -Type=simple -Restart=always -Environment="HOME=/var/lib/osmo-epdg" -ExecStartPre=/usr/bin/mkdir -p /var/lib/osmo-epdg -ExecStart=/usr/bin/osmo-epdg -RestartSec=2 - -[Install] -WantedBy=multi-user.target diff --git a/contrib/systemd/osmo-epdg.service b/contrib/systemd/osmo-epdg.service index a62a972..95ce43f 100644 --- a/contrib/systemd/osmo-epdg.service +++ b/contrib/systemd/osmo-epdg.service @@ -1,13 +1,14 @@ [Unit] -Description=Osmocom DIAMETER to GSUP translator -After=osmo-hlr.service +Description=Osmocom ePDG (Evolved Packet Data Gateway) After=network-online.target Wants=network-online.target [Service] Type=simple Restart=always -Environment="HOME=/var/lib/osmo-epdg" +WorkingDirectory=/var/lib/osmo-epdg +Environment="ERL_FLAGS=-config /etc/osmocom/osmo-epdg/osmo-epdg.config" +ExecStartPre=-/usr/bin/ip link del gtp0 ExecStartPre=/usr/bin/mkdir -p /var/lib/osmo-epdg ExecStart=/usr/bin/osmo-epdg RestartSec=2 diff --git a/debian/osmo-epdg.dirs b/debian/osmo-epdg.dirs new file mode 100644 index 0000000..563b7ec --- /dev/null +++ b/debian/osmo-epdg.dirs @@ -0,0 +1 @@ +/var/lib/osmo-epdg diff --git a/debian/osmo-epdg.install b/debian/osmo-epdg.install index 62aec37..f74f71b 100644 --- a/debian/osmo-epdg.install +++ b/debian/osmo-epdg.install @@ -1,3 +1,4 @@ +/etc/osmocom/osmo-epdg/osmo-epdg.config /etc/osmocom/osmo-epdg/ /contrib/systemd/osmo-epdg.service /lib/systemd/system/ /_build/default/bin/osmo-epdg /usr/bin/ -/_build/default/lib/gen_socket/priv/lib/gen_socket*.so /usr/lib/${DEB_HOST_MULTIARCH}/ +/_build/default/lib/gen_socket/priv/lib/gen_socket*.so /usr/lib/ diff --git a/debian/rules b/debian/rules index 55115ce..cf84877 100755 --- a/debian/rules +++ b/debian/rules @@ -19,6 +19,13 @@ cp _checkouts/gen_socket/priv/lib/gen_socket*.so ./_build/default/lib/gen_socket/priv/lib/; \ fi +override_dh_install: + install -d debian/tmp/etc/osmocom/osmo-epdg/ + install -m 755 config/sys.config debian/tmp/etc/osmocom/osmo-epdg/osmo-epdg.config + sed -i 's#_build/default/lib/gen_socket/priv/lib#/usr/lib/#g' \ + debian/tmp/etc/osmocom/osmo-epdg/osmo-epdg.config + dh_install + override_dh_clean: dh_clean rm -rf _build _checkouts -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Icd640d517b33a840d73aaabef9c594541848357a Gerrit-Change-Number: 36022 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: rebar.lock: Update after dependency fixes/updates

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36021?usp=email ) Change subject: rebar.lock: Update after dependency fixes/updates ...................................................................... rebar.lock: Update after dependency fixes/updates This contains 32bit compilation fixes for gen_socket and support to set tundev iface name in gtp_u_kmod. Change-Id: Iea501aca2a15df48aaae2672dcb9d39716ea585c --- M config/sys.config M rebar.lock 2 files changed, 29 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/21/36021/1 diff --git a/config/sys.config b/config/sys.config index 660aded..8ed5ca6 100755 --- a/config/sys.config +++ b/config/sys.config @@ -42,20 +42,20 @@ %% =========================================== {gtp_u_kmod, [ %% grx: Name used to log by the module. - {sockets, [{grx, [%% ip: IP Address assigned at the tunnel, used as local GTP-U IP Address. - {ip, {127,0,0,2}}, - %% Create the tun socket on a given netns: - %%{netns, "mynetns"}, - %% Bind tun socket to a particular interface (SO_BINDTODEVICE): - %%{netdev, "grx"}, - %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND): - freebind, - % Create gtp tundev with role SGSN: - {role, sgsn}%, - %{vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%, - % %%{netdev, "upstream"} - % ] - %} + {sockets, [{gtp0, [%% ip: IP Address assigned at the tunnel, used as local GTP-U IP Address. + {ip, {127,0,0,2}}, + %% Create the tun socket on a given netns: + %%{netns, "mynetns"}, + %% Bind tun socket to a particular interface (SO_BINDTODEVICE): + %%{netdev, "grx"}, + %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND): + freebind, + % Create gtp tundev with role SGSN: + {role, sgsn}%, + %{vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%, + % %%{netdev, "upstream"} + % ] + %} ] }] } diff --git a/rebar.lock b/rebar.lock index 4eefe8e..5c6c2bc 100644 --- a/rebar.lock +++ b/rebar.lock @@ -6,7 +6,7 @@ 1}, {<<"erlando">>, {git,"https://github.com/travelping/erlando.git", - {ref,"2cb56e06308beb4d65ae2217a02dc60bafc99b9d"}}, + {ref,"7ed3a732d1af082a3a2745c36dfd9406148391be"}}, 1}, {<<"gen_netlink">>, {git,"https://github.com/osmocom/gen_netlink", @@ -14,12 +14,12 @@ 1}, {<<"gen_socket">>, {git,"https://github.com/osmocom/gen_socket", - {ref,"35e11d6e2f6d87b02dcfc7507a9500bf7ca7329e"}}, + {ref,"672086c9e73b5e19208436d74ad75ac00f608c4e"}}, 2}, {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1}, {<<"gtp_u_kmod">>, {git,"https://github.com/osmocom/gtp_u_kmod", - {ref,"1dc27ed724403026431f51dd4c3f882499a036b0"}}, + {ref,"b3656ebb11528a2db3171dbf94f1a8bf0d6ffd00"}}, 0}, {<<"gtplib">>,{pkg,<<"gtplib">>,<<"3.2.0">>},0}, {<<"lager">>, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iea501aca2a15df48aaae2672dcb9d39716ea585c Gerrit-Change-Number: 36021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: gtp-link: close sockets on error

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/36017?usp=email ) Change subject: gtp-link: close sockets on error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/36017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I9c437de9712ebe568528b4c9ee1e89a4ba5cd5d1 Gerrit-Change-Number: 36017 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Feb 2024 16:16:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024