February 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: osmo_io: Move notify_connected function to backend
by pespin 23 Feb '24

23 Feb '24

Attention is currently required from: daniel, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email ) Change subject: osmo_io: Move notify_connected function to backend ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I905ec85210570aff8addadfc9603335d04eb057a Gerrit-Change-Number: 35909 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Feb 2024 13:22:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Use osmocom gtplib pointing to newer version of code
by pespin 23 Feb '24

23 Feb '24

Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email ) Change subject: Use osmocom gtplib pointing to newer version of code ...................................................................... Patch Set 3: (3 comments) File rebar.config: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/1ef0e040_5a9d… PS3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib", {branch, "osmocom/master"}}}, > wouldn't it be better to use an exact commit instead? that way it would be clear from git history wh […] This information is kept in rebar.lock. For now it's good keeping it like this while we are doing active development. File rebar.lock: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/5949754d_3842… PS3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}}, > * unrelated change […] Because it's rebar.lock and not rebar.config. If rebar.lock exists (it is generated upon built if doesn't exist), then during checkout the values in that file are used. If no rebar.lock exists, then the values from rebar.config are used. I intended to merge this change here too, since osmo_gsup was updated to also accomodate new changes required (osmo_gsup HEAD of the rebar.config branch changed). https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/180b6359_5128… PS3, Line 37: {git,"https://github.com/uwiger/parse_trans.git", > unrelated change (unlike gitlab, there is no git redirect if using github urls without . […] This appeared automatically when updating gtplib. It's newer gtplib pulling this in afaict. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaf2e195aaeac6d1b157a4b0dd6cd3d80deaa1308 Gerrit-Change-Number: 36052 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 23 Feb 2024 13:19:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/gerrit: don't build osmo-epdg for debian:11
by pespin 23 Feb '24

23 Feb '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36060?usp=email ) Change subject: jobs/gerrit: don't build osmo-epdg for debian:11 ...................................................................... jobs/gerrit: don't build osmo-epdg for debian:11 After switching to a newer gtplib, a newer OTP is required that isn't in debian 11. Disable it, as Pau suggested. Related: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/3#message-d76c9c565d6… Change-Id: I6a9147aef85612f3fb00920edea8c6706954b007 --- M jobs/gerrit-verifications.yml 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 2998619..936c49c 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -193,7 +193,7 @@ repos_url: '{gerrit_url}/erlang/{repos}' gerrit_project: 'erlang/{repos}' cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' - pipeline_binpkgs: "debian:11 debian:12" + pipeline_binpkgs: "debian:12" - osmo-e1-hardware: a2_name: JOB_TYPE -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6a9147aef85612f3fb00920edea8c6706954b007 Gerrit-Change-Number: 36060 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: jobs/gerrit: don't build osmo-epdg for debian:11
by pespin 23 Feb '24

23 Feb '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36060?usp=email ) Change subject: jobs/gerrit: don't build osmo-epdg for debian:11 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6a9147aef85612f3fb00920edea8c6706954b007 Gerrit-Change-Number: 36060 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Feb 2024 13:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-trx[master]: ms: add demod test tool and data
by Hoernchen 23 Feb '24

23 Feb '24

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36047?usp=email ) Change subject: ms: add demod test tool and data ...................................................................... Patch Set 3: (1 comment) File utils/va-test/burst-gen.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/36047/comment/df84e167_55cd4328 PS3, Line 80: // mrv(): bits(), demod_bits() {} > this can be dropped? All of this is debug code which is why it contains copied code from the sigproclib and constants so they can be modified, there is no point cleaning this up or trying to make it pretty, it's supposed to be modified and actively debugged. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I852e34d9667d1f12f235f8b3da1fcc0d738b2db9 Gerrit-Change-Number: 36047 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Feb 2024 11:12:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ggsn[master]: doc: fix typo ndoe -> node
by osmith 23 Feb '24

23 Feb '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36061?usp=email ) Change subject: doc: fix typo ndoe -> node ...................................................................... doc: fix typo ndoe -> node Change-Id: Ib78b5de45b93a7534163de2cd91211e9be75445d --- M doc/manuals/chapters/configuration.adoc 1 file changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/61/36061/1 diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index e87e5b0..5314d10 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -101,7 +101,7 @@ ---- <1> Change into privileged mode <2> Enter the interactive configuration mode -<3> Enter the config ndoe of the GGSN instance `ggsn0` +<3> Enter the config node of the GGSN instance `ggsn0` <4> Take the GGSN instance out of shutdown @@ -121,7 +121,7 @@ ---- <1> Change into privileged mode <2> Enter the interactive configuration mode -<3> Enter the config ndoe of the GGSN instance `ggsn0` +<3> Enter the config node of the GGSN instance `ggsn0` <4> Shut down the GGSN instance @@ -215,8 +215,8 @@ ---- <1> Change into privileged mode <2> Enter the interactive configuration mode -<3> Enter the config ndoe of the GGSN instance `ggsn0` -<4> Enter the config ndoe of the APN `internet` +<3> Enter the config node of the GGSN instance `ggsn0` +<4> Enter the config node of the APN `internet` <5> Take the APN out of shutdown @@ -237,8 +237,8 @@ ---- <1> Change into privileged mode <2> Enter the interactive configuration mode -<3> Enter the config ndoe of the GGSN instance `ggsn0` -<4> Enter the config ndoe of the APN `internet` +<3> Enter the config node of the GGSN instance `ggsn0` +<4> Enter the config node of the APN `internet` <5> Shut down the APN [[ggsn_no_root]] -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36061?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ib78b5de45b93a7534163de2cd91211e9be75445d Gerrit-Change-Number: 36061 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-epdg[master]: Use osmocom gtplib pointing to newer version of code
by osmith 23 Feb '24

23 Feb '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email ) Change subject: Use osmocom gtplib pointing to newer version of code ...................................................................... Patch Set 3: (3 comments) File rebar.config: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/a81cf836_0918… PS3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib", {branch, "osmocom/master"}}}, wouldn't it be better to use an exact commit instead? that way it would be clear from git history which commit was used at which time File rebar.lock: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/4ad6f843_7e95… PS3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}}, * unrelated change * just so I understand it, why is this using osmocom/master for osmo_gsup instead of master/a commit from master? https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/faf6a3b2_b5b9… PS3, Line 37: {git,"https://github.com/uwiger/parse_trans.git", unrelated change (unlike gitlab, there is no git redirect if using github urls without .git) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaf2e195aaeac6d1b157a4b0dd6cd3d80deaa1308 Gerrit-Change-Number: 36052 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Feb 2024 09:27:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Use osmocom gtplib pointing to newer version of code
by osmith 23 Feb '24

23 Feb '24

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email ) Change subject: Use osmocom gtplib pointing to newer version of code ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > to disable build of osmo-epdg for in debian11 I need to touch osmo-ci? yes: https://gerrit.osmocom.org/c/osmo-ci/+/36060 I've also disabled building osmo-epdg for debian 11 in OBS. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaf2e195aaeac6d1b157a4b0dd6cd3d80deaa1308 Gerrit-Change-Number: 36052 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Feb 2024 09:16:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: jobs/gerrit: don't build osmo-epdg for debian:11
by osmith 23 Feb '24

23 Feb '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36060?usp=email ) Change subject: jobs/gerrit: don't build osmo-epdg for debian:11 ...................................................................... jobs/gerrit: don't build osmo-epdg for debian:11 After switching to a newer gtplib, a newer OTP is required that isn't in debian 11. Disable it, as Pau suggested. Related: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/3#message-d76c9c565d6… Change-Id: I6a9147aef85612f3fb00920edea8c6706954b007 --- M jobs/gerrit-verifications.yml 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/60/36060/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 2998619..936c49c 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -193,7 +193,7 @@ repos_url: '{gerrit_url}/erlang/{repos}' gerrit_project: 'erlang/{repos}' cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' - pipeline_binpkgs: "debian:11 debian:12" + pipeline_binpkgs: "debian:12" - osmo-e1-hardware: a2_name: JOB_TYPE -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6a9147aef85612f3fb00920edea8c6706954b007 Gerrit-Change-Number: 36060 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-abis[master]: [cosmetic] Don't break lines shorter than 120 chars
by laforge 23 Feb '24

23 Feb '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36039?usp=email ) Change subject: [cosmetic] Don't break lines shorter than 120 chars ...................................................................... [cosmetic] Don't break lines shorter than 120 chars Change-Id: I0595ee899639d0eb798eb8d9372793db36f05b7a --- M src/input/ipaccess.c 1 file changed, 13 insertions(+), 8 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 41e8b89..04244a6 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -603,8 +603,7 @@ val = line->keepalive_idle_timeout > 0 ? line->keepalive_idle_timeout : DEFAULT_TCP_KEEPALIVE_IDLE_TIMEOUT; - ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPIDLE, - &val, sizeof(val)); + ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPIDLE, &val, sizeof(val)); if (ret < 0) { LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP keepalive idle time: %s\n", strerror(errno)); @@ -612,8 +611,7 @@ val = line->keepalive_probe_interval > -1 ? line->keepalive_probe_interval : DEFAULT_TCP_KEEPALIVE_INTERVAL; - ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPINTVL, - &val, sizeof(val)); + ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPINTVL, &val, sizeof(val)); if (ret < 0) { LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP keepalive interval: %s\n", strerror(errno)); @@ -621,15 +619,13 @@ val = line->keepalive_num_probes > 0 ? line->keepalive_num_probes : DEFAULT_TCP_KEEPALIVE_RETRY_COUNT; - ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPCNT, - &val, sizeof(val)); + ret = setsockopt(fd, IPPROTO_TCP, TCP_KEEPCNT, &val, sizeof(val)); if (ret < 0) LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP keepalive count: %s\n", strerror(errno)); val = 1000 * line->keepalive_num_probes * line->keepalive_probe_interval + line->keepalive_idle_timeout; - ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, - &val, sizeof(val)); + ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, &val, sizeof(val)); if (ret < 0) LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP user timeout: %s\n", strerror(errno)); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0595ee899639d0eb798eb8d9372793db36f05b7a Gerrit-Change-Number: 36039 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2025

2024

2023

2022

gerrit-log February 2024