February 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: Cosmetic: Makefile.am: make SUBDIRS diff friendly

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36063?usp=email ) Change subject: Cosmetic: Makefile.am: make SUBDIRS diff friendly ...................................................................... Cosmetic: Makefile.am: make SUBDIRS diff friendly Change-Id: I49e1b08e48dc324f313228e8c69679c37aa774f4 --- M Makefile.am 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index 7fb2529..5db4ac6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,5 +1,14 @@ ## Process this file with automake to produce Makefile.in -SUBDIRS = lib gtp ggsn sgsnemu doc contrib utils tests +SUBDIRS = \ + lib \ + gtp \ + ggsn \ + sgsnemu \ + doc \ + contrib \ + utils \ + tests \ + $(NULL) pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libgtp.pc -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I49e1b08e48dc324f313228e8c69679c37aa774f4 Gerrit-Change-Number: 36063 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[M] Change in osmo-ggsn[master]: Cosmetic: AM_CFLAGS: make diff friendly

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36064?usp=email ) Change subject: Cosmetic: AM_CFLAGS: make diff friendly ...................................................................... Cosmetic: AM_CFLAGS: make diff friendly Change-Id: I3303cd8ba8c8b21ff267608833d9fb4833ffc471 --- M ggsn/Makefile.am M gtp/Makefile.am M lib/Makefile.am M sgsnemu/Makefile.am M tests/gtp/Makefile.am M tests/lib/Makefile.am 6 files changed, 51 insertions(+), 7 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn/Makefile.am b/ggsn/Makefile.am index d4c82ad..0c6f334 100644 --- a/ggsn/Makefile.am +++ b/ggsn/Makefile.am @@ -2,7 +2,15 @@ AM_LDFLAGS = @EXEC_LDFLAGS@ -AM_CFLAGS = -D_GNU_SOURCE -fno-builtin -Wall -DSBINDIR='"$(sbindir)"' $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) +AM_CFLAGS = \ + -D_GNU_SOURCE \ + -fno-builtin \ + -Wall \ + -DSBINDIR='"$(sbindir)"' \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOCTRL_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ + $(NULL) osmo_ggsn_LDADD = @EXEC_LDADD@ -lgtp -L../gtp ../lib/libmisc.a $(LIBOSMOCORE_LIBS) $(LIBOSMOCTRL_LIBS) $(LIBOSMOVTY_LIBS) diff --git a/gtp/Makefile.am b/gtp/Makefile.am index 99ad8bb..f96f429 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -8,7 +8,12 @@ include_HEADERS = gtp.h gsn.h pdp.h gtpie.h -AM_CFLAGS = -fno-builtin -Wall -DSBINDIR='"$(sbindir)"' $(LIBOSMOCORE_CFLAGS) +AM_CFLAGS = \ + -fno-builtin \ + -Wall \ + -DSBINDIR='"$(sbindir)"' \ + $(LIBOSMOCORE_CFLAGS) \ + $(NULL) libgtp_la_SOURCES = gtp.c gtp.h gsn.c gsn.h gtpie.c gtpie.h pdp.c pdp.h lookupa.c lookupa.h queue.c queue.h libgtp_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined diff --git a/lib/Makefile.am b/lib/Makefile.am index 9dcd13b..9dfd456 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -2,7 +2,12 @@ noinst_HEADERS = gnugetopt.h ippool.h lookup.h syserr.h tun.h in46_addr.h netdev.h gtp-kernel.h netns.h util.h icmpv6.h checksum.h -AM_CFLAGS = -fno-builtin -Wall -DSBINDIR='"$(sbindir)"' $(LIBOSMOCORE_CFLAGS) +AM_CFLAGS = \ + -fno-builtin \ + -Wall \ + -DSBINDIR='"$(sbindir)"' \ + $(LIBOSMOCORE_CFLAGS) \ + $(NULL) libmisc_a_SOURCES = getopt1.c getopt.c ippool.c lookup.c tun.c debug.c in46_addr.c netdev.c netns.c util.c icmpv6.c checksum.c diff --git a/sgsnemu/Makefile.am b/sgsnemu/Makefile.am index 1f75de0..7e7fdbb 100644 --- a/sgsnemu/Makefile.am +++ b/sgsnemu/Makefile.am @@ -2,12 +2,21 @@ AM_LDFLAGS = @EXEC_LDFLAGS@ -AM_CFLAGS = -D_GNU_SOURCE -fno-builtin -Wall -DSBINDIR='"$(sbindir)"' $(LIBOSMOCORE_CFLAGS) +AM_CFLAGS = \ + -D_GNU_SOURCE \ + -fno-builtin \ + -Wall \ + -DSBINDIR='"$(sbindir)"' \ + $(LIBOSMOCORE_CFLAGS) \ + $(NULL) sgsnemu_LDADD = @EXEC_LDADD@ -lgtp -L../gtp ../lib/libmisc.a $(LIBOSMOCORE_LIBS) if ENABLE_GTP_KERNEL -AM_CFLAGS += -DGTP_KERNEL $(LIBGTPNL_CFLAGS) +AM_CFLAGS += \ + -DGTP_KERNEL \ + $(LIBGTPNL_CFLAGS) \ + $(NULL) sgsnemu_LDADD += $(LIBGTPNL_LIBS) endif diff --git a/tests/gtp/Makefile.am b/tests/gtp/Makefile.am index ef69260..ad2ed82 100644 --- a/tests/gtp/Makefile.am +++ b/tests/gtp/Makefile.am @@ -1,4 +1,8 @@ -AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS) +AM_CFLAGS = \ + -Wall \ + -I$(top_srcdir)/include \ + $(LIBOSMOCORE_CFLAGS) \ + $(NULL) AM_LDFLAGS = -no-install EXTRA_DIST = \ diff --git a/tests/lib/Makefile.am b/tests/lib/Makefile.am index e807281..7c01915 100644 --- a/tests/lib/Makefile.am +++ b/tests/lib/Makefile.am @@ -1,4 +1,8 @@ -AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS) +AM_CFLAGS = \ + -Wall \ + -I$(top_srcdir)/include \ + $(LIBOSMOCORE_CFLAGS) \ + $(NULL) AM_LDFLAGS = -no-install EXTRA_DIST = ippool_test.ok \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3303cd8ba8c8b21ff267608833d9fb4833ffc471 Gerrit-Change-Number: 36064 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[M] Change in osmo-ggsn[master]: Cosmetic: {lib,gtp}/Makefile.am: diff friendly

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36065?usp=email ) Change subject: Cosmetic: {lib,gtp}/Makefile.am: diff friendly ...................................................................... Cosmetic: {lib,gtp}/Makefile.am: diff friendly Change-Id: Ib1956794edc6e82cfa6c5419b2609565674d98a4 --- M gtp/Makefile.am M lib/Makefile.am 2 files changed, 52 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/gtp/Makefile.am b/gtp/Makefile.am index f96f429..666befe 100644 --- a/gtp/Makefile.am +++ b/gtp/Makefile.am @@ -15,6 +15,20 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) -libgtp_la_SOURCES = gtp.c gtp.h gsn.c gsn.h gtpie.c gtpie.h pdp.c pdp.h lookupa.c lookupa.h queue.c queue.h +libgtp_la_SOURCES = \ + gsn.c \ + gsn.h \ + gtp.c \ + gtp.h \ + gtpie.c \ + gtpie.h \ + lookupa.c \ + lookupa.h \ + pdp.c \ + pdp.h \ + queue.c \ + queue.h \ + $(NULL) + libgtp_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined libgtp_la_LIBADD = $(LIBOSMOCORE_LIBS) diff --git a/lib/Makefile.am b/lib/Makefile.am index 9dfd456..bef8962 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -1,6 +1,19 @@ noinst_LIBRARIES = libmisc.a -noinst_HEADERS = gnugetopt.h ippool.h lookup.h syserr.h tun.h in46_addr.h netdev.h gtp-kernel.h netns.h util.h icmpv6.h checksum.h +noinst_HEADERS = \ + checksum.h \ + gnugetopt.h \ + gtp-kernel.h \ + icmpv6.h \ + in46_addr.h \ + ippool.h \ + lookup.h \ + netdev.h \ + netns.h \ + syserr.h \ + tun.h \ + util.h \ + $(NULL) AM_CFLAGS = \ -fno-builtin \ @@ -9,7 +22,20 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) -libmisc_a_SOURCES = getopt1.c getopt.c ippool.c lookup.c tun.c debug.c in46_addr.c netdev.c netns.c util.c icmpv6.c checksum.c +libmisc_a_SOURCES = \ + checksum.c \ + debug.c \ + getopt.c \ + getopt1.c \ + icmpv6.c \ + in46_addr.c \ + ippool.c \ + lookup.c \ + netdev.c \ + netns.c \ + tun.c \ + util.c \ + $(NULL) if ENABLE_GTP_KERNEL AM_CFLAGS += -DGTP_KERNEL $(LIBGTPNL_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ib1956794edc6e82cfa6c5419b2609565674d98a4 Gerrit-Change-Number: 36065 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Change struct osmo_io_ops to contain struct, not union

by fixeria

Attention is currently required from: daniel, jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36062?usp=email ) Change subject: osmo_io: Change struct osmo_io_ops to contain struct, not union ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d302df8d00369e7b30437a52deb205f75882be3 Gerrit-Change-Number: 36062 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Feb 2024 18:15:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: Make socket.c compile without libsctp support (--disable-libsctp)

by fixeria

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36055?usp=email ) Change subject: Make socket.c compile without libsctp support (--disable-libsctp) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I214a16b60e0149a8b1cdcfd3c788cc56a1a40476 Gerrit-Change-Number: 36055 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 25 Feb 2024 17:52:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libosmo-abis[master]: Fix critical bug in default TCP keepalive user timeout

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36079?usp=email ) Change subject: Fix critical bug in default TCP keepalive user timeout ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/36079/comment/bba8c665_81c8f3e4 PS2, Line 22: Ia7659c209aea0d26eb37d31e771adc91b17ae668 > This commit (https://gerrit.osmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idca24d3e676a45d860d9eec60dc2097d8d87f3bf Gerrit-Change-Number: 36079 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Feb 2024 10:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libosmo-abis[master]: Fix critical bug in default TCP keepalive user timeout

by laforge

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/36079?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+2 by pespin The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Fix critical bug in default TCP keepalive user timeout ...................................................................... Fix critical bug in default TCP keepalive user timeout It turns out that our calculation of the TCP_USER_TIMEOUT value was flawed in several ways: * there should have been parenthesis around the + operator (line->keepalive_probe_interval + line->keepalive_idle_timeout) as the keepalive_idle_timeout is in seconds, not milli-seconds. * in the default case, all those values are configured to -1 (E1INP_USE_DEFAULT). This means we're using 1000 * -1 * -1 + -1 = 999 i.e. just below a second which clearly is not enough for a lossy satellite or wifi back-haul. This fixes a regression introduced in Ia7659c209aea0d26eb37d31e771adc91b17ae668 (libosmo-abis >= 1.4.0) when TCP keepalive user timeouts became enabled by default. The initial support for TCP_USER_TIMEOUT was merged in I5e7425958472aa5d758e09bfbefc7d7d37bf6f5f (libosmo-abis >= 0.7.0) but since TCP keepalives were not yet enabled by default, only users with explicit TCP keepalive configuration in their config files would be affected - and then only of the second part of the bug (operator precedence). In addition, let's print the actually-used values to the log, helping to spot unintended values. Change-Id: Idca24d3e676a45d860d9eec60dc2097d8d87f3bf Closes: OS#6375 Related: OS#5785, SYS#6801 Fixes: Ia7659c209aea0d26eb37d31e771adc91b17ae668 --- M src/input/ipaccess.c 1 file changed, 56 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/79/36079/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idca24d3e676a45d860d9eec60dc2097d8d87f3bf Gerrit-Change-Number: 36079 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[S] Change in osmo-trx[master]: ms: update osmocom-bb submodule

by fixeria

Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36048?usp=email ) Change subject: ms: update osmocom-bb submodule ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: A similar commit is stuck in Gerrit for a few weeks: https://gerrit.osmocom.org/c/osmo-trx/+/35859 Sadly, nobody else than @pespin@sysmocom.de did code review, and now we end up with another patch doing the same thing. I don't care which one gets merged in the end, just sharing my general disappointment about the lack of code review and duplicated effort. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0140f0a5333469f356c85a95660e10bbdd67cd25 Gerrit-Change-Number: 36048 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Sat, 24 Feb 2024 16:34:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[L] Change in osmo-bsc[master]: ctrl: Add lchan show to all ctrl levels

by matanp

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email to look at the new patch set (#3). Change subject: ctrl: Add lchan show to all ctrl levels ...................................................................... ctrl: Add lchan show to all ctrl levels This new commands show information about logical channels: net.btsN.trxM.tsI.show-lchan.full net.btsN.trxM.show-lchan.full net.btsN.show-lchan.full net.show-lchan.full Change-Id: I23c1a7e6f6679e3964e359fb202ffe6781a07e8a --- M include/osmocom/bsc/ctrl.h M src/osmo-bsc/bsc_ctrl.c M src/osmo-bsc/bts_ctrl.c M src/osmo-bsc/bts_trx_ctrl.c M src/osmo-bsc/bts_trx_ts_ctrl.c M src/osmo-bsc/bts_trx_ts_lchan_ctrl.c 6 files changed, 224 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/36084/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I23c1a7e6f6679e3964e359fb202ffe6781a07e8a Gerrit-Change-Number: 36084 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[L] Change in osmo-bsc[master]: ctrl: Add lchan show to all ctrl levels

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email ) Change subject: ctrl: Add lchan show to all ctrl levels ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bsc_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14667): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/c33c3843_03e9e9be PS2, Line 848: if (!strlen(bts_dump)) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I23c1a7e6f6679e3964e359fb202ffe6781a07e8a Gerrit-Change-Number: 36084 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 24 Feb 2024 14:43:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024