February 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: comment: gsm_04_08.h: add a spec hint

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35871?usp=email ) Change subject: comment: gsm_04_08.h: add a spec hint ...................................................................... comment: gsm_04_08.h: add a spec hint Change-Id: I2a606047db88ea47317397a790611048dead6403 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/35871/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 5d1da74..075b6ca 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -2233,7 +2233,8 @@ }; /*! GSM 04.08 Bearer Capability: Speech Version Indication - * (See also 3GPP TS 24.008, Table 10.5.103) */ + * (See also 3GPP TS 24.008, Table 10.5.103 + * and 3GPP TS 26.103, Table 4.1 "Support of Codec Types in Radio Access Technologies") */ enum gsm48_bcap_speech_ver { GSM48_BCAP_SV_FR = 0, /*!< GSM FR V1 (GSM FR) */ GSM48_BCAP_SV_HR = 1, /*!< GSM HR V1 (GSM HR) */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2a606047db88ea47317397a790611048dead6403 Gerrit-Change-Number: 35871 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: fix GAPK I/O producing too many UL frames

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email ) Change subject: mobile: fix GAPK I/O producing too many UL frames ...................................................................... mobile: fix GAPK I/O producing too many UL frames GAPK I/O is currently generating too many UL voice frames, causing Tx queue overflow in the L1 PHY. Change the logic to make DL voice frames drive the Uplink processing chain, like we do for CSD. Change-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1 --- M src/host/layer23/include/osmocom/bb/mobile/gapk_io.h M src/host/layer23/include/osmocom/bb/mobile/tch.h M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gapk_io.c M src/host/layer23/src/mobile/tch.c M src/host/layer23/src/mobile/tch_voice.c 6 files changed, 29 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/70/35870/1 diff --git a/src/host/layer23/include/osmocom/bb/mobile/gapk_io.h b/src/host/layer23/include/osmocom/bb/mobile/gapk_io.h index b9f1bc5..ab8b657 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/gapk_io.h +++ b/src/host/layer23/include/osmocom/bb/mobile/gapk_io.h @@ -42,6 +42,6 @@ void gapk_io_state_free(struct gapk_io_state *state); void gapk_io_enqueue_dl(struct gapk_io_state *state, struct msgb *msg); -int gapk_io_serve_ms(struct osmocom_ms *ms, struct gapk_io_state *state); +void gapk_io_dequeue_ul(struct osmocom_ms *ms, struct gapk_io_state *state); #endif /* WITH_GAPK_IO */ diff --git a/src/host/layer23/include/osmocom/bb/mobile/tch.h b/src/host/layer23/include/osmocom/bb/mobile/tch.h index 293397d..b026bd5 100644 --- a/src/host/layer23/include/osmocom/bb/mobile/tch.h +++ b/src/host/layer23/include/osmocom/bb/mobile/tch.h @@ -24,6 +24,5 @@ }; int tch_init(struct osmocom_ms *ms); -int tch_serve_ms(struct osmocom_ms *ms); int tch_send_msg(struct osmocom_ms *ms, struct msgb *msg); int tch_send_mncc_frame(struct osmocom_ms *ms, const struct gsm_data_frame *frame); diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c index 453990e..477c4fa 100644 --- a/src/host/layer23/src/mobile/app_mobile.c +++ b/src/host/layer23/src/mobile/app_mobile.c @@ -81,7 +81,6 @@ w |= gsm322_cs_dequeue(ms); w |= gsm_sim_job_dequeue(ms); w |= mncc_dequeue(ms); - w |= tch_serve_ms(ms); if (w) work = 1; } while (w); diff --git a/src/host/layer23/src/mobile/gapk_io.c b/src/host/layer23/src/mobile/gapk_io.c index 4699bae..7a0674a 100644 --- a/src/host/layer23/src/mobile/gapk_io.c +++ b/src/host/layer23/src/mobile/gapk_io.c @@ -513,49 +513,23 @@ msgb_enqueue_count(&state->tch_dl_fb, msg, &state->tch_dl_fb_len); + + /* Decode and play a received DL TCH frame */ + osmo_gapk_pq_execute(state->pq_sink); } /* Serves both UL/DL TCH frame I/O buffers */ -int gapk_io_serve_ms(struct osmocom_ms *ms, struct gapk_io_state *state) +void gapk_io_dequeue_ul(struct osmocom_ms *ms, struct gapk_io_state *state) { - int work = 0; + struct msgb *msg; - /** - * Make sure we have at least two DL frames - * to prevent discontinuous playback. - */ - if (state->tch_dl_fb_len < 2) - return 0; + /* Record and encode an UL TCH frame */ + osmo_gapk_pq_execute(state->pq_source); - /** - * TODO: if there is an active call, but no TCH frames - * in DL buffer, put silence frames using the upcoming - * ECU (Error Concealment Unit) of libosmocodec. - */ - while (!llist_empty(&state->tch_dl_fb)) { - /* Decode and play a received DL TCH frame */ - osmo_gapk_pq_execute(state->pq_sink); - - /* Record and encode an UL TCH frame back */ - osmo_gapk_pq_execute(state->pq_source); - - work |= 1; - } - - while (!llist_empty(&state->tch_ul_fb)) { - struct msgb *tch_msg; - - /* Obtain one TCH frame from the UL buffer */ - tch_msg = msgb_dequeue_count(&state->tch_ul_fb, - &state->tch_ul_fb_len); - - /* Push a voice frame to the lower layers */ - tch_send_msg(ms, tch_msg); - - work |= 1; - } - - return work; + /* Obtain one TCH frame from the UL buffer */ + msg = msgb_dequeue_count(&state->tch_ul_fb, &state->tch_ul_fb_len); + if (msg != NULL) + tch_send_msg(ms, msg); } /** diff --git a/src/host/layer23/src/mobile/tch.c b/src/host/layer23/src/mobile/tch.c index 5acdef2..b78682f 100644 --- a/src/host/layer23/src/mobile/tch.c +++ b/src/host/layer23/src/mobile/tch.c @@ -45,7 +45,6 @@ int tch_voice_recv(struct osmocom_ms *ms, struct msgb *msg); int tch_data_recv(struct osmocom_ms *ms, struct msgb *msg); -int tch_voice_serve_ms(struct osmocom_ms *ms); /* Receive a Downlink traffic (voice/data) frame from the lower layers */ static int tch_recv_cb(struct osmocom_ms *ms, struct msgb *msg) @@ -116,20 +115,6 @@ return tch_send_msg(ms, nmsg); } -int tch_serve_ms(struct osmocom_ms *ms) -{ - struct tch_state *state = ms->tch_state; - int rc = 0; - - if (state == NULL) - return 0; - if (state->is_voice) - rc = tch_voice_serve_ms(ms); - /* TODO: else tch_data_serve_ms() */ - - return rc; -} - static void tch_trans_cstate_active_cb(struct gsm_trans *trans, bool rx_only) { struct osmocom_ms *ms = trans->ms; diff --git a/src/host/layer23/src/mobile/tch_voice.c b/src/host/layer23/src/mobile/tch_voice.c index a85d7dc..ac793e8 100644 --- a/src/host/layer23/src/mobile/tch_voice.c +++ b/src/host/layer23/src/mobile/tch_voice.c @@ -90,11 +90,12 @@ return tch_forward_mncc(ms, msg); case TCH_VOICE_IOH_GAPK: #ifdef WITH_GAPK_IO - /* Enqueue a frame to the DL TCH buffer */ - if (state->gapk_io != NULL) + if (state->gapk_io != NULL) { gapk_io_enqueue_dl(state->gapk_io, msg); - else + gapk_io_dequeue_ul(ms, state->gapk_io); + } else { msgb_free(msg); + } break; #endif case TCH_VOICE_IOH_L1PHY: @@ -107,18 +108,6 @@ return 0; } -int tch_voice_serve_ms(struct osmocom_ms *ms) -{ -#ifdef WITH_GAPK_IO - struct tch_voice_state *state = &ms->tch_state->voice; - - if (state->handler == TCH_VOICE_IOH_GAPK) - return gapk_io_serve_ms(ms, state->gapk_io); -#endif - - return 0; -} - int tch_voice_state_init(struct gsm_trans *trans, struct tch_voice_state *state) { struct osmocom_ms *ms = trans->ms; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3a7fa223cb592acd5b850819e0682c9c8f81e9d1 Gerrit-Change-Number: 35870 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: init TCH state earlier (on receipt of CC ALERTING)

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email ) Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING) ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/4ff00fcc_80b138cb PS2, Line 19: Rx only mode makes no sense for data calls, so in tch_recv_cb() we > WI mean if the data you receive while the call is not fully connected can actually contain meaningfu […] Ah, I see your point now. But no, I don't think there can be any meaningful data before the call gets CONNECTed. AFAIR, it was even stated somewhere in the specs. that V.110 TA shall not be engaged before CC CONNECT. When a regular phone/modem gets a data call, it remains in AT-command mode (assuming that auto-answer is disabled) until you send `ATA` (answer) command. So it's impossible to send any data before accepting a call. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec Gerrit-Change-Number: 35739 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:23:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: GTPv2/S2b: use correct instance id in the F-TEID

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35869?usp=email ) Change subject: GTPv2/S2b: use correct instance id in the F-TEID ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Yeah I think makes sense, I probably swapped those when writting the code. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I053fe5661a38ce6fa7995964a0346129b56c823e Gerrit-Change-Number: 35869 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: GTPv2/S2b: use correct instance id in the F-TEID

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35869?usp=email ) Change subject: GTPv2/S2b: use correct instance id in the F-TEID ...................................................................... GTPv2/S2b: use correct instance id in the F-TEID I've no idea why, but it seems the GTPu is the EBI, but the GTP-C is always 0. This way it works with open5gs. Change-Id: I053fe5661a38ce6fa7995964a0346129b56c823e --- M src/epdg_gtpc_s2b.erl 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/69/35869/1 diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl index ca05d9b..6c1a7fc 100644 --- a/src/epdg_gtpc_s2b.erl +++ b/src/epdg_gtpc_s2b.erl @@ -342,7 +342,7 @@ }, #v2_eps_bearer_id{eps_bearer_id = Bearer#gtp_bearer.ebi}, #v2_fully_qualified_tunnel_endpoint_identifier{ - instance = 0, + instance = Bearer#gtp_bearer.ebi, interface_type = 31, %% "S2b-U ePDG GTP-U" key = Bearer#gtp_bearer.local_data_tei, ipv4 = gtp_utils:ip_to_bin(LocalAddr) @@ -352,7 +352,7 @@ #v2_international_mobile_subscriber_identity{imsi = Imsi}, #v2_rat_type{rat_type = 3}, %% 3 = WLAN #v2_fully_qualified_tunnel_endpoint_identifier{ - instance = Bearer#gtp_bearer.ebi, + instance = 0, interface_type = 30, %% "S2b ePDG GTP-C" key = LocalCtlTEI, ipv4 = gtp_utils:ip_to_bin(LocalAddr) @@ -374,7 +374,7 @@ seq_no = SeqNo}) -> IEs = [#v2_eps_bearer_id{eps_bearer_id = Bearer#gtp_bearer.ebi}, #v2_fully_qualified_tunnel_endpoint_identifier{ - instance = Bearer#gtp_bearer.ebi, + instance = 0, interface_type = 30, %% "S2b ePDG GTP-C" key = Bearer#gtp_bearer.local_data_tei, ipv4 = gtp_utils:ip_to_bin(LocalAddr) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I053fe5661a38ce6fa7995964a0346129b56c823e Gerrit-Change-Number: 35869 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email ) Change subject: mobile: cosmetic: fix '(ptr *) foo' shour be '(ptr *)foo' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id6ed92b27c61ae9dfbb702a3abdc75e5daa8235d Gerrit-Change-Number: 35867 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:14:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: assert() values returned by get_string_value()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email ) Change subject: mobile: assert() values returned by get_string_value() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I58bc31a4c3d952f71ed2c53b65bb30538172ca4e Gerrit-Change-Number: 35868 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:14:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: init TCH state earlier (on receipt of CC ALERTING)

by pespin

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email ) Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING) ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/744874c0_04519b45 PS2, Line 19: Rx only mode makes no sense for data calls, so in tch_recv_cb() we > I do not understand what you mean here, sorry. WI mean if the data you receive while the call is not fully connected can actually contain meaningful data/bytes which you should not be dropping. The CC CONNECTED signal comes out of band from the channel afaiu, so there's no real synch point on where the data actually starts? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec Gerrit-Change-Number: 35739 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:14:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35861?usp=email ) Change subject: rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window() ...................................................................... rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window() * drop unused variable 'i' (fixes -Wunused-but-set-variable) * reduce nesting in the for-loop Change-Id: Ic0efd2f84a17d287b73261c102bca84e8274bb2a --- M src/rlcmac/rlc_window_ul.c 1 file changed, 18 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/rlcmac/rlc_window_ul.c b/src/rlcmac/rlc_window_ul.c index af1c32b..e8c07e6 100644 --- a/src/rlcmac/rlc_window_ul.c +++ b/src/rlcmac/rlc_window_ul.c @@ -291,18 +291,16 @@ unsigned int gprs_rlcmac_rlc_ul_window_move_window(struct gprs_rlcmac_rlc_ul_window *ulw) { struct gprs_rlcmac_rlc_window *w = rlc_ulw_as_w(ulw); - unsigned int i; - uint16_t bsn; unsigned int moved = 0; + uint16_t bsn; - for (i = 0, bsn = gprs_rlcmac_rlc_ul_window_v_a(ulw); + for (bsn = gprs_rlcmac_rlc_ul_window_v_a(ulw); bsn != gprs_rlcmac_rlc_ul_window_v_s(ulw); - i++, bsn = gprs_rlcmac_rlc_window_mod_sns_bsn(w, bsn + 1)) { - if (gprs_rlcmac_rlc_v_b_is_acked(&ulw->v_b, bsn)) { - gprs_rlcmac_rlc_v_b_mark_invalid(&ulw->v_b, bsn); - moved += 1; - } else + bsn = gprs_rlcmac_rlc_window_mod_sns_bsn(w, bsn + 1)) { + if (!gprs_rlcmac_rlc_v_b_is_acked(&ulw->v_b, bsn)) break; + moved += 1; + gprs_rlcmac_rlc_v_b_mark_invalid(&ulw->v_b, bsn); } return moved; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/35861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic0efd2f84a17d287b73261c102bca84e8274bb2a Gerrit-Change-Number: 35861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: set TRAFFIC.{ind,req} mode during call establishment

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35740?usp=email ) Change subject: mobile: set TRAFFIC.{ind,req} mode during call establishment ...................................................................... Patch Set 3: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/35740/comment/d2ddb85d_067e1b94 PS1, Line 7012: } > Now you have removed the audio mode setting from the init function of the MS instance, so you can re […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab68cb47c28380a9c1efc149c6196ea54f75fdb8 Gerrit-Change-Number: 35740 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 05 Feb 2024 20:12:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024