Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35915?usp=email )
Change subject: mobile: use osmo_csd_chan_mode_rate_desc[] from libosmogsm
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35915?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I862329fbf19c515be88f2c23989b3991886a2cf4
Gerrit-Change-Number: 35915
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Feb 2024 15:08:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> To me its clear given the combination matrix above that it makes no sense to create a type for each […]
Ok, thank you @pespin@sysmocom.de and @laforge@osmocom.org for the feedback! I will rework the VTY commands, marking as WIP for now. BTW, I think we also want to rename the `sctp-role (client|server)` command to something more neutral.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d
Gerrit-Change-Number: 35796
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Feb 2024 13:06:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email )
Change subject: Implement M3UA-over-TCP (in addition to SCTP)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I agree that conceptually it is "mixing layers". […]
To me its clear given the combination matrix above that it makes no sense to create a type for each of those permutations.
Futhermore, following the same rule of thumb we'd also have yet another axis where one would have "tcp-client" and another "tcp-server", and "sctp-client", and "sctp-server". All of that makes no sense, it's clearly trying to put together stuff from different layers, which we already keep properly separated by the "role asp|sg" and "sctp-role client|server".
I'd really go for adding a "transport tcp|sctp" and be done with. Most of the code can be kept the same and we only need to patch sections really doing stuff with lower layers.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35796?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d
Gerrit-Change-Number: 35796
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Feb 2024 13:01:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35908?usp=email )
Change subject: ttcn3-bts-test: do not start osmo-bts-virtual / virtphy containers
......................................................................
ttcn3-bts-test: do not start osmo-bts-virtual / virtphy containers
We cannot execute the virtphy based testcases due to the limitations
of Docker (see https://github.com/moby/libnetwork/issues/2397). The
function starting the testsuite was already commented out, but not
the lines starting containers with osmo-bts-virtual and virtphy.
To put it simple, we start and immediately terminate those containers.
And since recently (Feb 1st), we started seeing socket creation errors
in both containers, causing jenkins.sh to abort early. It's yet
unclear what's the cause of those socket errors, but regardless of
that we should still be running other pending testcases.
Change-Id: I7c9ccc9cc400edb7a05e222e51671fd49631a4cd
Fixes: OS#6352
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 26 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 4128e08..92d83ef 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -182,8 +182,11 @@
docker_kill_wait ${BUILD_TAG}-bts
cp virtphy/osmo-bts.gen.cfg $VOL_BASE_DIR/bts/
network_replace_subnet_in_configs
-start_bts virtual 0
-start_virtphy
+# FIXME: multicast to/from a docker bridge network is currently not possible.
+# See https://github.com/moby/libnetwork/issues/2397.
+echo "XXX: not running the virtphy configuration"
+#start_bts virtual 0
+#start_virtphy
# ... and execute the testsuite again with different cfg
#start_testsuite virtphy
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35908?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I7c9ccc9cc400edb7a05e222e51671fd49631a4cd
Gerrit-Change-Number: 35908
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35908?usp=email )
Change subject: ttcn3-bts-test: do not start osmo-bts-virtual / virtphy containers
......................................................................
ttcn3-bts-test: do not start osmo-bts-virtual / virtphy containers
We cannot execute the virtphy based testcases due to the limitations
of Docker (see https://github.com/moby/libnetwork/issues/2397). The
function starting the testsuite was already commented out, but not
the lines starting containers with osmo-bts-virtual and virtphy.
To put it simple, we start and immediately terminate those containers.
And since recently (Feb 1st), we started seeing socket creation errors
in both containers, causing jenkins.sh to abort early. It's yet
unclear what's the cause of those socket errors, but regardless of
that we should still be running other pending testcases.
Change-Id: I7c9ccc9cc400edb7a05e222e51671fd49631a4cd
Fixes: OS#6352
---
M ttcn3-bts-test/jenkins.sh
1 file changed, 26 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/08/35908/1
diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh
index 4128e08..92d83ef 100755
--- a/ttcn3-bts-test/jenkins.sh
+++ b/ttcn3-bts-test/jenkins.sh
@@ -182,8 +182,11 @@
docker_kill_wait ${BUILD_TAG}-bts
cp virtphy/osmo-bts.gen.cfg $VOL_BASE_DIR/bts/
network_replace_subnet_in_configs
-start_bts virtual 0
-start_virtphy
+# FIXME: multicast to/from a docker bridge network is currently not possible.
+# See https://github.com/moby/libnetwork/issues/2397.
+echo "XXX: not running the virtphy configuration"
+#start_bts virtual 0
+#start_virtphy
# ... and execute the testsuite again with different cfg
#start_testsuite virtphy
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35908?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I7c9ccc9cc400edb7a05e222e51671fd49631a4cd
Gerrit-Change-Number: 35908
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange