February 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: s2b: Fix FTEID interface in CreateSessionResponse

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35934?usp=email ) Change subject: s2b: Fix FTEID interface in CreateSessionResponse ...................................................................... s2b: Fix FTEID interface in CreateSessionResponse Change-Id: Iac76804738cdf237024bd762d5ea3aaf9a2cb9c1 --- M src/epdg_gtpc_s2b.erl 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl index 05aed1b..2adda97 100644 --- a/src/epdg_gtpc_s2b.erl +++ b/src/epdg_gtpc_s2b.erl @@ -302,7 +302,7 @@ % Do GTP specific msg parsing here, pass only relevant fields: #{{v2_fully_qualified_tunnel_endpoint_identifier,1} := #v2_fully_qualified_tunnel_endpoint_identifier{ - interface_type = 30, %% "S2b ePDG GTP-C" + interface_type = 32, %% "S2b PGW GTP-C" key = RemoteTEIC, ipv4 = _IPc4, ipv6 = _IPc6}, {v2_pdn_address_allocation,0} := Paa, {v2_bearer_context,0} := #v2_bearer_context{instance = 0, group = BearerIE}} = Resp#gtp.ie, @@ -310,7 +310,7 @@ #{{v2_eps_bearer_id,0} := #v2_eps_bearer_id{instance = 0, eps_bearer_id = Ebi}, {v2_fully_qualified_tunnel_endpoint_identifier,4} := #v2_fully_qualified_tunnel_endpoint_identifier{ - interface_type = 31, %% "S2b-U ePDG GTP-U" + interface_type = 33, %% "S2b-U PGW GTP-U" key = RemoteTEID, ipv4 = IPu4, ipv6 = IPu6} } = BearerIE, Bearer = gtp_session_find_bearer_by_ebi(Sess0, Ebi), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iac76804738cdf237024bd762d5ea3aaf9a2cb9c1 Gerrit-Change-Number: 35934 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: s2b: Fix FTEID interface in CreateSessionResponse

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35934?usp=email ) Change subject: s2b: Fix FTEID interface in CreateSessionResponse ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iac76804738cdf237024bd762d5ea3aaf9a2cb9c1 Gerrit-Change-Number: 35934 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Feb 2024 09:51:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: Expect NAI instead of Imsi in S6b AAR

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35931?usp=email ) Change subject: Expect NAI instead of Imsi in S6b AAR ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6599b84c2a0e1a758cb63bb9e419fa4c3cf4f4a6 Gerrit-Change-Number: 35931 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Feb 2024 09:51:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: gsup_server: Allow receiveing AuthInfo without PdpInfo

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35929?usp=email ) Change subject: gsup_server: Allow receiveing AuthInfo without PdpInfo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ife5293fd5942875c13bf29a462496bd8ea9212b7 Gerrit-Change-Number: 35929 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Feb 2024 09:51:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to co...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email ) Change subject: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to correct place ...................................................................... cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to correct place All the different procedures are placed in order, except this one. Change-Id: If0877deca2bcbf40229c9c61f471112f1e8cdb0e --- M tests/gsup/gsup_test.c 1 file changed, 25 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/42/35942/1 diff --git a/tests/gsup/gsup_test.c b/tests/gsup/gsup_test.c index 3d7ea40..fb3708a 100644 --- a/tests/gsup/gsup_test.c +++ b/tests/gsup/gsup_test.c @@ -454,20 +454,6 @@ 0x51, /* GSM0808_CAUSE_INVALID_MESSAGE_CONTENTS */ }; - static const uint8_t send_e_process_access_signalling_req[] = { - 0x40, /* OSMO_GSUP_MSGT_E_PROCESS_ACCESS_SIGNALLING_REQUEST */ - TEST_IMSI_IE, - - /* Session ID and state (continue) */ - 0x30, 0x04, 0xde, 0xad, 0xbe, 0xef, - 0x31, 0x01, 0x02, - - TEST_CLASS_INTER_MSC_IE, - TEST_SOURCE_NAME_IE, - TEST_DESTINATION_NAME_IE, - TEST_AN_APDU_IE, /* (Handover Detect) */ - }; - static const uint8_t send_e_send_end_signal_res[] = { 0x3E, /* OSMO_GSUP_MSGT_E_SEND_END_SIGNAL_RESULT */ TEST_IMSI_IE, @@ -482,6 +468,20 @@ TEST_AN_APDU_IE, /* (Handover Complete) */ }; + static const uint8_t send_e_process_access_signalling_req[] = { + 0x40, /* OSMO_GSUP_MSGT_E_PROCESS_ACCESS_SIGNALLING_REQUEST */ + TEST_IMSI_IE, + + /* Session ID and state (continue) */ + 0x30, 0x04, 0xde, 0xad, 0xbe, 0xef, + 0x31, 0x01, 0x02, + + TEST_CLASS_INTER_MSC_IE, + TEST_SOURCE_NAME_IE, + TEST_DESTINATION_NAME_IE, + TEST_AN_APDU_IE, /* (Handover Detect) */ + }; + static const uint8_t send_e_forward_access_signalling_req [] = { 0x44, /* OSMO_GSUP_MSGT_E_FORWARD_ACCESS_SIGNALLING_REQUEST */ TEST_IMSI_IE, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0877deca2bcbf40229c9c61f471112f1e8cdb0e Gerrit-Change-Number: 35942 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: gsup.adoc: Add links to section of each message type in table

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: gsup.adoc: Add links to section of each message type in table ...................................................................... gsup.adoc: Add links to section of each message type in table Change-Id: Idbc8a8f2e41f90e545a420517bd030399fb229ac --- M common/chapters/gsup.adoc 1 file changed, 112 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/98/35898/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idbc8a8f2e41f90e545a420517bd030399fb229ac Gerrit-Change-Number: 35898 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35899?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req ...................................................................... gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req Change-Id: Iccb397410d1b08c8fbc87fdcad1e787f025a5d9f --- M common/chapters/gsup.adoc 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/99/35899/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iccb397410d1b08c8fbc87fdcad1e787f025a5d9f Gerrit-Change-Number: 35899 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: gsup.adoc: Add links to section of each message type in table

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email ) Change subject: gsup.adoc: Add links to section of each message type in table ...................................................................... Patch Set 1: (1 comment) File common/chapters/gsup.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898/comment/4964b33a_6b47… PS1, Line 1129: ?? > Looks like you forgot to update these IEIs? I didn't forget, I didn't look them up since I considered this to be yet some other work and it was of no use for me here (I basically wanted to clarify which messages there are). I'll see if I have them added quickly. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Idbc8a8f2e41f90e545a420517bd030399fb229ac Gerrit-Change-Number: 35898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Feb 2024 09:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: gsup.adoc: Fix Authentication Info message naming in table

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35897?usp=email ) Change subject: gsup.adoc: Fix Authentication Info message naming in table ...................................................................... gsup.adoc: Fix Authentication Info message naming in table Change-Id: I6d5c95334c961f1f0aa083107713c31d9894c7aa --- M common/chapters/gsup.adoc 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index 8be4bae..912ff6b 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -1041,9 +1041,9 @@ |0x04|Update Location Request |0x05|Update Location Error |0x06|Update Location Result -|0x08|Send Auth Info Request -|0x09|Send Auth Info Error -|0x0a|Send Auth Info Result +|0x08|Send Authentication Info Request +|0x09|Send Authentication Info Error +|0x0a|Send Authentication Info Result |0x0b|Authentication Failure Report |0x0c|Purge MS Request |0x0d|Purge MS Error -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I6d5c95334c961f1f0aa083107713c31d9894c7aa Gerrit-Change-Number: 35897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in libosmo-sccp[master]: vty_test_runner: Don't wait for more than 10s when connecting to sockets

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35940?usp=email ) Change subject: vty_test_runner: Don't wait for more than 10s when connecting to sockets ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35940?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iadb437ce0bafb28baa978d287dbb1006ec97f236 Gerrit-Change-Number: 35940 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 12 Feb 2024 09:31:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024