December 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: rspro_client: Make struct osmo_rspro_client private

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email ) Change subject: rspro_client: Make struct osmo_rspro_client private ...................................................................... rspro_client: Make struct osmo_rspro_client private That struct contains lots of implementation specific fields we may want to change in the future, like the current use to ipa_client_conn which will eventually be deprecated. Related: OS#5896 Change-Id: I3bacae853101a79804553175ebd4482acb188597 --- M include/osmocom/rspro/rspro_client.h M src/rspro_client_fsm.h 2 files changed, 13 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/21/39021/1 diff --git a/include/osmocom/rspro/rspro_client.h b/include/osmocom/rspro/rspro_client.h index 76f3da6..0a9f587 100644 --- a/include/osmocom/rspro/rspro_client.h +++ b/include/osmocom/rspro/rspro_client.h @@ -34,19 +34,6 @@ /* Expects message in msg->l2h */ typedef int (*osmo_rspro_client_read_cb_t)(struct osmo_rspro_client *rsproc, struct msgb *msg); -struct osmo_rspro_client { - const char *unit_name; - - struct ipa_client_conn *link; - osmo_rspro_client_read_cb_t read_cb; - void *data; - - struct osmo_timer_list ping_timer; - struct osmo_timer_list connect_timer; - int is_connected; - int got_ipa_pong; -}; - struct osmo_rspro_client *osmo_rspro_client_create(void *talloc_ctx, const char *unit_name, const char *ip_addr, diff --git a/src/rspro_client_fsm.h b/src/rspro_client_fsm.h index 55fe4a4..dfed2db 100644 --- a/src/rspro_client_fsm.h +++ b/src/rspro_client_fsm.h @@ -3,6 +3,7 @@ #include <osmocom/core/fsm.h> #include <osmocom/abis/ipa.h> #include <osmocom/rspro/RsproPDU.h> +#include <osmocom/rspro/rspro_client.h> #include "rspro_util.h" @@ -17,7 +18,18 @@ SRVC_E_RSPRO_TX /* transmit a RSPRO PDU to the peer */ }; -struct rspro_server_conn; +struct osmo_rspro_client { + const char *unit_name; + + struct ipa_client_conn *link; + osmo_rspro_client_read_cb_t read_cb; + void *data; + + struct osmo_timer_list ping_timer; + struct osmo_timer_list connect_timer; + int is_connected; + int got_ipa_pong; +}; /* representing a client-side connection to a RSPRO server */ struct rspro_server_conn { -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3bacae853101a79804553175ebd4482acb188597 Gerrit-Change-Number: 39021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: Makefile:am: Improve formatting and order of CFLAGS and LIBS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email ) Change subject: Makefile:am: Improve formatting and order of CFLAGS and LIBS ...................................................................... Makefile:am: Improve formatting and order of CFLAGS and LIBS Place osmocom libraries in proper dependency order. Change-Id: Ia766a09103d2216258a83cc98899e6cae4b0351d --- M src/Makefile.am M src/bankd/Makefile.am M src/client/Makefile.am M src/server/Makefile.am 4 files changed, 39 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/20/39020/1 diff --git a/src/Makefile.am b/src/Makefile.am index b305ce2..5c10373 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -8,7 +8,9 @@ SUBDIRS += client AM_CFLAGS = -Wall -I$(top_srcdir)/include -I$(top_builddir)/include \ - $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ + $(OSMOABIS_CFLAGS) \ + $(OSMOGSM_CFLAGS) \ + $(OSMOCORE_CFLAGS) \ -I$(top_srcdir)/include/osmocom/rspro RSPRO_LIBVERSION=2:0:0 diff --git a/src/bankd/Makefile.am b/src/bankd/Makefile.am index 4899aef..937464b 100644 --- a/src/bankd/Makefile.am +++ b/src/bankd/Makefile.am @@ -1,6 +1,8 @@ AM_CFLAGS = -Wall -I$(top_srcdir)/include -I$(top_builddir)/include -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ - $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ + $(OSMOABIS_CFLAGS) \ + $(OSMOGSM_CFLAGS) \ + $(OSMOCORE_CFLAGS) \ $(PCSC_CFLAGS) noinst_HEADERS = bankd.h internal.h gsmtap.h @@ -14,8 +16,12 @@ osmo_remsim_bankd_SOURCES = ../slotmap.c ../rspro_client_fsm.c ../debug.c \ bankd_main.c bankd_pcsc.c gsmtap.c -osmo_remsim_bankd_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ - $(PCSC_LIBS) $(CSV_LIBS) $(top_builddir)/src/libosmo-rspro.la +osmo_remsim_bankd_LDADD = $(OSMOABIS_LIBS) \ + $(OSMOGSM_LIBS) \ + $(OSMOCORE_LIBS) \ + $(PCSC_LIBS) \ + $(CSV_LIBS) \ + $(top_builddir)/src/libosmo-rspro.la # as suggested in http://lists.gnu.org/archive/html/automake/2009-03/msg00011.html FORCE: diff --git a/src/client/Makefile.am b/src/client/Makefile.am index f158424..069206e 100644 --- a/src/client/Makefile.am +++ b/src/client/Makefile.am @@ -1,5 +1,7 @@ AM_CFLAGS = -Wall -I$(top_srcdir)/include -I/$(top_builddir)/include -I$(top_srcdir)/src \ - $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ + $(OSMOABIS_CFLAGS) \ + $(OSMOGSM_CFLAGS) \ + $(OSMOCORE_CFLAGS) \ $(PCSC_CFLAGS) $(USB_CFLAGS) \ $(OSMOSIMTRACE2_CFLAGS) \ -I$(top_srcdir)/include/osmocom/rspro @@ -9,8 +11,10 @@ osmo_remsim_client_shell_SOURCES = user_shell.c remsim_client_main.c \ remsim_client.c main_fsm.c ../rspro_client_fsm.c ../debug.c osmo_remsim_client_shell_CFLAGS = $(AM_CFLAGS) -osmo_remsim_client_shell_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ - $(top_builddir)/src/libosmo-rspro.la +osmo_remsim_client_shell_LDADD = $(OSMOABIS_LIBS) \ + $(OSMOGSM_LIBS) \ + $(OSMOCORE_LIBS) \ + $(top_builddir)/src/libosmo-rspro.la if BUILD_CLIENT_IFDHANDLER EXTRA_DIST=PkgInfo osmo-remsim-client-reader_conf.in @@ -24,8 +28,10 @@ libifd_remsim_client_la_CFLAGS = $(AM_CFLAGS) libifd_remsim_client_la_CPPFLAGS = $(PCSC_CFLAGS) libifd_remsim_client_la_LDFLAGS = -no-undefined -libifd_remsim_client_la_LIBADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ - $(top_builddir)/src/libosmo-rspro.la +libifd_remsim_client_la_LIBADD = $(OSMOABIS_LIBS) \ + $(OSMOGSM_LIBS) \ + $(OSMOCORE_LIBS) \ + $(top_builddir)/src/libosmo-rspro.la endif if BUILD_CLIENT_ST2 @@ -34,10 +40,12 @@ remsim_client.c main_fsm.c ../rspro_client_fsm.c ../debug.c osmo_remsim_client_st2_CPPFLAGS = -DUSB_SUPPORT -DSIMTRACE_SUPPORT osmo_remsim_client_st2_CFLAGS = $(AM_CFLAGS) -osmo_remsim_client_st2_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ +osmo_remsim_client_st2_LDADD = $(OSMOABIS_LIBS) \ + $(OSMOGSM_LIBS) \ + $(OSMOCORE_LIBS) \ $(OSMOUSB_LIBS) $(OSMOSIMTRACE2_LIBS) \ $(USB_LIBS) \ $(top_builddir)/src/libosmo-rspro.la endif -noinst_HEADERS = client.h +noinst_HEADERS = client.h diff --git a/src/server/Makefile.am b/src/server/Makefile.am index f6278a3..b51ea94 100644 --- a/src/server/Makefile.am +++ b/src/server/Makefile.am @@ -1,8 +1,12 @@ AM_CFLAGS = -Wall -I$(top_srcdir)/include -I$(top_builddir)/include -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ - $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ - $(ULFIUS_CFLAGS) $(JANSSON_CFLAGS) $(ORCANIA_CFLAGS) + $(OSMOABIS_CFLAGS) \ + $(OSMOGSM_CFLAGS) \ + $(OSMOCORE_CFLAGS) \ + $(ULFIUS_CFLAGS) \ + $(JANSSON_CFLAGS) \ + $(ORCANIA_CFLAGS) noinst_HEADERS = rspro_server.h rest_api.h @@ -10,8 +14,12 @@ osmo_remsim_server_SOURCES = remsim_server.c rspro_server.c rest_api.c \ ../rspro_util.c ../slotmap.c ../debug.c -osmo_remsim_server_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ - $(ULFIUS_LIBS) $(JANSSON_LIBS) $(ORCANIA_LIBS) \ +osmo_remsim_server_LDADD = $(OSMOABIS_LIBS) \ + $(OSMOGSM_LIBS) \ + $(OSMOCORE_LIBS) \ + $(ULFIUS_LIBS) \ + $(JANSSON_LIBS) \ + $(ORCANIA_LIBS) \ $(top_builddir)/src/libosmo-rspro.la # as suggested in http://lists.gnu.org/archive/html/automake/2009-03/msg00011.html -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia766a09103d2216258a83cc98899e6cae4b0351d Gerrit-Change-Number: 39020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp: Rework gtp_resp() into gtp_resp_pdp()

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38933?usp=email ) Change subject: gtp: Rework gtp_resp() into gtp_resp_pdp() ...................................................................... Patch Set 3: (1 comment) File gtp/gtp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38933/comment/d8b48d21_92e43075?us… : PS3, Line 132: static int gtp_resp(struct gsn_t *gsn, union gtp_packet *packet, int len, struct sockaddr_in *peer, int fd, uint16_t seq, uint64_t tid, uint16_t flow, uint32_t tei); This is not needed afaict. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id9ff95e0e2a10a22e65ecf42b2a2b06a0f2d1a45 Gerrit-Change-Number: 38933 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Dec 2024 17:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email ) Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... Patch Set 4: (1 comment) File gtp/gsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38930/comment/f7bfa9ba_44393715?us… : PS4, Line 119: TALLOC_CTX *tall_gsn_ctx = NULL; this should be static afaiu? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Dec 2024 17:06:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email ) Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: missing entry in TODO-RELEASE annoncing new API. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Dec 2024 17:05:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: assign random TEID-C to Context Req/Resp/Ack messages

by pespin

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email ) Change subject: SGSN: assign random TEID-C to Context Req/Resp/Ack messages ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icac28280a810e8d24eeeaaae1fb1a15278fde8da Gerrit-Change-Number: 38921 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Dec 2024 17:03:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: Context Req In: use correct TEID-C

by pespin

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920?usp=email ) Change subject: SGSN: Context Req In: use correct TEID-C ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I84dc7dda8ee1227edd68d1482a4c5bf267c16418 Gerrit-Change-Number: 38920 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Dec 2024 17:03:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Dec 2024 17:02:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct ...................................................................... Patch Set 6: (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397/comment/dc2100b6_cf74… : PS6, Line 628: * NOTE: The old osmo-SGSN will always respond with a ServiceAccept even when the spec is clear this is not neede. osmo-sgsn needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29237997e414aea80f254247da54f909410a4b36 Gerrit-Change-Number: 38397 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Dec 2024 17:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 3 weeks

1
0
0 0

[L] Change in osmo-msc[master]: Use gsup_client_mux from libosmo-gsup-client

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email ) Change subject: Use gsup_client_mux from libosmo-gsup-client ...................................................................... Use gsup_client_mux from libosmo-gsup-client gsup_client_mux code was cloned a couple months ago to libosmo-gsup-client, use it in osmo-msc and drop its own copy. The code was not dropped at the time because it required tweaking the unit tests, because they were wrapping some underlaying functions which cannot be wrapped anymore since the code using them is now inside the separate already-linked libosmo-gsup-client.so. Solve it by actually wrapping one layer up in the gsup_client_mux itself since it now something we mantain here anymore. Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242 --- M TODO-RELEASE M include/osmocom/msc/Makefile.am D include/osmocom/msc/gsup_client_mux.h M src/libmsc/Makefile.am M src/libmsc/e_link.c M src/libmsc/gsm_04_11_gsup.c M src/libmsc/gsm_09_11.c D src/libmsc/gsup_client_mux.c M src/libmsc/msc_net_init.c M src/libvlr/vlr.c M src/osmo-msc/msc_main.c M tests/msc_vlr/Makefile.am M tests/msc_vlr/msc_vlr_tests.c 13 files changed, 47 insertions(+), 249 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/19/39019/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34d02ae219f3ec8daf47942c46f52b21eab21242 Gerrit-Change-Number: 39019 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024