November 2024 - gerrit-log - lists.osmocom.org

[S] Change in meta-telephony[laforge/nightly]: libosmo-abis after libosmo-netif

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email ) Change subject: libosmo-abis after libosmo-netif ...................................................................... libosmo-abis after libosmo-netif Depends: libosmo-abis I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif I13d6e88158f6d9ce017986283183ee9c2cc68cae Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 --- M recipes-osmocom/libosmo-abis/libosmo-abis.inc M recipes-osmocom/libosmo-netif/libosmo-netif.inc M recipes-osmocom/osmo-mgw/osmo-mgw.inc 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: osmith: Verified pespin: Looks good to me, approved diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis.inc b/recipes-osmocom/libosmo-abis/libosmo-abis.inc index 955ebe3..84393d0 100644 --- a/recipes-osmocom/libosmo-abis/libosmo-abis.inc +++ b/recipes-osmocom/libosmo-abis/libosmo-abis.inc @@ -2,9 +2,9 @@ HOMEPAGE = "https://osmocom.org/projects/libosmo-abis" LICENSE = "AGPLv3" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -INC_PR="r1.${META_TELEPHONY_OSMO_INC}" +INC_PR="r2.${META_TELEPHONY_OSMO_INC}" -DEPENDS = "libosmocore ortp libtalloc" +DEPENDS = "libosmocore libosmo-netif ortp libtalloc" inherit autotools pkgconfig diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif.inc b/recipes-osmocom/libosmo-netif/libosmo-netif.inc index 3b5ef19..72d7140 100644 --- a/recipes-osmocom/libosmo-netif/libosmo-netif.inc +++ b/recipes-osmocom/libosmo-netif/libosmo-netif.inc @@ -3,9 +3,9 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" -INC_PR="r1.${META_TELEPHONY_OSMO_INC}" +INC_PR="r2.${META_TELEPHONY_OSMO_INC}" -DEPENDS = "libosmo-abis libtalloc" +DEPENDS = "libosmocore libtalloc" PACKAGECONFIG ??= "\ libsctp \ diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw.inc b/recipes-osmocom/osmo-mgw/osmo-mgw.inc index 5e740db..9662896 100644 --- a/recipes-osmocom/osmo-mgw/osmo-mgw.inc +++ b/recipes-osmocom/osmo-mgw/osmo-mgw.inc @@ -3,9 +3,9 @@ LICENSE = "AGPLv3" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -DEPENDS = "libosmocore libosmo-netif" +DEPENDS = "libosmocore libosmo-netif libosmo-abis" -INC_PR="r4.${META_TELEPHONY_OSMO_INC}" +INC_PR="r5.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 Gerrit-Change-Number: 38881 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in meta-telephony[laforge/nightly]: libosmo-abis after libosmo-netif

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email ) Change subject: libosmo-abis after libosmo-netif ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 Gerrit-Change-Number: 38881 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 10:38:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in meta-telephony[laforge/nightly]: libosmo-abis after libosmo-netif

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email ) Change subject: libosmo-abis after libosmo-netif ...................................................................... Patch Set 2: Verified+1 (3 comments) Patchset: PS2: tested with sysmocom-oe-userbuilds File recipes-osmocom/libosmo-abis/libosmo-abis.inc: https://gerrit.osmocom.org/c/meta-telephony/+/38881/comment/4f26fa51_ec0d6c… : PS1, Line 7: DEPENDS = "libosmo-netif ortp libtalloc" > you still need to keep libosmocore, since the library also depends directly on libosmocore. Done File recipes-osmocom/osmo-mgw/osmo-mgw.inc: https://gerrit.osmocom.org/c/meta-telephony/+/38881/comment/4f608e1c_9bcdcb… : PS1, Line 6: DEPENDS = "libosmocore libosmo-abis" > osmo-mgw also uses libosmo-netif directly, so keep it. Done -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 Gerrit-Change-Number: 38881 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 10:37:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in meta-telephony[laforge/nightly]: libosmo-abis after libosmo-netif

by osmith

Attention is currently required from: osmith, pespin. Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by osmith Change subject: libosmo-abis after libosmo-netif ...................................................................... libosmo-abis after libosmo-netif Depends: libosmo-abis I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif I13d6e88158f6d9ce017986283183ee9c2cc68cae Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 --- M recipes-osmocom/libosmo-abis/libosmo-abis.inc M recipes-osmocom/libosmo-netif/libosmo-netif.inc M recipes-osmocom/osmo-mgw/osmo-mgw.inc 3 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/81/38881/2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 Gerrit-Change-Number: 38881 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in libosmo-netif[master]: examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38872?usp=email ) Change subject: examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg() ...................................................................... examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg() The function osmo_ipa_process_msg() is already called internally by the segmentation callback osmo_ipa_segmentation_cb(), which calls ipa_check_pull_headers() which in turn calls osmo_ipa_process_msg(). The program was still working because it was using msg->data which isn't modified by osmo_ipa_process_msg(), but the l2h pointer was incorrectly modified. Change-Id: Idec574f59587c681dd059266c9a9cf244bf41dc3 --- M examples/ipa-stream-client.c 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c index b58370e..2604266 100644 --- a/examples/ipa-stream-client.c +++ b/examples/ipa-stream-client.c @@ -115,13 +115,7 @@ return 0; } - if (osmo_ipa_process_msg(msg) < 0) { - LOGP(DIPATEST, LOGL_ERROR, "bad IPA message\n"); - msgb_free(msg); - return 0; - } - - num = osmo_load32be(msg->data); + num = osmo_load32be(msgb_l2(msg)); LOGP(DLINP, LOGL_DEBUG, "received msg number %d\n", num); llist_for_each_entry_safe(cur, tmp, &msg_sent_list, head) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Idec574f59587c681dd059266c9a9cf244bf41dc3 Gerrit-Change-Number: 38872 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in meta-telephony[laforge/nightly]: libosmo-abis after libosmo-netif

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email ) Change subject: libosmo-abis after libosmo-netif ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File recipes-osmocom/libosmo-abis/libosmo-abis.inc: https://gerrit.osmocom.org/c/meta-telephony/+/38881/comment/21aab630_fd6504… : PS1, Line 7: DEPENDS = "libosmo-netif ortp libtalloc" you still need to keep libosmocore, since the library also depends directly on libosmocore. File recipes-osmocom/osmo-mgw/osmo-mgw.inc: https://gerrit.osmocom.org/c/meta-telephony/+/38881/comment/42d77c8d_14ae20… : PS1, Line 6: DEPENDS = "libosmocore libosmo-abis" osmo-mgw also uses libosmo-netif directly, so keep it. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 Gerrit-Change-Number: 38881 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 10:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in meta-telephony[laforge/nightly]: libosmo-abis after libosmo-netif

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email ) Change subject: libosmo-abis after libosmo-netif ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: tested with sysmocom-oe-userbuilds -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 Gerrit-Change-Number: 38881 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 10:27:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in meta-telephony[laforge/nightly]: libosmo-abis after libosmo-netif

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email ) Change subject: libosmo-abis after libosmo-netif ...................................................................... libosmo-abis after libosmo-netif Depends: libosmo-abis I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif I13d6e88158f6d9ce017986283183ee9c2cc68cae Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 --- M recipes-osmocom/libosmo-abis/libosmo-abis.inc M recipes-osmocom/libosmo-netif/libosmo-netif.inc M recipes-osmocom/osmo-mgw/osmo-mgw.inc 3 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/81/38881/1 diff --git a/recipes-osmocom/libosmo-abis/libosmo-abis.inc b/recipes-osmocom/libosmo-abis/libosmo-abis.inc index 955ebe3..a08545b 100644 --- a/recipes-osmocom/libosmo-abis/libosmo-abis.inc +++ b/recipes-osmocom/libosmo-abis/libosmo-abis.inc @@ -2,9 +2,9 @@ HOMEPAGE = "https://osmocom.org/projects/libosmo-abis" LICENSE = "AGPLv3" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -INC_PR="r1.${META_TELEPHONY_OSMO_INC}" +INC_PR="r2.${META_TELEPHONY_OSMO_INC}" -DEPENDS = "libosmocore ortp libtalloc" +DEPENDS = "libosmo-netif ortp libtalloc" inherit autotools pkgconfig diff --git a/recipes-osmocom/libosmo-netif/libosmo-netif.inc b/recipes-osmocom/libosmo-netif/libosmo-netif.inc index 3b5ef19..72d7140 100644 --- a/recipes-osmocom/libosmo-netif/libosmo-netif.inc +++ b/recipes-osmocom/libosmo-netif/libosmo-netif.inc @@ -3,9 +3,9 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" -INC_PR="r1.${META_TELEPHONY_OSMO_INC}" +INC_PR="r2.${META_TELEPHONY_OSMO_INC}" -DEPENDS = "libosmo-abis libtalloc" +DEPENDS = "libosmocore libtalloc" PACKAGECONFIG ??= "\ libsctp \ diff --git a/recipes-osmocom/osmo-mgw/osmo-mgw.inc b/recipes-osmocom/osmo-mgw/osmo-mgw.inc index 5e740db..2b47b55 100644 --- a/recipes-osmocom/osmo-mgw/osmo-mgw.inc +++ b/recipes-osmocom/osmo-mgw/osmo-mgw.inc @@ -3,9 +3,9 @@ LICENSE = "AGPLv3" LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" -DEPENDS = "libosmocore libosmo-netif" +DEPENDS = "libosmocore libosmo-abis" -INC_PR="r4.${META_TELEPHONY_OSMO_INC}" +INC_PR="r5.${META_TELEPHONY_OSMO_INC}" inherit autotools pkgconfig systemd -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/38881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: I9b29b974ae158e3bcfe622db13dae22ce4bac003 Gerrit-Change-Number: 38881 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in osmo-e1-hardware[master]: contrib/jenkins: libosmo-abis after libosmo-netif

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38875?usp=email ) Change subject: contrib/jenkins: libosmo-abis after libosmo-netif ...................................................................... contrib/jenkins: libosmo-abis after libosmo-netif Depends: libosmo-abis I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif I13d6e88158f6d9ce017986283183ee9c2cc68cae Change-Id: I0a15d59616f2b492ec52f279e26f3986aaafc5b2 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved; Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index b2f49f5..eaba400 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -75,6 +75,7 @@ mkdir -p "$deps" osmo-build-dep.sh libosmocore "" ac_cv_path_DOXYGEN=false + osmo-build-dep.sh libosmo-netif "" --disable-doxygen osmo-build-dep.sh libosmo-abis SW_DIRS="software/e1-tracer/record software/e1-tracer/analyze" -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I0a15d59616f2b492ec52f279e26f3986aaafc5b2 Gerrit-Change-Number: 38875 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in osmo-e1-hardware[master]: contrib/jenkins: libosmo-abis after libosmo-netif

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38875?usp=email ) Change subject: contrib/jenkins: libosmo-abis after libosmo-netif ...................................................................... Patch Set 3: (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38875/comment/c6a898e8_582c… : PS2, Line 78: osmo-build-dep.sh libosmo-netif > add "" --disable-doxygen Done -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I0a15d59616f2b492ec52f279e26f3986aaafc5b2 Gerrit-Change-Number: 38875 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 10:25:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024