Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38625?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: sigtran: xua_msg.h,msg_types.h: Make headers private
......................................................................
sigtran: xua_msg.h,msg_types.h: Make headers private
Those headers are only used internally in libosmo-sigtran, since those
objects have no real use outside of it. Mark the headers as no-install,
which implicitly makes them private.
This decreases the amount of public APIs the libosmo-sigtran has.
Change-Id: Icd23bf9c9364c33ea2ba709e3ef4439813a168f4
---
M include/osmocom/sigtran/Makefile.am
M src/Makefile.am
R src/xua_msg.h
R src/xua_types.h
4 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/25/38625/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38625?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Icd23bf9c9364c33ea2ba709e3ef4439813a168f4
Gerrit-Change-Number: 38625
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38625?usp=email )
Change subject: sigtran: xua_msg.h,msg_types.h: Make headers private
......................................................................
sigtran: xua_msg.h,msg_types.h: Make headers private
Those headers are only used internally in libosmo-sigtran, since those
objects have no real use outside of it. Mark the headers as no-install,
which implicitly makes them private since they won't be accessible to be
used as they are not installed.
This decreases the amount of public APIs the libosmo-sigtran has.
Change-Id: Icd23bf9c9364c33ea2ba709e3ef4439813a168f4
---
M include/osmocom/sigtran/Makefile.am
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/25/38625/1
diff --git a/include/osmocom/sigtran/Makefile.am b/include/osmocom/sigtran/Makefile.am
index 8d90b0b..19f9dba 100644
--- a/include/osmocom/sigtran/Makefile.am
+++ b/include/osmocom/sigtran/Makefile.am
@@ -1,5 +1,15 @@
-sigtran_HEADERS = xua_types.h xua_msg.h sccp_sap.h \
- sigtran_sap.h sccp_helpers.h mtp_sap.h osmo_ss7.h
+noinst_HEADERS = \
+ xua_msg.h \
+ xua_types.h \
+ $(NULL)
+
+sigtran_HEADERS = \
+ mtp_sap.h \
+ osmo_ss7.h \
+ sccp_helpers.h \
+ sccp_sap.h \
+ sigtran_sap.h \
+ $(NULL)
sigtrandir = $(includedir)/osmocom/sigtran
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38625?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Icd23bf9c9364c33ea2ba709e3ef4439813a168f4
Gerrit-Change-Number: 38625
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38616?usp=email )
Change subject: Add PFCP stats item group
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I actually nee to merge this one since I already merged the ttcn3 related patch, otherwise the check against nightly will be unexpected. Merging since it was already reviewed at least by fixeria.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38616?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic71df8df83e97f4015077677e426c803f84d31ea
Gerrit-Change-Number: 38616
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Nov 2024 17:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38623?usp=email )
Change subject: hnbgw: Avoid using struct osmo_pfcp_cp_peer fields directly
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Requires https://gerrit.osmocom.org/c/libosmo-pfcp/+/38622 merged to have jenkins passing.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38623?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I2f587cfb7fd556bcfc43bf70fc93bc79a3c211ca
Gerrit-Change-Number: 38623
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 04 Nov 2024 17:11:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No