November 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-netif[master]: stream_cli: Support destroy object within user callback

by daniel

Attention is currently required from: fixeria, osmith, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38911?usp=email ) Change subject: stream_cli: Support destroy object within user callback ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I952938474fa2780bf3c906cbdffb2d024b03c1b7 Gerrit-Change-Number: 38911 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Nov 2024 10:16:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 4 weeks

1
0
0 0

[XS] Change in ...pyosmocom[master]: Bump version to 0.0.7

by dexter

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email ) Change subject: Bump version to 0.0.7 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks. Jenkins is back to normal now. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iefe39999e6435a04c12bfbb847873fa605b4ef68 Gerrit-Change-Number: 38951 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Nov 2024 09:50:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 4 weeks

1
0
0 0

[XS] Change in pysim[master]: ts_31_102: fix testcase for EF_ePDGSelection

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38941?usp=email ) Change subject: ts_31_102: fix testcase for EF_ePDGSelection ...................................................................... ts_31_102: fix testcase for EF_ePDGSelection the testcase EF_ePDGSelection has a wrong testvector in the plmn field. This test vector is accepted because there is a complementary error in pyosmocom. However, the root problem got fixed (see depends), which means that the test vector of EF_ePDGSelection now needs to be updated. Depends: pyosmocom.git: I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Related: OS#6598 --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 4eeacf2..1795341 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -876,6 +876,7 @@ _test_de_encode = [ ( '800600f110000100', {'e_pdg_selection': [{'plmn': '001-01', 'epdg_priority': 1, 'epdg_fqdn_format': 'operator_identified' }] }), ( '800600110000a001', {'e_pdg_selection': [{'plmn': '001-001', 'epdg_priority': 160, 'epdg_fqdn_format': 'location_based' }] }), + ( '800600011000a001', {'e_pdg_selection': [{'plmn': '001-010', 'epdg_priority': 160, 'epdg_fqdn_format': 'location_based' }] }), ] class ePDGSelection(BER_TLV_IE, tag=0x80): _construct = GreedyRange(Struct('plmn'/PlmnAdapter(Bytes(3)), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Gerrit-Change-Number: 38941 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

6 months, 4 weeks

1
0
0 0

[XS] Change in pysim[master]: ts_31_102: fix testcase for EF_ePDGSelection

by dexter

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38941?usp=email ) Change subject: ts_31_102: fix testcase for EF_ePDGSelection ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: (just fixed the merge conflict.) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Gerrit-Change-Number: 38941 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Nov 2024 09:36:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 4 weeks

1
0
0 0

[S] Change in docker-playground[master]: pcuif: increase PCUIF version number

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/38094?usp=email ) Change subject: pcuif: increase PCUIF version number ...................................................................... Abandoned We have found a simpler solution. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I15f7150b51047379a557a1f8df6330eca597f2e3 Gerrit-Change-Number: 38094 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

6 months, 4 weeks

1
0
0 0

[S] Change in docker-playground[master]: pcuif: increase PCUIF version number

by dexter

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/docker-playground/+/38094?usp=email ) Change subject: pcuif: increase PCUIF version number ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > should this [and related patches] be abandoned? This one in any case, the related ones too, but I want to look at those before. Maybe it is not a bad idea to put some comments. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I15f7150b51047379a557a1f8df6330eca597f2e3 Gerrit-Change-Number: 38094 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Nov 2024 09:34:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

6 months, 4 weeks

1
0
0 0

[XS] Change in pysim[master]: ts_31_102: fix testcase for EF_ePDGSelection

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38941?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ts_31_102: fix testcase for EF_ePDGSelection ...................................................................... ts_31_102: fix testcase for EF_ePDGSelection the testcase EF_ePDGSelection has a wrong testvector in the plmn field. This test vector is accepted because there is a complementary error in pyosmocom. However, the root problem got fixed (see depends), which means that the test vector of EF_ePDGSelection now needs to be updated. Depends: pyosmocom.git: I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Related: OS#6598 --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/38941/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Gerrit-Change-Number: 38941 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

6 months, 4 weeks

1
0
0 0

[XS] Change in pysim[master]: ts_31_102: fix testcase for EF_ePDGSelection

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38941?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by dexter, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: ts_31_102: fix testcase for EF_ePDGSelection ...................................................................... ts_31_102: fix testcase for EF_ePDGSelection the testcase EF_ePDGSelection has a wrong testvector in the plmn field. This test vector is accepted because there is a complementary error in pyosmocom. However, the root problem got fixed (see depends), which means that the test vector of EF_ePDGSelection now needs to be updated. Depends: pyosmocom.git: I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Related: OS#6598 --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/41/38941/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38941?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I96fd4c13c8e58ef33ddf9e3124617b1b59b9b2c1 Gerrit-Change-Number: 38941 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

6 months, 4 weeks

1
0
0 0

[XS] Change in pysim[master]: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for E...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38688?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. ...................................................................... Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. Related: pyosmocom.git I3811b227d629bd4e051a480c9622967e31f8a376 Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e --- M pySim/ts_31_102.py M pySim/ts_51_011.py 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 636cf37..4eeacf2 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -875,7 +875,7 @@ class EF_ePDGSelection(TransparentEF): _test_de_encode = [ ( '800600f110000100', {'e_pdg_selection': [{'plmn': '001-01', 'epdg_priority': 1, 'epdg_fqdn_format': 'operator_identified' }] }), - ( '800600011000a001', {'e_pdg_selection': [{'plmn': '001-001', 'epdg_priority': 160, 'epdg_fqdn_format': 'location_based' }] }), + ( '800600110000a001', {'e_pdg_selection': [{'plmn': '001-001', 'epdg_priority': 160, 'epdg_fqdn_format': 'location_based' }] }), ] class ePDGSelection(BER_TLV_IE, tag=0x80): _construct = GreedyRange(Struct('plmn'/PlmnAdapter(Bytes(3)), diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index d28e8ee..eb1984e 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -886,6 +886,8 @@ _test_de_encode = [ ( '62f2100000fffe01', { "lai": { "mcc_mnc": "262-01", "lac_min": "0000", "lac_max": "fffe" }, "pnn_record_id": 1 } ), + ( '216354789abcde12', + { "lai": { "mcc_mnc": "123-456", "lac_min": "789a", "lac_max": "bcde" }, "pnn_record_id": 18 } ), ] def __init__(self, fid='6fc6', sfid=None, name='EF.OPL', rec_len=(8, 8), desc='Operator PLMN List', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=rec_len, **kwargs) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e Gerrit-Change-Number: 38688 Gerrit-PatchSet: 4 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

6 months, 4 weeks

1
0
0 0

[S] Change in docker-playground[master]: pcuif: increase PCUIF version number

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/docker-playground/+/38094?usp=email ) Change subject: pcuif: increase PCUIF version number ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: should this [and related patches] be abandoned? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I15f7150b51047379a557a1f8df6330eca597f2e3 Gerrit-Change-Number: 38094 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Nov 2024 07:30:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024