October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: utils: fix lost inttypes mess for embedded builds
by laforge 21 Oct '24

21 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38443?usp=email ) Change subject: utils: fix lost inttypes mess for embedded builds ...................................................................... utils: fix lost inttypes mess for embedded builds Oh no, again? Yes, this, again. Change-Id: I412f5813d566cf71f3e44c3c1dc16200fa518a47 --- M src/core/utils.c 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/utils.c b/src/core/utils.c index 1ec940d..5757b52 100644 --- a/src/core/utils.c +++ b/src/core/utils.c @@ -25,6 +25,14 @@ #include <stdint.h> #include <errno.h> #include <stdio.h> +#if !defined(PRId64) || !defined(PRIu64) +/* +it gets lost every few years.. +https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=953844 +https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067692 +*/ +#include <sys/types.h> +#endif #include <inttypes.h> #include <limits.h> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I412f5813d566cf71f3e44c3c1dc16200fa518a47 Gerrit-Change-Number: 38443 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmocore[master]: utils: fix lost inttypes mess for embedded builds
by laforge 21 Oct '24

21 Oct '24

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/38443?usp=email ) Change subject: utils: fix lost inttypes mess for embedded builds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38443?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I412f5813d566cf71f3e44c3c1dc16200fa518a47 Gerrit-Change-Number: 38443 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Oct 2024 11:10:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9]
by laforge 21 Oct '24

21 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email ) Change subject: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9] ...................................................................... gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9] The MCS9 actually goes to the first octet, MCS1..8 fill the second one. Change-Id: I85316af9b57e8113077305798cb2d82a24e48e00 Fixes: a7d7cf28 "gsm_12_21.h: add flags for NM_ATT_IPACC_SUPP_FEATURES" Related: OS#4505 --- M include/osmocom/gsm/protocol/gsm_12_21.h 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index 39b1d45..ff10b07 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -835,15 +835,15 @@ #define NM_IPAC_F_GPRS_CODING_CS3 (1 << 2) #define NM_IPAC_F_GPRS_CODING_CS4 (1 << 3) /*! ip.access support flags for NM_IPAC_EIE_GPRS_CODING (EGPRS) */ -#define NM_IPAC_F_GPRS_CODING_MCS1 (1 << 7) -#define NM_IPAC_F_GPRS_CODING_MCS2 (1 << 8) -#define NM_IPAC_F_GPRS_CODING_MCS3 (1 << 9) -#define NM_IPAC_F_GPRS_CODING_MCS4 (1 << 10) -#define NM_IPAC_F_GPRS_CODING_MCS5 (1 << 11) -#define NM_IPAC_F_GPRS_CODING_MCS6 (1 << 12) -#define NM_IPAC_F_GPRS_CODING_MCS7 (1 << 13) -#define NM_IPAC_F_GPRS_CODING_MCS8 (1 << 14) -#define NM_IPAC_F_GPRS_CODING_MCS9 (1 << 15) +#define NM_IPAC_F_GPRS_CODING_MCS1 (1 << 8) +#define NM_IPAC_F_GPRS_CODING_MCS2 (1 << 9) +#define NM_IPAC_F_GPRS_CODING_MCS3 (1 << 10) +#define NM_IPAC_F_GPRS_CODING_MCS4 (1 << 11) +#define NM_IPAC_F_GPRS_CODING_MCS5 (1 << 12) +#define NM_IPAC_F_GPRS_CODING_MCS6 (1 << 13) +#define NM_IPAC_F_GPRS_CODING_MCS7 (1 << 14) +#define NM_IPAC_F_GPRS_CODING_MCS8 (1 << 15) +#define NM_IPAC_F_GPRS_CODING_MCS9 (1 << 7) /*! ip.access support flags for NM_IPAC_EIE_RTP_FEATURES */ #define NM_IPAC_F_RTP_FEAT_COMPR_CONTROL (1 << 0) /* RTP Compression Control */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85316af9b57e8113077305798cb2d82a24e48e00 Gerrit-Change-Number: 34427 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9]
by laforge 21 Oct '24

21 Oct '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email ) Change subject: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9] ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > These flags are applied to a `uint32_t` value in **native** endianness for the host. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85316af9b57e8113077305798cb2d82a24e48e00 Gerrit-Change-Number: 34427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Oct 2024 11:10:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: docs/shell: Add missing :ref: when referencing other command
by laforge 21 Oct '24

21 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36224?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: docs/shell: Add missing :ref: when referencing other command ...................................................................... docs/shell: Add missing :ref: when referencing other command Change-Id: I18f110e6313932d82b19ecaa7e07ef00c2339513 --- M docs/shell.rst 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/docs/shell.rst b/docs/shell.rst index 768765e..375e2d3 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -1002,7 +1002,7 @@ ~~~~~~~~~~~~~~~ This command will request deletion of all access rules stored within the ARA-M applet. Use it with caution, there is no undo. Any rules later -intended must be manually inserted again using `aram_store_ref_ar_do` +intended must be manually inserted again using :ref:`aram_store_ref_ar_do` GlobalPlatform commands -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I18f110e6313932d82b19ecaa7e07ef00c2339513 Gerrit-Change-Number: 36224 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libgtpnl[master]: dev_create: Avoid passing IFLA_GTP_FD* attribute with value -1
by laforge 21 Oct '24

21 Oct '24

Attention is currently required from: fixeria, pablo, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libgtpnl/+/38460?usp=email ) Change subject: dev_create: Avoid passing IFLA_GTP_FD* attribute with value -1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: this probably should be back-ported / patch-released? -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/38460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib7e1d362fbb556c9b15b25408058fbf00bcc7aa3 Gerrit-Change-Number: 38460 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pablo <pablo(a)gnumonks.org> Gerrit-Attention: pablo <pablo(a)gnumonks.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Mon, 21 Oct 2024 11:09:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libgtpnl[master]: dev_create: Avoid passing IFLA_GTP_FD* attribute with value -1
by laforge 21 Oct '24

21 Oct '24

Attention is currently required from: fixeria, pablo, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libgtpnl/+/38460?usp=email ) Change subject: dev_create: Avoid passing IFLA_GTP_FD* attribute with value -1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/38460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib7e1d362fbb556c9b15b25408058fbf00bcc7aa3 Gerrit-Change-Number: 38460 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pablo <pablo(a)gnumonks.org> Gerrit-Attention: pablo <pablo(a)gnumonks.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Mon, 21 Oct 2024 11:09:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: core/tun.c: Fix wrong documentation ret type in tundev_open_fd()
by laforge 21 Oct '24

21 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38476?usp=email ) Change subject: core/tun.c: Fix wrong documentation ret type in tundev_open_fd() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I208821cf216c2a700caf6517a885cf44fc6958e1 Gerrit-Change-Number: 38476 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Oct 2024 11:08:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libgtpnl[master]: build: fix bashims in configure.ac
by laforge 21 Oct '24

21 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/38474?usp=email ) Change subject: build: fix bashims in configure.ac ...................................................................... build: fix bashims in configure.ac $ foo=bar $ foo+=zzz dash: 2: foo+=zzz: not found Fixes: 1.2.5-6-g0bd1e0d Change-Id: I2c0a62ab80f480502dd2a1bcf4aef71e70152ea6 --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/configure.ac b/configure.ac index 6eabd32..24658a4 100644 --- a/configure.ac +++ b/configure.ac @@ -71,9 +71,9 @@ if test x"$werror" = x"yes" then WERROR_FLAGS="-Werror" - WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" - WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" - WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" + WERROR_FLAGS="$WERROR_FLAGS -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" + WERROR_FLAGS="$WERROR_FLAGS -Wno-error=deprecated -Wno-error=deprecated-declarations" + WERROR_FLAGS="$WERROR_FLAGS -Wno-error=cpp" # "#warning" regular_CFLAGS="$WERROR_FLAGS" regular_CPPFLAGS="$WERROR_FLAGS" fi -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/38474?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I2c0a62ab80f480502dd2a1bcf4aef71e70152ea6 Gerrit-Change-Number: 38474 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libgtpnl[master]: Revert `configure: regular_C(PP)FLAGS -> C(PP)FLAGS`
by laforge 21 Oct '24

21 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/38473?usp=email ) Change subject: Revert `configure: regular_C(PP)FLAGS -> C(PP)FLAGS` ...................................................................... Revert `configure: regular_C(PP)FLAGS -> C(PP)FLAGS` This commit reverts dd335ef8fc41567e324a3d26f1ec30d04c69a0bb. Observed: ``` $ configure && make CPPFLAGS=-DNDEBUG gcc -DHAVE_CONFIG_H -I. -I.. -DNDEBUG -I../include -I/usr/include/libmnl -DNDEBUG -Wall -Waggregate-return -Wmissing-declarations -Wmissing-prototypes -Wshadow -Wstrict-prototypes -Wformat=2 -pipe -std=gnu11 -fvisibility=hidden -Wall -Waggregate-return -Wmissing-declarations -Wmissing-prototypes -Wshadow -Wstrict-prototypes -Wformat=2 -pipe -std=gnu11 -MT gtp-tunnel.o -MD -MP -MF $depbase.Tpo -c -o gtp-tunnel.o gtp-tunnel.c &&\ ``` Expected: ``` gcc -DHAVE_CONFIG_H -I. -I.. -D_FILE_OFFSET_BITS=64 -D_REENTRANT -I../include -I/usr/include/libmnl -D_FILE_OFFSET_BITS=64 -D_REENTRANT -Wall -Waggregate-return -Wmissing-declarations -Wmissing-prototypes -Wshadow -Wstrict-prototypes -Wformat=2 -pipe -std=gnu11 -fvisibility=hidden -Wall -Waggregate-return -Wmissing-declarations -Wmissing-prototypes -Wshadow -Wstrict-prototypes -Wformat=2 -pipe -std=gnu11 -MT gtp-tunnel.o -MD -MP -MF $depbase.Tpo -c -o gtp-tunnel.o gtp-tunnel.c &&\ ``` Including ${CFLAGS} in AM_CFLAGS (which is totally wrong) is the cause for the double apperance of -DNDEBUG. _FILE_OFFSET_BITS is lost because dd335 violated one core principle of autoconf/automake: configure MUST run idempotent and not touch CPPFLAGS and CFLAGS, pursuant to automake.info §3.6 "User variables". Change-Id: I5cc30885cec564346997269b51decbbe49548ddf --- M Make_global.am M configure.ac 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/Make_global.am b/Make_global.am index 9a3d5b2..f2cb36c 100644 --- a/Make_global.am +++ b/Make_global.am @@ -1,2 +1,2 @@ -AM_CPPFLAGS = ${CPPFLAGS} -I${top_srcdir}/include ${LIBMNL_CFLAGS} -AM_CFLAGS = ${CFLAGS} ${GCC_FVISIBILITY_HIDDEN} +AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_srcdir}/include ${LIBMNL_CFLAGS} +AM_CFLAGS = ${regular_CFLAGS} ${GCC_FVISIBILITY_HIDDEN} diff --git a/configure.ac b/configure.ac index 90e4dce..6eabd32 100644 --- a/configure.ac +++ b/configure.ac @@ -9,8 +9,8 @@ AC_CONFIG_HEADERS([config.h]) AM_INIT_AUTOMAKE([foreign tar-pax no-dist-gzip dist-bzip2 1.6 subdir-objects]) -CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64 -D_REENTRANT" -CFLAGS="$CFLAGS -Wall -Waggregate-return -Wmissing-declarations \ +regular_CPPFLAGS="-D_FILE_OFFSET_BITS=64 -D_REENTRANT" +regular_CFLAGS="-Wall -Waggregate-return -Wmissing-declarations \ -Wmissing-prototypes -Wshadow -Wstrict-prototypes \ -Wformat=2 -pipe" @@ -55,8 +55,8 @@ [sanitize=$enableval], [sanitize="no"]) if test x"$sanitize" = x"yes" then - CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined" - CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" + regular_CFLAGS="-fsanitize=address -fsanitize=undefined" + regular_CPPFLAGS="-fsanitize=address -fsanitize=undefined" fi AC_ARG_ENABLE(werror, @@ -74,8 +74,8 @@ WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" - CFLAGS="$CFLAGS $WERROR_FLAGS" - CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" + regular_CFLAGS="$WERROR_FLAGS" + regular_CPPFLAGS="$WERROR_FLAGS" fi AC_ARG_ENABLE(qemu_tests, @@ -91,8 +91,8 @@ AC_MSG_ERROR([missing programs for --enable-qemu-tests]) fi -AC_SUBST([CPPFLAGS]) -AC_SUBST([CFLAGS]) +AC_SUBST([regular_CPPFLAGS]) +AC_SUBST([regular_CFLAGS]) AC_CONFIG_FILES([ Makefile include/Makefile -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/38473?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I5cc30885cec564346997269b51decbbe49548ddf Gerrit-Change-Number: 38473 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0