October 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: vlr: vlr_subscr_handle_cancel_req(): rework function
by lynxis lazus 21 Oct '24

21 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38493?usp=email ) Change subject: vlr: vlr_subscr_handle_cancel_req(): rework function ...................................................................... vlr: vlr_subscr_handle_cancel_req(): rework function Invalid the subscriber towards the MSC/SGSN when receiving a Cancel Request from the HLR. FIXME: canceling a fsm is still problematic if the VLR is in the middle of a LU, because it still want to send back a failure when asked via HLR. So when the HLR is doing a Cancel Location with reason Update Location (instead of withdrawn), the VLR shouldn't allowed to transmit a Location Update Reject message.. Change-Id: Idf24d49cc6af53043da7ffaf7dda2993f2e812a5 --- M src/libvlr/vlr.c 1 file changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/93/38493/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index b8650c7..4b6c05b 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1288,27 +1288,31 @@ static int vlr_subscr_handle_cancel_req(struct vlr_subscr *vsub, const struct osmo_gsup_message *gsup_msg) { + enum gsm48_reject_value gsm48_rej; enum osmo_fsm_term_cause fsm_cause = OSMO_FSM_TERM_ERROR; + struct vlr_instance *vlr = vsub->vlr; struct osmo_gsup_message gsup_reply = {0}; - int rc, is_update_procedure = !gsup_msg->cancel_type || + int is_update_procedure = !gsup_msg->cancel_type || gsup_msg->cancel_type == OSMO_GSUP_CANCEL_TYPE_UPDATE; - vlr_rate_ctr_inc(vsub->vlr, VLR_CTR_GSUP_TX_CANCEL_RES); + vlr_rate_ctr_inc(vlr, VLR_CTR_GSUP_TX_CANCEL_RES); LOGVSUBP(LOGL_INFO, vsub, "Cancelling MS subscriber (%s)\n", is_update_procedure ? "update procedure" : "subscription withdraw"); - gsup_reply.message_type = OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT; - gsup_reply.cn_domain = vlr_is_cs(vsub->vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS; - rc = vlr_subscr_tx_gsup_message(vsub, &gsup_reply); + gsm48_rej = vlr_gmm_cause_to_reject_cause_domain(gsup_msg->cause, vlr_is_cs(vlr)); + vlr_subscr_cancel_attach_fsm(vsub, fsm_cause, gsm48_rej); - vlr_subscr_cancel_attach_fsm(vsub, fsm_cause, vlr_gmm_cause_to_reject_cause_domain(gsup_msg->cause, true)); + if (vlr->ops.subscr_inval) + vlr->ops.subscr_inval(vsub->msc_conn_ref, vsub, gsm48_rej, is_update_procedure); - vlr_rate_ctr_inc(vsub->vlr, VLR_CTR_DETACH_BY_CANCEL); + vlr_rate_ctr_inc(vlr, VLR_CTR_DETACH_BY_CANCEL); vlr_subscr_detach(vsub); - return rc; + gsup_reply.message_type = OSMO_GSUP_MSGT_LOCATION_CANCEL_RESULT; + gsup_reply.cn_domain = vlr_is_cs(vlr) ? OSMO_GSUP_CN_DOMAIN_CS : OSMO_GSUP_CN_DOMAIN_PS; + return vlr_subscr_tx_gsup_message(vsub, &gsup_reply); } /* Handle Check_IMEI_VLR result and error from HLR */ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idf24d49cc6af53043da7ffaf7dda2993f2e812a5 Gerrit-Change-Number: 38493 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-msc[master]: NOT_FOR_MASTER: hard remove paging_request_join_vsub()
by lynxis lazus 21 Oct '24

21 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38494?usp=email ) Change subject: NOT_FOR_MASTER: hard remove paging_request_join_vsub() ...................................................................... NOT_FOR_MASTER: hard remove paging_request_join_vsub() The paging_request_join_vsub() is a MSC function which uses two vsub and got called by the VLR code, which can't work in the future when moving libvlr into an own (shared) library. Also this is a layer violation. Either we create callback for this or rewrite it. FIXME: is this case even valid? Can we have multiple MS with different TMSIs and waiting paging requests? And if so, when can this happen? Change-Id: I84d9690df1d90598689e2b0e9400573aa45b8620 --- M src/libvlr/vlr.c M src/libvlr/vlr_auth_fsm.c 2 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/94/38494/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 4b6c05b..f6c3ab8 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -35,7 +35,6 @@ #include <osmocom/vlr/vlr_sgs.h> #include <osmocom/vlr/vlr.h> #include <osmocom/msc/gsup_client_mux.h> -#include <osmocom/msc/paging.h> #include <netinet/in.h> #include <arpa/inet.h> @@ -176,7 +175,6 @@ #define vlr_stat_item_set(vlr, idx, val) \ osmo_stat_item_set(osmo_stat_item_group_get_item((vlr)->statg, idx), val) - /*********************************************************************** * Convenience functions ***********************************************************************/ @@ -604,8 +602,6 @@ vlr_subscr_name(vsub), osmo_use_count_to_str_c(OTC_SELECT, &vsub->use_count)); - /* Take over some state from the previous vsub */ - paging_request_join_vsub(vsub, exists); if (!vsub->msisdn[0]) OSMO_STRLCPY_ARRAY(vsub->msisdn, exists->msisdn); if (!vsub->name[0]) diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index d00219b..85f30f4 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -696,3 +696,4 @@ at->use_count++; return true; } + -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I84d9690df1d90598689e2b0e9400573aa45b8620 Gerrit-Change-Number: 38494 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-msc[master]: vlr: Add support for CS and PS timers
by Jenkins Builder 21 Oct '24

21 Oct '24

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email ) Change subject: vlr: Add support for CS and PS timers ...................................................................... Patch Set 1: (15 comments) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/3fc22120_5133a086?usp… : PS1, Line 46: [VLR_SUB_AS_WAIT_RESP] = { .T = 3260 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/8133164c_9dea1583?usp… : PS1, Line 47: [VLR_SUB_AS_WAIT_RESP_RESYNC] = { .T = 3260 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/cb3809f3_f675f913?usp… : PS1, Line 48: [VLR_SUB_AS_WAIT_ID_IMSI] = { .T = 3270 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/be064cb3_7a1cbfce?usp… : PS1, Line 52: [VLR_SUB_AS_WAIT_RESP] = { .T = 3360 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/e9846a9d_5fd2245c?usp… : PS1, Line 53: [VLR_SUB_AS_WAIT_RESP_RESYNC] = { .T = 3360 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/b4a88ee9_a3075c4f?usp… : PS1, Line 54: [VLR_SUB_AS_WAIT_ID_IMSI] = { .T = 3370 }, please, no spaces at the start of a line File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/ad006836_4143c5f1?usp… : PS1, Line 339: [LU_COMPL_VLR_S_WAIT_IMEI] = { .T = 3370 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/8c3569d0_67b6e75b?usp… : PS1, Line 340: [LU_COMPL_VLR_S_WAIT_IMEI_TMSI] = { .T = 3370 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/d6bfd113_140905f4?usp… : PS1, Line 341: [LU_COMPL_VLR_S_WAIT_TMSI_CNF] = { .T = 3350 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/b211d42e_6be7d338?usp… : PS1, Line 683: [VLR_ULA_S_WAIT_IMEISV] = { .T = 3270 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/aef50c07_f058a9db?usp… : PS1, Line 684: [VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY] = { .T = 3270 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/0e94095a_473aae63?usp… : PS1, Line 685: [VLR_ULA_S_WAIT_IMSI] = { .T = 3270 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/b56fa36d_332ed30c?usp… : PS1, Line 689: [VLR_ULA_S_WAIT_IMEISV] = { .T = 3370 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/6d58c513_45775484?usp… : PS1, Line 690: [VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY] = { .T = 3370 }, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19328): https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/0ddb6b6c_df02a871?usp… : PS1, Line 691: [VLR_ULA_S_WAIT_IMSI] = { .T = 3370 }, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba Gerrit-Change-Number: 38486 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 21 Oct 2024 18:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-msc[master]: vlr: add bool is_ps to vlr_alloc()
by lynxis lazus 21 Oct '24

21 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38485?usp=email ) Change subject: vlr: add bool is_ps to vlr_alloc() ...................................................................... vlr: add bool is_ps to vlr_alloc() The vlr must known if it is CS or PS. As this is a very severe configuration entry, add it to the main allocation. Change-Id: Ib77aad8492a198131c966d4ac4cf8f5f727edcfa --- M include/osmocom/vlr/vlr.h M src/libmsc/msc_net_init.c M src/libvlr/vlr.c 3 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/85/38485/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index 035e028..257dd09 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -318,7 +318,7 @@ int vlr_subscr_rx_tmsi_reall_compl(struct vlr_subscr *vsub); int vlr_subscr_rx_imsi_detach(struct vlr_subscr *vsub); -struct vlr_instance *vlr_alloc(void *ctx, const struct vlr_ops *ops); +struct vlr_instance *vlr_alloc(void *ctx, const struct vlr_ops *ops, bool is_ps); int vlr_start(struct vlr_instance *vlr, struct gsup_client_mux *gcm); int vlr_gsup_rx(struct gsup_client_mux *gcm, void *data, const struct osmo_gsup_message *gsup_msg); diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index 21f68cf..5f10e6c 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -110,7 +110,7 @@ { osmo_vlr_set_log_cat(OSMO_VLR_LOGC_VLR, DVLR); osmo_vlr_set_log_cat(OSMO_VLR_LOGC_SGS, DSGS); - net->vlr = vlr_alloc(net, &msc_vlr_ops); + net->vlr = vlr_alloc(net, &msc_vlr_ops, false); if (!net->vlr) return -ENOMEM; net->vlr->user_ctx = net; diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index b81484a..0575583 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1512,7 +1512,7 @@ vlr_subscr_cancel_attach_fsm(vsub, OSMO_FSM_TERM_TIMEOUT, GSM48_REJECT_CONGESTION); } -struct vlr_instance *vlr_alloc(void *ctx, const struct vlr_ops *ops) +struct vlr_instance *vlr_alloc(void *ctx, const struct vlr_ops *ops, bool is_ps) { struct vlr_instance *vlr = talloc_zero(ctx, struct vlr_instance); OSMO_ASSERT(vlr); @@ -1536,6 +1536,7 @@ memcpy(&vlr->ops, ops, sizeof(vlr->ops)); /* defaults */ + vlr->cfg.is_ps = is_ps; vlr->cfg.assign_tmsi = true; vlr->cfg.nri_bitlen = OSMO_NRI_BITLEN_DEFAULT; vlr->cfg.nri_ranges = osmo_nri_ranges_alloc(vlr); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib77aad8492a198131c966d4ac4cf8f5f727edcfa Gerrit-Change-Number: 38485 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-msc[master]: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid
by lynxis lazus 21 Oct '24

21 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email ) Change subject: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid ...................................................................... vlr: on subscriber disconnect, check if LU & Auth FSM are even valid Those fsm can be NULL. Change-Id: Iaea7d37cfa439fd1adea7440409f6248aef947ef --- M src/libvlr/vlr.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/87/38487/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 73e3a9f..b924f81 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1611,8 +1611,10 @@ { /* This corresponds to a MAP-ABORT from MSC->VLR on a classic B * interface */ - osmo_fsm_inst_term(vsub->lu_fsm, OSMO_FSM_TERM_REQUEST, NULL); - osmo_fsm_inst_term(vsub->auth_fsm, OSMO_FSM_TERM_REQUEST, NULL); + if (vsub->lu_fsm) + osmo_fsm_inst_term(vsub->lu_fsm, OSMO_FSM_TERM_REQUEST, NULL); + if (vsub->auth_fsm) + osmo_fsm_inst_term(vsub->auth_fsm, OSMO_FSM_TERM_REQUEST, NULL); vsub->msc_conn_ref = NULL; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaea7d37cfa439fd1adea7440409f6248aef947ef Gerrit-Change-Number: 38487 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-msc[master]: vlr: Add support for CS and PS timers
by lynxis lazus 21 Oct '24

21 Oct '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email ) Change subject: vlr: Add support for CS and PS timers ...................................................................... vlr: Add support for CS and PS timers To prepare for PS support, add related PS timers and try to keep the code simple to support both domains. Use osmo_tdef_fsm_inst_state_chg() where possible because this way we can have a t_def pointer which we set at the start. Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba --- M include/osmocom/vlr/vlr.h M src/libmsc/msc_vty.c M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_access_req_fsm.h M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_auth_fsm.h M src/libvlr/vlr_lu_fsm.c M src/libvlr/vlr_lu_fsm.h M tests/msc_vlr/msc_vlr_test_no_authen.c 10 files changed, 129 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/86/38486/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index 257dd09..ed6438b 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -421,7 +421,10 @@ bool vlr_subscr_matches_msisdn(struct vlr_subscr *vsub, const char *msisdn); bool vlr_subscr_matches_imei(struct vlr_subscr *vsub, const char *imei); -unsigned long vlr_timer_secs(struct vlr_instance *vlr, int timer); +unsigned long vlr_timer_secs(struct vlr_instance *vlr, int cs_timer, int ps_timer); + +/* vlr_tdefs is pointing to msc_tdefs_vlr or sgsn_tdefs_vlr depending on the domain*/ +extern struct osmo_tdef *vlr_tdefs; int vlr_subscr_changed(struct vlr_subscr *vsub); int vlr_subscr_purge(struct vlr_subscr *vsub) __attribute__((warn_unused_result)); diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index d9eec51..7e6b350 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -1048,7 +1048,7 @@ VTY_NEWLINE); } - if (!vlr_timer_secs(vsub->vlr, 3212)) { + if (!vlr_timer_secs(vsub->vlr, 3212, 3312)) { MSC_VTY_DUMP(vty, offset, "Expires: never (T3212 is disabled)%s", VTY_NEWLINE); } else if (vsub->expire_lu == VLR_SUBSCRIBER_NO_EXPIRATION) { diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 0575583..73e3a9f 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -200,14 +200,28 @@ { /* terminator */ } }; +/* 3GPP TS 24.008, table 11.2 Mobility management timers (network-side) */ +struct osmo_tdef sgsn_tdefs_vlr[] = { + { .T = 3312, .default_val = 60, .unit = OSMO_TDEF_M, .desc = "Subscriber expiration timeout" }, + { .T = 3350, .default_val = 6, .desc = "Attach/RAU Complete Reallocation procedure" }, + { .T = 3360, .default_val = 6, .desc = "Authentication procedure" }, + { .T = 3370, .default_val = 6, .desc = "Identification procedure" }, + { /* terminator */ } +}; + +struct osmo_tdef *vlr_tdefs; + /* This is just a wrapper around the osmo_tdef API. * TODO: we should start using osmo_tdef_fsm_inst_state_chg() */ -unsigned long vlr_timer_secs(struct vlr_instance *vlr, int timer) +unsigned long vlr_timer_secs(struct vlr_instance *vlr, int cs_timer, int ps_timer) { /* NOTE: since we usually do not need more than one instance of the VLR, * and since libosmocore's osmo_tdef API does not (yet) support dynamic * configuration, we always use the global instance of msc_tdefs_vlr. */ - return osmo_tdef_get(msc_tdefs_vlr, timer, OSMO_TDEF_S, 0); + if (vlr_is_cs(vlr)) + return osmo_tdef_get(vlr_tdefs, cs_timer, OSMO_TDEF_S, 0); + else + return osmo_tdef_get(vlr_tdefs, ps_timer, OSMO_TDEF_S, 0); } /* return static buffer with printable name of VLR subscriber */ @@ -732,7 +746,7 @@ /* Mark the subscriber as inactive if it stopped to do periodical location updates. */ if (osmo_clock_gettime(CLOCK_MONOTONIC, &now) == 0) { - vsub->expire_lu = now.tv_sec + vlr_timer_secs(vsub->vlr, 3212); + vsub->expire_lu = now.tv_sec + vlr_timer_secs(vsub->vlr, 3212, 3312); } else { LOGVLR(LOGL_ERROR, "%s: Could not enable Location Update expiry: unable to read current time\n", vlr_subscr_name(vsub)); @@ -749,7 +763,7 @@ /* Periodic location update might be disabled from the VTY, * so we shall not expire subscribers until explicit IMSI Detach. */ - if (!vlr_timer_secs(vlr, 3212)) + if (!vlr_timer_secs(vlr, 3212, 3312)) goto done; if (llist_empty(&vlr->subscribers)) @@ -1551,16 +1565,23 @@ /* reset shared timer definitions */ osmo_tdefs_reset(msc_tdefs_vlr); + osmo_tdefs_reset(sgsn_tdefs_vlr); /* osmo_auth_fsm.c */ - vlr_auth_fsm_init(); + vlr_auth_fsm_init(is_ps); + /* osmo_lu_fsm.c */ - vlr_lu_fsm_init(); + vlr_lu_fsm_init(is_ps); /* vlr_access_request_fsm.c */ - vlr_parq_fsm_init(); + vlr_parq_fsm_init(is_ps); /* vlr_sgs_fsm.c */ vlr_sgs_fsm_init(); + if (is_ps) + vlr_tdefs = sgsn_tdefs_vlr; + else + vlr_tdefs = msc_tdefs_vlr; + return vlr; err_statg: diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index 910ee67..3b897cd 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -20,6 +20,7 @@ */ #include <osmocom/core/fsm.h> +#include <osmocom/core/tdef.h> #include <osmocom/gsm/gsup.h> #include <osmocom/gsm/gsm48.h> #include <osmocom/vlr/vlr.h> @@ -50,6 +51,18 @@ { 0, NULL } }; +struct osmo_tdef_state_timeout msc_parq_tdef_states[32] = { + [PR_ARQ_S_WAIT_CHECK_IMEI] = { .T = 3270 }, + [PR_ARQ_S_WAIT_OBTAIN_IMSI] = { .T = 3270 }, +}; + +struct osmo_tdef_state_timeout sgsn_parq_tdef_states[32] = { + [PR_ARQ_S_WAIT_CHECK_IMEI] = { .T = 3370 }, + [PR_ARQ_S_WAIT_OBTAIN_IMSI] = { .T = 3370 }, +}; + +struct osmo_tdef_state_timeout *parq_fsm_state_tdef; + struct proc_arq_priv { struct vlr_instance *vlr; struct vlr_subscr *vsub; @@ -201,8 +214,7 @@ if (0 /* IMEI check required */) { /* Chck_IMEI_VLR */ vlr->ops.tx_id_req(par->msc_conn_ref, GSM_MI_TYPE_IMEI); - osmo_fsm_inst_state_chg(fi, PR_ARQ_S_WAIT_CHECK_IMEI, - vlr_timer_secs(vlr, 3270), 3270); + osmo_tdef_fsm_inst_state_chg(fi, PR_ARQ_S_WAIT_CHECK_IMEI, parq_fsm_state_tdef, vlr_tdefs, 0); } else _proc_arq_vlr_post_imei(fi); } @@ -404,8 +416,7 @@ /* TMSI was included, are we permitted to use it? */ if (vlr->cfg.parq_retrieve_imsi) { /* Obtain_IMSI_VLR */ - osmo_fsm_inst_state_chg(fi, PR_ARQ_S_WAIT_OBTAIN_IMSI, - vlr_timer_secs(vlr, 3270), 3270); + osmo_tdef_fsm_inst_state_chg(fi, PR_ARQ_S_WAIT_OBTAIN_IMSI, parq_fsm_state_tdef, vlr_tdefs, 0); return; } else { /* Set User Error: Unidentified Subscriber */ @@ -803,8 +814,13 @@ }; #endif -void vlr_parq_fsm_init(void) +void vlr_parq_fsm_init(bool is_ps) { + if (is_ps) + parq_fsm_state_tdef = sgsn_parq_tdef_states; + else + parq_fsm_state_tdef = msc_parq_tdef_states; + //OSMO_ASSERT(osmo_fsm_register(&upd_loc_child_vlr_fsm) == 0); OSMO_ASSERT(osmo_fsm_register(&proc_arq_vlr_fsm) == 0); } diff --git a/src/libvlr/vlr_access_req_fsm.h b/src/libvlr/vlr_access_req_fsm.h index d6cbabd..42b2c7e 100644 --- a/src/libvlr/vlr_access_req_fsm.h +++ b/src/libvlr/vlr_access_req_fsm.h @@ -16,5 +16,5 @@ PR_ARQ_S_DONE, }; -void vlr_parq_fsm_init(void); +void vlr_parq_fsm_init(bool is_ps); void vlr_parq_fsm_set_log_subsys(int log_level); diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c index 2405131..d00219b 100644 --- a/src/libvlr/vlr_auth_fsm.c +++ b/src/libvlr/vlr_auth_fsm.c @@ -21,6 +21,7 @@ #include <osmocom/core/fsm.h> +#include <osmocom/core/tdef.h> #include <osmocom/core/utils.h> #include <osmocom/gsm/gsup.h> #include <osmocom/vlr/vlr.h> @@ -41,6 +42,20 @@ { 0, NULL } }; +struct osmo_tdef_state_timeout msc_auth_tdef_states[32] = { + [VLR_SUB_AS_WAIT_RESP] = { .T = 3260 }, + [VLR_SUB_AS_WAIT_RESP_RESYNC] = { .T = 3260 }, + [VLR_SUB_AS_WAIT_ID_IMSI] = { .T = 3270 }, +}; + +struct osmo_tdef_state_timeout sgsn_auth_tdef_states[32] = { + [VLR_SUB_AS_WAIT_RESP] = { .T = 3360 }, + [VLR_SUB_AS_WAIT_RESP_RESYNC] = { .T = 3360 }, + [VLR_SUB_AS_WAIT_ID_IMSI] = { .T = 3370 }, +}; + +struct osmo_tdef_state_timeout *auth_fsm_state_tdef; + /* private state of the auth_fsm_instance */ struct auth_fsm_priv { struct vlr_subscr *vsub; @@ -344,8 +359,7 @@ GSM_29002_TIMER_M, 0); } else { /* go straight ahead with sending auth request */ - osmo_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_RESP, - vlr_timer_secs(vsub->vlr, 3260), 3260); + osmo_tdef_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_RESP, auth_fsm_state_tdef, vlr_tdefs, 6); _vlr_subscr_authenticate(fi); } } @@ -398,8 +412,8 @@ return; pass: - osmo_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_RESP, - vlr_timer_secs(vsub->vlr, 3260), 3260); + osmo_tdef_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_RESP, auth_fsm_state_tdef, vlr_tdefs, 0); + _vlr_subscr_authenticate(fi); } @@ -421,9 +435,7 @@ if (!afp->by_imsi) { vlr->ops.tx_id_req(vsub->msc_conn_ref, GSM_MI_TYPE_IMSI); - osmo_fsm_inst_state_chg(fi, - VLR_SUB_AS_WAIT_ID_IMSI, - vlr_timer_secs(vlr, 3270), 3270); + osmo_tdef_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_ID_IMSI, auth_fsm_state_tdef, vlr_tdefs, 0); } else { auth_fsm_term(fi, AUTH_FSM_FAILURE, GSM48_REJECT_ILLEGAL_MS); } @@ -465,8 +477,7 @@ switch (event) { case VLR_AUTH_E_HLR_SAI_ACK: vlr_subscr_update_tuples(vsub, gsup); - osmo_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_RESP_RESYNC, - vlr_timer_secs(vsub->vlr, 3260), 3260); + osmo_tdef_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_RESP_RESYNC, auth_fsm_state_tdef, vlr_tdefs, 0); _vlr_subscr_authenticate(fi); break; case VLR_AUTH_E_HLR_SAI_NACK: @@ -497,9 +508,7 @@ if (!afp->by_imsi) { vlr->ops.tx_id_req(vsub->msc_conn_ref, GSM_MI_TYPE_IMSI); - osmo_fsm_inst_state_chg(fi, - VLR_SUB_AS_WAIT_ID_IMSI, - vlr_timer_secs(vlr, 3270), 3270); + osmo_tdef_fsm_inst_state_chg(fi, VLR_SUB_AS_WAIT_ID_IMSI, auth_fsm_state_tdef, vlr_tdefs, 0); } else { /* Result = Aborted */ auth_fsm_term(fi, AUTH_FSM_FAILURE, GSM48_REJECT_SYNCH_FAILURE); @@ -614,8 +623,13 @@ .cleanup = auth_fsm_cleanup, }; -void vlr_auth_fsm_init(void) +void vlr_auth_fsm_init(bool is_ps) { + if (is_ps) + auth_fsm_state_tdef = sgsn_auth_tdef_states; + else + auth_fsm_state_tdef = msc_auth_tdef_states; + OSMO_ASSERT(osmo_fsm_register(&vlr_auth_fsm) == 0); } diff --git a/src/libvlr/vlr_auth_fsm.h b/src/libvlr/vlr_auth_fsm.h index 139f919..1cb25b6 100644 --- a/src/libvlr/vlr_auth_fsm.h +++ b/src/libvlr/vlr_auth_fsm.h @@ -37,6 +37,6 @@ bool is_r99, bool is_utran); -void vlr_auth_fsm_init(void); +void vlr_auth_fsm_init(bool is_ps); void vlr_auth_fsm_set_log_subsys(int log_level); bool auth_try_reuse_tuple(struct vlr_subscr *vsub, uint8_t key_seq); diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 2017cb8..fca8347 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -20,6 +20,7 @@ */ #include <osmocom/core/fsm.h> +#include <osmocom/core/tdef.h> #include <osmocom/gsm/gsm48.h> #include <osmocom/vlr/vlr.h> @@ -328,6 +329,20 @@ { 0, NULL } }; +struct osmo_tdef_state_timeout msc_lu_compl_tdef_states[32] = { + [LU_COMPL_VLR_S_WAIT_IMEI] = { .T = 3270 }, + [LU_COMPL_VLR_S_WAIT_IMEI_TMSI] = { .T = 3270 }, + [LU_COMPL_VLR_S_WAIT_TMSI_CNF] = { .T = 3250 }, +}; + +struct osmo_tdef_state_timeout sgsn_lu_compl_tdef_states[32] = { + [LU_COMPL_VLR_S_WAIT_IMEI] = { .T = 3370 }, + [LU_COMPL_VLR_S_WAIT_IMEI_TMSI] = { .T = 3370 }, + [LU_COMPL_VLR_S_WAIT_TMSI_CNF] = { .T = 3350 }, +}; + +struct osmo_tdef_state_timeout *lu_compl_fsm_state_tdef; + struct lu_compl_vlr_priv { struct vlr_subscr *vsub; void *msc_conn_ref; @@ -431,8 +446,7 @@ return; } - osmo_fsm_inst_state_chg(fi, LU_COMPL_VLR_S_WAIT_TMSI_CNF, - vlr_timer_secs(vlr, 3250), 3250); + osmo_tdef_fsm_inst_state_chg(fi, LU_COMPL_VLR_S_WAIT_TMSI_CNF, lu_compl_fsm_state_tdef, vlr_tdefs, 6); vlr->ops.tx_lu_acc(lcvp->msc_conn_ref, vsub->tmsi_new, lcvp->lu_type); } @@ -455,11 +469,11 @@ /* If imeisv_early is enabled: IMEI already retrieved and checked (vlr_loc_upd_node1_pre), don't do it again. */ if (vlr->cfg.check_imei_rqd && !vlr->cfg.retrieve_imeisv_early) { /* Check IMEI VLR */ - osmo_fsm_inst_state_chg(fi, + osmo_tdef_fsm_inst_state_chg(fi, lcvp->assign_tmsi ? LU_COMPL_VLR_S_WAIT_IMEI_TMSI : LU_COMPL_VLR_S_WAIT_IMEI, - vlr_timer_secs(vlr, 3270), 3270); + lu_compl_fsm_state_tdef, vlr_tdefs, 6); vlr->ops.tx_id_req(lcvp->msc_conn_ref, GSM_MI_TYPE_IMEI); return; } @@ -665,6 +679,20 @@ { 0, NULL } }; +struct osmo_tdef_state_timeout msc_lu_tdef_states[32] = { + [VLR_ULA_S_WAIT_IMEISV] = { .T = 3270 }, + [VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY] = { .T = 3270 }, + [VLR_ULA_S_WAIT_IMSI] = { .T = 3270 }, +}; + +struct osmo_tdef_state_timeout sgsn_lu_tdef_states[32] = { + [VLR_ULA_S_WAIT_IMEISV] = { .T = 3370 }, + [VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY] = { .T = 3370 }, + [VLR_ULA_S_WAIT_IMSI] = { .T = 3370 }, +}; + +struct osmo_tdef_state_timeout *lu_fsm_state_tdef; + struct lu_fsm_priv { struct vlr_instance *vlr; struct vlr_subscr *vsub; @@ -942,7 +970,7 @@ LOGPFSM(fi, "%s()\n", __func__); if (vlr->cfg.check_imei_rqd && vlr->cfg.retrieve_imeisv_early) { - osmo_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY, vlr_timer_secs(lfp->vlr, 3270), 3270); + osmo_tdef_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_HLR_CHECK_IMEI_EARLY, lu_fsm_state_tdef, vlr_tdefs, 0); vlr_subscr_tx_req_check_imei(lfp->vsub); } else { vlr_loc_upd_node1(fi); @@ -977,8 +1005,7 @@ OSMO_ASSERT(lfp->vsub); /* Obtain_IMSI_VLR */ - osmo_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_IMSI, - vlr_timer_secs(vlr, 3270), 3270); + osmo_tdef_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_IMSI, lu_fsm_state_tdef, vlr_tdefs, 0); vlr->ops.tx_id_req(lfp->msc_conn_ref, GSM_MI_TYPE_IMSI); /* will continue at vlr_loc_upd_node1_pre() once IMSI arrives */ } @@ -1114,8 +1141,7 @@ _start_lu_main(fi); } else { vlr->ops.tx_id_req(lfp->msc_conn_ref, GSM_MI_TYPE_IMEISV); - osmo_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_IMEISV, - vlr_timer_secs(vlr, 3270), 3270); + osmo_tdef_fsm_inst_state_chg(fi, VLR_ULA_S_WAIT_IMEISV, lu_fsm_state_tdef, vlr_tdefs, 0); } } @@ -1587,8 +1613,16 @@ lu_fsm_failure(fi, gsm48_cause); } -void vlr_lu_fsm_init(void) +void vlr_lu_fsm_init(bool is_ps) { + if (is_ps) { + lu_fsm_state_tdef = sgsn_lu_tdef_states; + lu_compl_fsm_state_tdef = sgsn_lu_compl_tdef_states; + } else { + lu_fsm_state_tdef = msc_lu_tdef_states; + lu_compl_fsm_state_tdef = msc_lu_compl_tdef_states; + } + OSMO_ASSERT(osmo_fsm_register(&vlr_lu_fsm) == 0); OSMO_ASSERT(osmo_fsm_register(&upd_hlr_vlr_fsm) == 0); OSMO_ASSERT(osmo_fsm_register(&sub_pres_vlr_fsm) == 0); diff --git a/src/libvlr/vlr_lu_fsm.h b/src/libvlr/vlr_lu_fsm.h index 86acd58..1eee75d 100644 --- a/src/libvlr/vlr_lu_fsm.h +++ b/src/libvlr/vlr_lu_fsm.h @@ -16,5 +16,5 @@ VLR_ULA_S_DONE }; -void vlr_lu_fsm_init(void); +void vlr_lu_fsm_init(bool is_ps); void vlr_lu_fsm_set_log_subsys(int log_subsys); diff --git a/tests/msc_vlr/msc_vlr_test_no_authen.c b/tests/msc_vlr/msc_vlr_test_no_authen.c index 384a069..8d8b153 100644 --- a/tests/msc_vlr/msc_vlr_test_no_authen.c +++ b/tests/msc_vlr/msc_vlr_test_no_authen.c @@ -941,7 +941,7 @@ vlr_subscr_put(vsub, __func__); /* Let T3212 (periodic Location update timer) expire */ - fake_time_passes(vlr_timer_secs(net->vlr, 3212) + 60 * 4, 0); + fake_time_passes(vlr_timer_secs(net->vlr, 3212, 3312) + 60 * 4, 0); /* The subscriber should now be gone. */ vsub = vlr_subscr_find_by_imsi(net->vlr, imsi, __func__); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba Gerrit-Change-Number: 38486 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ggsn[master]: ggsn: apply configured APN MTU to tun
by pespin 21 Oct '24

21 Oct '24

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38484?usp=email to look at the new patch set (#2). Change subject: ggsn: apply configured APN MTU to tun ...................................................................... ggsn: apply configured APN MTU to tun Related: OS#6298 Related: SYS#7122 Change-Id: Ifae556169d895860812c9ea5633292d7e3fab338 --- M ggsn/ggsn.c M ggsn/ggsn.h M ggsn/ggsn_vty.c 3 files changed, 33 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/84/38484/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ifae556169d895860812c9ea5633292d7e3fab338 Gerrit-Change-Number: 38484 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ggsn[master]: ggsn: Support announcing APN MTU over PCO
by pespin 21 Oct '24

21 Oct '24

Attention is currently required from: fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38457?usp=email ) Change subject: ggsn: Support announcing APN MTU over PCO ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > 0 MTU might be interesting. But fine with me. I think you can actually set it eg in linux iface, and it should simply disallow any traffic. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38457?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8532acfffadda9e83962b30e4f6b17eb8b3362ac Gerrit-Change-Number: 38457 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 21 Oct 2024 17:56:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: GTP: CreatePDPContext: only use IMEISV IE when IMEISV is known
by lynxis lazus 21 Oct '24

21 Oct '24

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38444?usp=email ) Change subject: GTP: CreatePDPContext: only use IMEISV IE when IMEISV is known ...................................................................... Patch Set 2: (1 comment) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/38444/comment/c3f61ca3_31693301?us… : PS1, Line 303: if (mmctx->imei[0] != 0x00) { > IMHO checking against ='\0' is good enough and more efficient. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I812af1e702e77214244f32ae65663c1a03b23962 Gerrit-Change-Number: 38444 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Oct 2024 17:44:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ggsn[master]: ggsn: Support announcing APN MTU over ICMPv6 RA
by lynxis lazus 21 Oct '24

21 Oct '24

Attention is currently required from: daniel, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38470?usp=email ) Change subject: ggsn: Support announcing APN MTU over ICMPv6 RA ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8bb67915dd5f39ad9ffb80e5aaf9af1e7d70c96c Gerrit-Change-Number: 38470 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Oct 2024 17:43:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0