August 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-tester[master]: contrib/jenkins-build: libosmocore: disable-uring

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/34201 ) Change subject: contrib/jenkins-build: libosmocore: disable-uring ...................................................................... contrib/jenkins-build: libosmocore: disable-uring This should fix the many builds currently failing from the osmo-gsm-tester_build jobs. Related: OS#5751 Change-Id: Ibc9605933380351a5fd23b772868c0e698b39c37 --- M contrib/jenkins-build-osmo-bsc.sh M contrib/jenkins-build-osmo-bts-oc2g.sh M contrib/jenkins-build-osmo-bts-sysmo.sh M contrib/jenkins-build-osmo-bts.sh M contrib/jenkins-build-osmo-ggsn.sh M contrib/jenkins-build-osmo-hlr.sh M contrib/jenkins-build-osmo-hnbgw.sh M contrib/jenkins-build-osmo-mgw.sh M contrib/jenkins-build-osmo-msc.sh M contrib/jenkins-build-osmo-nitb.sh M contrib/jenkins-build-osmo-pcu-oc2g.sh M contrib/jenkins-build-osmo-pcu-sysmo.sh M contrib/jenkins-build-osmo-pcu.sh M contrib/jenkins-build-osmo-sgsn.sh M contrib/jenkins-build-osmo-stp.sh M contrib/jenkins-build-osmo-trx.sh M contrib/jenkins-build-osmocom-bb.sh 17 files changed, 30 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/01/34201/1 diff --git a/contrib/jenkins-build-osmo-bsc.sh b/contrib/jenkins-build-osmo-bsc.sh index 761fc39..65c6158 100755 --- a/contrib/jenkins-build-osmo-bsc.sh +++ b/contrib/jenkins-build-osmo-bsc.sh @@ -4,7 +4,7 @@ name="osmo-bsc" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo libosmo-sccp ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-bts-oc2g.sh b/contrib/jenkins-build-osmo-bts-oc2g.sh index 74ebf44..e777d6f 100755 --- a/contrib/jenkins-build-osmo-bts-oc2g.sh +++ b/contrib/jenkins-build-osmo-bts-oc2g.sh @@ -31,7 +31,7 @@ git_url="${prev_git_url}" L1_OC2G_HEADERS="$PWD/oc2g-fw/inc" -build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug +build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug --disable-uring build_repo libosmo-abis --disable-dahdi build_repo libosmo-netif --disable-doxygen build_repo osmo-bts --disable-sysmocom-bts --enable-oc2g --with-oc2g="$L1_OC2G_HEADERS" diff --git a/contrib/jenkins-build-osmo-bts-sysmo.sh b/contrib/jenkins-build-osmo-bts-sysmo.sh index 472e73d..a8a35ca 100755 --- a/contrib/jenkins-build-osmo-bts-sysmo.sh +++ b/contrib/jenkins-build-osmo-bts-sysmo.sh @@ -25,7 +25,7 @@ prefix_real="$DESTDIR$prefix" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug +build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug --disable-uring build_repo libosmo-abis --disable-dahdi build_repo libosmo-netif --disable-doxygen build_repo osmo-bts --enable-sysmocom-bts --with-openbsc=$base/openbsc/openbsc/include diff --git a/contrib/jenkins-build-osmo-bts.sh b/contrib/jenkins-build-osmo-bts.sh index 27f82cc..6e9416a 100755 --- a/contrib/jenkins-build-osmo-bts.sh +++ b/contrib/jenkins-build-osmo-bts.sh @@ -6,7 +6,7 @@ have_repo octphy-2g-headers -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo osmo-bts ${SANITIZE_FLAGS} --enable-trx --with-openbsc=$base/openbsc/openbsc/include --enable-octphy --with-octsdr-2g=$base/octphy-2g-headers diff --git a/contrib/jenkins-build-osmo-ggsn.sh b/contrib/jenkins-build-osmo-ggsn.sh index fec2633..d727eab 100755 --- a/contrib/jenkins-build-osmo-ggsn.sh +++ b/contrib/jenkins-build-osmo-ggsn.sh @@ -4,7 +4,7 @@ name="osmo-ggsn" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo osmo-ggsn ${SANITIZE_FLAGS} create_bin_tgz osmo-ggsn diff --git a/contrib/jenkins-build-osmo-hlr.sh b/contrib/jenkins-build-osmo-hlr.sh index b6d6947..d02515d 100755 --- a/contrib/jenkins-build-osmo-hlr.sh +++ b/contrib/jenkins-build-osmo-hlr.sh @@ -4,7 +4,7 @@ name="osmo-hlr" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo osmo-hlr ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-hnbgw.sh b/contrib/jenkins-build-osmo-hnbgw.sh index 556f9c1..7ca20b4 100755 --- a/contrib/jenkins-build-osmo-hnbgw.sh +++ b/contrib/jenkins-build-osmo-hnbgw.sh @@ -4,7 +4,7 @@ name="osmo-hnbgw" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo libosmo-sccp ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-mgw.sh b/contrib/jenkins-build-osmo-mgw.sh index 2128fa2..f8dde72 100755 --- a/contrib/jenkins-build-osmo-mgw.sh +++ b/contrib/jenkins-build-osmo-mgw.sh @@ -4,7 +4,7 @@ name="osmo-mgw" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo osmo-mgw ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-msc.sh b/contrib/jenkins-build-osmo-msc.sh index 64243de..bfe148e 100755 --- a/contrib/jenkins-build-osmo-msc.sh +++ b/contrib/jenkins-build-osmo-msc.sh @@ -4,7 +4,7 @@ name="osmo-msc" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo libsmpp34 ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-nitb.sh b/contrib/jenkins-build-osmo-nitb.sh index 8ecbdba..7eb446d 100755 --- a/contrib/jenkins-build-osmo-nitb.sh +++ b/contrib/jenkins-build-osmo-nitb.sh @@ -4,7 +4,7 @@ name="osmo-nitb" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore --disable-doxygen +build_repo libosmocore --disable-doxygen --disable-uring build_repo libosmo-abis --disable-dahdi build_repo libosmo-netif --disable-doxygen build_repo openggsn diff --git a/contrib/jenkins-build-osmo-pcu-oc2g.sh b/contrib/jenkins-build-osmo-pcu-oc2g.sh index 60f42f7..985d953 100755 --- a/contrib/jenkins-build-osmo-pcu-oc2g.sh +++ b/contrib/jenkins-build-osmo-pcu-oc2g.sh @@ -31,7 +31,7 @@ git_url="${prev_git_url}" L1_OC2G_HEADERS="$PWD/oc2g-fw/inc" -build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug +build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug --disable-uring build_repo osmo-pcu --disable-sysmocom-dsp -enable-oc2gbts-phy --with-oc2g="$L1_OC2G_HEADERS" create_bin_tgz osmo-pcu diff --git a/contrib/jenkins-build-osmo-pcu-sysmo.sh b/contrib/jenkins-build-osmo-pcu-sysmo.sh index e55fd3d..2c8be7b 100755 --- a/contrib/jenkins-build-osmo-pcu-sysmo.sh +++ b/contrib/jenkins-build-osmo-pcu-sysmo.sh @@ -25,7 +25,7 @@ prefix_real="$DESTDIR$prefix" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug +build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug --disable-uring build_repo osmo-pcu --enable-sysmocom-dsp create_bin_tgz osmo-pcu diff --git a/contrib/jenkins-build-osmo-pcu.sh b/contrib/jenkins-build-osmo-pcu.sh index 1877f9c..5e88380 100755 --- a/contrib/jenkins-build-osmo-pcu.sh +++ b/contrib/jenkins-build-osmo-pcu.sh @@ -4,7 +4,7 @@ name="osmo-pcu" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-pcsc --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-pcsc --disable-doxygen --disable-uring build_repo osmo-pcu ${SANITIZE_FLAGS} create_bin_tgz osmo-pcu diff --git a/contrib/jenkins-build-osmo-sgsn.sh b/contrib/jenkins-build-osmo-sgsn.sh index 128e7b7..d624f45 100755 --- a/contrib/jenkins-build-osmo-sgsn.sh +++ b/contrib/jenkins-build-osmo-sgsn.sh @@ -4,7 +4,7 @@ name="osmo-sgsn" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo libosmo-sccp ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-stp.sh b/contrib/jenkins-build-osmo-stp.sh index c937eef..5fd4abb 100755 --- a/contrib/jenkins-build-osmo-stp.sh +++ b/contrib/jenkins-build-osmo-stp.sh @@ -4,7 +4,7 @@ name="osmo-stp" . "$(dirname "$0")/jenkins-build-common.sh" -build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen +build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen --disable-uring build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo libosmo-sccp ${SANITIZE_FLAGS} diff --git a/contrib/jenkins-build-osmo-trx.sh b/contrib/jenkins-build-osmo-trx.sh index 57e0906..d9c5f4f 100755 --- a/contrib/jenkins-build-osmo-trx.sh +++ b/contrib/jenkins-build-osmo-trx.sh @@ -31,7 +31,7 @@ # build_repo_limesuite # AddressSanitizer is not enabled on purpose since overhead affects the clocking. -build_repo libosmocore --disable-doxygen +build_repo libosmocore --disable-doxygen --disable-uring build_repo osmo-trx --with-uhd --with-lms create_bin_tgz "osmo-trx-uhd osmo-trx-lms" diff --git a/contrib/jenkins-build-osmocom-bb.sh b/contrib/jenkins-build-osmocom-bb.sh index 0c09aee..ef407f3 100755 --- a/contrib/jenkins-build-osmocom-bb.sh +++ b/contrib/jenkins-build-osmocom-bb.sh @@ -7,7 +7,7 @@ FW_RPM_URL="http://download.opensuse.org/repositories/home:/mnhauke:/osmocom:/nightly/o…" -build_repo libosmocore --disable-doxygen +build_repo libosmocore --disable-doxygen --disable-uring build_repo libosmo-gprs build_repo_dir osmocom-bb src/host/virt_phy ${SANITIZE_FLAGS} build_repo_dir osmocom-bb src/host/osmocon ${SANITIZE_FLAGS} -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/34201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ibc9605933380351a5fd23b772868c0e698b39c37 Gerrit-Change-Number: 34201 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in osmo-bsc[master]: pcuif_proto: use confirmation flag in struct gsm_pcu_if_pch

by dexter

Attention is currently required from: osmith, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 ) Change subject: pcuif_proto: use confirmation flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Same as I said on the other patch: I'm not liking this approach. […] I am not happy with this either. I will rename the "confirmed_imm_ass" to "confirm" and add some logic to osmo-bsc to make the behavior look like the one on osmo-bts as good as possible. I already have an idea. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3d2842626b7e8325860ea3160c7d900d39e953a0 Gerrit-Change-Number: 34192 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Aug 2023 08:41:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in pysim[master]: sim-rest-server: fix REST method info

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34154 ) Change subject: sim-rest-server: fix REST method info ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm not entirely sure this is an improvement. […] I agree with that, but I am not sure how much effort this would be. Quickly looking at pySim-shellp.py I would say we need a runtime state (rs) object and a profile (see init_card()) Then we could use the select method in lchan[0]. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib0178823abb18187404249cfed71cfb3123d1d74 Gerrit-Change-Number: 34154 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 25 Aug 2023 08:08:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in docker-playground[master]: debian-*-erlang: Install on libsctp-dev to enable sctp support in erl...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34200 ) Change subject: debian-*-erlang: Install on libsctp-dev to enable sctp support in erlang apps ...................................................................... debian-*-erlang: Install on libsctp-dev to enable sctp support in erlang apps The current "--enable-sctp" flag when building erlang consists of supporting SCTP if the libsctp library is found at runtime, by dynamically linking to it only when SCTP features are requested. The erlang package in debian only lists libsctp as a Build-Depends, but it is not installed by default, so apps wishing to use SCTP will fail: """ [error] CRASH REPORT Process <0.155.0> with 0 neighbours crashed with reason: no match of right hand value {error,{shutdown,{open,eprotonosupport} """ Installing the libsctp library fixes the issue. Related: OS#5757 Change-Id: I5ca332f9064c16491116608577b3f68379d840e6 --- M debian-bookworm-erlang/Dockerfile M debian-bullseye-erlang/Dockerfile 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/00/34200/1 diff --git a/debian-bookworm-erlang/Dockerfile b/debian-bookworm-erlang/Dockerfile index 0c13fd5..1ccc6cb 100644 --- a/debian-bookworm-erlang/Dockerfile +++ b/debian-bookworm-erlang/Dockerfile @@ -46,6 +46,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libpcap-dev \ + libsctp-dev \ && \ apt-get clean diff --git a/debian-bullseye-erlang/Dockerfile b/debian-bullseye-erlang/Dockerfile index 9477ebc..de8a111 100644 --- a/debian-bullseye-erlang/Dockerfile +++ b/debian-bullseye-erlang/Dockerfile @@ -37,6 +37,7 @@ RUN apt-get update && \ apt-get -y install \ libpcap-dev \ + libsctp-dev \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5ca332f9064c16491116608577b3f68379d840e6 Gerrit-Change-Number: 34200 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: cosmetic: Fix typo in comment

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34197 ) Change subject: cosmetic: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1f6a47aa8eb59224f4259969707f7e41d3c56a18 Gerrit-Change-Number: 34197 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 16:23:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Attempt reconnecting if connect fails

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 ) Change subject: gsup: Attempt reconnecting if connect fails ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0 Gerrit-Change-Number: 34199 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 16:22:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Log connect failures

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34198 ) Change subject: gsup: Log connect failures ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I273d37aa75cfacbc7c3302d035c2391d9bdd9b2e Gerrit-Change-Number: 34198 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Aug 2023 16:21:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Attempt reconnecting if connect fails

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 ) Change subject: gsup: Attempt reconnecting if connect fails ...................................................................... gsup: Attempt reconnecting if connect fails Related: OS#5657 Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0 --- M src/gsup_client.erl 1 file changed, 25 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/99/34199/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0 Gerrit-Change-Number: 34199 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Attempt reconnecting if connec fails

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 ) Change subject: gsup: Attempt reconnecting if connec fails ...................................................................... gsup: Attempt reconnecting if connec fails Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0 --- M src/gsup_client.erl 1 file changed, 24 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/99/34199/1 diff --git a/src/gsup_client.erl b/src/gsup_client.erl index 204dd76..55b1c5d 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -65,17 +65,20 @@ ipa_proto:init(), % register the GSUP codec with the IPA core; ignore result as we mgiht be doing this multiple times ipa_proto:register_codec(?IPAC_PROTO_EXT_GSUP, fun gsup_protocol:encode/1, fun gsup_protocol:decode/1), + connect([Address, Port, Options]). + +connect([Address, Port, Options]) -> lager:info("Connecting to GSUP HLR on IP ~s port ~p~n", [Address, Port]), - CcmOptions = #ipa_ccm_options{ - serial_number="HSS-00-00-00-00-00-00", - unit_id="0/0/0", - mac_address="00:00:00:00:00:00", - location="00:00:00:00:00:00", - unit_type="00:00:00:00:00:00", - equipment_version="00:00:00:00:00:00", - sw_version="00:00:00:00:00:00", - unit_name="HSS-00-00-00-00-00-00" - }, + CcmOptions = #ipa_ccm_options{ + serial_number="HSS-00-00-00-00-00-00", + unit_id="0/0/0", + mac_address="00:00:00:00:00:00", + location="00:00:00:00:00:00", + unit_type="00:00:00:00:00:00", + equipment_version="00:00:00:00:00:00", + sw_version="00:00:00:00:00:00", + unit_name="HSS-00-00-00-00-00-00" + }, case ipa_proto:connect(Address, Port, Options) of {ok, {Socket, IpaPid}} -> ipa_proto:set_ccm_options(Socket, CcmOptions), @@ -85,11 +88,11 @@ {ok, #gsupc_state{socket=Socket, ipa_pid=IpaPid}}; {error, Reason} -> lager:error("Connecting to GSUP HLR on IP ~s port ~p failed: ~p~n", [Address, Port, Reason]), + lager:info("Reconnecting to GSUP HLR in 5s...~n", []), timer:sleep(5000), - {stop, Reason} + connect([Address, Port, Options]) end. - % send a given GSUP message and synchronously wait for message type ExpRes or ExpErr handle_call({transceive_gsup, GsupMsgTx, ExpRes, ExpErr}, _From, State) -> Socket = State#gsupc_state.socket, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0 Gerrit-Change-Number: 34199 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Log connect failures

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34198 to look at the new patch set (#3). Change subject: gsup: Log connect failures ...................................................................... gsup: Log connect failures Change-Id: I273d37aa75cfacbc7c3302d035c2391d9bdd9b2e --- M src/gsup_client.erl 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/98/34198/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I273d37aa75cfacbc7c3302d035c2391d9bdd9b2e Gerrit-Change-Number: 34198 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023