August 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch

by pespin

Attention is currently required from: osmith, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 ) Change subject: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 2: Code-Review-1 (5 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/f4493e8c_4f1e0c93 PS2, Line 11: PCH, we have not the same flexibility as we have it in osmo-bsc. you mean osmo-bts here? https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/bbe0f1dc_390c8ddc PS2, Line 14: osmo-bts (cofirm PAGING messages, send non confirmed IMMEDIATE confirm File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/0fb28540_cd9a752b PS2, Line 559: if (!pch->confirm) why are you making so many suppositions here? Just do whatever the request asks you to do. The logic on what's needed is based in osmo-pcu, not here. Some versions of PCU may require confirmations, some not. Just stick to what the primitive asks. https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/245d3d6b_9a8a13ed PS2, Line 561: "PCU sends IMMEDIATE ASSIGNMENT via PCH but requests no conformation, will send confirmation anyway!\n"); confirmation https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/86d227db_a0174dd9 PS2, Line 566: if (pch->confirm) this also should go out. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3d2842626b7e8325860ea3160c7d900d39e953a0 Gerrit-Change-Number: 34192 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Aug 2023 13:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in osmo-pcu[master]: pcu_l1_if: add support for PCU_IF_SAPI_AGCH_2 for PCUIF v.11

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34058 ) Change subject: pcu_l1_if: add support for PCU_IF_SAPI_AGCH_2 for PCUIF v.11 ...................................................................... Patch Set 2: Code-Review-1 (4 comments) File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/37f87897_604e4566 PS2, Line 1037: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false); if we don't need cofnirmation so far, we don't need to pass a msg_id based on TLLI which may be actually TLLI_UNUSED sometimes. Hence, I think for not it's better to pass TLLI_UNUSED always here. https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/36465058_67a5f519 PS2, Line 1055: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false); Same, TLLI_UNUSED File src/pcu_l1_if.h: https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/1c5f882d_e7e3a6e7 PS2, Line 150: void pcu_l1if_tx_agch2(struct gprs_rlcmac_bts *bts, bitvec *block, int plen, bool conform, uint32_t msg_id); typo: confirm File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/3300277c_f63cd3da PS2, Line 278: /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX why did you drop this comment? This all still holds true afaict if v10 is being used. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9effdcec1da91a6e2e7a7c41f95d3300ad1bb292 Gerrit-Change-Number: 34058 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Aug 2023 13:48:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_proto: add confirm flag to struct gsm_pcu_if_pch

by pespin

Attention is currently required from: osmith, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34190 ) Change subject: pcuif_proto: add confirm flag to struct gsm_pcu_if_pch ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia202862aafc1f0cb6601574ef61eb9155de11f04 Gerrit-Change-Number: 34190 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Aug 2023 13:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[L] Change in libosmo-netif[master]: stream: Add server-side (segmentation) support for IPA

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 ) Change subject: stream: Add server-side (segmentation) support for IPA ...................................................................... stream: Add server-side (segmentation) support for IPA With this commit, IPA segmentation can be taken care of by setting the segmentation callback osmo_ipa_segmentation_cb(). Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f Related: OS#5753, OS#5751 Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c --- M examples/ipa-stream-server.c M include/osmocom/netif/stream.h M src/stream_srv.c M tests/stream/stream_test.c M tests/stream/stream_test.ok 5 files changed, 378 insertions(+), 10 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/examples/ipa-stream-server.c b/examples/ipa-stream-server.c index c72ed9a..1caef96 100644 --- a/examples/ipa-stream-server.c +++ b/examples/ipa-stream-server.c @@ -51,12 +51,6 @@ { LOGP(DSTREAMTEST, LOGL_DEBUG, "received message from stream (len=%d)\n", msgb_length(msg)); - if (osmo_ipa_process_msg(msg) < 0) { - LOGP(DSTREAMTEST, LOGL_ERROR, "Bad IPA message\n"); - msgb_free(msg); - return 0; - } - osmo_stream_srv_send(conn, msg); return 0; } @@ -84,6 +78,7 @@ osmo_stream_srv_set_name(conn, "ipa_srv"); osmo_stream_srv_set_read_cb(conn, read_cb); osmo_stream_srv_set_closed_cb(conn, close_cb); + osmo_stream_srv_set_segmentation_cb(conn, osmo_ipa_segmentation_cb); return 0; } diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index 057815b..6240205 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -58,6 +58,9 @@ void osmo_stream_srv_set_flush_and_destroy(struct osmo_stream_srv *conn); void osmo_stream_srv_set_data(struct osmo_stream_srv *conn, void *data); +void osmo_stream_srv_set_segmentation_cb(struct osmo_stream_srv *conn, + int (*segmentation_cb)(struct msgb *msg)); + void osmo_stream_srv_send(struct osmo_stream_srv *conn, struct msgb *msg); int osmo_stream_srv_recv(struct osmo_stream_srv *conn, struct msgb *msg); diff --git a/src/stream_srv.c b/src/stream_srv.c index c8d3233..f46175b 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -753,6 +753,23 @@ conn->data = data; } +/*! \brief Set the segmentation callback for target osmo_stream_srv structure. + * The connection has to have been established prior to calling this function. + * \param[in,out] conn Target Stream Server to modify + * \param[in] segmentation_cb Segmentation callback to be set */ +void osmo_stream_srv_set_segmentation_cb(struct osmo_stream_srv *conn, + int (*segmentation_cb)(struct msgb *msg)) +{ + /* Note that the following implies that iofd != NULL, since + * osmo_stream_srv_create2() creates the iofd member, too */ + OSMO_ASSERT(conn->mode == OSMO_STREAM_MODE_OSMO_IO); + /* Copy default settings */ + struct osmo_io_ops conn_ops = srv_ioops; + /* Set segmentation cb for this connection */ + conn_ops.segmentation_cb = segmentation_cb; + osmo_iofd_set_ioops(conn->iofd, &conn_ops); +} + /*! \brief Get application private data of the stream server * \param[in] conn Stream Server * \returns Application private data, as set by \ref osmo_stream_srv_set_data() */ diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c index 67603e9..01ebb23 100644 --- a/tests/stream/stream_test.c +++ b/tests/stream/stream_test.c @@ -1,6 +1,7 @@ /* - * (C) 2019 by sysmocom - s.f.m.c. GmbH. - * Author: Max Suraev + * (C) 2023 by sysmocom - s.f.m.c. GmbH. + * Authors: Max Suraev + * Alexander Rehbein * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -8,19 +9,23 @@ * (at your option) any later version. */ +#include <inttypes.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <unistd.h> #include <errno.h> +#include <osmocom/core/byteswap.h> #include <osmocom/core/select.h> #include <osmocom/core/talloc.h> #include <osmocom/core/msgb.h> #include <osmocom/core/logging.h> #include <osmocom/core/application.h> #include <osmocom/core/timer.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/netif/ipa.h> #include <osmocom/netif/stream.h> #define RECONNECT_TIMEOUT_SECS 9 @@ -366,9 +371,273 @@ printf("{%lu.%06lu} %s test complete.\n\n", tv.tv_sec, tv.tv_usec, ASTR(autoreconnect)); } +/* Segmentation test code (using IPA) */ +#define IPAC_MSG_PING_LEN 0x01 +static const uint8_t ipac_msg_ping[] = { + 0x00, IPAC_MSG_PING_LEN, + IPAC_PROTO_IPACCESS, + IPAC_MSGT_PING +}; +#define IPAC_MSG_PONG_LEN 0x01 +static const uint8_t ipac_msg_pong[] = { + 0x00, IPAC_MSG_PONG_LEN, + IPAC_PROTO_IPACCESS, + IPAC_MSGT_PONG +}; +#define IPAC_MSG_ID_REQ_LEN 0x03 +static const uint8_t ipac_msg_idreq[] = { + 0x00, IPAC_MSG_ID_REQ_LEN, + IPAC_PROTO_IPACCESS, + IPAC_MSGT_ID_GET, + 0x01, IPAC_IDTAG_UNITNAME +}; +#define ipac_msg_idreq_third (sizeof(ipac_msg_idreq)/3) +#define ipac_msg_idreq_last_third (sizeof(ipac_msg_idreq) - 2 * ipac_msg_idreq_third) +#define IPAC_MSG_ID_RESP_LEN 0x07 +static const uint8_t ipac_msg_idresp[] = { + 0x00, IPAC_MSG_ID_RESP_LEN, + IPAC_PROTO_IPACCESS, + IPAC_MSGT_ID_RESP, + 0x01, IPAC_IDTAG_UNITNAME, 0xde, 0xad, 0xbe, 0xef +}; + +#define put_ipa_msg(unsigned_char_ptr, struct_msgb_ptr, byte_array) do {\ + (unsigned_char_ptr) = msgb_put(struct_msgb_ptr, sizeof(byte_array));\ + memcpy(unsigned_char_ptr, byte_array, sizeof(byte_array));\ +} while (0) + +/* Array indices correspond to enum values stringified on the right */ +static const char * const IPAC_MSG_TYPES[] = { + [0] = "IPAC_MSGT_PING", + [1] = "IPAC_MSGT_PONG", + [2] = "UNEXPECTED VALUE", + [3] = "UNEXPECTED VALUE", + [4] = "IPAC_MSGT_ID_GET", + [5] = "IPAC_MSGT_ID_RESP", +}; + +#define IPAC_MSGT_OFFSET 3 +/* Append a message to UCHAR_PTR_DST. SRC_IPAC_MSG_BUF is expected to be a + * buffer containing an IPA message of type IPAC_PROTO_ACCESS that is + * syntactically correct up to offset 3 (IPAC_MSGT_OFFSET). + * Uses a counter so that appended messages can be distinguished easily in the logs */ +#define CLI_APPEND_MSG(OSMO_STREAM_CLI_PTR, UCHAR_PTR_DST, STRUCT_MSGB_PTR, SRC_IPAC_MSG_BUF) do {\ + LOGCLI(OSMO_STREAM_CLI_PTR, "[%u-cli] Appending msg of type %s into buffer\n",\ + ++test_segm_ipa_stream_srv_msglognum_cli, IPAC_MSG_TYPES[SRC_IPAC_MSG_BUF[IPAC_MSGT_OFFSET]]);\ + LOGCLI(OSMO_STREAM_CLI_PTR, "\t(msg dump: %s)\n", osmo_hexdump(SRC_IPAC_MSG_BUF,\ + sizeof(SRC_IPAC_MSG_BUF)));\ + put_ipa_msg(UCHAR_PTR_DST, STRUCT_MSGB_PTR, SRC_IPAC_MSG_BUF);\ +} while (0) + +static unsigned test_segm_ipa_stream_srv_msglognum_cli = 0; +static int test_segm_ipa_stream_srv_cli_connect_cb(struct osmo_stream_cli *cli) +{ + unsigned char *data; + struct msgb *m = msgb_alloc_headroom(128, 0, "IPA messages"); + if (m == NULL) { + fprintf(stderr, "Cannot allocate message\n"); + return -ENOMEM; + } + + /* Send 4 and 1/3 messages */ + /* Append 4 */ + CLI_APPEND_MSG(cli, data, m, ipac_msg_ping); + CLI_APPEND_MSG(cli, data, m, ipac_msg_pong); + CLI_APPEND_MSG(cli, data, m, ipac_msg_ping); + CLI_APPEND_MSG(cli, data, m, ipac_msg_idresp); + /* Append 1/3 */ + LOGCLI(cli, "[(0%u + 1/3)-cli] Appending 1st third of msg of type %s into buffer\n", + test_segm_ipa_stream_srv_msglognum_cli, IPAC_MSG_TYPES[ipac_msg_idreq[3]]); + LOGCLI(cli, "\t(dump: %s)\n", osmo_hexdump(ipac_msg_idreq, ipac_msg_idreq_third)); + data = msgb_put(m, ipac_msg_idreq_third); + memcpy(data, ipac_msg_idreq, ipac_msg_idreq_third); + + LOGCLI(cli, "Sending 4 + 1/3 messages as one:\n"); + LOGCLI(cli, "\t(msg dump: %s)\n\n", osmo_hexdump(m->data, m->len)); + osmo_stream_cli_send(cli, m); + return 0; +} + +static bool test_segm_ipa_stream_srv_all_msgs_processed = false; + +static void send_last_third(void *osmo_stream_cli_arg) +{ + struct osmo_stream_cli *osc = osmo_stream_cli_arg; + unsigned char *data; + struct msgb *reply = msgb_alloc_headroom(128, 0, "IPA delayed reply"); + + LOGCLI(osc, "Delay for sending last third of message is over\n"); + if (reply == NULL) { + fprintf(stderr, "Cannot allocate message\n"); + return; + } + LOGCLI(osc, "[%u-cli] Appending: Last third of IPAC_MSGT_ID_GET\n", + ++test_segm_ipa_stream_srv_msglognum_cli); + data = msgb_put(reply, ipac_msg_idreq_last_third); + memcpy(data, ipac_msg_idreq + 2 * ipac_msg_idreq_third, + ipac_msg_idreq_last_third); + /* Append two entire messages */ + CLI_APPEND_MSG(osc, data, reply, ipac_msg_pong); + CLI_APPEND_MSG(osc, data, reply, ipac_msg_pong); + LOGCLI(osc, "\tSending:" + "[ Last third of IPAC_MSGT_ID_GET | IPAC_MSGT_PONG | IPAC_MSGT_PONG ]\n"); + LOGCLI(osc, "\t(msg dump: %s)\n\n", osmo_hexdump(reply->data, reply->len)); + osmo_stream_cli_send(osc, reply); +} + +static struct osmo_timer_list fragmented_send_tl_cli; + +static int test_segm_ipa_stream_srv_cli_read_cb(struct osmo_stream_cli *osc, struct msgb *msg) +{ + unsigned char *data; + struct ipa_head *h = (struct ipa_head *) msg->data; + uint8_t ipac_msg_type = ((uint8_t *)h)[sizeof(struct ipa_head)]; + struct msgb *reply = msgb_alloc_headroom(128, 0, "IPA reply"); + if (reply == NULL) { + fprintf(stderr, "Cannot allocate message\n"); + return -ENOMEM; + } + LOGCLI(osc, "Received message from stream (total len = %" PRIu16 ")\n", msgb_length(msg)); + if (ipac_msg_type < 0 || 5 < ipac_msg_type) { + fprintf(stderr, "Received unexpected IPAC message type %"PRIu8"\n", ipac_msg_type); + return -ENOMSG; + } + LOGCLI(osc, "\tType: %s\n", IPAC_MSG_TYPES[ipac_msg_type]); + if (ipac_msg_type == IPAC_MSGT_ID_GET) { + LOGCLI(osc, "Got IPAC_MSGT_ID_GET from server\n"); + LOGCLI(osc, "[(%u + 2/3) -cli] Appending: Second third of IPAC_MSGT_ID_GET\n", + test_segm_ipa_stream_srv_msglognum_cli); + data = msgb_put(reply, ipac_msg_idreq_third); + memcpy(data, ipac_msg_idreq + ipac_msg_idreq_third, + ipac_msg_idreq_third); + LOGCLI(osc, "\tSending: Second third of IPAC_MSGT_ID_GET\n"); + LOGCLI(osc, "\t(msg dump: %s)\n", osmo_hexdump(reply->data, reply->len)); + osmo_stream_cli_send(osc, reply); + osmo_timer_setup(&fragmented_send_tl_cli, send_last_third, osc); + osmo_timer_add(&fragmented_send_tl_cli); + osmo_timer_schedule(&fragmented_send_tl_cli, 0, 500000); + } else if (ipac_msg_type == IPAC_MSGT_ID_RESP) { + LOGCLI(osc, "\tresult= %s\n", + osmo_hexdump((const unsigned char *)h, sizeof(*h) + h->len)); + LOGCLI(osc, "\texpected=%s\n", + osmo_hexdump(ipac_msg_idresp, sizeof(ipac_msg_idresp))); + } + printf("\n"); + return 0; +} + +static void *test_segm_ipa_stream_srv_run_client(void) +{ + struct osmo_stream_cli *osc; + void *ctx = talloc_named_const(NULL, 0, __func__); + + (void) msgb_talloc_ctx_init(ctx, 0); + osc = osmo_stream_cli_create(ctx); + if (osc == NULL) { + fprintf(stderr, "osmo_stream_cli_create_iofd()\n"); + return NULL; + } + osmo_stream_cli_set_addr(osc, "127.0.0.11"); + osmo_stream_cli_set_port(osc, 1111); + osmo_stream_cli_set_connect_cb(osc, test_segm_ipa_stream_srv_cli_connect_cb); + osmo_stream_cli_set_data(osc, ctx); + osmo_stream_cli_set_read_cb2(osc, test_segm_ipa_stream_srv_cli_read_cb); + osmo_stream_cli_set_nodelay(osc, true); + if (osmo_stream_cli_open(osc) < 0) { + fprintf(stderr, "Cannot open stream client\n"); + return NULL; + } + + return NULL; +} + +int test_segm_ipa_stream_srv_srv_read_cb(struct osmo_stream_srv *conn, struct msgb *msg) +{ + static unsigned msgnum_srv = 0; + struct ipa_head *ih = (struct ipa_head *)msg->l1h; + unsigned char *data; + struct msgb *m; + uint8_t *msgt = msg->l2h; /* Octet right after IPA header */ + LOGSRV(conn, "[%u-srv] Received IPA message from stream (payload len = %" PRIu16 ")\n", + ++msgnum_srv, msgb_length(msg)); + LOGSRV(conn, "\tmsg buff data (including stripped headers): %s\n", + osmo_hexdump((unsigned char *)ih, osmo_ntohs(ih->len) + sizeof(*ih))); + LOGSRV(conn, "\tIPA payload: %s\n", osmo_hexdump(ih->data, osmo_ntohs(ih->len))); + LOGSRV(conn, "\tType: %s\n", IPAC_MSG_TYPES[*msgt]); + LOGSRV(conn, "\t(msg dump: %s)\n", osmo_hexdump(msg->l1h, msg->len + sizeof(struct ipa_head))); + if (*msgt == IPAC_MSGT_ID_RESP) { /* */ + LOGSRV(conn, "Send IPAC_MSGT_ID_GET to trigger client to send next third\n\n"); + m = msgb_alloc_headroom(128, 0, "IPA messages"); + if (m == NULL) { + fprintf(stderr, "Cannot allocate message\n"); + return -ENOMEM; + } + put_ipa_msg(data, m, ipac_msg_idreq); + osmo_stream_srv_send(conn, m); + } else if (msgnum_srv == 7 && *msgt == IPAC_MSGT_PONG) { + test_segm_ipa_stream_srv_all_msgs_processed = true; + } + return 0; +} + +static int test_segm_ipa_stream_srv_srv_close_cb(struct osmo_stream_srv *conn) +{ + osmo_stream_srv_set_segmentation_cb(conn, NULL); + return 0; +} + +static int test_segm_ipa_stream_srv_srv_accept_cb(struct osmo_stream_srv_link *srv, int fd) +{ + void *ctx = talloc_named_const(NULL, 0, __func__); + struct osmo_stream_srv *oss = + osmo_stream_srv_create2(ctx, srv, fd, NULL); + if (oss == NULL) { + fprintf(stderr, "Error while creating connection\n"); + return -1; + } + osmo_stream_srv_set_segmentation_cb(oss, osmo_ipa_segmentation_cb); + osmo_stream_srv_set_read_cb(oss, test_segm_ipa_stream_srv_srv_read_cb); + osmo_stream_srv_set_closed_cb(oss, test_segm_ipa_stream_srv_srv_close_cb); + return 0; +} + +static void test_segm_ipa_stream_srv_run(void *ctx, const char *host, unsigned port, + struct osmo_stream_srv_link *srv) +{ + const char *testname = "test_segm_ipa_stream_srv"; + osmo_stream_srv_link_set_accept_cb(srv, + test_segm_ipa_stream_srv_srv_accept_cb); + if (osmo_stream_srv_link_open(srv) < 0) { + printf("Unable to open server\n"); + exit(1); + } + test_segm_ipa_stream_srv_run_client(); + + printf("______________________________________Running test %s______________________________________\n", testname); + alarm(2); + + while (!test_segm_ipa_stream_srv_all_msgs_processed) { + osmo_gettimeofday_override_add(0, 1); /* small increment to easily spot iterations */ + osmo_select_main(1); + } + alarm(0); + printf("==================================Test %s complete========================================\n\n", testname); +} + +static void sigalarm_handler(int _foo) +{ + printf("FAIL: test did not run successfully\n"); + exit(EXIT_FAILURE); +} int main(void) { + + if (signal(SIGALRM, sigalarm_handler) == SIG_ERR) { + perror("signal"); + exit(EXIT_FAILURE); + } + struct osmo_stream_srv_link *srv; char *host = "127.0.0.11"; unsigned port = 1111; @@ -406,8 +675,8 @@ test_recon(tall_test, host, port, 12, srv, true); test_recon(tall_test, host, port, 8, srv, false); - osmo_stream_srv_link_destroy(srv); - printf("Stream tests completed\n"); + test_segm_ipa_stream_srv_run(tall_test, host, port, srv); + printf("Stream tests completed\n"); return EXIT_SUCCESS; } diff --git a/tests/stream/stream_test.ok b/tests/stream/stream_test.ok index 2106295..f21b486 100644 --- a/tests/stream/stream_test.ok +++ b/tests/stream/stream_test.ok @@ -48,4 +48,73 @@ {11.000019} [OK] Client's read_cb_cli(): 0-byte read, auto-reconnect will be triggered if enabled {20.000019} non-reconnecting test complete. +______________________________________Running test test_segm_ipa_stream_srv______________________________________ +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [1-cli] Appending msg of type IPAC_MSGT_PING into buffer +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 ) +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [2-cli] Appending msg of type IPAC_MSGT_PONG into buffer +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 01 ) +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [3-cli] Appending msg of type IPAC_MSGT_PING into buffer +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 ) +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [4-cli] Appending msg of type IPAC_MSGT_ID_RESP into buffer +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 07 fe 05 01 01 de ad be ef ) +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): [(04 + 1/3)-cli] Appending 1st third of msg of type IPAC_MSGT_ID_GET into buffer +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (dump: 00 03 ) +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): Sending 4 + 1/3 messages as one: +{20.000020} [OK] Client's test_segm_ipa_stream_srv_cli_connect_cb(): (msg dump: 00 01 fe 00 00 01 fe 01 00 01 fe 00 00 07 fe 05 01 01 de ad be ef 00 03 ) + +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [1-srv] Received IPA message from stream (payload len = 1) +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 01 fe 00 +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): IPA payload: 00 +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Type: IPAC_MSGT_PING +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): (msg dump: 00 01 fe 00 ) +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [2-srv] Received IPA message from stream (payload len = 1) +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 01 fe 01 +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): IPA payload: 01 +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Type: IPAC_MSGT_PONG +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): (msg dump: 00 01 fe 01 ) +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [3-srv] Received IPA message from stream (payload len = 1) +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 01 fe 00 +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): IPA payload: 00 +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Type: IPAC_MSGT_PING +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): (msg dump: 00 01 fe 00 ) +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [4-srv] Received IPA message from stream (payload len = 7) +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 07 fe 05 01 01 de ad be ef +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): IPA payload: 05 01 01 de ad be ef +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Type: IPAC_MSGT_ID_RESP +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): (msg dump: 00 07 fe 05 01 01 de ad be ef ) +{20.000022} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Send IPAC_MSGT_ID_GET to trigger client to send next third + +{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): Received message from stream (total len = 6) +{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): Type: IPAC_MSGT_ID_GET +{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): Got IPAC_MSGT_ID_GET from server +{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): [(4 + 2/3) -cli] Appending: Second third of IPAC_MSGT_ID_GET +{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): Sending: Second third of IPAC_MSGT_ID_GET +{20.000024} [OK] Client's test_segm_ipa_stream_srv_cli_read_cb(): (msg dump: fe 04 ) + +{20.500024} [OK] Client's send_last_third(): Delay for sending last third of message is over +{20.500024} [OK] Client's send_last_third(): [5-cli] Appending: Last third of IPAC_MSGT_ID_GET +{20.500024} [OK] Client's send_last_third(): [6-cli] Appending msg of type IPAC_MSGT_PONG into buffer +{20.500024} [OK] Client's send_last_third(): (msg dump: 00 01 fe 01 ) +{20.500024} [OK] Client's send_last_third(): [7-cli] Appending msg of type IPAC_MSGT_PONG into buffer +{20.500024} [OK] Client's send_last_third(): (msg dump: 00 01 fe 01 ) +{20.500024} [OK] Client's send_last_third(): Sending:[ Last third of IPAC_MSGT_ID_GET | IPAC_MSGT_PONG | IPAC_MSGT_PONG ] +{20.500024} [OK] Client's send_last_third(): (msg dump: 01 01 00 01 fe 01 00 01 fe 01 ) + +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [5-srv] Received IPA message from stream (payload len = 3) +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 03 fe 04 01 01 +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): IPA payload: 04 01 01 +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Type: IPAC_MSGT_ID_GET +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): (msg dump: 00 03 fe 04 01 01 ) +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [6-srv] Received IPA message from stream (payload len = 1) +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 01 fe 01 +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): IPA payload: 01 +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Type: IPAC_MSGT_PONG +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): (msg dump: 00 01 fe 01 ) +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): [7-srv] Received IPA message from stream (payload len = 1) +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): msg buff data (including stripped headers): 00 01 fe 01 +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): IPA payload: 01 +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): Type: IPAC_MSGT_PONG +{20.500026} [NA|OK] Server's test_segm_ipa_stream_srv_srv_read_cb(): (msg dump: 00 01 fe 01 ) +==================================Test test_segm_ipa_stream_srv complete======================================== + Stream tests completed -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c Gerrit-Change-Number: 33197 Gerrit-PatchSet: 15 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Cosmetic: msc: f_tc_ho_inter_msc_out: fix indent

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34178 ) Change subject: Cosmetic: msc: f_tc_ho_inter_msc_out: fix indent ...................................................................... Cosmetic: msc: f_tc_ho_inter_msc_out: fix indent Change-Id: Ie648a485991aff0c28182955a7df2d1505457978 --- M msc/MSC_Tests.ttcn 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 7c4d8ba..e5c48bb 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6030,9 +6030,9 @@ cpars := valueof(t_CallParams('12345'H, 0)); if (pars.use_ipv6) { - cpars.mgw_conn_1.mgw_rtp_ip := "::1"; - cpars.mgw_conn_2.mgw_rtp_ip := "::2"; - cpars.bss_rtp_ip := "::3"; + cpars.mgw_conn_1.mgw_rtp_ip := "::1"; + cpars.mgw_conn_2.mgw_rtp_ip := "::2"; + cpars.bss_rtp_ip := "::3"; } var hexstring ho_number := f_gen_msisdn(99999); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie648a485991aff0c28182955a7df2d1505457978 Gerrit-Change-Number: 34178 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_ho_inter_bsc_csd: new test

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34177 ) Change subject: msc: TC_ho_inter_bsc_csd: new test ...................................................................... msc: TC_ho_inter_bsc_csd: new test Related: OS#4394 Change-Id: I391856282d046e915c374e0efb06d4da870bff1f --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 22 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 9f74199..396c3f7 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -133,6 +133,7 @@ boolean ran_is_geran, boolean use_osmux, boolean use_ipv6, + boolean use_csd, boolean verify_cell_id, OCT3 common_id_last_eutran_plmn optional }; diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 25d6a10..7c4d8ba 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -414,6 +414,7 @@ ran_is_geran := ran_is_geran, use_osmux := use_osmux, use_ipv6 := false, + use_csd := false, verify_cell_id := verify_cell_id, common_id_last_eutran_plmn := omit }; @@ -5773,6 +5774,9 @@ cpars.mgw_conn_2.mgw_rtp_ip := "::2"; cpars.bss_rtp_ip := "::3"; } + if (pars.use_csd) { + f_set_cpars_csd(cpars, "BS25T", '1'B, GSM48_BCAP_TR_TRANSP, GSM48_BCAP_UR_4800); + } f_init_handler(pars); @@ -5949,13 +5953,14 @@ f_expect_clear(); setverdict(pass); } -function f_tc_ho_inter_bsc_main(boolean use_ipv6 := false, integer a5_n := 0) runs on MTC_CT { +function f_tc_ho_inter_bsc_main(boolean use_ipv6 := false, integer a5_n := 0, boolean use_csd := false) runs on MTC_CT { var BSC_ConnHdlr vc_conn0; var BSC_ConnHdlr vc_conn1; f_init(2); var BSC_ConnHdlrPars pars0 := f_init_pars(53); pars0.use_ipv6 := use_ipv6; + pars0.use_csd := use_csd; pars0.net.expect_ciph := a5_n > 0; pars0.net.expect_auth := pars0.net.expect_ciph; pars0.net.kc_support := bit2oct('00000001'B << a5_n); @@ -5970,6 +5975,7 @@ var BSC_ConnHdlrPars pars1 := f_init_pars(53); pars1.use_ipv6 := use_ipv6; + pars1.use_csd := use_csd; pars1.net.expect_ciph := pars0.net.expect_ciph; pars1.net.expect_auth := pars0.net.expect_ciph; pars1.net.kc_support := bit2oct('00000001'B << a5_n); @@ -6008,6 +6014,9 @@ testcase TC_ho_inter_bsc_ipv6() runs on MTC_CT { f_tc_ho_inter_bsc_main(true); } +testcase TC_ho_inter_bsc_csd() runs on MTC_CT { + f_tc_ho_inter_bsc_main(use_csd := true); +} function f_ML3_patch_seq_nr_MS_NW(in uint2_t seq_nr, inout octetstring enc_l3) { log("MS_NW patching N(SD)=", seq_nr, " into dtap ", enc_l3); @@ -7412,6 +7421,7 @@ execute( TC_ho_inter_bsc_a5_3() ); execute( TC_ho_inter_bsc_a5_4() ); execute( TC_ho_inter_bsc_ipv6() ); + execute( TC_ho_inter_bsc_csd() ); execute( TC_ho_inter_msc_out() ); execute( TC_ho_inter_msc_out_a5_1() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I391856282d046e915c374e0efb06d4da870bff1f Gerrit-Change-Number: 34177 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_ho_inter_msc_out_csd: new test

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34179 ) Change subject: msc: TC_ho_inter_msc_out_csd: new test ...................................................................... msc: TC_ho_inter_msc_out_csd: new test Related: OS#4394 Change-Id: Id45a634888776265a88d607080b951a2cc33820d --- M msc/MSC_Tests.ttcn 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index e5c48bb..0bd1b02 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6034,6 +6034,9 @@ cpars.mgw_conn_2.mgw_rtp_ip := "::2"; cpars.bss_rtp_ip := "::3"; } + if (pars.use_csd) { + f_set_cpars_csd(cpars, "BS25T", '1'B, GSM48_BCAP_TR_TRANSP, GSM48_BCAP_UR_4800); + } var hexstring ho_number := f_gen_msisdn(99999); f_init_handler(pars); @@ -6346,6 +6349,16 @@ vc_conn := f_start_handler_with_pars(refers(f_tc_ho_inter_msc_out), pars); vc_conn.done; } +testcase TC_ho_inter_msc_out_csd() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(1); + + var BSC_ConnHdlrPars pars := f_init_pars(54); + pars.use_csd := true; + + vc_conn := f_start_handler_with_pars(refers(f_tc_ho_inter_msc_out), pars); + vc_conn.done; +} private function f_tc_lu_imsi_auth_tmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { pars.net.expect_auth := true; @@ -7428,6 +7441,7 @@ execute( TC_ho_inter_msc_out_a5_3() ); execute( TC_ho_inter_msc_out_a5_4() ); execute( TC_ho_inter_msc_out_ipv6() ); + execute( TC_ho_inter_msc_out_csd() ); execute( TC_lu_imsi_auth_tmsi_check_imei() ); execute( TC_lu_imsi_auth3g_tmsi_check_imei() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id45a634888776265a88d607080b951a2cc33820d Gerrit-Change-Number: 34179 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_ho_inter_msc_out_csd: new test

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34179 ) Change subject: msc: TC_ho_inter_msc_out_csd: new test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34179 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id45a634888776265a88d607080b951a2cc33820d Gerrit-Change-Number: 34179 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Aug 2023 13:18:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Cosmetic: msc: f_tc_ho_inter_msc_out: fix indent

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34178 ) Change subject: Cosmetic: msc: f_tc_ho_inter_msc_out: fix indent ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie648a485991aff0c28182955a7df2d1505457978 Gerrit-Change-Number: 34178 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Aug 2023 13:18:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_ho_inter_bsc_csd: new test

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34177 ) Change subject: msc: TC_ho_inter_bsc_csd: new test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I391856282d046e915c374e0efb06d4da870bff1f Gerrit-Change-Number: 34177 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 25 Aug 2023 13:18:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023