August 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ci[master]: repo-install-test: add debian12

by daniel

Attention is currently required from: osmith, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34037 ) Change subject: repo-install-test: add debian12 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I51fa3c5212b5e29f4c2804384781693e8de2c097 Gerrit-Change-Number: 34037 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Aug 2023 09:28:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if.cpp: Fix gsmtap not sent in PCU_IF_SAPI_PCH_DT

by osmith

Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34019 ) Change subject: pcu_l1_if.cpp: Fix gsmtap not sent in PCU_IF_SAPI_PCH_DT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2cfa0486a3483140ce219b4645e0544e7923870a Gerrit-Change-Number: 34019 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Aug 2023 08:49:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: ul_tbf: Implement TBF_Starting time (phase1)

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34046 ) Change subject: rlcmac: ul_tbf: Implement TBF_Starting time (phase1) ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If6b7766ee1ba6667db4e54e897f376f5b27ad73d Gerrit-Change-Number: 34046 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Aug 2023 08:47:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in libosmo-gprs[master]: rlcmac: ul_tbf: Factor out function configuring TBF to lower layers

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34045 ) Change subject: rlcmac: ul_tbf: Factor out function configuring TBF to lower layers ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34045 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I174327b25b726662a6b5902008e205ddb3de2fe0 Gerrit-Change-Number: 34045 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Aug 2023 08:43:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in libosmo-gprs[master]: rlcmac: Fix Starting Time fn->fn calculation

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 ) Change subject: rlcmac: Fix Starting Time fn->fn calculation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/2796a24b_49595a50 PS2, Line 7: fn rfn? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3 Gerrit-Change-Number: 34044 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Aug 2023 08:40:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add missing msg->l2h

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34035 ) Change subject: dahdi: Add missing msg->l2h ...................................................................... dahdi: Add missing msg->l2h l2h is now set in all receive functions after putting received data to the msgb. Change-Id: Ieec5e2e6bacc4bce465c29b2148537e8b2218a00 --- M src/input/dahdi.c 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/input/dahdi.c b/src/input/dahdi.c index b4e6657..2120575 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -181,11 +181,12 @@ LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); return ret; } - msgb_put(msg, ret - 2); if (ret <= 3) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); return ret; } + msgb_put(msg, ret - 2); + msg->l2h = msg->data; return e1inp_rx_ts_lapd(e1i_ts, msg); } @@ -317,11 +318,12 @@ LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); return ret; } - msgb_put(msg, ret - 2); if (ret <= 3) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); return ret; } + msgb_put(msg, ret - 2); + msg->l2h = msg->data; return e1inp_rx_ts(e1i_ts, msg, 0, 0); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieec5e2e6bacc4bce465c29b2148537e8b2218a00 Gerrit-Change-Number: 34035 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add msgb_free() to prevent memeory leaks

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34036 ) Change subject: dahdi: Add msgb_free() to prevent memeory leaks ...................................................................... dahdi: Add msgb_free() to prevent memeory leaks Change-Id: I862dfa80dc195639552f99ec0734ec94290a7bb5 --- M src/input/dahdi.c 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/input/dahdi.c b/src/input/dahdi.c index 2120575..7838866 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -179,10 +179,12 @@ handle_dahdi_exception(e1i_ts); else if (ret < 0) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + msgb_free(msg); return ret; } if (ret <= 3) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + msgb_free(msg); return ret; } msgb_put(msg, ret - 2); @@ -316,10 +318,12 @@ handle_dahdi_exception(e1i_ts); else if (ret < 0) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + msgb_free(msg); return ret; } if (ret <= 3) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + msgb_free(msg); return ret; } msgb_put(msg, ret - 2); @@ -377,6 +381,7 @@ ret = read(bfd->fd, msg->data, D_TSX_ALLOC_SIZE); if (ret < 0 || ret != D_TSX_ALLOC_SIZE) { LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "read error %d %s\n", ret, strerror(errno)); + msgb_free(msg); return ret; } @@ -446,6 +451,7 @@ ret = read(bfd->fd, msg->data, D_TSX_ALLOC_SIZE); if (ret < 0 || ret != D_TSX_ALLOC_SIZE) { LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "read error %d %s\n", ret, strerror(errno)); + msgb_free(msg); return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I862dfa80dc195639552f99ec0734ec94290a7bb5 Gerrit-Change-Number: 34036 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34034 ) Change subject: dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty ...................................................................... dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty Not doing so will cause 100% CPU usage, because the write functions are constantly called if their queue is empty. Change-Id: I2c544594eb187110861ab2564323654a2dc6e85a --- M src/input/dahdi.c 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/dahdi.c b/src/input/dahdi.c index acf1f94..b4e6657 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -277,8 +277,10 @@ /* get the next msg for this timeslot */ msg = e1inp_tx_ts(e1i_ts, NULL); - if (!msg) + if (!msg) { + osmo_fd_write_disable(bfd); return; + } if (msgb_tailroom(msg) >= 2) { /* two bytes of space for the FCS added by DAHDI in the kernel */ @@ -402,8 +404,10 @@ /* get the next msg for this timeslot */ msg = e1inp_tx_ts(e1i_ts, NULL); - if (!msg) + if (!msg) { + osmo_fd_write_disable(bfd); return 0; + } if (msg->len != D_BCHAN_TX_GRAN) { /* This might lead to a transmit underrun, as we call tx -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2c544594eb187110861ab2564323654a2dc6e85a Gerrit-Change-Number: 34034 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34034 ) Change subject: dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2c544594eb187110861ab2564323654a2dc6e85a Gerrit-Change-Number: 34034 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 02 Aug 2023 19:55:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in pysim[master]: pySim-trace_test: fix shebang line

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/34040 ) Change subject: pySim-trace_test: fix shebang line ...................................................................... pySim-trace_test: fix shebang line Related: OS#6094 Change-Id: Ib2d3a4659f5db9772ddcd9a4ae73c04fec1070fc --- M tests/pySim-trace_test.sh 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/tests/pySim-trace_test.sh b/tests/pySim-trace_test.sh index 0ec5e0f..40c5db6 100755 --- a/tests/pySim-trace_test.sh +++ b/tests/pySim-trace_test.sh @@ -1,4 +1,4 @@ -#/bin/bash +#!/bin/bash PYSIM_TRACE=../pySim-trace.py GSMTAP_TRACE=pySim-trace_test_gsmtap.pcapng -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34040 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2d3a4659f5db9772ddcd9a4ae73c04fec1070fc Gerrit-Change-Number: 34040 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023