July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: improve accessibility of unit-data
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898 ) Change subject: S1AP_Emulation: improve accessibility of unit-data ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > An expect mechanism where I can register a template sounds like a good idea. […] I think the problem with the "register a template" was that you cannot send templates through test ports, only values. So it's not possible in an easy/straight-forward way, and that's why we have expects only for IMSIs and other values in other *_Emulation components. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I041b45b247e365b0d4ee8645c07dc5f26007af82 Gerrit-Change-Number: 33898 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 07:44:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: fix incorrect comment
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33909 ) Change subject: S1AP_Emulation: fix incorrect comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1134ddf1f847dd297b13f0664099da6fdc8059bd Gerrit-Change-Number: 33909 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 07:43:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 ) Change subject: S1AP_Emulation: initialize comp_ref member of S1apAssociationTable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If86a18a4a953665c1e2bf7f757880ba3ac6c0f83 Gerrit-Change-Number: 33910 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 07:43:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33915 ) Change subject: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/libmsc/ran_msg_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/33915/comment/24d75352_48d498e1 PS1, Line 1354: . this is false. We don't support CSDoTDM, as we don't have a ciruit-switched A interface. We only do AoIP and hence CSDoIP. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibc452d37d4215c961a7946eef3ba2e7efdba078b Gerrit-Change-Number: 33915 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 07:42:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33914 ) Change subject: ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4095124be8ffb293863f35bea440cd465048a9fd Gerrit-Change-Number: 33914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 07:42:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_mgcp_codec_from_sc(): cosmetic: remove unneeded breaks
by laforge 25 Jul '23

25 Jul '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33913 ) Change subject: ran_a_mgcp_codec_from_sc(): cosmetic: remove unneeded breaks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I23d94c2d81c929deb819c02f4ddac3a702a3867d Gerrit-Change-Number: 33913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Jul 2023 07:41:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD
by fixeria 25 Jul '23

25 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33915 ) Change subject: ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD ...................................................................... ran_a_channel_type_to_speech_codec_list(): set PI/PT for CSD As per 3GPP TS 48.008, section 3.2.2.103, the Codec Type is valid if at least one of FI, PI or PT is set to '1'. Otherwise the Speech Codec Element is considered invalid and shall be ignored. Change-Id: Ibc452d37d4215c961a7946eef3ba2e7efdba078b Related: OS#6110, OS#4394 --- M src/libmsc/ran_msg_a.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/15/33915/1 diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index 3788805..c96b018 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -1349,7 +1349,12 @@ switch (ct->ch_indctr) { case GSM0808_CHAN_DATA: - scl->codec[0].type = GSM0808_SCT_CSD; + scl->codec[0] = (struct gsm0808_speech_codec) { + .pi = true, /* PI indicates CSDoIP is supported */ + .pt = true, /* PT indicates CSDoTDM is supported */ + .type = GSM0808_SCT_CSD, + .cfg = 0, /* R2/R3 not set (redundancy not supported) */ + }; scl->len = 1; break; case GSM0808_CHAN_SPEECH: -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibc452d37d4215c961a7946eef3ba2e7efdba078b Gerrit-Change-Number: 33915 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE
by fixeria 25 Jul '23

25 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33914 ) Change subject: ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE ...................................................................... ran_a_mgcp_codec_from_sc(): map GSM0808_SCT_CSD to CODEC_CLEARMODE Change-Id: I4095124be8ffb293863f35bea440cd465048a9fd Related: OS#6110, OS#4394 --- M src/libmsc/ran_msg_a.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/33914/1 diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index 37acedb..3788805 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -254,6 +254,8 @@ return CODEC_AMRWB_16000_1; case GSM0808_SCT_HR6: return CODEC_AMRWB_16000_1; + case GSM0808_SCT_CSD: + return CODEC_CLEARMODE; default: return CODEC_PCMU_8000_1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4095124be8ffb293863f35bea440cd465048a9fd Gerrit-Change-Number: 33914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: ran_a_mgcp_codec_from_sc(): cosmetic: remove unneeded breaks
by fixeria 25 Jul '23

25 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33913 ) Change subject: ran_a_mgcp_codec_from_sc(): cosmetic: remove unneeded breaks ...................................................................... ran_a_mgcp_codec_from_sc(): cosmetic: remove unneeded breaks Change-Id: I23d94c2d81c929deb819c02f4ddac3a702a3867d Related: OS#6110, OS#4394 --- M src/libmsc/ran_msg_a.c 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/13/33913/1 diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c index d2ab09f..37acedb 100644 --- a/src/libmsc/ran_msg_a.c +++ b/src/libmsc/ran_msg_a.c @@ -238,34 +238,24 @@ switch (sc->type) { case GSM0808_SCT_FR1: return CODEC_GSM_8000_1; - break; case GSM0808_SCT_FR2: return CODEC_GSMEFR_8000_1; - break; case GSM0808_SCT_FR3: return CODEC_AMR_8000_1; - break; case GSM0808_SCT_FR4: return CODEC_AMRWB_16000_1; - break; case GSM0808_SCT_FR5: return CODEC_AMRWB_16000_1; - break; case GSM0808_SCT_HR1: return CODEC_GSMHR_8000_1; - break; case GSM0808_SCT_HR3: return CODEC_AMR_8000_1; - break; case GSM0808_SCT_HR4: return CODEC_AMRWB_16000_1; - break; case GSM0808_SCT_HR6: return CODEC_AMRWB_16000_1; - break; default: return CODEC_PCMU_8000_1; - break; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I23d94c2d81c929deb819c02f4ddac3a702a3867d Gerrit-Change-Number: 33913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: fix send_assignment_complete(): proper SCE encoding for CSD
by fixeria 25 Jul '23

25 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33912 ) Change subject: fix send_assignment_complete(): proper SCE encoding for CSD ...................................................................... fix send_assignment_complete(): proper SCE encoding for CSD As stated in 3GPP TS 48.008, section 3.2.2.103, coding of the Speech Codec Element for the CSData Codec Type differs from coding for the actual speech codecs like FR/HR/AMR/etc. However, osmo-bsc currently encodes the "Speech Codec (Choosen)" IE regardless of the channel mode, be it GSM0808_CHAN_SPEECH or GSM0808_CHAN_DATA. This causes failures at the establishment stage of modem-to-modem data calls. Change-Id: I8b94c0292964f6d5f5ffa98ad8da03728f8bf6a0 Related: OS#6110, OS#4393 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 55 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/33912/1 diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index 037c256..fbc2b1d 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -200,21 +200,26 @@ return; } + if (gscon_is_aoip(conn) && bsc_chan_ind_requires_rtp_stream(conn->assignment.ch_indctr)) { + if (!osmo_mgcpc_ep_ci_get_crcx_info_to_sockaddr(conn->user_plane.mgw_endpoint_ci_msc, + &addr_local)) { + assignment_fail(GSM0808_CAUSE_EQUIPMENT_FAILURE, + "Unable to compose RTP address of MGW -> MSC"); + return; + } + addr_local_p = &addr_local; + } + /* Generate rtp related fields */ - if (bsc_chan_ind_requires_rtp_stream(conn->assignment.ch_indctr)) { + switch (conn->assignment.ch_indctr) { + case GSM0808_CHAN_SPEECH: perm_spch = gsm0808_permitted_speech(lchan->type, lchan->current_ch_mode_rate.chan_mode); - if (gscon_is_aoip(conn)) { - if (!osmo_mgcpc_ep_ci_get_crcx_info_to_sockaddr(conn->user_plane.mgw_endpoint_ci_msc, - &addr_local)) { - assignment_fail(GSM0808_CAUSE_EQUIPMENT_FAILURE, - "Unable to compose RTP address of MGW -> MSC"); - return; - } - addr_local_p = &addr_local; - } + /* below is AoIP specific logic */ + if (!gscon_is_aoip(conn)) + break; - if (gscon_is_aoip(conn) && conn->assignment.req.use_osmux) { + if (conn->assignment.req.use_osmux) { if (!osmo_mgcpc_ep_ci_get_crcx_info_to_osmux_cid(conn->user_plane.mgw_endpoint_ci_msc, &osmux_cid)) { assignment_fail(GSM0808_CAUSE_EQUIPMENT_FAILURE, @@ -223,14 +228,28 @@ } } - /* Only AoIP networks include a speech codec (chosen) in the - * assignment complete message. */ - if (gscon_is_aoip(conn)) { - /* Extrapolate speech codec from speech mode */ - gsm0808_speech_codec_from_chan_type(&sc, perm_spch); - sc.cfg = conn->lchan->current_ch_mode_rate.s15_s0; - sc_ptr = &sc; - } + /* Extrapolate speech codec from speech mode */ + gsm0808_speech_codec_from_chan_type(&sc, perm_spch); + sc.cfg = conn->lchan->current_ch_mode_rate.s15_s0; + sc_ptr = &sc; + break; + case GSM0808_CHAN_DATA: + /* below is AoIP specific logic */ + if (!gscon_is_aoip(conn)) + break; + + /* The coding of Speech Codec Element for the CSData Codec Type + * is defined in 3GPP TS 48.008 section 3.2.2.103 */ + sc = (struct gsm0808_speech_codec) { + .pi = true, /* PI indicates CSDoIP is supported */ + .pt = true, /* PT indicates CSDoTDM is supported */ + .type = GSM0808_SCT_CSD, + .cfg = 0, /* R2/R3 not set (redundancy not supported) */ + }; + sc_ptr = &sc; + break; + default: + break; } resp = gsm0808_create_ass_compl2(lchan->abis_ip.ass_compl.rr_cause, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8b94c0292964f6d5f5ffa98ad8da03728f8bf6a0 Gerrit-Change-Number: 33912 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0