July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-hlr[master]: USSD: fix handling of ussd-DataCodingScheme != 0x0f
by fixeria 04 Jul '23

04 Jul '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33528 ) Change subject: USSD: fix handling of ussd-DataCodingScheme != 0x0f ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib7bac660b1a7942adcfbe7b14f162c95061a25db Gerrit-Change-Number: 33528 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 04 Jul 2023 18:47:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: ipa: fix a typo in ipa_ccm_rcvmsg_base(): PING -> PONG
by fixeria 04 Jul '23

04 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33568 ) Change subject: ipa: fix a typo in ipa_ccm_rcvmsg_base(): PING -> PONG ...................................................................... ipa: fix a typo in ipa_ccm_rcvmsg_base(): PING -> PONG Change-Id: I83e7326758e533a008eec28641dae619216ea84a --- M src/gsm/ipa.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/68/33568/1 diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c index 93e34df..4092614 100644 --- a/src/gsm/ipa.c +++ b/src/gsm/ipa.c @@ -479,7 +479,7 @@ case IPAC_MSGT_PING: ret = ipa_ccm_send_pong(bfd->fd); if (ret < 0) { - LOGP(DLINP, LOGL_ERROR, "Cannot send PING " + LOGP(DLINP, LOGL_ERROR, "Cannot send PONG " "message. Reason: %s\n", strerror(errno)); break; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I83e7326758e533a008eec28641dae619216ea84a Gerrit-Change-Number: 33568 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hlr[master]: gsup_server: fix msgb memleak in osmo_gsup_server_read_cb()
by fixeria 04 Jul '23

04 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33567 ) Change subject: gsup_server: fix msgb memleak in osmo_gsup_server_read_cb() ...................................................................... gsup_server: fix msgb memleak in osmo_gsup_server_read_cb() I noticed that inability to send IPA PONG in response to IPA PING from osmo-{msc,sgsn} results in an "IPA Multiplex" chunk being leaked. No matter what's returned from ipa_server_conn_ccm(), we need to free the msgb containing the incoming IPA message. Change-Id: I5c5acbffc2913f78db4894ae3633b5eca9c2e8d6 --- M src/gsup_server.c 1 file changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/67/33567/1 diff --git a/src/gsup_server.c b/src/gsup_server.c index 097a854..91110eb 100644 --- a/src/gsup_server.c +++ b/src/gsup_server.c @@ -179,11 +179,9 @@ if (hh->proto == IPAC_PROTO_IPACCESS) { rc = ipa_server_conn_ccm(conn, msg); - if (rc < 0) { - /* conn is already invalid here! */ - return -1; - } msgb_free(msg); + if (rc < 0) /* conn is already invalid here! */ + return -1; return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33567 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I5c5acbffc2913f78db4894ae3633b5eca9c2e8d6 Gerrit-Change-Number: 33567 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: gmm: Accept event LOW_LVL_FAIL in RAU/SR_INITIATED states
by pespin 04 Jul '23

04 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33566 ) Change subject: gmm: Accept event LOW_LVL_FAIL in RAU/SR_INITIATED states ...................................................................... gmm: Accept event LOW_LVL_FAIL in RAU/SR_INITIATED states This even is triggered by the GSM itself due to internal timeouts as a consequence of lower layers not resolving the request (with accept or reject events). Change-Id: Ic1072629595e75c411b421e71f6ffac5dd41da3b --- M src/gmm/gmm_ms_fsm.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/66/33566/1 diff --git a/src/gmm/gmm_ms_fsm.c b/src/gmm/gmm_ms_fsm.c index 770ede7..f219bbe 100644 --- a/src/gmm/gmm_ms_fsm.c +++ b/src/gmm/gmm_ms_fsm.c @@ -243,6 +243,9 @@ enum gsm48_gmm_cause cause; switch (event) { + case GPRS_GMM_MS_EV_LOW_LVL_FAIL: + gmm_ms_fsm_state_chg(fi, GPRS_GMM_MS_ST_REGISTERED); + break; case GPRS_GMM_MS_EV_RAU_REJECTED: cause = *(uint8_t *)data; /* 3GPP TS 24.008 Figure 4.1b */ @@ -273,6 +276,9 @@ static void st_gmm_ms_sr_initiated(struct osmo_fsm_inst *fi, uint32_t event, void *data) { switch (event) { + case GPRS_GMM_MS_EV_LOW_LVL_FAIL: + gmm_ms_fsm_state_chg(fi, GPRS_GMM_MS_ST_REGISTERED); + break; case GPRS_GMM_MS_EV_SR_REJECTED: gmm_ms_fsm_state_chg(fi, GPRS_GMM_MS_ST_REGISTERED); break; @@ -357,6 +363,7 @@ }, [GPRS_GMM_MS_ST_RAU_INITIATED] = { .in_event_mask = + X(GPRS_GMM_MS_EV_LOW_LVL_FAIL) | X(GPRS_GMM_MS_EV_RAU_REJECTED) | X(GPRS_GMM_MS_EV_RAU_ACCEPTED), .out_state_mask = @@ -367,6 +374,7 @@ }, [GPRS_GMM_MS_ST_SR_INITIATED] = { .in_event_mask = + X(GPRS_GMM_MS_EV_LOW_LVL_FAIL) | X(GPRS_GMM_MS_EV_SR_REJECTED) | X(GPRS_GMM_MS_EV_SR_ACCEPTED), .out_state_mask = -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic1072629595e75c411b421e71f6ffac5dd41da3b Gerrit-Change-Number: 33566 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hlr[master]: lu_fsm: fix memleak in lu_fsm_wait_insert_data_result()
by fixeria 04 Jul '23

04 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33564 ) Change subject: lu_fsm: fix memleak in lu_fsm_wait_insert_data_result() ...................................................................... lu_fsm: fix memleak in lu_fsm_wait_insert_data_result() Currently osmo-hlr leaks memory (msgb holding 1203 bytes of data and a struct osmo_gsup_req) on receipt of OSMO_GSUP_MSGT_INSERT_DATA_ERROR. Change-Id: I4c70a06169158c869360707a7a62436dbf13b9b3 --- M src/lu_fsm.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/64/33564/1 diff --git a/src/lu_fsm.c b/src/lu_fsm.c index e6ed31a..8599f59 100644 --- a/src/lu_fsm.c +++ b/src/lu_fsm.c @@ -275,6 +275,7 @@ case OSMO_GSUP_MSGT_INSERT_DATA_ERROR: lu_failure(lu, GMM_CAUSE_NET_FAIL, "Rx %s", osmo_gsup_message_type_name(req->gsup.message_type)); + osmo_gsup_req_free(req); break; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4c70a06169158c869360707a7a62436dbf13b9b3 Gerrit-Change-Number: 33564 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hlr[master]: ussd: fix GSUP memleaks in rx_proc_ss_{req,error}()
by fixeria 04 Jul '23

04 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33565 ) Change subject: ussd: fix GSUP memleaks in rx_proc_ss_{req,error}() ...................................................................... ussd: fix GSUP memleaks in rx_proc_ss_{req,error}() Also take a chance to use a more suitable error cause value. Change-Id: I22ba5ad470989b7e8ba8fe2be170eac4adcb48c5 --- M src/hlr_ussd.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/65/33565/1 diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c index 35b74b6..8d5237f 100644 --- a/src/hlr_ussd.c +++ b/src/hlr_ussd.c @@ -631,7 +631,8 @@ if (!ss) { LOGP(DSS, LOGL_ERROR, "%s/0x%08x: CONTINUE for unknown SS session\n", gsup->imsi, gsup->session_id); - osmo_gsup_req_respond_err(gsup_req, GMM_CAUSE_INV_MAND_INFO, "CONTINUE for unknown SS session"); + osmo_gsup_req_respond_err(gsup_req, GMM_CAUSE_MSGT_INCOMP_P_STATE, + "CONTINUE for unknown SS session"); return; } @@ -652,6 +653,8 @@ if (!ss) { LOGP(DSS, LOGL_ERROR, "%s/0x%08x: END for unknown SS session\n", gsup->imsi, gsup->session_id); + osmo_gsup_req_respond_err(gsup_req, GMM_CAUSE_MSGT_INCOMP_P_STATE, + "END for unknown SS session"); return; } @@ -682,4 +685,5 @@ { LOGP(DSS, LOGL_NOTICE, "%s/0x%08x: Process SS ERROR (%s)\n", req->gsup.imsi, req->gsup.session_id, osmo_gsup_session_state_name(req->gsup.session_state)); + osmo_gsup_req_free(req); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I22ba5ad470989b7e8ba8fe2be170eac4adcb48c5 Gerrit-Change-Number: 33565 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[XL] Change in osmo-msc[master]: ASCI: Add call control for VGCS/VBS
by dexter 04 Jul '23

04 Jul '23

Attention is currently required from: jolly. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33511 ) Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... Patch Set 10: (5 comments) Patchset: PS10: I had a quick look. I only have a few cosmetic hints yet. File include/osmocom/msc/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/8fd36414_f95c638e PS10, Line 28: vgcs_fsm.h \ maybe rename this to "msc_vgcs" (not critical, but i see all the msc_ prefixes and msc_ho.h presumably has the FSM for handover) File include/osmocom/msc/vgcs_fsm.h: https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/69715b20_3dfd73fe PS10, Line 210: void _gsm44068_bcc_gcc_trans_free(struct gsm_trans *trans); why does this function begin with an underscore? To me this looks like a function that is not really public but needs to be called by a unittest, but I see you use this function in transaction.c File src/libmsc/vgcs_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/141f40c0_335bdc3d PS10, Line 559: { VGCS_GCC_EV_TIMEOUT, "Timeout due to inactiviy" }, It probably makes more sense to stringify the constant names using OSMO_VALUE_STRING(). The reason for this is that it is then easier to grep for an event name in the code when it appears in the log. Just look at the other FSMs (e.g. handover_fsm.c from osmo-bsc) https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/66797acd_66cb0865 PS10, Line 951: #define connect_option false maybe use capital letters, so that it is immediately clear, that this is a define constant? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 10 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 04 Jul 2023 15:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: new bb, no fn delay
by Hoernchen 04 Jul '23

04 Jul '23

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/33560 ) Change subject: ms: new bb, no fn delay ...................................................................... ms: new bb, no fn delay Change-Id: I506e9f841646373abdd17278ee8b48a01dc3725f --- M Transceiver52M/ms/ms_upper.cpp 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/60/33560/1 diff --git a/Transceiver52M/ms/ms_upper.cpp b/Transceiver52M/ms/ms_upper.cpp index 63f5926..5b4ce95 100644 --- a/Transceiver52M/ms/ms_upper.cpp +++ b/Transceiver52M/ms/ms_upper.cpp @@ -466,7 +466,7 @@ trxcon::msgb_talloc_ctx_init(tall_trxcon_ctx, 0); trxc_log_init(tall_trxcon_ctx); - trxcon::g_trxcon = trxcon::trxcon_inst_alloc(tall_trxcon_ctx, 0, 0); + trxcon::g_trxcon = trxcon::trxcon_inst_alloc(tall_trxcon_ctx, 0); trxcon::g_trxcon->gsmtap = nullptr; trxcon::g_trxcon->phyif = nullptr; trxcon::g_trxcon->phy_quirks.fbsb_extend_fns = 866; // 4 seconds, known to work. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I506e9f841646373abdd17278ee8b48a01dc3725f Gerrit-Change-Number: 33560 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: ms: new bb split
by Hoernchen 04 Jul '23

04 Jul '23

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/33559 ) Change subject: ms: new bb split ...................................................................... ms: new bb split Change-Id: If3a47105e777a86a311646b4f30cb756e046dc56 --- M Transceiver52M/Makefile.am 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/59/33559/1 diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am index 875e9a1..fbd9849 100644 --- a/Transceiver52M/Makefile.am +++ b/Transceiver52M/Makefile.am @@ -80,6 +80,7 @@ TRXCON_LDADD = \ $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libtrxcon.a \ $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1sched.a \ + $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1gprs.a \ $(LIBOSMOCODING_LIBS) MS_SOURCES = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If3a47105e777a86a311646b4f30cb756e046dc56 Gerrit-Change-Number: 33559 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: ms: fix qg log
by Hoernchen 04 Jul '23

04 Jul '23

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/33558 ) Change subject: ms: fix qg log ...................................................................... ms: fix qg log Change-Id: I0f5dcb13d1bd9e626e1eeab6ca767ca1b5ae43b8 --- M Transceiver52M/ms/logging.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/58/33558/1 diff --git a/Transceiver52M/ms/logging.c b/Transceiver52M/ms/logging.c index 9ee0738..ee59299 100644 --- a/Transceiver52M/ms/logging.c +++ b/Transceiver52M/ms/logging.c @@ -76,6 +76,7 @@ void trxc_log_init(void *tallctx) { osmo_init_logging2(tallctx, &trxcon_log_info); + log_target_file_switch_to_wqueue(osmo_stderr_target); trxcon_set_log_cfg(&trxcon_log_cfg[0], ARRAY_SIZE(trxcon_log_cfg)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/33558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0f5dcb13d1bd9e626e1eeab6ca767ca1b5ae43b8 Gerrit-Change-Number: 33558 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0