July 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-trx[master]: ms: remove syncthing tool
by Hoernchen 06 Jul '23

06 Jul '23

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32952 ) Change subject: ms: remove syncthing tool ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie97069a109324b6e96c66a4b24d03f9745b6a52e Gerrit-Change-Number: 32952 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jul 2023 16:17:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: fix the gain init for blade
by pespin 06 Jul '23

06 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32942 ) Change subject: ms: fix the gain init for blade ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > It's just the channel arg, the 30 is the same number as before. Ah indeed, thanks I didn't understand it. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic5a25d6f5606fba599b8144fbec7285047dca3c9 Gerrit-Change-Number: 32942 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jul 2023 16:09:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-trx[master]: ms: prettify scheduling + add odroid
by Hoernchen 06 Jul '23

06 Jul '23

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32943 ) Change subject: ms: prettify scheduling + add odroid ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why not simply provide specific config files for specific platforms and keep the code generic? There are currently 2 supoorted targets: odroid and rpi, nothing else, and dynamic config stuff for random other untested devices that no one is using are part of a future patchset. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icaf42fd5f76dc2d53dc526558aa8ceaa9c190f7b Gerrit-Change-Number: 32943 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jul 2023 16:08:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: fix the gain init for blade
by Hoernchen 06 Jul '23

06 Jul '23

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32942 ) Change subject: ms: fix the gain init for blade ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Can you explain where thoes 30 and 0 dB figures come from? It's just the channel arg, the 30 is the same number as before. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ic5a25d6f5606fba599b8144fbec7285047dca3c9 Gerrit-Change-Number: 32942 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jul 2023 16:07:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms : fix the template formatting
by Hoernchen 06 Jul '23

06 Jul '23

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32941 ) Change subject: ms : fix the template formatting ...................................................................... ms : fix the template formatting Those lines predate the .clang-format changes. Change-Id: I891bdf95004accebbbe54916e4472bd381fac545 --- M Transceiver52M/ms/bladerf_specific.h M Transceiver52M/ms/ms.cpp M Transceiver52M/ms/uhd_specific.h 3 files changed, 35 insertions(+), 13 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/ms/bladerf_specific.h b/Transceiver52M/ms/bladerf_specific.h index d5088a7..e1e8cc6 100644 --- a/Transceiver52M/ms/bladerf_specific.h +++ b/Transceiver52M/ms/bladerf_specific.h @@ -39,14 +39,16 @@ const int SAMPLE_SCALE_FACTOR = 15; // actually 16 but sigproc complains about clipping.. // see https://en.cppreference.com/w/cpp/language/parameter_pack "Brace-enclosed initializers" example -template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) +template <typename Arg, typename... Args> +void expand_args(std::ostream &out, Arg &&arg, Args &&...args) { out << '(' << std::forward<Arg>(arg); (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; out << ')' << std::endl; } -template <class R, class... Args> using RvalFunc = R (*)(Args...); +template <class R, class... Args> +using RvalFunc = R (*)(Args...); template <class R, class... Args> R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, @@ -67,7 +69,8 @@ #pragma pack(push, 1) using blade_sample_type = std::complex<int16_t>; enum class blade_speed_buffer_type { HS, SS }; -template <blade_speed_buffer_type T> struct blade_usb_message { +template <blade_speed_buffer_type T> +struct blade_usb_message { uint32_t reserved; uint64_t ts; uint32_t meta_flags; @@ -76,7 +79,8 @@ static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); -template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { +template <unsigned int SZ, blade_speed_buffer_type T> +struct blade_otw_buffer { static_assert((SZ >= 2 && !(SZ % 2)), "min size is 2x usb buffer!"); blade_usb_message<T> m[SZ]; int actual_samples_per_msg() @@ -172,7 +176,8 @@ }; #pragma pack(pop) -template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { +template <unsigned int SZ, blade_speed_buffer_type T> +struct blade_otw_buffer_helper { static_assert((SZ >= 1024 && ((SZ & (SZ - 1)) == 0)), "only buffer size multiples of 1024 allowed!"); static blade_otw_buffer<SZ / 512, T> x; }; @@ -181,7 +186,8 @@ // using buf_in_use = blade_otw_buffer<2, blade_speed_buffer_type::SS>; using bh_fn_t = std::function<int(dev_buf_t *)>; -template <typename T> struct blade_hw { +template <typename T> +struct blade_hw { struct bladerf *dev; struct bladerf_stream *rx_stream; struct bladerf_stream *tx_stream; diff --git a/Transceiver52M/ms/ms.cpp b/Transceiver52M/ms/ms.cpp index ec2c5f8..d191ed5 100644 --- a/Transceiver52M/ms/ms.cpp +++ b/Transceiver52M/ms/ms.cpp @@ -49,7 +49,8 @@ static int offset_ctr = 0; #endif -template <> std::atomic<bool> ms_trx::base::stop_me_flag(false); +template <> +std::atomic<bool> ms_trx::base::stop_me_flag(false); void tx_test(ms_trx *t, ts_hitter_q_t *q, unsigned int *tsc) { @@ -137,7 +138,8 @@ } } #ifdef SYNCTHINGONLY -template <typename A> auto parsec(std::vector<std::string> &v, A &itr, std::string arg, bool *rv) +template <typename A> +auto parsec(std::vector<std::string> &v, A &itr, std::string arg, bool *rv) { if (*itr == arg) { *rv = true; @@ -158,15 +160,17 @@ } return false; } -template <typename A> bool parsec(std::vector<std::string> &v, A &itr, std::string arg, int scale, int *rv) +template <typename A> +bool parsec(std::vector<std::string> &v, A &itr, std::string arg, int scale, int *rv) { return parsec( - v, itr, arg, [scale](const char *v) -> auto{ return atoi(v) * scale; }, rv); + v, itr, arg, [scale](const char *v) -> auto { return atoi(v) * scale; }, rv); } -template <typename A> bool parsec(std::vector<std::string> &v, A &itr, std::string arg, int scale, unsigned int *rv) +template <typename A> +bool parsec(std::vector<std::string> &v, A &itr, std::string arg, int scale, unsigned int *rv) { return parsec( - v, itr, arg, [scale](const char *v) -> auto{ return atoi(v) * scale; }, rv); + v, itr, arg, [scale](const char *v) -> auto { return atoi(v) * scale; }, rv); } int main(int argc, char *argv[]) diff --git a/Transceiver52M/ms/uhd_specific.h b/Transceiver52M/ms/uhd_specific.h index 8295a54..726bb95 100644 --- a/Transceiver52M/ms/uhd_specific.h +++ b/Transceiver52M/ms/uhd_specific.h @@ -65,7 +65,8 @@ using dev_buf_t = uhd_buf_wrap; using bh_fn_t = std::function<int(dev_buf_t *)>; -template <typename T> struct uhd_hw { +template <typename T> +struct uhd_hw { uhd::usrp::multi_usrp::sptr dev; uhd::rx_streamer::sptr rx_stream; uhd::tx_streamer::sptr tx_stream; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I891bdf95004accebbbe54916e4472bd381fac545 Gerrit-Change-Number: 32941 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: xua_default_lm_fsm.c: Log rx ASP_UP timeout with NOTICE level
by pespin 06 Jul '23

06 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33621 ) Change subject: xua_default_lm_fsm.c: Log rx ASP_UP timeout with NOTICE level ...................................................................... xua_default_lm_fsm.c: Log rx ASP_UP timeout with NOTICE level Some user run into this scenario recently and it was difficult to find out why the SCTP links were being restarted. Add a new log line with NOTICE level explicitly stating the reason to restart the ASP. Related: SYS#6511 Change-Id: I5a388d2d96bcf1cbb76981c476abf37dbe213df0 --- M src/xua_default_lm_fsm.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/21/33621/1 diff --git a/src/xua_default_lm_fsm.c b/src/xua_default_lm_fsm.c index e5cceea..15958f2 100644 --- a/src/xua_default_lm_fsm.c +++ b/src/xua_default_lm_fsm.c @@ -167,6 +167,7 @@ case T_WAIT_ASP_UP: /* we have been waiting for the ASP to come up, but it * failed to do so */ + LOGPFSML(fi, LOGL_NOTICE, "Peer didn't send any ASP_UP in time! restarting ASP\n"); restart_asp(fi); break; case T_WAIT_NOTIFY: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33621 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5a388d2d96bcf1cbb76981c476abf37dbe213df0 Gerrit-Change-Number: 33621 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in gapk[master]: aarch64: add get_cycles
by Hoernchen 06 Jul '23

06 Jul '23

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/33620 ) Change subject: aarch64: add get_cycles ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/33620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I489fb8346fbc7440f40695f01d80a89b90761165 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jul 2023 15:45:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: aarch64: add get_cycles
by Jenkins Builder 06 Jul '23

06 Jul '23

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/33620 ) Change subject: aarch64: add get_cycles ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gapk/get_cycles.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9076): https://gerrit.osmocom.org/c/gapk/+/33620/comment/882cd3e5_20be735b PS2, Line 108: typedef unsigned long cycles_t; do not add new typedefs -- To view, visit https://gerrit.osmocom.org/c/gapk/+/33620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I489fb8346fbc7440f40695f01d80a89b90761165 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jul 2023 15:20:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: aarch64: add get_cycles
by Hoernchen 06 Jul '23

06 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/gapk/+/33620 to look at the new patch set (#2). Change subject: aarch64: add get_cycles ...................................................................... aarch64: add get_cycles borrowed from arch/arm64/include/asm/arch_timer.h Change-Id: I489fb8346fbc7440f40695f01d80a89b90761165 --- M include/osmocom/gapk/get_cycles.h 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/20/33620/2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/33620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I489fb8346fbc7440f40695f01d80a89b90761165 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: ASCI: Forward lchan activation states to VGCS FSM
by jolly 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33614 to look at the new patch set (#3). Change subject: ASCI: Forward lchan activation states to VGCS FSM ...................................................................... ASCI: Forward lchan activation states to VGCS FSM Change-Id: I757b562e02480c1a68446d91217910069f17d060 Related: OS#4852 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 67 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/14/33614/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I757b562e02480c1a68446d91217910069f17d060 Gerrit-Change-Number: 33614 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0