July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: csd_bs_list_to_gsm0808_channel_type: add T 300
by fixeria 07 Jul '23

07 Jul '23

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33591 ) Change subject: csd_bs_list_to_gsm0808_channel_type: add T 300 ...................................................................... Patch Set 1: (2 comments) File src/libmsc/csd_bs.c: https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/17ff4f9d_c65d3e35 PS1, Line 187: GSM0808_DATA_HALF_LM See my comment below, I think either TCH/H2.4 or TCH/F2.4 would work here, so ` GSM0808_DATA_FULL_PREF`? https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/dd739661_6ed5c48c PS1, Line 196: GSM0808_DATA_FULL_BM Rates below 9600 can be carried over half-rate channels too, since we have TCH/H4.8 and TCH/H2.4. Maybe use `GSM0808_DATA_FULL_PREF` here and above? Not 100% sure though, adding Laf0rge as a reviewer. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0 Gerrit-Change-Number: 33591 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 07 Jul 2023 10:57:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: mncc_test: fix talloc_named_const
by osmith 07 Jul '23

07 Jul '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33589 ) Change subject: mncc_test: fix talloc_named_const ...................................................................... mncc_test: fix talloc_named_const Change-Id: I0f0a5497eb37b9f9b9102e01cee8c1bda85c5dfe --- M tests/mncc/mncc_test.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/tests/mncc/mncc_test.c b/tests/mncc/mncc_test.c index f752cab..9532846 100644 --- a/tests/mncc/mncc_test.c +++ b/tests/mncc/mncc_test.c @@ -67,7 +67,7 @@ int main(void) { - void *ctx = talloc_named_const(NULL, 0, "smpp_test"); + void *ctx = talloc_named_const(NULL, 0, "mncc_test"); osmo_init_logging2(ctx, &log_info); log_set_use_color(osmo_stderr_target, 0); log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0f0a5497eb37b9f9b9102e01cee8c1bda85c5dfe Gerrit-Change-Number: 33589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: TC_lu_and_mt_csd: reduce call open time
by osmith 07 Jul '23

07 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33631 ) Change subject: TC_lu_and_mt_csd: reduce call open time ...................................................................... TC_lu_and_mt_csd: reduce call open time Related: OS#4394 Change-Id: Ie733028f7953d5d9fa1907efdb19485dee93ece9 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/33631/1 diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index b3b3373..8b390ea 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1835,12 +1835,12 @@ deactivate(dlcx); } -function f_mt_call(inout CallParameters cpars) +function f_mt_call(inout CallParameters cpars, float open_time := 5.0) runs on BSC_ConnHdlr { f_mt_call_establish(cpars); - f_call_keep_open(cpars); + f_call_keep_open(cpars, open_time); log("Hangup"); f_call_hangup(cpars, true); diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 4c14070..09e2885 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -7223,7 +7223,7 @@ cpars.mncc_bearer_cap.data.user_rate := user_rate; f_perform_lu(); - f_mt_call(cpars); + f_mt_call(cpars, 0.5); } friend function f_tc_lu_and_mt_csd(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { f_init_handler(pars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie733028f7953d5d9fa1907efdb19485dee93ece9 Gerrit-Change-Number: 33631 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/RAN_Emulation: testcase.stop -> mtc.stop
by osmith 07 Jul '23

07 Jul '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 ) Change subject: library/RAN_Emulation: testcase.stop -> mtc.stop ...................................................................... library/RAN_Emulation: testcase.stop -> mtc.stop Stop the MTC (main test component) on error, otherwise some tests don't stop here and keep going forever. MSC_Test_0-RAN(106)@7e006c664067: Unable to find to-be-destroyed IMSI in ImsiTable MSC_Test_0-RAN(106)@7e006c664067: Dynamic test case error: testcase.stop MSC_Test_0-RAN(106)@7e006c664067: setverdict(error): none -> error MSC_Test_0-RAN(106)@7e006c664067: Final verdict of PTC: error MSC_Test-GSUP-IPA(110)@7e006c664067: CCM Rx:{ msg_type := IPAC_MSGT_PING (0), u := omit } MSC_Test-GSUP-IPA(110)@7e006c664067: CCM Tx:{ msg_type := IPAC_MSGT_PONG (1), u := omit } MSC_Test-GSUP-IPA(110)@7e006c664067: CCM Rx:{ msg_type := IPAC_MSGT_PING (0), u := omit } MSC_Test-GSUP-IPA(110)@7e006c664067: CCM Tx:{ msg_type := IPAC_MSGT_PONG (1), u := omit } … Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab --- M library/RAN_Emulation.ttcnpp 1 file changed, 30 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/33630/1 diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index 6a1f784..2fba50a 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -406,7 +406,8 @@ return; } } - testcase.stop("RAN Connection table full!"); + setverdict(fail, "RAN Connection table full!"); + mtc.stop; } private function f_conn_table_del(integer sccp_conn_id) @@ -1449,7 +1450,8 @@ return; } } - testcase.stop("No space left in ExpectTable"); + setverdict(fail, "No space left in ExpectTable"); + mtc.stop; } private function f_create_imsi(hexstring imsi, OCT4 tmsi, RAN_ConnHdlr hdlr) @@ -1463,7 +1465,8 @@ return; } } - testcase.stop("No space left in ImsiTable"); + setverdict(fail, "No space left in ImsiTable"); + mtc.stop; } private function f_destroy_imsi(hexstring imsi, RAN_ConnHdlr hdlr) @@ -1477,7 +1480,8 @@ return; } } - testcase.stop("Unable to find to-be-destroyed IMSI in ImsiTable"); + setverdict(fail, "Unable to find to-be-destroyed IMSI in ImsiTable"); + mtc.stop; } private function f_expect_table_init() -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab Gerrit-Change-Number: 33630 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_setup: use MNCC bcaps for CSD
by fixeria 07 Jul '23

07 Jul '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33590 ) Change subject: gsm48_cc_tx_setup: use MNCC bcaps for CSD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I56e49ebc41696912a81b8f4f63fbc36d0b605e9e Gerrit-Change-Number: 33590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 10:38:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: mncc_test: fix talloc_named_const
by fixeria 07 Jul '23

07 Jul '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33589 ) Change subject: mncc_test: fix talloc_named_const ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0f0a5497eb37b9f9b9102e01cee8c1bda85c5dfe Gerrit-Change-Number: 33589 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 10:35:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: flexible template for value_type buffer sum
by Hoernchen 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/32955 to look at the new patch set (#4). Change subject: ms: flexible template for value_type buffer sum ...................................................................... ms: flexible template for value_type buffer sum Manual attempts to get the number of complex and single samples right turned out to be a bit error prone at times... Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82 --- M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_rx_lower.cpp 2 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/55/32955/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82 Gerrit-Change-Number: 32955 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in docker-playground[master]: MME_Tests: add docker tests for MME
by fixeria 07 Jul '23

07 Jul '23

Attention is currently required from: laforge, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33571 ) Change subject: MME_Tests: add docker tests for MME ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic1ce1dace47353b0dcf321c923a78567e3ddefb9 Gerrit-Change-Number: 33571 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 10:03:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: ASCI: rtp_stream_commit(): Also update MGW on conn mode change
by jolly 07 Jul '23

07 Jul '23

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33499 ) Change subject: ASCI: rtp_stream_commit(): Also update MGW on conn mode change ...................................................................... Patch Set 8: (1 comment) File src/libmsc/rtp_stream.c: https://gerrit.osmocom.org/c/osmo-msc/+/33499/comment/e8a22240_57dfd1d9 PS7, Line 440: if (rtps->crcx_conn_mode != mode) > This really needs to be moved to the top of the function, and early return in order to trigger all t […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33499 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7a5637d0a7f1df13133e522fc78ba75eeeb2873e Gerrit-Change-Number: 33499 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 08:22:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: validate RSL "channel rate and type" against VGCS/VBS flags
by jolly 07 Jul '23

07 Jul '23

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33290 ) Change subject: validate RSL "channel rate and type" against VGCS/VBS flags ...................................................................... Patch Set 2: (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/33290/comment/0ac1988d_346d314c PS2, Line 782: int bts_supports_cm(const struct gsm_bts *bts, > iiuc this function actually returns a bool? do you mind submitting an extra patch returning bool and […] Not actually related to this project, but an easy one. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5e7f65b44cef6e2f7ad4f152f80a1686a4f511e3 Gerrit-Change-Number: 33290 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 07 Jul 2023 08:22:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0