Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33591 ) Change subject: csd_bs_list_to_gsm0808_channel_type: add T 300 ...................................................................... Patch Set 1: (2 comments) File src/libmsc/csd_bs.c: https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/17ff4f9d_c65d3e35 PS1, Line 187: GSM0808_DATA_HALF_LM See my comment below, I think either TCH/H2.4 or TCH/F2.4 would work here, so ` GSM0808_DATA_FULL_PREF`? https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/dd739661_6ed5c48c PS1, Line 196: GSM0808_DATA_FULL_BM Rates below 9600 can be carried over half-rate channels too, since we have TCH/H4.8 and TCH/H2.4. Maybe use `GSM0808_DATA_FULL_PREF` here and above? Not 100% sure though, adding Laf0rge as a reviewer. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0 Gerrit-Change-Number: 33591 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Fri, 07 Jul 2023 10:57:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment