Attention is currently required from: osmith, laforge.

View Change

2 comments:

• File src/libmsc/csd_bs.c:

  • Patch Set #1, Line 187: GSM0808_DATA_HALF_LM

    See my comment below, I think either TCH/H2.4 or TCH/F2.4 would work here, so ` GSM0808_DATA_FULL_PREF`?

  • Patch Set #1, Line 196: GSM0808_DATA_FULL_BM

    Rates below 9600 can be carried over half-rate channels too, since we have TCH/H4.8 and TCH/H2.4. Maybe use `GSM0808_DATA_FULL_PREF` here and above? Not 100% sure though, adding Laf0rge as a reviewer.

To view, visit change 33591. To unsubscribe, or for help writing mail filters, visit settings.