July 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: ASCI: Add decoding of VGCS/VBS A-interface messages
by jolly 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33612 to look at the new patch set (#3). Change subject: ASCI: Add decoding of VGCS/VBS A-interface messages ...................................................................... ASCI: Add decoding of VGCS/VBS A-interface messages Change-Id: I77b4d072d76039b1889ae4bba4a602e956405eb8 Related: OS#4852 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 125 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/33612/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I77b4d072d76039b1889ae4bba4a602e956405eb8 Gerrit-Change-Number: 33612 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[XL] Change in osmo-bsc[master]: ASCI: Add processing and FSMs for VGCS/VBS
by jolly 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 to look at the new patch set (#3). Change subject: ASCI: Add processing and FSMs for VGCS/VBS ...................................................................... ASCI: Add processing and FSMs for VGCS/VBS Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Related: OS#4852 --- M include/osmocom/bsc/Makefile.am M include/osmocom/bsc/gsm_data.h A include/osmocom/bsc/vgcs_fsm.h M src/osmo-bsc/Makefile.am M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/osmo_bsc_bssap.c A src/osmo-bsc/vgcs_fsm.c 7 files changed, 1,457 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/33611/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in gapk[master]: aarch64: add get_cycles
by Jenkins Builder 06 Jul '23

06 Jul '23

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/33620 ) Change subject: aarch64: add get_cycles ...................................................................... Patch Set 1: (2 comments) File include/osmocom/gapk/get_cycles.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9067): https://gerrit.osmocom.org/c/gapk/+/33620/comment/1bd0fc91_c4f34db5 PS1, Line 108: typedef unsigned long cycles_t; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9067): https://gerrit.osmocom.org/c/gapk/+/33620/comment/879ee11b_c69a72d9 PS1, Line 109: static inline cycles_t get_cycles() Bad function definition - cycles_t get_cycles() should probably be cycles_t get_cycles(void) -- To view, visit https://gerrit.osmocom.org/c/gapk/+/33620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I489fb8346fbc7440f40695f01d80a89b90761165 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jul 2023 15:08:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: aarch64: add get_cycles
by Hoernchen 06 Jul '23

06 Jul '23

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/33620 ) Change subject: aarch64: add get_cycles ...................................................................... aarch64: add get_cycles borrowed from arch/arm64/include/asm/arch_timer.h Change-Id: I489fb8346fbc7440f40695f01d80a89b90761165 --- M include/osmocom/gapk/get_cycles.h 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/20/33620/1 diff --git a/include/osmocom/gapk/get_cycles.h b/include/osmocom/gapk/get_cycles.h index 40ac570..c225e4b 100644 --- a/include/osmocom/gapk/get_cycles.h +++ b/include/osmocom/gapk/get_cycles.h @@ -103,6 +103,16 @@ #endif return ret & ~TICK_PRIV_BIT; } +#elif defined(__aarch64__) + +typedef unsigned long cycles_t; +static inline cycles_t get_cycles() +{ + cycles_t cval; + asm volatile("isb" : : : "memory"); + asm volatile("mrs %0, cntvct_el0" : "=r" (cval)); + return cval; +} #elif defined(__PPC__) #define CPU_FTR_601 0x00000100 typedef unsigned long cycles_t; -- To view, visit https://gerrit.osmocom.org/c/gapk/+/33620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I489fb8346fbc7440f40695f01d80a89b90761165 Gerrit-Change-Number: 33620 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in docker-playground[master]: MME_Tests: add docker tests for MME
by osmith 06 Jul '23

06 Jul '23

Attention is currently required from: laforge, fixeria, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33571 ) Change subject: MME_Tests: add docker tests for MME ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic1ce1dace47353b0dcf321c923a78567e3ddefb9 Gerrit-Change-Number: 33571 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jul 2023 15:03:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ASCI: Forward lchan activation states to VGCS FSM
by Jenkins Builder 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33614 ) Change subject: ASCI: Forward lchan activation states to VGCS FSM ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/lchan_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9059): https://gerrit.osmocom.org/c/osmo-bsc/+/33614/comment/ddea36d5_03cd98b2 PS2, Line 464: info->for_conn->vgcs_chan.new_lchan? spaces required around that '?' (ctx:VxE) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I757b562e02480c1a68446d91217910069f17d060 Gerrit-Change-Number: 33614 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 14:41:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in osmo-bsc[master]: ASCI: Add FSM for VGCS/VBS
by Jenkins Builder 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33611 ) Change subject: ASCI: Add FSM for VGCS/VBS ...................................................................... Patch Set 2: (4 comments) File include/osmocom/bsc/vgcs_fsm.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9058): https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/6ada7a28_7de88b8f PS2, Line 59: /* Channel link failed. (Talker faild.) */ 'faild' may be misspelled - perhaps 'failed'? File src/osmo-bsc/vgcs_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9058): https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/5aaafc56_77d02d48 PS2, Line 373: LOG_CALL(conn, LOGL_DEBUG, "Calling subscriber assiged and now on uplink.\n"); 'assiged' may be misspelled - perhaps 'assigned'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9058): https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/f64aba1b_6cd34c9d PS2, Line 668: no_aoip: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9058): https://gerrit.osmocom.org/c/osmo-bsc/+/33611/comment/cb4735c0_c12579b8 PS2, Line 1155: strcpy(conn->vgcs_chan.msc_rtp_addr, req.msc_rtp_addr); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9e94fb4f27bb438b7093c031344a3400bfa34f1 Gerrit-Change-Number: 33611 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 14:41:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: ASCI: Add decoding of VGCS/VBS A-interface messages
by Jenkins Builder 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33612 ) Change subject: ASCI: Add decoding of VGCS/VBS A-interface messages ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/osmo_bsc_bssap.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-9056): https://gerrit.osmocom.org/c/osmo-bsc/+/33612/comment/0db18e1e_7185d746 PS2, Line 1384: struct msgb *msg, unsigned int length) code indent should use tabs where possible -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I77b4d072d76039b1889ae4bba4a602e956405eb8 Gerrit-Change-Number: 33612 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 06 Jul 2023 14:41:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in docker-playground[master]: MME_Tests: add docker tests for MME
by dexter 06 Jul '23

06 Jul '23

Attention is currently required from: osmith, laforge, fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33571 ) Change subject: MME_Tests: add docker tests for MME ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: (I have also fixed freediameter.conf - the MME requires a slightly different configuration then the SMF) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic1ce1dace47353b0dcf321c923a78567e3ddefb9 Gerrit-Change-Number: 33571 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jul 2023 14:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: Cleanup code style of rate counters in osmo_bsc_msc.c
by jolly 06 Jul '23

06 Jul '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33597 to look at the new patch set (#2). Change subject: Cleanup code style of rate counters in osmo_bsc_msc.c ...................................................................... Cleanup code style of rate counters in osmo_bsc_msc.c Change-Id: I7cfd4f20ebfee0c8df9305372977d6628d6337c5 --- M src/osmo-bsc/osmo_bsc_msc.c 1 file changed, 189 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/33597/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7cfd4f20ebfee0c8df9305372977d6628d6337c5 Gerrit-Change-Number: 33597 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0