Attention is currently required from: Hoernchen, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33329 )
Change subject: layer23: fix handling of logging category mask (-d option)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
IIUC the problem now is that the logging mask from command is not applied until after reading the config file, which means during read config file whatever calls to LOGP won't have the desired mask.
Maybe calling it *before* (like it used to be) and *after* is better.
That being said, I don't really like having 2 ways (cmdline, vty) of configuring stuff, everyhing becomes confusing.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33329
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1b2b7804bf99b71f96e9197f7824cfd20431e8a1
Gerrit-Change-Number: 33329
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Jun 2023 09:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
daniel has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30935 )
Change subject: libosmogsm: Add osmo_io support to ipa
......................................................................
Abandoned
We should use osmo-netif ipa support in the future, so no need for this
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0f955d5a36afe7a08d31b8ba4185260362c2bcca
Gerrit-Change-Number: 30935
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: abandon
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33333 )
Change subject: socket: Ensure fd is not negative in osmo_sock_get_name_buf()
......................................................................
socket: Ensure fd is not negative in osmo_sock_get_name_buf()
Write to str even in case of error because this is already the current
behaviour and it's what osmo_stream_cli_get_sockname() and
osmo_sock_get_name2{,_c}() expect.
Change-Id: I76727993224ef87b475c33360c24966e82e866ec
Fixes: Coverity CID#321044
---
M src/core/socket.c
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/33333/1
diff --git a/src/core/socket.c b/src/core/socket.c
index 1b14794..02e16bc 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -1550,6 +1550,11 @@
char portbuf_l[6], portbuf_r[6];
int rc;
+ if (fd < 0) {
+ osmo_strlcpy(str, "<error-bad-fd>", str_len);
+ return -EBADF;
+ }
+
/* get local */
if ((rc = osmo_sock_get_ip_and_port(fd, hostbuf_l, sizeof(hostbuf_l), portbuf_l, sizeof(portbuf_l), true))) {
osmo_strlcpy(str, "<error-in-getsockname>", str_len);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I76727993224ef87b475c33360c24966e82e866ec
Gerrit-Change-Number: 33333
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newchange
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33332 )
Change subject: stream: Assert that fd is valid in stream_cli_handle_connecting()
......................................................................
stream: Assert that fd is valid in stream_cli_handle_connecting()
This function should never be called if we don't have a valid fd.
Change-Id: If0bed2bae556e0a8233e9e66e82c70a5c677fc3c
Fixes: Coverity CID#321045
---
M src/stream.c
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/32/33332/1
diff --git a/src/stream.c b/src/stream.c
index 2ba4cde..31aa058 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -480,6 +480,7 @@
socklen_t len = sizeof(error);
int fd = osmo_stream_cli_fd(cli);
+ OSMO_ASSERT(fd >= 0);
if (ret < 0) {
osmo_stream_cli_reconnect(cli);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: If0bed2bae556e0a8233e9e66e82c70a5c677fc3c
Gerrit-Change-Number: 33332
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 )
Change subject: tweak lots of logging
......................................................................
Patch Set 7:
(1 comment)
File src/osmo-hnbgw/hnbgw_cn.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/2734f3ed_06f27d8a
PS3, Line 515: LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "using: cs7-%u %s <-> %s %s %s\n",
> multi-line logging is allways a PITA from the point of anyone trying to process log files. […]
I am not using multi line logging here ... ?
(and i am very aware that they must not be used)
I initially had no idea what Pau meant by the comment:
"This would rpboably better with a couple defines _FMT and _ARGS, so that it ends up in same log line and not in an extra one."
In the meantime, it has become clear that Pau means the LOG_CNLINK(LOGL_DEBUG) in line 581, followed by calling hnbgw_cnlink_log_self() which will LOG_CNLINK(LOGL_NOTICE) right after that.
I've explained that there is a minor detail being logged on DEBUG, followed by a very pivotal log line on NOTICE. These log lines are separate on purpose, and they should both be there; by my explicit choice made from reading log output and making sure that all the interesting bits show, while still ensuring a useful log on more quiet log levels. The DEBUG log is part of a family of log lines aimed at "tracing" all the ss7 and sccp instance decisions, it should not clutter the NOTICE log. The NOTICE log is a marker showing at which point in time the cnlink is fully configured for the first time.
I am still not clear what Pau means by "with a couple defines _FMT and _ARGS", I guessed the source file and line info. If yes, my response is that this log line happens only at program startup and happens exactly once per cnlink, so carrying the caller's source file+line info is not important. It is aimed at telling the user the resolved cnlink config; the DEBUG log is aimed at indicating which code path chose that config and why.
I have specifically made these choices on purpose, and it seems there is a misunderstanding in the code review?
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06
Gerrit-Change-Number: 33171
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Jun 2023 02:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171
to look at the new patch set (#7).
Change subject: tweak lots of logging
......................................................................
tweak lots of logging
Make lots of small tweaks in logging around RUA to SCCP context maps, CN
link selection and HNBAP:
- remove duplicate log context (e.g. LOGHNB() already shows the HNB Id)
- bring more sense into logging categories and levels / reduce noise
- add and clarify the details being logged at what points in time
Related: SYS#6412
Change-Id: I41275d8c3e272177976a9302795884666c35cd06
---
M include/osmocom/hnbgw/context_map.h
M src/osmo-hnbgw/context_map.c
M src/osmo-hnbgw/context_map_sccp.c
M src/osmo-hnbgw/hnbgw.c
M src/osmo-hnbgw/hnbgw_cn.c
M src/osmo-hnbgw/hnbgw_hnbap.c
M src/osmo-hnbgw/hnbgw_l3.c
M src/osmo-hnbgw/hnbgw_rua.c
8 files changed, 94 insertions(+), 41 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/71/33171/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06
Gerrit-Change-Number: 33171
Gerrit-PatchSet: 7
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
