Attention is currently required from: laforge, pespin, lynxis lazus.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 )
Change subject: sgsn: Add TC_attach_timeout_after_pdp_act
......................................................................
Patch Set 3:
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/d8d143f6_c557…
PS1, Line 1037: attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B;
> So there are two topics: […]
I've uploaded a patch at https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32648/1 , hope it does what was asked for. I ran all the SGSN tests along with the change as well, nothing that didn't fail already on the current Jenkins build failed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib3e3c021707b707811388616e28d7d7cc22f7b53
Gerrit-Change-Number: 31199
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 07 May 2023 19:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32648 )
Change subject: library: Define 'solSACapability' as '0'
......................................................................
library: Define 'solSACapability' as '0'
"according to a comment in f_gmm_attach() there's an encoder problem if it's omit. This sounds like the ts_GMM_ATTACH_REQ()
should be changed to define solSACapability as '0' insteads of omit. At that point none of the users of ts_GMM_ATTACH_REQ
will need to manually modify it anymore."
(quote: hwelte on Gerrit (https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comments/17ed155d_cc5…
Related: OS#4221
Change-Id: I9eaa39274456e5cc0a1cf025bf956970efc4a51f
---
M library/L3_Templates.ttcn
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/48/32648/1
diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index 610d410..156bdb2 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -2209,7 +2209,7 @@
smCapabilitiesviaGPRSChannels := '0'B,
ucs2Support := '1'B,
ssScreeningIndicator := '01'B,
- solSACapability := omit,
+ solSACapability := '0'B,
revisionLevelIndicatior := omit,
pFCFeatureMode := omit,
extendedGEAbits := omit,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32648
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9eaa39274456e5cc0a1cf025bf956970efc4a51f
Gerrit-Change-Number: 32648
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32644 )
Change subject: sm: Fix APN IE content not transmitted in Act PDP Ctx Req
......................................................................
Patch Set 1:
(1 comment)
File src/sm/sm_pdu.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32644/comment/d65c78bd_87fdc48f
PS1, Line 208: rc = osmo_apn_from_str(msg->tail, msgb_tailroom(msg), sme->apn);
: if (rc < 0)
: return -EINVAL;
: *l = rc;
: msgb_put(msg, *l);
> IMHO this is highly unusual: passing a pointer to msg->tail and storing some data before doing the msgb_put. All the "legacy" code that I recall does the msgb_put() first. It would at that point ASSERT if we ever overrun msgb_tailroom, before anything is memcpying over it.
I would not say it's highly unusual, but rather a common practice in cases when you don't know how much to `msgb_put()` before calling a buffer filling function, e.g. `read()` or `recv()`.
Below are grep results for all my local repositories (39 matches total):
```
$ ./gits do grep "msg->tail, msgb_tailroom" | grep "msgb_tailroom[(]" | wc -l
13
$ ./gits do grep "msg->data, msgb_tailroom" | grep "msgb_tailroom[(]" | wc -l
9
$ ./gits do grep "msgb_data(msg), msgb_tailroom" | grep "msgb_tailroom[(]" | wc -l
17
```
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32644
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I70be2ff5e7e0fea5e93d7b9963064c38a0382f30
Gerrit-Change-Number: 32644
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 May 2023 06:22:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: neels, daniel.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618 )
Change subject: simplify: one g_hnbgw as global state and root ctx
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I3d54a5bb30c16a990c6def2a0ed207f60a95ef5d
Gerrit-Change-Number: 32618
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 May 2023 05:48:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32621 )
Change subject: add non-installed libhnbgw.la for test linkage
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/osmo-hnbgw/Makefile.am:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32621/comment/18a54df0_e2bb92e9
PS2, Line 67: LIBOSMOGTLV_CFLAGS
Just to clarify: `LIBOSMOGTLV_{CFLAGS,LIBS}` will be added automatically by libtool because libosmo-gtlv is a dependency of libosmo-pfcp.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32621
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id2a706a30fb459005c676bb29c196cf3a582fa01
Gerrit-Change-Number: 32621
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 May 2023 05:42:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment