May 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-hnbgw[master]: simplify: one g_hnbgw as global state and root ctx

by Jenkins Builder

Attention is currently required from: neels. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618 ) Change subject: simplify: one g_hnbgw as global state and root ctx ...................................................................... Patch Set 2: (1 comment) File src/osmo-hnbgw/hnbgw_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6850): https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618/comment/ada3be10_ca170f9b PS2, Line 299: talloc_free((void*)g_hnbgw->config.iuh_local_ip); "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3d54a5bb30c16a990c6def2a0ed207f60a95ef5d Gerrit-Change-Number: 32618 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 May 2023 22:15:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: comment typo fix in ranap_rab_ass.c

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32646 ) Change subject: comment typo fix in ranap_rab_ass.c ...................................................................... comment typo fix in ranap_rab_ass.c Change-Id: I28b4c966c399acbff46faa36f0f05cda7356e44e --- M src/osmo-hnbgw/ranap_rab_ass.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/46/32646/1 diff --git a/src/osmo-hnbgw/ranap_rab_ass.c b/src/osmo-hnbgw/ranap_rab_ass.c index 78805b8..cd8e625 100644 --- a/src/osmo-hnbgw/ranap_rab_ass.c +++ b/src/osmo-hnbgw/ranap_rab_ass.c @@ -87,7 +87,7 @@ RANAP_Criticality_reject, &asn_DEF_RANAP_RAB_AssignmentResponse, rab_assignment_response); - /* 'msg' has been generated, we cann now release the input 'out' */ + /* 'msg' has been generated, we can now release the input 'rab_assignment_response' */ ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_RAB_AssignmentResponse, rab_assignment_response); if (!msg) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I28b4c966c399acbff46faa36f0f05cda7356e44e Gerrit-Change-Number: 32646 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[L] Change in osmo-hnbgw[master]: simplify: one g_hnbgw as global state and root ctx

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618 to look at the new patch set (#2). Change subject: simplify: one g_hnbgw as global state and root ctx ...................................................................... simplify: one g_hnbgw as global state and root ctx So far we jump through hoops everywhere to pass around osmo-hnbgw's global singleton state to all code paths. Some files choose to spawn a static "global" pointer. And we also have the talloc root tall_hnb_ctx. Simplify: - Have a single global g_hnbgw pointer. Drop all function args and backpointers to the global state. - Use that global g_hnbgw as talloc root context, instead of passing a separate tall_hnb_ctx around. (Cosmetic preparation for separate osmo_hnbgw_main.c file) Change-Id: I3d54a5bb30c16a990c6def2a0ed207f60a95ef5d --- M include/osmocom/hnbgw/context_map.h M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/hnbgw_cn.h M include/osmocom/hnbgw/hnbgw_pfcp.h M include/osmocom/hnbgw/ps_rab_fsm.h M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/context_map_rua.c M src/osmo-hnbgw/context_map_sccp.c M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_hnbap.c M src/osmo-hnbgw/hnbgw_pfcp.c M src/osmo-hnbgw/hnbgw_rua.c M src/osmo-hnbgw/hnbgw_vty.c M src/osmo-hnbgw/mgw_fsm.c M src/osmo-hnbgw/ps_rab_ass_fsm.c M src/osmo-hnbgw/ps_rab_fsm.c 17 files changed, 234 insertions(+), 255 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/18/32618/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3d54a5bb30c16a990c6def2a0ed207f60a95ef5d Gerrit-Change-Number: 32618 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in osmo-hnbgw[master]: drop ctrl_test_runner.py

by neels

Attention is currently required from: neels, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32626 to look at the new patch set (#4). Change subject: drop ctrl_test_runner.py ...................................................................... drop ctrl_test_runner.py Unused and contains no actual tests. Change-Id: If3d6614334b692e49efcc45d1e4fb29a00c68602 --- M tests/Makefile.am D tests/ctrl_test_runner.py 2 files changed, 11 insertions(+), 209 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/26/32626/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If3d6614334b692e49efcc45d1e4fb29a00c68602 Gerrit-Change-Number: 32626 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: actually run vty-tests: osmotestconfig.py

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32625 ) Change subject: actually run vty-tests: osmotestconfig.py ...................................................................... actually run vty-tests: osmotestconfig.py Change-Id: Id60e5dfb22b7cea33c53388d339838add101de44 --- M tests/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index 23fcd8a..a5d33ce 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -38,7 +38,7 @@ python-tests: $(MAKE) vty-test osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v -# osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v + osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else python-tests: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id60e5dfb22b7cea33c53388d339838add101de44 Gerrit-Change-Number: 32625 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: vty: fix doc strings for 'show {hnb,ue}'

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32627 ) Change subject: vty: fix doc strings for 'show {hnb,ue}' ...................................................................... vty: fix doc strings for 'show {hnb,ue}' Fixes: OS#5987 Change-Id: I79f8b13a9f22fb8311017005cc0a3ac3a7e78983 --- M src/osmo-hnbgw/hnbgw_vty.c 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index 8d2366f..70c2d13 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -221,7 +221,10 @@ hnb_context_name(ue->hnb), VTY_NEWLINE); } -DEFUN(show_hnb, show_hnb_cmd, "show hnb all", SHOW_STR "Display information about all HNB") +#define SHOW_HNB_STR SHOW_STR "Display information about HNB\n" + +DEFUN(show_hnb, show_hnb_cmd, "show hnb all", + SHOW_HNB_STR "All HNB\n") { struct hnb_context *hnb; unsigned int count = 0; @@ -241,7 +244,8 @@ return CMD_SUCCESS; } -DEFUN(show_one_hnb, show_one_hnb_cmd, "show hnb NAME ", SHOW_STR "Display information about a HNB") +DEFUN(show_one_hnb, show_one_hnb_cmd, "show hnb NAME ", + SHOW_HNB_STR "HNB name\n") { struct hnb_context *hnb; const char *identity_info = argv[0]; @@ -261,7 +265,8 @@ return CMD_SUCCESS; } -DEFUN(show_ue, show_ue_cmd, "show ue all", SHOW_STR "Display information about a UE") +DEFUN(show_ue, show_ue_cmd, "show ue all", + SHOW_STR "Display HNBAP information about UE\n" "All UE\n") { struct ue_context *ue; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I79f8b13a9f22fb8311017005cc0a3ac3a7e78983 Gerrit-Change-Number: 32627 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: ctrl: Add getting SI5 neighbor list

by matanp

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32645 ) Change subject: ctrl: Add getting SI5 neighbor list ...................................................................... ctrl: Add getting SI5 neighbor list Change-Id: I71f5f23473b94059ac64770ceb256b4df36c0ef7 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/45/32645/1 diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 479e5b7..b243d7f 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -546,6 +546,14 @@ CTRL_CMD_DEFINE_RO(bts_neighbor_list_si2, "neighbor-list si2"); +static int get_bts_neighbor_list_si5(struct ctrl_cmd *cmd, void *data) +{ + const struct gsm_bts *bts = cmd->node; + return get_bts_neighbor_list(cmd, &bts->si_common.si5_neigh_list); +} + +CTRL_CMD_DEFINE_RO(bts_neighbor_list_si5, "neighbor-list si5"); + static int verify_bts_neighbor_list_add_del(struct ctrl_cmd *cmd, const char *value, void *_data) { int arfcn; @@ -1009,6 +1017,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_rf_states); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_c0_power_red); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si2); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_si5); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_add); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_del); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I71f5f23473b94059ac64770ceb256b4df36c0ef7 Gerrit-Change-Number: 32645 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: ctrl: Add getting neighbor list

by matanp

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 to look at the new patch set (#3). Change subject: ctrl: Add getting neighbor list ...................................................................... ctrl: Add getting neighbor list Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/65/32565/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: pass pco & qos from apn

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32643 ) Change subject: layer23: modem: pass pco & qos from apn ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4088e3e96a58bd667627023f144a05137415dd32 Gerrit-Change-Number: 32643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 May 2023 11:54:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Use in SN SAP the TLLI retrieved from GMM

by laforge

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32637 ) Change subject: layer23: modem: Use in SN SAP the TLLI retrieved from GMM ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/32637/comment/8e0cfd90_0952e509 PS1, Line 7: SN SM? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icac16626a6b89489b7f1ee2ab8ffbaca04e8bacc Gerrit-Change-Number: 32637 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 May 2023 11:54:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023