May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: bsc: TC_assignment_csd: delete mgcp EP after clear

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32660 ) Change subject: bsc: TC_assignment_csd: delete mgcp EP after clear ...................................................................... bsc: TC_assignment_csd: delete mgcp EP after clear Fix the test for sccplite, where it fails at the third rate with: Crit already present{ connid := omit, endpoint := omit, transid := omit } For each rate that gets tested, a new expectation (Crit) gets set by f_tc_assignment_csd() (f_establish_fully() -> f_create_mgcp_expect()). If the expectation already exists at this point, it leads to the error above. While the rate gets tested, the expectation gets removed in MGCP_Emulation:main() (ops.create_cb.apply -> ExpectedCreateCallback()), but only if the EP is not known. So without this patch: * T_14k4: passes, EP is not known, Crit gets removed * T_9k6: passes, EP is known, Crit does not get removed * T_4k8: error, because Crit already exists Related: OS#4393 Change-Id: Ib8d27a670931105f45b994799c4757fffabdf97d --- M bsc/BSC_Tests.ttcn 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/32660/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 5e739b2..3861f34 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1875,6 +1875,7 @@ } f_perform_clear(); + f_create_mgcp_delete_ep(g_media.mgcp_ep); } private function f_tc_assignment_csd_all(charstring id) runs on MSC_ConnHdlr { /* Data rates that require multi-slot HSCSD assignment are not tested -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8d27a670931105f45b994799c4757fffabdf97d Gerrit-Change-Number: 32660 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/MGCP_Emulation: fix typo

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32658 ) Change subject: library/MGCP_Emulation: fix typo ...................................................................... library/MGCP_Emulation: fix typo Change-Id: Ie456993821264b564458f6a9131889dac969d344 --- M library/MGCP_Emulation.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/32658/1 diff --git a/library/MGCP_Emulation.ttcn b/library/MGCP_Emulation.ttcn index 53aae1b..3167579 100644 --- a/library/MGCP_Emulation.ttcn +++ b/library/MGCP_Emulation.ttcn @@ -448,7 +448,7 @@ runs on MGCP_Emulation_CT { var integer i; - /* Check an entry like this is not already presnt */ + /* Check an entry like this is not already present */ for (i := 0; i < sizeof(MgcpExpectTable); i := i+1) { if (crit == MgcpExpectTable[i].crit) { setverdict(fail, "Crit already present", crit); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie456993821264b564458f6a9131889dac969d344 Gerrit-Change-Number: 32658 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in libosmo-abis[master]: fix use-after-free in ipaccess_bts_keepalive_fsm_alloc()

by Hoernchen

Attention is currently required from: osmith, pespin, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32641 ) Change subject: fix use-after-free in ipaccess_bts_keepalive_fsm_alloc() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/32641/comment/75f1adc5_38e1e8fc PS1, Line 33: *** calling ipaccess_keepalive_fsm_cleanup() > > why is cleanup() called here if it was freed above? […] Actually Pau needs to ask Pau because Pau and Oliver reworked the patch which - even though it is based on a first draft by me - has nothing in common with that version. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic56c4b5b7b24b63104908a0c24f2f645ba4c5c1b Gerrit-Change-Number: 32641 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 May 2023 10:38:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Fix spec reference in RSL header file

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/32656 ) Change subject: cosmetic: Fix spec reference in RSL header file ...................................................................... cosmetic: Fix spec reference in RSL header file Change-Id: I671ee927b49099f7c8cc1fbd5f8b19f94ba1af81 --- M include/osmocom/gsm/protocol/gsm_08_58.h 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/32656/1 diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index e932ff8..b5de6ab 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -673,7 +673,7 @@ #define RSL_CHANNEED_TCH_F 0x02 #define RSL_CHANNEED_TCH_ForH 0x03 -/*! RSL Cell Broadcast Command (Chapter 9.3.45) */ +/*! RSL Cell Broadcast Command (Chapter 9.3.41) */ struct rsl_ie_cb_cmd_type { #if OSMO_IS_LITTLE_ENDIAN uint8_t last_block:2; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I671ee927b49099f7c8cc1fbd5f8b19f94ba1af81 Gerrit-Change-Number: 32656 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: gsm_08_58.h: Add 'struct rsl_ie_nch_drx_info'

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/32657 ) Change subject: gsm_08_58.h: Add 'struct rsl_ie_nch_drx_info' ...................................................................... gsm_08_58.h: Add 'struct rsl_ie_nch_drx_info' This adds the definition of 'struct rsl_ie_nch_drx_info' representing the bit-field of the 'NCH DRX Information IE' of A-bis RSL. Change-Id: I9586b5cb8514010d9358fcfc97c3d34741294522 Related: OS#5781 --- M include/osmocom/gsm/protocol/gsm_08_58.h 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/32657/1 diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index b5de6ab..0a44db9 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -699,6 +699,23 @@ #define RSL_CB_CMD_LASTBLOCK_2 2 #define RSL_CB_CMD_LASTBLOCK_3 3 +/*! NCH DRX Information (Chapter 9.3.47) */ +struct rsl_ie_nch_drx_info { +#if OSMO_IS_LITTLE_ENDIAN + uint8_t nln:2; + uint8_t emlpp_priority:3; + uint8_t nln_status:1; + uint8_t spare:2; +#elif OSMO_IS_BIG_ENDIAN +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ + uint8_t spare:2, nln_status:1, emlpp_priority:3, nln:2; +#endif +} __attribute__ ((packed)); + +/*! Command Indicator (Chapter 9.3.48) */ +#define RSL_CMD_INDICATOR_START 0x00 +#define RSL_CMD_INDICATOR_STOP 0x01 + /* Chapter 3.3.2.3 Brocast control channel */ /* CCCH-CONF, NC is not combined */ #define RSL_BCCH_CCCH_CONF_1_NC 0x00 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9586b5cb8514010d9358fcfc97c3d34741294522 Gerrit-Change-Number: 32657 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Add TC_attach_timeout_after_pdp_act

by laforge

Attention is currently required from: arehbein, pespin, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 ) Change subject: sgsn: Add TC_attach_timeout_after_pdp_act ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3e3c021707b707811388616e28d7d7cc22f7b53 Gerrit-Change-Number: 31199 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 May 2023 08:52:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: Define 'solSACapability' as '0'

by laforge

Attention is currently required from: arehbein. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32648 ) Change subject: library: Define 'solSACapability' as '0' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9eaa39274456e5cc0a1cf025bf956970efc4a51f Gerrit-Change-Number: 32648 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 May 2023 08:51:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32605 ) Change subject: PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND ...................................................................... PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND Even though we do not need it right now, let's add the message type PCU_IF_MSG_E1_CCU_IND. This message type has been added to the PCUIF protocol recently. Related: OS#5927 Change-Id: Ib6482d88e924f285658b933f32be42a4f63bee71 --- M library/PCUIF_Types.ttcn 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index 76306a3..a6af2a0 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -33,6 +33,7 @@ PCU_IF_MSG_DATA_CNF_DT ('11'O), PCU_IF_MSG_RACH_IND ('22'O), PCU_IF_MSG_INFO_IND ('32'O), + PCU_IF_MSG_E1_CCU_IND ('33'O), PCU_IF_MSG_ACT_REQ ('40'O), PCU_IF_MSG_TIME_IND ('52'O), PCU_IF_MSG_INTERF_IND ('53'O), @@ -216,6 +217,17 @@ record length(2) of octetstring addr length(16) } with { variant "" }; +/* E1 CCU connection parameters */ +type record PCUIF_e1_ccu_ind { + /* GSM/GPRS air interface */ + uint8_t trx_nr, + uint8_t ts_nr, + /* E1 line interface */ + uint8_t e1_nr, + uint8_t e1_ts, + uint8_t e1_ts_ss +} with { variant "" }; + type record PCUIF_act_req { uint8_t is_activate, uint8_t trx_nr, @@ -311,6 +323,7 @@ PCUIF_rach_ind rach_ind, PCUIF_txt_ind txt_ind, PCUIF_info_ind info_ind, + PCUIF_e1_ccu_ind e1_ccu_ind, PCUIF_act_req act_req, PCUIF_time_ind time_ind, PCUIF_interf_ind interf_ind, @@ -334,6 +347,7 @@ rach_ind, msg_type = PCU_IF_MSG_RACH_IND; txt_ind, msg_type = PCU_IF_MSG_TXT_IND; info_ind, msg_type = PCU_IF_MSG_INFO_IND; + e1_ccu_ind, msg_type = PCU_IF_MSG_E1_CCU_IND; act_req, msg_type = PCU_IF_MSG_ACT_REQ; time_ind, msg_type = PCU_IF_MSG_TIME_IND; interf_ind, msg_type = PCU_IF_MSG_INTERF_IND; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib6482d88e924f285658b933f32be42a4f63bee71 Gerrit-Change-Number: 32605 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[L] Change in libosmo-abis[master]: e1d: reconnect to osmo-e1d after connection loss

by dexter

Attention is currently required from: laforge, pespin, keith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 ) Change subject: e1d: reconnect to osmo-e1d after connection loss ...................................................................... Patch Set 10: (1 comment) Patchset: PS2: > I think for the Keith's specific application it would be better to use the DAHDI driver. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338 Gerrit-Change-Number: 32374 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 08 May 2023 08:17:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: keith <keith(a)rhizomatica.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: Support (optional) indication of NCH position in SI1 rest octets

by jolly

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32655 ) Change subject: Support (optional) indication of NCH position in SI1 rest octets ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32655/comment/abb21d3b_a1aada6e PS2, Line 1113: "nch-position num-blocks <1-7> first-block <0-6>", These are actually 5 arguments, but here are only 3 descriptions of them. https://gerrit.osmocom.org/c/osmo-bsc/+/32655/comment/9b8c1b1b_f8054e66 PS2, Line 1114: "NCH (Notification Channel) position within CCCH" Missing \n to separate descriptions. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iefde0af44a663f22462a54d68a58caa560eceb2f Gerrit-Change-Number: 32655 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 08 May 2023 08:14:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023