May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-pcu[master]: ctrl: drop deprecated neighbor resolution interface

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32275 ) Change subject: ctrl: drop deprecated neighbor resolution interface ...................................................................... ctrl: drop deprecated neighbor resolution interface Related: OS#5809 Change-Id: Iff008c77ab49dd8855d54d2d44198475086012e4 --- M src/gprs_pcu.c M src/gprs_pcu.h M src/nacc_fsm.c M src/nacc_fsm.h M src/pcu_vty.c 5 files changed, 11 insertions(+), 108 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve arehbein: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c index de6b669..2ad5c71 100644 --- a/src/gprs_pcu.c +++ b/src/gprs_pcu.c @@ -131,8 +131,6 @@ pcu->vty.ws_pdch = 0; pcu->vty.llc_codel_interval_msec = LLC_CODEL_USE_DEFAULT; pcu->vty.llc_idle_ack_csec = 10; - pcu->vty.neigh_ctrl_addr = NULL; /* don't use CTRL iface for Neigh Addr Resolution */ - pcu->vty.neigh_ctrl_port = OSMO_CTRL_PORT_BSC_NEIGH; pcu->T_defs = T_defs_pcu; osmo_tdefs_reset(pcu->T_defs); diff --git a/src/gprs_pcu.h b/src/gprs_pcu.h index 956f0e7..66cfca3 100644 --- a/src/gprs_pcu.h +++ b/src/gprs_pcu.h @@ -112,9 +112,6 @@ uint32_t llc_discard_csec; uint32_t llc_idle_ack_csec; uint32_t llc_codel_interval_msec; /* 0=disabled, -1=use default interval */ - /* Remote BSS resolution sevice (CTRL iface) */ - char *neigh_ctrl_addr; - uint16_t neigh_ctrl_port; } vty; struct gsmtap_inst *gsmtap; diff --git a/src/nacc_fsm.c b/src/nacc_fsm.c index 0719d2c..c513423 100644 --- a/src/nacc_fsm.c +++ b/src/nacc_fsm.c @@ -358,63 +358,11 @@ } } -static int send_neigh_addr_req_ctrl_iface(struct nacc_fsm_ctx *ctx) -{ - struct gprs_rlcmac_bts *bts = ctx->ms->bts; - struct gprs_pcu *pcu = bts->pcu; - struct ctrl_cmd *cmd = NULL; - int rc; - - /* We may have changed to this state previously (eg: we are handling - * another Pkt cell Change Notify with different target). Avoid - * re-creating the socket in that case. */ - if (ctx->neigh_ctrl_conn->write_queue.bfd.fd == -1) { - rc = osmo_sock_init2_ofd(&ctx->neigh_ctrl_conn->write_queue.bfd, - AF_UNSPEC, SOCK_STREAM, IPPROTO_TCP, - NULL, 0, pcu->vty.neigh_ctrl_addr, pcu->vty.neigh_ctrl_port, - OSMO_SOCK_F_CONNECT); - if (rc < 0) { - LOGPFSML(ctx->fi, LOGL_ERROR, - "Failed to establish CTRL (neighbor resolution) connection to BSC r=%s:%u\n\n", - pcu->vty.neigh_ctrl_addr, pcu->vty.neigh_ctrl_port); - goto err_term; - } - } - - cmd = ctrl_cmd_create(ctx, CTRL_TYPE_GET); - if (!cmd) { - LOGPFSML(ctx->fi, LOGL_ERROR, "CTRL msg creation failed\n"); - goto err_term; - } - - cmd->id = talloc_asprintf(cmd, "%u", arfcn_bsic_2_ctrl_id(ctx->neigh_key.tgt_arfcn, - ctx->neigh_key.tgt_bsic)); - cmd->variable = talloc_asprintf(cmd, "neighbor_resolve_cgi_ps_from_lac_ci.%d.%d.%d.%d", - ctx->neigh_key.local_lac, ctx->neigh_key.local_ci, - ctx->neigh_key.tgt_arfcn, ctx->neigh_key.tgt_bsic); - rc = ctrl_cmd_send(&ctx->neigh_ctrl_conn->write_queue, cmd); - if (rc) { - LOGPFSML(ctx->fi, LOGL_ERROR, "CTRL msg sent failed: %d\n", rc); - goto err_term; - } - - talloc_free(cmd); - return 0; - -err_term: - talloc_free(cmd); - return -1; -} - static int send_neigh_addr_req(struct nacc_fsm_ctx *ctx) { struct gprs_rlcmac_bts *bts = ctx->ms->bts; - /* If PCU was configured to use the old CTRL interface, use it: */ - if (ctx->neigh_ctrl_conn) - return send_neigh_addr_req_ctrl_iface(ctx); - - /* Otherwise, by default the new PCUIF over IPA Abis multiplex proto should be used: */ + /* Using PCUIF over IPA Abis multiplex proto: */ return pcu_tx_neigh_addr_res_req(bts, &ctx->neigh_key); } @@ -833,15 +781,6 @@ ctx->fi = NULL; } - if (ctx->neigh_ctrl_conn) { - if (ctx->neigh_ctrl_conn->write_queue.bfd.fd != -1) { - osmo_wqueue_clear(&ctx->neigh_ctrl_conn->write_queue); - osmo_fd_unregister(&ctx->neigh_ctrl_conn->write_queue.bfd); - close(ctx->neigh_ctrl_conn->write_queue.bfd.fd); - ctx->neigh_ctrl_conn->write_queue.bfd.fd = -1; - } - } - return 0; } @@ -859,19 +798,6 @@ if (!ctx->fi) goto free_ret; - /* If CTRL ip present, use the old CTRL interface for neighbor resolution */ - if (ms->bts->pcu->vty.neigh_ctrl_addr) { - ctx->neigh_ctrl = ctrl_handle_alloc(ctx, ctx, NULL); - ctx->neigh_ctrl->reply_cb = nacc_fsm_ctrl_reply_cb; - ctx->neigh_ctrl_conn = osmo_ctrl_conn_alloc(ctx, ctx->neigh_ctrl); - if (!ctx->neigh_ctrl_conn) - goto free_ret; - /* Older versions of osmo_ctrl_conn_alloc didn't properly initialize fd to -1, - * so make sure to do it here otherwise fd may be valid fd 0 and cause trouble */ - ctx->neigh_ctrl_conn->write_queue.bfd.fd = -1; - llist_add(&ctx->neigh_ctrl_conn->list_entry, &ctx->neigh_ctrl->ccon_list); - } - return ctx; free_ret: talloc_free(ctx); diff --git a/src/nacc_fsm.h b/src/nacc_fsm.h index c051637..ec6db2e 100644 --- a/src/nacc_fsm.h +++ b/src/nacc_fsm.h @@ -46,8 +46,6 @@ struct nacc_fsm_ctx { struct osmo_fsm_inst *fi; struct GprsMs* ms; /* back pointer */ - struct ctrl_handle *neigh_ctrl; - struct ctrl_connection *neigh_ctrl_conn; struct neigh_cache_entry_key neigh_key; /* target cell info from MS */ struct osmo_cell_global_id_ps cgi_ps; /* target cell info resolved from req_{arfcn+bsic} */ struct si_cache_value si_info; /* SI info resolved from SGSN, to be sent to MS */ diff --git a/src/pcu_vty.c b/src/pcu_vty.c index 54e0df6..84c0456 100644 --- a/src/pcu_vty.c +++ b/src/pcu_vty.c @@ -303,11 +303,6 @@ if (the_pcu->vty.ns_priority != -1) vty_out(vty, " gb socket-priority %d%s", the_pcu->vty.ns_priority, VTY_NEWLINE); - if (the_pcu->vty.neigh_ctrl_addr) { - vty_out(vty, " neighbor resolution %s %u%s", - the_pcu->vty.neigh_ctrl_addr, the_pcu->vty.neigh_ctrl_port, VTY_NEWLINE); - } - osmo_tdef_vty_write(vty, the_pcu->T_defs, " timer "); return CMD_SUCCESS; @@ -1107,26 +1102,6 @@ return CMD_SUCCESS; } -DEFUN(cfg_neighbor_resolution, cfg_neighbor_resolution_cmd, - "neighbor resolution " VTY_IPV46_CMD " [<0-65535>]", - "Manage local and remote-BSS neighbor cells\n" - "Connect to Neighbor Resolution Service (CTRL interface) to given ip and port\n" - "IPv4 address to connect to\n" "IPv6 address to connect to\n" - "Port to connect to (default 4248)\n") -{ - vty_out(vty, "%% Warning: The CTRL interface for Neighbor Address Resolution is now deprecated." - "Upgrade osmo-bsc and drop the 'neighbor resolution " VTY_IPV46_CMD " [<0-65535>]' VTY " - "option in order to let osmo-pcu use the new resoluton method using the PCUIF over IPA " - "multiplex, which will work out of the box without required configuration.%s", VTY_NEWLINE); - osmo_talloc_replace_string(the_pcu, &the_pcu->vty.neigh_ctrl_addr, argv[0]); - if (argc > 1) - the_pcu->vty.neigh_ctrl_port = atoi(argv[1]); - else - the_pcu->vty.neigh_ctrl_port = OSMO_CTRL_PORT_BSC_NEIGH; - return CMD_SUCCESS; -} - - DEFUN(show_bts_timer, show_bts_timer_cmd, "show bts-timer " OSMO_TDEF_VTY_ARG_T_OPTIONAL, SHOW_STR "Show BTS controlled timers\n" @@ -1350,7 +1325,6 @@ install_element(PCU_NODE, &cfg_pcu_gb_dialect_cmd); install_element(PCU_NODE, &cfg_pcu_gb_ip_dscp_cmd); install_element(PCU_NODE, &cfg_pcu_gb_priority_cmd); - install_element(PCU_NODE, &cfg_neighbor_resolution_cmd); install_element(PCU_NODE, &cfg_pcu_timer_cmd); install_element_ve(&show_bts_stats_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32275 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iff008c77ab49dd8855d54d2d44198475086012e4 Gerrit-Change-Number: 32275 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in osmo-pcu[master]: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks

by laforge

Attention is currently required from: jolly, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 ) Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 May 2023 15:21:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: pcu_sock: fix PCUIF interface (PCH)

by laforge

Attention is currently required from: jolly, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32693 ) Change subject: pcu_sock: fix PCUIF interface (PCH) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I82443f2b402aa2416469c8c50b1c050323ef3b8f Gerrit-Change-Number: 32693 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 May 2023 15:20:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: codec: replace GSM-FR ECU with new implementation

by laforge

Attention is currently required from: falconia, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 ) Change subject: codec: replace GSM-FR ECU with new implementation ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think review of this patch is slightly more difficult than it should be due to mixing a file rename with introducing new code. Maybe first have a commit doing the rename (purely cosmetic, non-functional) and then a commit that adds the new implementation? Also, I'm not sure if we actually still need to support the direct API that doesn't go through osmo_ecu_ops_fr. osmo-bts >= 1.2.0 already uses the the ecu_ops architecture. But unfortunately 0.8.0 - 1.1.0 use the old API, so it was in use longer than I thought :/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0200e423ca6165c1313ec9a4effc3f3047f5f032 Gerrit-Change-Number: 32685 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 May 2023 15:18:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: docs: add SUPI/SUCI usage example

by laforge

Attention is currently required from: merlinchlosta. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32688 ) Change subject: docs: add SUPI/SUCI usage example ...................................................................... Patch Set 1: (6 comments) Patchset: PS1: > Harald suggested including the "SUCI tutorial"[1] into the official documentation, so I thought a pu […] thanks for submitting it. I'll put on my todo list to remove the whitespaces which the linter complains about. side note: ISIM-SJA2 is going EOL soon (we still have ~ 11,000 in stock for the next few months) and I'm currently working on the successor product which will (at least in one variant with a more beefy processor in the card for the EC crypto) also support the "SUCI calculation on SIM". File docs/suci-tutorial.rst: https://gerrit.osmocom.org/c/pysim/+/32688/comment/53adbb55_ce145e10 PS1, Line 6: . pySIM probably makes sense to mention the two different fundamental ways of SUCI calculation (on card / on UE) and mention that this is only about the "on UE" variant? https://gerrit.osmocom.org/c/pysim/+/32688/comment/5901d94a_7b4b6403 PS1, Line 33: If you bought : the SIM card from your network maybe make it more explicit that this only works with a programmable card where you as the pySim user are functioning as the card issuer/operator? https://gerrit.osmocom.org/c/pysim/+/32688/comment/003cba4f_46f45733 PS1, Line 103: file is **invalid**: does the file contain invalid data, or do you mean it is invalidated (other term for deactivated)? https://gerrit.osmocom.org/c/pysim/+/32688/comment/fe40ee9c_7bb0fda7 PS1, Line 120: pySIM-shell (MF/ADF misc comment: this probably means we should add a decoder/encoder for this file, so people don't have to go through hex strings. https://gerrit.osmocom.org/c/pysim/+/32688/comment/4c4dad8e_cb38832d PS1, Line 168: sysmocom ISIM does best to always say "sysmoISIM-SJA2" as other products in the future may also be a "sysmocom ISIM" but have different feature sets. Same applies below in the next few lines until EOF. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2908ea9df7e78c596554731085902e2ab7278328 Gerrit-Change-Number: 32688 Gerrit-PatchSet: 1 Gerrit-Owner: merlinchlosta <merlin.chlosta(a)rub.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: merlinchlosta <merlin.chlosta(a)rub.de> Gerrit-Comment-Date: Fri, 12 May 2023 15:10:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: merlinchlosta <merlin.chlosta(a)rub.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: cards: Add support for Gialer SIM cards

by matanp

Attention is currently required from: laforge. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32686 ) Change subject: cards: Add support for Gialer SIM cards ...................................................................... Patch Set 4: (2 comments) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/32686/comment/ab910fa8_c7a48886 PS1, Line 1668: def autodetect(kls, scc): > maybe add the ATR as comment, or simply assume they all have the same ATR? Seems like it has a unique https://pcsc-tools.apdu.fr/smartcard_list.txt - I will check it and update, thanks a lot! File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/32686/comment/d798324a_3ff4236f PS4, Line 1713: why the '01' is required > this might specify whether it's OP or OPc? Or it might specify the algorithm? From their programming software, programming OP calculate and burns OPc. I will check the algorithm idea, thanks! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 Gerrit-Change-Number: 32686 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 12 May 2023 15:06:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: matanp <matan1008(a)gmail.com> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: paging: rename all IMM.ASS references to MACBLOCK

by laforge

Attention is currently required from: jolly, fixeria, msuraev, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32687 ) Change subject: paging: rename all IMM.ASS references to MACBLOCK ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: it looks like this is a purely cosmetic rename. If it is, it woudl be useful to have "[cosmetic]" or "cosmetic:" in the commit log subject line -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ifab37fdedaba98b160718113767e4ef6ee7d16ad Gerrit-Change-Number: 32687 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 May 2023 14:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-iuh[master]: add ranap_new_msg_reset2() with GlobalRNC-ID

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/32692 ) Change subject: add ranap_new_msg_reset2() with GlobalRNC-ID ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/32692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Iec70c3054333f01bc27ca0e69bfa325bbe36edd0 Gerrit-Change-Number: 32692 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 May 2023 14:43:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: cards: Add support for Gialer SIM cards

by laforge

Attention is currently required from: matanp. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32686 ) Change subject: cards: Add support for Gialer SIM cards ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/32686/comment/3e230f31_80afd147 PS1, Line 1668: def autodetect(kls, scc): > Unfortunately I don't have other sims to check for false positives (and I couldn't find any document […] maybe add the ATR as comment, or simply assume they all have the same ATR? File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/32686/comment/b6894548_00d3c0a7 PS4, Line 1713: why the '01' is required this might specify whether it's OP or OPc? Or it might specify the algorithm? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 Gerrit-Change-Number: 32686 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Fri, 12 May 2023 14:42:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: matanp <matan1008(a)gmail.com> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: VTY references: set git version and date

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32689 ) Change subject: VTY references: set git version and date ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I68a8c3893d3c3a3b1bc1aee442a17635b60ac531 Gerrit-Change-Number: 32689 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 May 2023 14:40:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023