May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: hnbgw: put copyright into define

by neels

Attention is currently required from: osmith, laforge, fixeria, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32679 ) Change subject: hnbgw: put copyright into define ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > The difference is, we write it into vty_info.copyright in main(): […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I13b2569a369724e0298b064a0876b95d6dafd9d0 Gerrit-Change-Number: 32679 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 May 2023 15:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-hlr[master]: Add support for multiple APN profiles for subscriber data

by daniel

Attention is currently required from: laforge, lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data ...................................................................... Patch Set 7: (1 comment) File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/0e763ee6_7b9f3349 PS5, Line 133: Define a PDP profile set.\n" : "Unique identifier for this PDP profile set.\n") > I wasn't sure what a complex scenario could be. […] I think the confusion is that there's only a pdp-profiles "default", but the help for default states "Unique identifier for this PDP profile set". -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f Gerrit-Change-Number: 32512 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 11 May 2023 15:30:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: VTY references: set git version and date

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32689 ) Change subject: VTY references: set git version and date ...................................................................... VTY references: set git version and date Fix that VTY references currently don't have the version from which they were generated. Set the same REVNUMBER and GIT_DATE variables in Makefile.docbook.inc (gets included in Makefile.vty-rference.inc) as in Makefile.asciidoc.inc. Use them with a new script to rewrite the <revhistory> block of vty references. Closes: OS#4063 Change-Id: I68a8c3893d3c3a3b1bc1aee442a17635b60ac531 --- M build/Makefile.docbook.inc A build/docbook-set-revhistory.py 2 files changed, 109 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/89/32689/1 diff --git a/build/Makefile.docbook.inc b/build/Makefile.docbook.inc index eb0ee25..eff6c66 100644 --- a/build/Makefile.docbook.inc +++ b/build/Makefile.docbook.inc @@ -34,9 +34,22 @@ %.xml-lint: %.xml xmllint --xinclude --postvalid --noout $< +GIT_VERSION := $(shell git describe --abbrev=4 --dirty --always --tags) +GIT_DATE := $(shell $(OSMO_GSM_MANUALS_DIR)/build/unix-time-to-fmt.py `git log -n 1 "--pretty=%at" ../.`) +ifeq (,$(BUILD_RELEASE)) + REVNUMBER := DRAFT $(GIT_VERSION) +else + REVNUMBER := $(GIT_VERSION) +endif + # Create a PDF file and lint it before # xslt path: find includes in both $(OSMO_GSM_MANUALS_DIR)/common/chapters and $(builddir)/generated %.pdf: %.xml %.xml-lint $(DOCBOOKS_DEPS) build common + set -x && \ + export GIT_DATE="$(GIT_DATE)" && \ + export REVNUMBER="$(REVNUMBER)" && \ + export TEMPFILE="$(INC_DIR)/_temp_$(notdir $<)" && \ + $(OSMO_GSM_MANUALS_DIR)/build/docbook-set-revhistory.py "$<" && \ dblatex --xslt-opts="--path $(realpath $(OSMO_GSM_MANUALS_DIR))/common/chapters:$(INC_DIR)" \ - $(dblatex_quiet) -P draft.mode=no -o $@ $< - + $(dblatex_quiet) -P draft.mode=no -o $@ "$$TEMPFILE" && \ + rm $$TEMPFILE diff --git a/build/docbook-set-revhistory.py b/build/docbook-set-revhistory.py new file mode 100755 index 0000000..8494ff0 --- /dev/null +++ b/build/docbook-set-revhistory.py @@ -0,0 +1,78 @@ +#!/usr/bin/env python3 +# Rewrite the revhistory part of the document for vty reference (OS#4063) +import os +import shutil +import sys + +xml_in = sys.argv[1] +xml_out = os.environ["TEMPFILE"] +git_date = os.environ["GIT_DATE"] +revnumber = os.environ["REVNUMBER"] + + +def get_author_initials(line): + return line.split("<authorinitials>")[1].split("</authorinitials>")[0] + + +def write_revhistory_block(h_out, author_initials): + h_out.write("<revhistory>\n") + h_out.write("<revision>\n") + h_out.write(f"<revnumber>{revnumber}</revnumber>\n") + h_out.write(f"<date>{git_date}</date>\n") + h_out.write(f"<authorinitials>{author_initials}</authorinitials>\n") + h_out.write("<revremark>Automatically Generated VTY Reference</revremark>\n") + h_out.write("</revision>\n") + h_out.write("</revhistory>\n") + + +def set_revhistory(): + """ + Replace the part of the docbook that looks like the following, and copy + all other lines. Just using python's xml library would be better, but it + fails on docbook's custom DTDs. + <revhistory> + <revision> + <revnumber>v1</revnumber> + <date>18th September 2017</date> + <authorinitials>nh</authorinitials> + <revremark>Initial</revremark> + </revision> + </revhistory> + """ + before = 0 + inside = 1 + after = 2 + + pos = before + author_initials = "" + + with open(xml_out, "w") as h_out: + with open(xml_in, "r") as h_in: + for line in h_in.readlines(): + if pos == before: + if "<revhistory>" in line: + h_out.write(line.split("<revhistory>")[0] + "\n") + pos = inside + + if pos in [before, after]: + h_out.write(line) + + if pos == inside: + if "<authorinitials>" in line: + author_initials = get_author_initials(line) + if "</revhistory>" in line: + write_revhistory_block(h_out, author_initials) + h_out.write(line.split("</revhistory>")[1]) + pos = after + + +def main(): + if xml_in.endswith("-vty-reference.xml"): + print(f"Changing revhistory to {revnumber}, {git_date}...") + set_revhistory() + else: + print("Copying without change of revhistory...") + shutil.copyfile(xml_in, xml_out) + + +main() -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I68a8c3893d3c3a3b1bc1aee442a17635b60ac531 Gerrit-Change-Number: 32689 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: cards: Add support for Gialer SIM cards

by matanp

Attention is currently required from: laforge, matanp. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/32686 to look at the new patch set (#4). Change subject: cards: Add support for Gialer SIM cards ...................................................................... cards: Add support for Gialer SIM cards Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 --- M pySim/cards.py 1 file changed, 68 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/32686/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 Gerrit-Change-Number: 32686 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: codec: replace GSM-FR ECU with new implementation

by falconia

Attention is currently required from: laforge, dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 ) Change subject: codec: replace GSM-FR ECU with new implementation ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > My general comment to this is that the current ECU interface is not set in stone. If you think there's a way to bring it more in-line with what the specs intend to do, and it's not rewriting half of osmo-bts, I'd be interested to hear/read about it. Regarding osmo-bts: I argue that a BTS should never be applying any ECU to its uplink at all. There *may* be a case for applying an ECU-like transform in the downlink path, if one were to take the rules of TS 28.062 section C.3.2.1.1 (written for TFO) and interpret them as also applying to TrFO - but even there I am not totally convinced. My main cause for hesitation in that case is that those C3211 rules are easy to implement for FR1 codec (just call a standard FR1 Rx DTX handler implementation such as Themyscira libgsmfrp), but seem inordinately difficult and awkward for EFR or HR1. (If someone has an actual legacy TRAU they could hook up to OCTOI so I could experiment with it, I would love to poke around and see what historical vendors actually did there!) A much much simpler alternative to trying to implement C3211 rules would be to simply induce a deliberate BFI condition on call B DL when a BFI was received from call A UL, and that's exactly what osmo-bts already does without any ECU: osmo-bts-trx sends dummy FACCH, whereas sysmoBTS PHY sends out a traffic frame with CRC3 bits inverted, thereby inducing a BFI condition in the MS receiver. (I say so based on observing what the Calypso DSP receives when a zero-length payload has been fed to sysmoBTS PHY in the DL.) Beyond osmo-bts, regarding the ECU concept in general: I am still not convinced that a standalone ECU (not part of a full speech decoder emitting a block of 160 linear PCM samples on its output) should exist at all! I don't see any reason for one to exist, nowhere do any specs call for such a thing, and it would be very difficult to implement one for any codec other than FR1. For HR1 and all later codecs, the ECU function has been baked into the main decoder from the get-go, and never implemented or even defined as a standalone component. FR1 is the lone exception, but even for FR1 the modular piece that is defined as separable from the main decoder is not an ECU, but a slightly bigger piece called the Rx DTX handler. Again, why should a separate ECU-by-itself exist at all, what need is there for one? This kind of deep technical discussion of which functionality should exist at a high level (higher level than code review details) is exactly what OsmoDevCall seems best suited for. I already added an FR/EFR codecs topic proposal to the OsmoDevCall wiki page, and I see absolutely nothing scheduled past May. It would be so much easier if we could talk about this FR/EFR codecs, ECUs etc topic in proper depth in June ODC! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0200e423ca6165c1313ec9a4effc3f3047f5f032 Gerrit-Change-Number: 32685 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 11 May 2023 13:18:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: cards: Add support for Gialer SIM cards

by matanp

Attention is currently required from: laforge, matanp. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/32686 to look at the new patch set (#3). Change subject: cards: Add support for Gialer SIM cards ...................................................................... cards: Add support for Gialer SIM cards Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 --- M pySim/cards.py 1 file changed, 69 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/32686/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 Gerrit-Change-Number: 32686 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: cards: Add support for Gialer SIM cards

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32686 ) Change subject: cards: Add support for Gialer SIM cards ...................................................................... Patch Set 2: (1 comment) File pySim/cards.py: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6944): https://gerrit.osmocom.org/c/pysim/+/32686/comment/86ab826c_739bcdae PS2, Line 1669: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 Gerrit-Change-Number: 32686 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 11 May 2023 12:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: cards: Add support for Gialer SIM cards

by matanp

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/32686 to look at the new patch set (#2). Change subject: cards: Add support for Gialer SIM cards ...................................................................... cards: Add support for Gialer SIM cards Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 --- M pySim/cards.py 1 file changed, 69 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/32686/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 Gerrit-Change-Number: 32686 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: cards: Add support for Gialer SIM cards

by matanp

Attention is currently required from: laforge. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32686 ) Change subject: cards: Add support for Gialer SIM cards ...................................................................... Patch Set 1: (2 comments) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/32686/comment/3ed96c3e_3e111ccf PS1, Line 1668: def autodetect(kls, scc): > isn't it possible to auto-detect the cards based on ATR or some other criteria? Unfortunately I don't have other sims to check for false positives (and I couldn't find any documentation about it) https://gerrit.osmocom.org/c/pysim/+/32686/comment/6d7de4fa_785edf55 PS1, Line 1700: > are you sure there aren't various other files you'd need to program? Like EF. […] From what I understand (captured https://smacarte.com/wp/grsimwrite_download/ usb traffic) the K and the Ki are same in this sim. I will add the OPC (no OP option) and the AD soon -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17 Gerrit-Change-Number: 32686 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 11 May 2023 12:32:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: docs: add SUPI/SUCI usage example

by merlinchlosta

merlinchlosta has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32688 ) Change subject: docs: add SUPI/SUCI usage example ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Harald suggested including the "SUCI tutorial"[1] into the official documentation, so I thought a pull request is a good place to discuss. I currently have no working setup to check the examples, but last time, it did still work. At least from my side, feel free to do direct edits on this PR to fix typos. [1] https://gist.github.com/mrlnc/01d6300f1904f154d969ff205136b753 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2908ea9df7e78c596554731085902e2ab7278328 Gerrit-Change-Number: 32688 Gerrit-PatchSet: 1 Gerrit-Owner: merlinchlosta <merlin.chlosta(a)rub.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 11 May 2023 11:20:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023