May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-pcu[master]: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks

by fixeria

Attention is currently required from: jolly, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 ) Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/16f1b6fa_4b9e1736 PS2, Line 15: It was not clear that PAGING : COMMAND and IMMEDIATE ASSIGNMENT (via PCH) require a confirmation by the : receiving end Reading this patch again I am not sure if I understand the goal you're aiming to achieve. Yes, RR Immediate Assignment messages sent via PCH do need to be confirmed, but what makes you think that paging requests need to be confirmed too? You're even saying there is a bug, but what exactly is broken? Take a look at `pcu_rx_data_cnf()`. This function checks if the SAPI is `PCU_IF_SAPI_PCH` and calls `bts_rcv_imm_ass_cnf` iff `data_cnf->data[2] == GSM48_MT_RR_IMM_ASS`. AFAICS, no confirmation is expected for paging requests. File src/gprs_rlcmac.c: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/14fc3dcd_44f3849f PS2, Line 33: The caller must use a TMSI/TLLI Is there anything in the specs. limiting the MI type to TMSI for PS paging? I am not aware of such limitations. TMSI may be unassigned and the MS can be paged by IMSI. This looks wrong to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 13:48:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-pcu[master]: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks

by dexter

Attention is currently required from: jolly, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 ) Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks ...................................................................... Patch Set 2: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/0debb836_982fe0c5 PS1, Line 7: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks > not sure what "paging backblocks" means here. I just mean a MAC block with a paging message inside. We generate those with write_paging_request() and send them to osmo-bts as a whole. Osmo-bts then does not interpret them any further it just sends them. https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/284a0019_88ae299f PS1, Line 28: OS##5927 > only one `#` please Done File src/gprs_rlcmac.c: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/6f6be98f_5405e950 PS1, Line 20: #include <osmocom/core/bitvec.h> > why adding this header? I had problems getting the bitvec type recognized but in the end it was just a missing struct in the function signature. I forgot to remove this one again. https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/27912027_fe7a93ae PS1, Line 49: mi->tmsi > You're saying TLLI, but actually passing a TMSI -- this is not always the same thing. […] gprs_rlcmac_paging_request() is called from gprs_bssgp_pcu.c:gprs_bssgp_pcu_rx_paging_ps(), which calls get_paging_ps_mi() to generate the mi. And this mi is always of type GSM_MI_TYPE_TMSI. So at least in that regard we should be fine. (we might consider to add an OSMO_ASSERT) As far as I am aware use the same the same identifier in TLLI and TMSI even though both could be different. However, after all, we do not do anything different than we did before since the MAC block we generate is also based on the same value. When the confirmation comes back, everything seems to end up in bts.cpp:tlli_from_imm_ass(), where we either use the direct TLLI value or extract the value from the MAC block. Whet confuses me though is that tlli_from_imm_ass() is apparently not able to handle paging_request macblocks even though osmo-bts sends confirmations for those. This is really confusing. Do you have an idea? I am a bit lost here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 12:45:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-pcu[master]: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks

by dexter

Attention is currently required from: jolly, pespin, fixeria. Hello Jenkins Builder, jolly, laforge, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 to look at the new patch set (#2). Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks ...................................................................... gprs_rlcmac: also use direct TLLI PCUIF for paging MAC blocks In the current code we still send PAGING COMMAND MAC blocks via SAPI PCU_IF_SAPI_PCH, which technically belongs to the older PCUIF version (v.10), which we are going to deprecate soon. To give some background information it should be noted that this bug has its root cause in a misconception on how the receiving end should behave when it receives PAGING COMMAND macblocks. It was not clear that PAGING COMMAND and IMMEDIATE ASSIGNMENT (via PCH) require a confirmation by the receiving end. Since osmo-bts uses the old V.10 PCUIF interface we get a confirmation for both message types, but osmo-bsc, which uses the newer V.11 interface will only confirm IMMEDIATE ASSIGNMENT messages, to distinguish between both message types it uses SAPI PCU_IF_SAPI_PCH for PAGING COMMAND and PCU_IF_SAPI_PCH_DT for IMMEDIATE ASSIGNMENT (confirmed). It is not only confusing to use two different SAPIs to access the PCH, but also wrong. In the new PCUIF interface we should only use PCU_IF_SAPI_PCH_DT. A coresponding patch for osmo-bsc is already submitted (see Depends). Depends: osmo-bsc.git I82443f2b402aa2416469c8c50b1c050323ef3b8f Related: OS#5927 Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 --- M src/gprs_rlcmac.c M src/pcu_l1_if.cpp M src/pcu_l1_if.h 3 files changed, 42 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/94/32694/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 ) Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ...................................................................... Patch Set 2: (3 comments) File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/1f2abde3_300a7121 PS2, Line 281: } nonamr; "fr_efr" instead of "noamr"? btw, iiuc dtx is for AMR, so "dtx" and "fr_efr" structs can be put in a union? https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/af560fd6_212fa9b0 PS2, Line 282: uint8_t last_cmr; isn't this AMR specific? I find it a bit confusing that a "noamr" struct is put inside a struct containing amr specific fields. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/d826be65_c66308ac PS2, Line 1315: if (lchan->type == GSM_LCHAN_TCH_F) "switch (lchan->type)" should make this function less cryptic imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 15 May 2023 12:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-pcu[master]: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks

by pespin

Attention is currently required from: jolly, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 ) Change subject: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks ...................................................................... Patch Set 1: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/8a3160af_5e2066d9 PS1, Line 7: gprs_rlcmac: also use direct TLLI PCUIF for paging macblocks not sure what "paging backblocks" means here. https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/363d7246_6fcaa9e7 PS1, Line 28: OS##5927 > only one `#` please Ack File src/gprs_rlcmac.c: https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/23c22d69_b53fcdb5 PS1, Line 20: #include <osmocom/core/bitvec.h> > why adding this header? It is clear this file uses bitved, but maybe it should be added as a separate patch. https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/cf69da90_6e7eb922 PS1, Line 49: mi->tmsi > You're saying TLLI, but actually passing a TMSI -- this is not always the same thing. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I99cfe373fa157cfb32b74c113ad9935347653a71 Gerrit-Change-Number: 32694 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 12:10:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: codec: replace GSM-FR ECU with new implementation

by pespin

Attention is currently required from: falconia, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 ) Change subject: codec: replace GSM-FR ECU with new implementation ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: LGTM without knowing details on the topic. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0200e423ca6165c1313ec9a4effc3f3047f5f032 Gerrit-Change-Number: 32685 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 12:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in libosmocore[master]: codec cosmetic: move old FR ECU code to ecu_fr_old.c

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32711 ) Change subject: codec cosmetic: move old FR ECU code to ecu_fr_old.c ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: +1, but I guess we want to merge this patch together with the next one so that we don't end up with an "old" one without a "new" one in place :) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia169b8bcc6331227a11b78eb7ffca0c7ab838c69 Gerrit-Change-Number: 32711 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 15 May 2023 11:56:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: pcu_sock: fix PCUIF interface (PCH)

by pespin

Attention is currently required from: jolly, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32693 ) Change subject: pcu_sock: fix PCUIF interface (PCH) ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32693/comment/5246f344_14d92fbf PS1, Line 559: return pcu_rx_rr_imm_ass(bts, pag_grp, pch_dt); if this function is only used for PCH, then please rename it to contain "_pch". https://gerrit.osmocom.org/c/osmo-bsc/+/32693/comment/139355b2_e1873f58 PS1, Line 560: return pcu_rx_rr_paging(bts, pag_grp, pch_dt); same here, add _pch to it please. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I82443f2b402aa2416469c8c50b1c050323ef3b8f Gerrit-Change-Number: 32693 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 11:52:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-hlr[master]: Add support for multiple APN profiles for subscriber data

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/7dc4f259_51153baf PS7, Line 9: Previous the HLR sent in the Insert Subscriber Data call only the Previously -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f Gerrit-Change-Number: 32512 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 15 May 2023 11:44:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ci[master]: obs: build_binpkg: ubuntu: use manuals container

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32683 ) Change subject: obs: build_binpkg: ubuntu: use manuals container ...................................................................... obs: build_binpkg: ubuntu: use manuals container Use the optimization of only installing osmo-gsm-manuals-dev and all its dependencies once not only with debian, but also with ubuntu. Change-Id: Ic9fef9f10b4384538e7a73479bf57a9b737a9a55 --- M scripts/obs/build_binpkg.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/scripts/obs/build_binpkg.py b/scripts/obs/build_binpkg.py index 37dc6be..67a4bec 100755 --- a/scripts/obs/build_binpkg.py +++ b/scripts/obs/build_binpkg.py @@ -85,7 +85,7 @@ # Optimization: use docker container with osmo-gsm-manuals-dev already # installed if it is in build depends - if distro.startswith("debian:") \ + if env["PACKAGEFORMAT"] == "deb" \ and lib.srcpkg.requires_osmo_gsm_manuals_dev(args.package): image_type += "_manuals" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9fef9f10b4384538e7a73479bf57a9b737a9a55 Gerrit-Change-Number: 32683 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023