May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-gsm-manuals[master]: VTY references: set git version and date

by osmith

Attention is currently required from: Max, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32689 ) Change subject: VTY references: set git version and date ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I68a8c3893d3c3a3b1bc1aee442a17635b60ac531 Gerrit-Change-Number: 32689 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Max <suraev(a)alumni.ntnu.no> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 13:55:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (include_ipy)

by dexter

Attention is currently required from: markb, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32533 ) Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (include_ipy) ...................................................................... Patch Set 5: (1 comment) File requirements.txt: https://gerrit.osmocom.org/c/pysim/+/32533/comment/117ccc05_43f51d8e PS4, Line 13: packaging > And AFAICS, you are using this module in previous patch, but adding the dependency here. […] Oh 3 places to add dependencies... I can see there are also other packages that were forgotten. (i have fixed this in a follow up patch) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc0e18b002a03ed17933be4d0b4f4e86ad99c26e Gerrit-Change-Number: 32533 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: markb <markboldyrev(a)gmail.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: markb <markboldyrev(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 13:54:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in pysim[master]: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable)

by dexter

Attention is currently required from: osmith, laforge, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32532 ) Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable) ...................................................................... Patch Set 15: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/32532/comment/b27d524d_598eb94a PS8, Line 11: Older versions will ignore the settable_object parameter > incase it matters: you should be able to extend the jenkins build job by running twice in different […] I think I will try this out. We can even do it in the same env just uninstalling+reinstalling the newer cmd2 version. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I38efe4702277ee092a5542d7d659df08cb0adeff Gerrit-Change-Number: 32532 Gerrit-PatchSet: 15 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 13:54:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (include_ipy)

by dexter

Attention is currently required from: markb, fixeria. Hello markb, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/32533 to look at the new patch set (#5). Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (include_ipy) ...................................................................... pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (include_ipy) In version 2.0.0, the use_ipython parameter in the Cmd constructor is renamed to include_ipy. There are still plenty of older cmd2 installations around, so let's work around this using a version check. See also: https://github.com/python-cmd2/cmd2 Commit: 2397280cad072a27a51f5ec1cc64908039d14bd1 Author: Kevin Van Brunt <kmvanbrunt(a)gmail.com> Date: 2021-03-26 18:56:33 This commit is based on pySim gerrit changes: Ifce40410587c85ae932774144b9548b154ee8ad0 I19d28276e73e7024f64ed693c3b5e37c1344c687 Change-Id: Ibc0e18b002a03ed17933be4d0b4f4e86ad99c26e --- M README.md M pySim-shell.py M requirements.txt M setup.py 4 files changed, 32 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/32533/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc0e18b002a03ed17933be4d0b4f4e86ad99c26e Gerrit-Change-Number: 32533 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: markb <markboldyrev(a)gmail.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: markb <markboldyrev(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: setup: add missing pyyaml to setup.py and README.md

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/32717 ) Change subject: setup: add missing pyyaml to setup.py and README.md ...................................................................... setup: add missing pyyaml to setup.py and README.md Change-Id: I1d35f38b17a315dd58e8dd91a27bfa6c2c85905d --- M setup.py 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/17/32717/1 diff --git a/setup.py b/setup.py index 17edad9..930ba15 100644 --- a/setup.py +++ b/setup.py @@ -17,6 +17,7 @@ "construct >= 2.9.51", "bidict", "gsm0338", + "pyyaml >= 5.1" "termcolor", "colorlog", "pycryptodome" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1d35f38b17a315dd58e8dd91a27bfa6c2c85905d Gerrit-Change-Number: 32717 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: requirements.txt: allow cmd2 versions greater than 1.5

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32632 ) Change subject: requirements.txt: allow cmd2 versions greater than 1.5 ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Please also update `setup.py` and `README.md`. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I87702c5250a3660c84458939167bffdca9c06059 Gerrit-Change-Number: 32632 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 13:54:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: requirements.txt: allow cmd2 versions greater than 1.5

by dexter

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/32632 to look at the new patch set (#3). Change subject: requirements.txt: allow cmd2 versions greater than 1.5 ...................................................................... requirements.txt: allow cmd2 versions greater than 1.5 Since we now have fixed the compatibility issues with recent cmd2 versions, we may allow also versions greater than 1.5 in the requirements.txt Change-Id: I87702c5250a3660c84458939167bffdca9c06059 --- M README.md M requirements.txt M setup.py 3 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/32632/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I87702c5250a3660c84458939167bffdca9c06059 Gerrit-Change-Number: 32632 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: README.md: add missing pycryptodome to dependency list

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/32718 ) Change subject: README.md: add missing pycryptodome to dependency list ...................................................................... README.md: add missing pycryptodome to dependency list Change-Id: Ib3cf13a1ad38749ac82d1b36fa32d9c5aba29e1a --- M README.md 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/18/32718/1 diff --git a/README.md b/README.md index da8dffc..555f482 100644 --- a/README.md +++ b/README.md @@ -45,6 +45,7 @@ - pyyaml >= 5.1 - termcolor - colorlog + - pycryptodome - packaging Example for Debian: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib3cf13a1ad38749ac82d1b36fa32d9c5aba29e1a Gerrit-Change-Number: 32718 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in pysim[master]: WIP: apply pylinth on cmd2 1.5 and later versions seperately

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/32719 ) Change subject: WIP: apply pylinth on cmd2 1.5 and later versions seperately ...................................................................... WIP: apply pylinth on cmd2 1.5 and later versions seperately Change-Id: I129b8c90ac80d75e125c81f5d5028fae3e295e6d --- M contrib/jenkins.sh 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/19/32719/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 34f47ea..fa583e1 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -31,6 +31,10 @@ ../tests/pysim-test.sh ;; "pylint") + # Be sure to run pylint with cmd2 version 1.5 so that we can be sure older cmd2 versions + # are still supported + pip uninstall -y cmd2 + pip install cmd2==1.5 # Run pylint to find potential errors # Ignore E1102: not-callable # pySim/filesystem.py: E1102: method is not callable (not-callable) @@ -42,6 +46,14 @@ --disable E0401 \ --enable W0301 \ pySim *.py + # Upgrade cmd2 and run pylint again against a recent version of cmd2, the parameters + # are the same as above + pip install --upgrade cmd2 + python3 -m pylint -j0 --errors-only \ + --disable E1102 \ + --disable E0401 \ + --enable W0301 \ + pySim *.py ;; "docs") rm -rf docs/_build -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I129b8c90ac80d75e125c81f5d5028fae3e295e6d Gerrit-Change-Number: 32719 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: VTY references: set git version and date

by pespin

Attention is currently required from: osmith, Max, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32689 ) Change subject: VTY references: set git version and date ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I68a8c3893d3c3a3b1bc1aee442a17635b60ac531 Gerrit-Change-Number: 32689 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Max <suraev(a)alumni.ntnu.no> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 13:54:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023