May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: another csv example for our usb CCID reader

by steviehs

Attention is currently required from: laforge, steviehs. Hello Jenkins Builder, neels, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/32710 to look at the new patch set (#2). Change subject: another csv example for our usb CCID reader ...................................................................... another csv example for our usb CCID reader Change-Id: Iec17af23ee9c752facb88b4a497b42678af6065d --- M doc/manuals/chapters/remsim-bankd.adoc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/10/32710/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/32710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iec17af23ee9c752facb88b4a497b42678af6065d Gerrit-Change-Number: 32710 Gerrit-PatchSet: 2 Gerrit-Owner: steviehs <sskrodzki(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: steviehs <sskrodzki(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2

by dexter

Attention is currently required from: falconia, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 ) Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 ...................................................................... Patch Set 2: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/1dede61f_a7bb9e35 PS2, Line 8: It might be helpful to mention DTX to make more clear what this is about. (At least I had to dig out the spec and look it up ;-) File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/a7577dab_27938f0f PS2, Line 281: } nonamr; > "fr_efr" instead of "noamr"? […] I would rename it to fr_efr too. As far as I can see this is about DTX, so maybe lets rename it to dtx_fr_efr to make that more clear. We also should rename the dtx sub struct above to dtx_amr in a follow up patch. https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/14c04255_63913940 PS2, Line 282: uint8_t last_cmr; > isn't this AMR specific? I find it a bit confusing that a "noamr" struct is put inside a struct cont […] Its a sub struct "tch", so the location should be fine. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/9f83b698_c275e36f PS2, Line 1334: bool is_nonamr_sid = false; better rename this to is_fr_efr_sid as well. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5 Gerrit-Change-Number: 32714 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 15:21:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in simtrace2[master]: fw: only build the bl with clang

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/32721 ) Change subject: fw: only build the bl with clang ...................................................................... fw: only build the bl with clang -Oz breaks cardem, so just build the bootloader with clang. Closes: OS#6026 Change-Id: Idb9e9a024fb8bfec28ff479c254ea73be0c8ef82 --- M contrib/jenkins.sh 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve; Verified pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index be6bda1..1e2846c 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -38,6 +38,7 @@ for build in $BUILDS; do board=`echo $build | cut -d "/" -f 1` app=`echo $build | cut -d "/" -f 2` + [ "$app" == "dfu" ] && use_clang_for_bl=1 || use_clang_for_bl=0 case "$build" in "owhw/cardem") comb="combined" @@ -57,7 +58,7 @@ esac echo echo "=============== $board / $app START ==============" - PATH="/opt/llvm-arm/bin:$PATH" make USE_CLANG=1 BOARD="$board" APP="$app" $comb + PATH="/opt/llvm-arm/bin:$PATH" make USE_CLANG="$use_clang_for_bl" BOARD="$board" APP="$app" $comb echo "=============== $board / $app RES:$? ==============" done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/32721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Idb9e9a024fb8bfec28ff479c254ea73be0c8ef82 Gerrit-Change-Number: 32721 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in simtrace2[master]: fw: only build the bl with clang

by Hoernchen

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/32721 ) Change subject: fw: only build the bl with clang ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/32721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Idb9e9a024fb8bfec28ff479c254ea73be0c8ef82 Gerrit-Change-Number: 32721 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 15:20:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-hlr[master]: Add support for multiple APN profiles for subscriber data

by neels

Attention is currently required from: laforge, daniel, lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data ...................................................................... Patch Set 7: (9 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/081a1a7a_ff75e2bd PS7, Line 11: This violates the spec spec reference please? let's also mention where exactly: HLR User manual 13.7.3 PDP Info / Access Point Name right? https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/4fb978ea_15d56a20 PS7, Line 17: premium premium? Patchset: PS7: It would be really cool to see all new VTY commands tested in the *.vty transcript test, because that would also be a lot easier to understand and review than just reading the vty.c code. File include/osmocom/hlr/hlr_ps.h: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/b73e89ef_b08aff54 PS7, Line 2: #pragma once https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/d912453f_051fb209 PS7, Line 28: (extra blank line) https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/6c7e8b40_01b242dd PS7, Line 38: (extra blank line) File src/gsup_server.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/66e5226d_83778dd4 PS7, Line 480: if (g_hlr->ps.pdp_profile.enabled) { maybe include these checks somehow? if (g_hlr->ps.pdp_profile.num_pdp_info) OSMO_ASSERT(g_hlr->ps.pdp_profile.num_pdp_infos <= ARRAY_SIZE(g_hlr->ps.pdp_profile.pdp_infos)); Could 'pdp_profile.enabled' be dropped because num_pdp_info == 0 means the same? File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/09328a10_c247f1aa PS5, Line 133: Define a PDP profile set.\n" : "Unique identifier for this PDP profile set.\n") > I think the confusion is that there's only a pdp-profiles "default", but the help for default states […] In the future, this may look like this: DEFUN(cfg_ps_pdp_profiles, cfg_ps_pdp_profiles_cmd, "pdp-profiles (default|NAME)", "Define a PDP profile set.\n" "Define the global default profile.\n" "Define a custom profile with this unique identifier.\n") does that make sense? if yes, i would do this now: DEFUN(cfg_ps_pdp_profiles, cfg_ps_pdp_profiles_cmd, "pdp-profiles default", "Define a PDP profile set.\n" "Define the global default profile.\n") File tests/test_nodes.vty: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/b50ea6ff_bd9aed01 PS7, Line 56: ps please also add tests for the command doc strings, to verify all new docs, like # ps? # ps (ps)# list (ps)# pdp-profiles ? etc and also add tests for write-back like # show running-config ... hlr ... ps pdp-profiles default ... -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f Gerrit-Change-Number: 32512 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 15 May 2023 15:20:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in simtrace2[master]: fw: only build the bl with clang

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/32721 ) Change subject: fw: only build the bl with clang ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/32721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Idb9e9a024fb8bfec28ff479c254ea73be0c8ef82 Gerrit-Change-Number: 32721 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 15:05:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: pcu: Fix Unbound integer operand of unary increment operator.

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32720 ) Change subject: pcu: Fix Unbound integer operand of unary increment operator. ...................................................................... pcu: Fix Unbound integer operand of unary increment operator. Change-Id: I0779feea8e6305b2d8daee68786eee1f8d8f4f29 --- M pcu/GPRS_Components.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index 37dcc97..a3e8c94 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -1205,7 +1205,7 @@ integer max_dummy := -1, template (value) TsTrxBtsNum nr := ts_TsTrxBtsNum) runs on MS_BTS_IFACE_CT return uint32_t { - var integer i; + var integer i := 0; var uint32_t dl_fn; while (true) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0779feea8e6305b2d8daee68786eee1f8d8f4f29 Gerrit-Change-Number: 32720 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in simtrace2[master]: fw: only build the bl with clang

by dexter

Attention is currently required from: Hoernchen. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/32721 ) Change subject: fw: only build the bl with clang ...................................................................... Patch Set 1: Verified+1 Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/simtrace2/+/32721/comment/ef918af4_951d2c54 PS1, Line 9: -Oz breaks cardem, so just build the bootloader with clang. I have tried different optimization levels, none f them worked. Either the resulting binary was too big or it stopped working as described in OS#6026 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/32721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Idb9e9a024fb8bfec28ff479c254ea73be0c8ef82 Gerrit-Change-Number: 32721 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 May 2023 15:03:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in gapk[master]: configure.ac: fix libtool issue with clang and sanitizer

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/32722 ) Change subject: configure.ac: fix libtool issue with clang and sanitizer ...................................................................... configure.ac: fix libtool issue with clang and sanitizer [this fix already exists in most of the other repos] As pointed out at https://github.com/libexpat/libexpat/issues/312 libtool does not play nice with clang sanitizer builds at all. For those builds LD shoud be set to clang too (and LDFLAGS needs the sanitizer flags as well), because the clang compiler driver knows how linking to the sanitizer libs works, but then at a later stage libtool fails to actually produce the shared libraries and the build fails. This is fixed by this patch. Addtionally LD_LIBRARY_PATH has no effect on conftest runs during configure time, so the rpath needs to be set to the asan library path to ensure the configure run does not fail due to a missing asan library, i.e.: SANS='-fsanitize=memory -fsanitize-recover=all -shared-libsan' export CC=clang-10 ASANPATH=$(dirname `$CC -print-file-name=libclang_rt.asan-x86_64.so`) export LDFLAGS="-Wl,-rpath,$ASANPATH $SANS $LDFLAGS" Change-Id: I13fa39e440b5e7d2231454c6f3a1de55e6025399 --- M configure.ac 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Hoernchen: Looks good to me, approved diff --git a/configure.ac b/configure.ac index ad659ca..9a318bb 100644 --- a/configure.ac +++ b/configure.ac @@ -16,6 +16,12 @@ AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_TESTDIR(tests) +dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang +AS_CASE(["$LD"],[*clang*], + [AS_CASE(["${host_os}"], + [*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-soname $wl$soname -o $lib'])]) + + # Options AC_ARG_ENABLE(gsmhr, [AS_HELP_STRING( -- To view, visit https://gerrit.osmocom.org/c/gapk/+/32722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I13fa39e440b5e7d2231454c6f3a1de55e6025399 Gerrit-Change-Number: 32722 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in gapk[master]: configure.ac: fix libtool issue with clang and sanitizer

by Hoernchen

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/32722 ) Change subject: configure.ac: fix libtool issue with clang and sanitizer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/32722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I13fa39e440b5e7d2231454c6f3a1de55e6025399 Gerrit-Change-Number: 32722 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 15 May 2023 15:01:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023