Attention is currently required from: dexter.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32711 )
Change subject: codec cosmetic: move old FR ECU code to ecu_fr_old.c
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> We probably might consider replacing the old implementation rather than having two.
The problem is that the two functions and their associated state structure that form the old implementation are all public API, and it was my understanding that per libosmocore policy, old public APIs are never removed, only marked as deprecated. Even if we decide to make an exception to that policy in the present case, gapk would need to be changed first to not use the old API, as it still does to the present day.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia169b8bcc6331227a11b78eb7ffca0c7ab838c69
Gerrit-Change-Number: 32711
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 15 May 2023 16:41:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32724 )
Change subject: osmo_io: Avoid read of uninitialized variable
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32724
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ica8087c73fc10f01026fdbe692b172ad07fe593d
Gerrit-Change-Number: 32724
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 15 May 2023 16:38:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: falconia.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32711 )
Change subject: codec cosmetic: move old FR ECU code to ecu_fr_old.c
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
We probably might consider replacing the old implementation rather than having two.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32711
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia169b8bcc6331227a11b78eb7ffca0c7ab838c69
Gerrit-Change-Number: 32711
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Mon, 15 May 2023 15:54:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: falconia, laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 )
Change subject: codec: replace GSM-FR ECU with new implementation
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS3:
This looks very clean to me on the first look.
File include/osmocom/codec/ecu.h:
https://gerrit.osmocom.org/c/libosmocore/+/32685/comment/a178ffcb_b5aa3dc7
PS3, Line 9: /* ECU state for GSM-FR - deprecated version only! */
It is not so clear why we keep this. As far as I understand this implementation intends to replace the old one.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0200e423ca6165c1313ec9a4effc3f3047f5f032
Gerrit-Change-Number: 32685
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 15 May 2023 15:52:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/32723 )
Change subject: sbcap: Update asn1c skeleton files
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I did run ttcn3-cbc-tests and everything works as before.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/32723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I385d14d4be308b991a48ce1033087f07bd1f47ea
Gerrit-Change-Number: 32723
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 15 May 2023 15:50:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment