[L] Change in libosmocore[master]: codec: replace GSM-FR ECU with new implementation - gerrit-log

15 May 2023


      Attention is currently required from: falconia, laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32685 )
Change subject: codec: replace GSM-FR ECU with new implementation
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS3: 
This looks very clean to me on the first look.
File include/osmocom/codec/ecu.h:
https://gerrit.osmocom.org/c/libosmocore/+/32685/comment/a178ffcb_b5aa3dc7 
PS3, Line 9: /* ECU state for GSM-FR - deprecated version only! */
It is not so clear why we keep this. As far as I understand this implementation intends to replace the old one.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0200e423ca6165c1313ec9a4effc3f3047f5f032
Gerrit-Change-Number: 32685
Gerrit-PatchSet: 3
Gerrit-Owner: falconia falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: falconia falcon@freecalypso.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Mon, 15 May 2023 15:52:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment