gerrit-log May 2023

gerrit-log@lists.osmocom.org

1 participants
2583 discussions

[XL] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 4: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4fbf1d96_b62a03e9 PS4, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9c93cacd_da59664f PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e92c5a95_23ba3ed7 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0eb06fb5_ce1b8ea4 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ebf4965_f2a97d90 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/59feda5a_f2bebe82 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6edc6cb4_88834268 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/360f3d1c_8811dfb1 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c75afcf2_33721964 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/80acb102_1423f47e PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6a54a941_71318bf4 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/faf46d46_c764395a PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2310f1b3_fe72fa18 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ae525fdb_6912d30c PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eefdafd8_3fb51bac PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d052d502_2e1cf68f PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fb480078_2cae54d2 PS4, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3528f135_b13bdd83 PS4, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/38e65da5_c79916f3 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7ef454d4_eae872d3 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e723fce_0ef659a3 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a1e61a67_a12b0a63 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/13483ef5_1d326262 PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd562331_0e64f37d PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd4d20b5_147c808a PS4, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ac2086c9_d041ca22 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73875d79_aa0bdeb6 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/747bb79b_638a4d37 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/774585b7_1fb66bf5 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56a4af76_5ce37ed4 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/10a120d1_42b720d3 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/353471e4_5d2782d9 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5072f818_054c9481 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/52f671a5_b0f2adde PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6217f3a6_0bc0a137 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/31f569f5_b4e15b5b PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a0af7d61_b215edbc PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ad28d304_e531551b PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b5c0ce2_37f23a3e PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2b571429_974ee52c PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b09c1449_acc39b8a PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/701ea8e7_ef83d0c1 PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78bf1a27_4277d7fb PS4, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bcb85b98_715be946 PS4, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fb3126bf_6b7c81c9 PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c695d6c8_58452231 PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/892be86a_ecf401e1 PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2bd64b65_8587c885 PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/19fdf3d8_6a18f20f PS4, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/670c84fa_438f1406 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9788660e_1d7ee686 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9117a6f2_8af62d6f PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7274dc4f_40434ec9 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56c04f42_1df0c3ff PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9a15a263_f4e09063 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0f20a11f_aa29cd69 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78165ccb_2a6a3346 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9c50e8ae_204abcb4 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf7adc45_b285825a PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36c35f38_c4fa8796 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1e66428c_d49d9352 PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4afe3ccf_5d00ba2c PS4, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5d8a0249_af9b9472 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b60b49dd_2149c184 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c883f6b_09cf8b2e PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d7a27cf5_b0039b59 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f8e6c446_25356e3b PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e788906_d7d4b0b1 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c276b5c3_4eef6db2 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8768caff_c45c9438 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/351b8fe4_bdfa40b6 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2686a46d_ec4e1459 PS4, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7aef8b63_1a5485f1 PS4, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f4e34a2_9a281d80 PS4, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dd617fa5_138816c3 PS4, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e6ad8e1_2f7a45eb PS4, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e162a46_7d4c909c PS4, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/13ab707e_82bd9479 PS4, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b081404a_01439c08 PS4, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5ef8117a_8dd809e3 PS4, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/19e20b68_ed6d5c65 PS4, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ced519d5_478d698e PS4, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d28faf12_2bef6675 PS4, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2f9bfd4d_7e84946b PS4, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5df69878_af3f30ea PS4, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8ea136e3_24b01a83 PS4, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05b27ceb_675833bf PS4, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/33152df2_3738123f PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e3dd9e41_c3379211 PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3cdf7d92_f705a47c PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/479b0a8a_16a31dd6 PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/031d18ac_aa908fa1 PS4, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a5f8227d_361d6c11 PS4, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bda56d09_6a4fb214 PS4, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b16c750d_311f9a70 PS4, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36a254a6_8b238eae PS4, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9ad007b6_d6c13d4a PS4, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b92618bf_dd9bce5e PS4, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/94638253_24b2516e PS4, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9be91819_fbd72cbe PS4, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78db0585_43ebbb24 PS4, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b86b9fc4_af699bf5 PS4, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8a2d0ba7_8c0b31f1 PS4, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/606d60dd_d2210843 PS4, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6e3b9468_e646e08a PS4, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27a3d8ee_298bfb34 PS4, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1be7acb4_dd7eead0 PS4, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f94fcf4e_06c1484d PS4, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d3d3d0b7_22890c01 PS4, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27bf1067_34c36693 PS4, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6a2fb37_79acce43 PS4, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f06f3177_706d8270 PS4, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5cff53fb_f1de6863 PS4, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c067394_0357a5c2 PS4, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d4b519ee_8f54a5c7 PS4, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/98797555_d485b42e PS4, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e6fde1db_7a1a7241 PS4, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f669ca87_a902cbc5 PS4, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89172641_284317e1 PS4, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e56dbe9a_ebc23628 PS4, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/596bb431_d8a88022 PS4, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e812cbba_d986eb03 PS4, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/87500794_cdeaf5c9 PS4, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6874c56a_3df5b5db PS4, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b8e54204_b8f65508 PS4, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9a320431_f1629c6d PS4, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7b5dc9be_b5ab1b7f PS4, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b0b47fbd_8c576497 PS4, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9789060f_25da5874 PS4, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b2109ab2_cd9fa939 PS4, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8394449e_b0bf2638 PS4, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92d78018_c06f3596 PS4, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e8ec74e7_be873f67 PS4, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/24217db1_0d88f8d4 PS4, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1c02f1aa_9dd7b819 PS4, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9a4d52cb_590b9777 PS4, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5af14f8a_7e3b7155 PS4, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4a4a0c76_78c68edf PS4, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/07a71f60_ca5b87d5 PS4, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/60861582_47f5011b PS4, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c8a21ac7_b1b98614 PS4, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d08768fe_2e94fe58 PS4, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d258e704_5f7f5a04 PS4, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a09a3973_f1800b2f PS4, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/81198a1b_cc104c37 PS4, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/15e82e4b_3220a497 PS4, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/14efd6da_684d83cb PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bde487c6_d7419d4f PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2086f792_0e11365f PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f134cdd_1b0b8701 PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a62b7b9c_6580d52a PS4, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/163bfce5_94e49c61 PS4, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/448201bc_7cc3dfd8 PS4, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8a53f8f6_0109094a PS4, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3fdc7ef5_cbe095e7 PS4, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/39735b48_cb672110 PS4, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5d8cf2da_17180cd5 PS4, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3e57d197_3a8f7e3c PS4, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/44a321fa_381b9923 PS4, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/33296e38_1df73684 PS4, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ca54e4f4_f289d1c5 PS4, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5b688ab6_a1c215ad PS4, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c97155d_7139a5c7 PS4, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/647e3c60_bf6c702d PS4, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/40a5e849_fe1f94db PS4, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/57658d33_2ca5d419 PS4, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f53dc83_8b80e44c PS4, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5432aab5_07bf978e PS4, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c1bf5e2c_9b48d018 PS4, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5eacaa05_1ff971dc PS4, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a8147833_4ea6582a PS4, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3414e598_485010b8 PS4, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5773fbd3_c6d63ebf PS4, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8cb8de7c_917597d2 PS4, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2a7693cc_b88a3cdd PS4, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7119df79_47422e43 PS4, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/877f74c6_2e2e2b35 PS4, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0cb45ce5_61ae9008 PS4, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d4ea9f7b_aa940e29 PS4, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c02fb4a5_750b1aa6 PS4, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8df439de_80d23aa6 PS4, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/04b9b8e4_96495a8a PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8d04e2c5_ffd27e09 PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/09761575_60eefb31 PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ac22a3a7_ea564b37 PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/136b7573_44877d2f PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c53286dc_35ef38f8 PS4, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b12fac06_c4f31ccc PS4, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/640c4005_f302dc63 PS4, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b5166b8b_a774fc7e PS4, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/994b8834_3ab71388 PS4, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/14cd5e9d_c8ded4bb PS4, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a238912a_9bf55242 PS4, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eaf99a0a_a246cd92 PS4, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cfda8403_bd2f5c39 PS4, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0619f3b_2918714e PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/46bd8622_1e5a3bfb PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a456af3_9dea9b84 PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e58a8208_96e6c2c8 PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/97747be7_b4d520ed PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b153a55_e6f02657 PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/01e094ff_4371b1d1 PS4, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/af9b0083_be90190b PS4, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e89b6e3c_80c227c8 PS4, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/76f3ca2a_5edd3f1f PS4, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/949a8fbb_e5e9919d PS4, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a931366e_725514f6 PS4, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7ec53ea8_2487ece1 PS4, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e69a0982_bafe9d1f PS4, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/26c6895c_48cb7d7c PS4, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/32a604a4_47bb4f84 PS4, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/20a85d75_095e168a PS4, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1d095736_28897f6e PS4, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/050d07a2_115fb844 PS4, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2b605832_da8eb09a PS4, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/edaceb5c_3070b779 PS4, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f0289b63_438c24e8 PS4, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/991ba12a_2f67e93d PS4, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7627): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d87a6055_15840fb9 PS4, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 14:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

[M] Change in libosmocore[master]: libosmogsm: Allow auth API caller to specify RES length

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33091 to look at the new patch set (#3). Change subject: libosmogsm: Allow auth API caller to specify RES length ...................................................................... libosmogsm: Allow auth API caller to specify RES length There are 3G algorithms which support different lengths of RES values (4, 8, 16 byte). For MILENAGE, we never really had to bother, as the 4-byte RES is simply the first 4 bytes of the 8-byte RES. However, for TUAK, the expected RES length is an input parameter to the Keccak crypto functions, so the result of all parameters (including CK, IK, ...) will be completely different for RES length 4 than RES length 8. So let's permit the caller of the osmocom auth API to specify the requested RES length via the osmo_auth_vector.res_len parameter. For backwards compatibility of callers of the old osmo_auth_gen_vec/ osmo_auth_gen_vec_auts API: Always force the res_len to 8 in this case, which was the hard-coded length before this patch. Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef --- M include/osmocom/crypt/auth.h M src/gsm/auth_core.c M src/gsm/auth_milenage.c M tests/osmo-auc-gen/osmo-auc-gen_test.ok M utils/osmo-auc-gen.c 5 files changed, 87 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/33091/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef Gerrit-Change-Number: 33091 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years

[XL] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33094 to look at the new patch set (#4). Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... libosmogsm: Add support for TUAK authentication algorithm The TUAK algorithm is specified in 3GPP TS 35.231, 232 and 233 and intended as an alternative to MILENAGE. It's based around the cryptographic function of KeccakP1600, which is part of SHA-3. This patch adds support for TUAK to the libosmogsm authentication core API via 'struct osmo_auth_impl'. Unit tests covering the test cases from the 3GPP specification are added (and are all passing). Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d --- A .checkpatch.conf M include/osmocom/crypt/auth.h M src/gsm/Makefile.am M src/gsm/auth_core.c A src/gsm/auth_tuak.c A src/gsm/tuak/KeccakP-1600-3gpp.c A src/gsm/tuak/KeccakP-1600-3gpp.h A src/gsm/tuak/tuak.c A src/gsm/tuak/tuak.h M tests/Makefile.am A tests/auth/tuak_test.c A tests/auth/tuak_test.ok 12 files changed, 1,187 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/33094/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years

[XL] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 3: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ce20b9f8_ef772323 PS3, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/748c59bb_d7be1b20 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8d01c63a_81117a47 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/95514046_f160e960 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/06642345_b61b0994 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0db44d3e_3dfb24f5 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3663c743_c8a2466a PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4ba53dbf_e1b5965b PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4291ed8_a5171e50 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1a58fe50_ed31f461 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f2daf4bd_0162bfa3 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2190d884_e33de024 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e9a73afa_0d0f778c PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/79ec80a0_c413d694 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e425c2e9_c90f1bb2 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf71cea3_49cbbc85 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2075879c_77990bf8 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/26763efe_acb5236f PS3, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2289a167_82d28f7b PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3bba4313_9f02ecf2 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dd3e9c76_6bffacb6 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c575dafb_5b8c70cb PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/693e305c_ee070c2e PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c674d0c6_4db736dd PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d81daa34_8bf8b113 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6d71866e_6b97d53e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/54eb5ee6_5a977a2f PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5296c42f_ca9b987e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3e4d82db_90b7875c PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a2112ffc_c5075151 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f0841add_c9662003 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d229772d_c7004f12 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/348ffd53_cb2c39ca PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2b6201a3_170c1e2c PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8aabae08_e05b3e27 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/524a5298_7f4cb226 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7df4c061_e0e05d37 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0406b5d9_c5b6328e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1516dd28_4979f6a0 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1fa9ec0b_6de3421b PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0c4c989_1fdb062d PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b97e0ebb_1c8434e9 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4926c8f7_f196e1f2 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5e8baea7_c45c4e25 PS3, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/290a2c0c_27b83e71 PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/01d21db2_629d3d73 PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b0a297b_7b4a8efa PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cc442ec3_ec96a88b PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/522b574a_0035f84a PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fe583fad_54e59355 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4340ae0e_81ca9326 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4fe1508_a6e59171 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/158293d7_9ec57c9a PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/566f56d8_0762d193 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/40735d85_6cb42671 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2ebcfa3d_b4056e08 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73f688fd_2d97b578 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5254767d_a7e5915b PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7fb1ebac_cc049aa4 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89b4f977_0c2251da PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b02fd15f_9b3decc2 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/484582b1_13f1a3a3 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1c1aeb79_cdf03b9b PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0cbc3a87_56623a97 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6a752458_4a80b078 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e5d44d72_80c60fb9 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd3a2b25_a9cf8868 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27d981e9_37e5590c PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/80717a8c_2ed6c4a1 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/95e874a9_365335c2 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9046c63f_f7e376ae PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc1a97d1_340138f9 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5ece5727_60e99b60 PS3, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2edc4310_8f8121b5 PS3, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e027587f_021920f3 PS3, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b1f5cff2_1a1524bb PS3, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b3fffc28_01d6b1f2 PS3, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/20ae1865_6bbe8e9e PS3, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6d27a703_5480306c PS3, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c56d9382_ff8ba629 PS3, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b5161f71_76ec241b PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9cf72daf_058d02b3 PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/74d1a8d0_f4e8f77b PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/24ee9d2f_af344c04 PS3, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cb75c622_1e61748c PS3, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51302a14_aca4b675 PS3, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dfba9441_8a7d7542 PS3, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/271742ad_16e0a1f0 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6dd05f66_970f0236 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85c81dd0_984c8a12 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/149f5013_d35539bf PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b522a2fb_814a323e PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/94854510_1d772180 PS3, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89ae2e39_d16fa701 PS3, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bb8a91dd_315740ae PS3, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8a9ff5f9_d81a40c1 PS3, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/636ffaf7_5f6a857c PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dcfe5574_ed91d0ab PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36976244_2a3f5a7d PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/beb7878a_0206cf4b PS3, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/990aec8e_07df7c6c PS3, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d6f7790f_f633d4f5 PS3, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d66b6c16_430c5aa8 PS3, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c32933fa_d20b03d7 PS3, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8fd8487e_13e15a18 PS3, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2de93f7a_0efd3b03 PS3, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa3048a1_7e0474d3 PS3, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/99408108_e5cf9e6a PS3, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ed671200_58f27274 PS3, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78f1a705_34d3a1dc PS3, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b88a33d_d7f899db PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2f1f1af3_553accf3 PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/619ec7b5_e4f7dc01 PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/87a044dc_b82c0db8 PS3, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8d6a0662_30dd43e2 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92a03089_6ae19636 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f762ec1_34dd0625 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6be39f61_d338d67d PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4dac51ce_8dd12616 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f0601cf_15db1382 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f3ed77e_5730f6f2 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3e2a6194_d3812cbc PS3, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8ffeb7a7_db301145 PS3, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ddc0397c_7255b61e PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6fd9269f_2ea495d8 PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e060a9e6_4930b538 PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92ee6d7b_8cfe3bcb PS3, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0323d9ce_068b18df PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/368c323f_ab883337 PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9f326a6e_1edc8883 PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0fadd573_ca405dcb PS3, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1e59ee07_150f3ca4 PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f01ff476_b93d6fae PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fbe56d3_5f2ce6c7 PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a21e95c2_6685533c PS3, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f25226d4_8a9e9352 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/94f5cc4e_f9fff415 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ad873d2_02bb12b9 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8126b370_f9f09b43 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5bcb408d_6ba3dbc1 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc6d1881_ac16ce98 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f7af1db1_2d4add11 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7433de2f_c350abc4 PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/146fdfd7_6b7102b2 PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9ae5b900_648adeda PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da31daec_6b174bbe PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c6b0ed87_7e9e6cd2 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e85b15be_6ea518c0 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bbfac5a0_7fc3480d PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/586dc61c_3285c983 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d5fcc0fb_bc571515 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a79a2f6_5f56d168 PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cd979f60_6f1c4557 PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/257c51ed_2e5cf36b PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/04eb058c_e452ef4b PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f15da48_1517e492 PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0f1f4bd6_3b5709ba PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/292aac30_dbb23013 PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62d72607_5c080b8a PS3, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c783976e_ab6bd6c0 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a83dd37e_f47b1069 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73f9fef9_2b988fa5 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c04c19fb_01b2302b PS3, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2a090a97_62a737d7 PS3, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/948f51db_7b76d5d7 PS3, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/134eee35_959131ee PS3, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2c786360_637a0ace PS3, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c74feb92_6ab679c7 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/45cd78a7_fec505d1 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/02a38e47_469723bb PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/be24c739_1edc6513 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bb182216_7d624d38 PS3, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cb344173_2e89caad PS3, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b39c2f3_ddfe92dd PS3, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a91e1735_e07e6927 PS3, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4a396235_b04ab51d PS3, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f513c9d6_bd789d6c PS3, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85f8789a_aef82817 PS3, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/58b08459_3a7bbc43 PS3, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/febf481f_8ccc1cae PS3, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/52984188_f71d7c23 PS3, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e633b93_677e9bf5 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d37bbdb3_3e0cf3e6 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88f997e4_8f53b012 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6327698_2977bc04 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a0c74d97_728864ae PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0b22e178_43b4da5f PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/111929ca_0b08799f PS3, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/79b8bec5_de8772c5 PS3, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/834fb1d9_2b2ba057 PS3, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/954d37f4_14bc9a01 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3f34f8b4_a93db4e9 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6469555f_3dc14f45 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/34d931d8_67d0bb40 PS3, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/02d14f36_1b080792 PS3, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8dfc8cb7_b81f2f75 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/989cef25_0f909383 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e990ba0_3aabe9ac PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fca4fe78_54e93de3 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/925e43a9_dbcda94d PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4575adfa_86ccd7fc PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc8be709_c38864c9 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/671f45a1_9f521cf4 PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a9a85c04_5b0d1735 PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b9691cd_1ff7f5bb PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d847ddf_b3a27b7f PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/71110cad_d06efa9f PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6183f4a5_2f80ed29 PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e7429dc2_3d8a7f9c PS3, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fadebb1_96137699 PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d9d0272f_ec71f07a PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d99e7df9_9d7b08fe PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0ba0f6ca_58928afd PS3, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/296d7a1e_a3d47cb1 PS3, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/41fad1ae_fb37b3f9 PS3, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eb490056_44f513ce PS3, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/63630e2a_824dc03e PS3, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd103c37_60c1bc98 PS3, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cacf47a7_25fdba5d PS3, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 14:44:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

[XL] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33094 to look at the new patch set (#3). Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... libosmogsm: Add support for TUAK authentication algorithm The TUAK algorithm is specified in 3GPP TS 35.231, 232 and 233 and intended as an alternative to MILENAGE. It's based around the cryptographic function of KeccakP1600, which is part of SHA-3. This patch adds support for TUAK to the libosmogsm authentication core API via 'struct osmo_auth_impl'. Unit tests covering the test cases from the 3GPP specification are added (and are all passing). Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d --- A .checkpatch.conf M include/osmocom/crypt/auth.h M src/gsm/Makefile.am M src/gsm/auth_core.c A src/gsm/auth_tuak.c A src/gsm/tuak/KeccakP-1600-3gpp.c A src/gsm/tuak/KeccakP-1600-3gpp.h A src/gsm/tuak/tuak.c A src/gsm/tuak/tuak.h M tests/Makefile.am A tests/auth/tuak_test.c A tests/auth/tuak_test.ok 12 files changed, 1,187 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/33094/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years

[L] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 2: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/240e1648_80d6ae70 PS2, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88f84fef_6fea8600 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/82c84ca3_bd0b3afc PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2fc80263_ebcf6dc8 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aba3f727_b7a6aa46 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f817d79b_b37b3976 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05604d55_7dc35eaa PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/81c7e9d5_7b538030 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b0393e6_c1e3897b PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/72326f39_90400c47 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e09344a_30d0e3ea PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a6bda17_8c146ec5 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/432695b0_4e6c1144 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7b6405cb_10580edc PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b1704f4_adbe0df9 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/61e9fe60_6a26f3fe PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/70d3284c_0310c744 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0cb6843d_95bd5de3 PS2, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56e0ccb6_a48cbc8f PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d9434946_cee1e73b PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f7b7332d_87e50212 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9dfa1695_7e7d4d96 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b9c4c0b3_ac183f4d PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/75bc208a_2252c219 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a0a58572_f83f0b85 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d5342bf_cb7edae5 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8e2d3cb3_c7584ef1 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f626e4d6_73f5ce8b PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aec51ffb_4251917e PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6b4420d9_47151bfe PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9dec71f7_13444901 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8349a792_38616d85 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d6ae162d_9ab0b9f1 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05acfde2_2ea9c090 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c897d60b_4b469026 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd3e75d8_4da0e934 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b01175ce_2f5cdf4a PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/be97d1cb_0e367963 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/29236ec7_ce8d9898 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc0c0b45_9f5ad072 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/679955aa_12a5ee48 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1d8baa2c_73af7bb2 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/48896748_28c9a452 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2632acac_c1ea7dd2 PS2, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d634dff2_9e80f113 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc5de524_3926a8ad PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2e4e4e1b_9d96c4c3 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c8f3c6e3_31f4b268 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6591089_dda267da PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1f6ef3c6_8212c12e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/07429942_0ea1cb9c PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/244356a6_5daca31d PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d0992ea_f4c7243c PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8b027066_0ca57eb8 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f1307598_36db0dfd PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/826b37eb_e8d90d48 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/59d40adf_b71db00e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d32ecceb_25d9803a PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3cc786f8_49850b8b PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a347d567_f132c05e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85400000_9b839de1 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/99aa6ed9_20f0555e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/efacbe8f_06ca4e75 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cddf556e_cb94809b PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/30d4e04b_0e05bc96 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d0490c03_4179ecf3 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e06eab41_459bfe78 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a827a937_667c0f46 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/efb6b032_bd3d0b74 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/221704d6_e4cc3cef PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1c72a60d_a7a22708 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6d0f600_32118092 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd6800f9_bfe7343d PS2, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/caba35a1_cbb7958f PS2, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17eaafe3_2e5a6f27 PS2, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89d10163_5330d3cd PS2, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3597b357_96754025 PS2, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4de6b36_d1c71848 PS2, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aac082f8_baf9dd07 PS2, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/943ef6f6_3d3488fb PS2, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b7992d12_b35b5211 PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6e813f33_2be9bc0e PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7b63f0ab_3d0b98ef PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8ad13732_0df446df PS2, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/047ec174_82207601 PS2, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c833b79_e55dd121 PS2, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e4d7699_53f3b02f PS2, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e182331b_99e0dfcf PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a8714010_13d016ae PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c7afd48b_9bcc68b7 PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/01f91f89_8c3ec5b0 PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/84786177_0f201b7d PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7e2921a3_079b15bc PS2, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88d0ab86_08fa84a5 PS2, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0240b367_f4724725 PS2, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4df932f9_4bc489f4 PS2, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e780e10_7178e33d PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/085c54d9_dc2e5fe9 PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/702c783b_22651b3a PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92820bdf_d044d057 PS2, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/091ac23b_42ad225d PS2, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3a81f12e_c23996f3 PS2, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5470eb05_53d71ac3 PS2, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da422303_6930924f PS2, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/526e0a00_8f07601e PS2, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5f7ddc05_83aab3c9 PS2, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3304e8d2_24425ed7 PS2, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a651cb9e_38bffca0 PS2, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36caf501_622bcb37 PS2, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a8db551c_daaf0015 PS2, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ff6683e6_fce25677 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7961f5eb_45794224 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2d09fd3f_522b7d53 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/09c72d54_cd8303d8 PS2, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fda2215c_f836875b PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b45ab20d_60cb12f4 PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b97d047f_6ee75feb PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fbf47e70_8cd98d41 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/daf0dea3_9c834db4 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4abe4ada_6c12696e PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/df93ea00_d60b6029 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aa50bafc_091d7410 PS2, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5b3a09ca_26d659d9 PS2, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ab8d1e07_01d02232 PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/957a79d6_8d4364fa PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/db8739ac_f82e16eb PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fde7574e_3a4ec8d2 PS2, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/574b6fa6_c25ef6eb PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/424c4f4a_43c7a112 PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1548ee5a_41f48ad4 PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/697c2f10_705bf7e6 PS2, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa9d47ce_3cf070d8 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a2570590_24c06705 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/750eb819_adfa55a4 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/35960919_b3e25af4 PS2, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78630f90_9c284532 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf1e3027_c7306723 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e178b87_2eca2e18 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c5bf1d6b_d5437783 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da1dc8fa_6a2d2450 PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/87d272a7_37e6a07a PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cdf1589a_dd45289c PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c41d7469_b0b0f57a PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc6f338e_dcf7c303 PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f5098a61_3252776d PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cd870857_4983065e PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e8ff8840_c6e26d15 PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3daa75cd_9646875d PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a61ec466_9c8eb85b PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c2004305_5a86750d PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ea41fa3e_aa5d85ee PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3bc0fe82_8bcc6811 PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e38a8ae6_b2ac2811 PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f0fa8ab_eee23cff PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/de78d5b0_069004f7 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fdc7c8e7_55cee436 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b4e598b5_871f6936 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5c18ab85_dd7978c7 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0e0bc769_9ed9c8c0 PS2, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/06d566e4_89534802 PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5ca87c29_d96f3a1c PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ba2daa3_039a309c PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a06123a8_3127bf6e PS2, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/09df563e_101f193a PS2, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b501487d_47f6ea63 PS2, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a67502c6_fd3d13b0 PS2, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/af4bc274_8fa99ffb PS2, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3b47518a_3d132d8d PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/52118f3f_c268a861 PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/208b1348_fdd9b57c PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b16f79c9_b3012c59 PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b72f34e7_342c8ce8 PS2, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3af63cad_852d5bb1 PS2, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c886833_3f22b9c0 PS2, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/84f26758_cb6f166c PS2, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fe3ff5e_29319aa0 PS2, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/23ed2218_32f0d3e6 PS2, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a4b28f9_f125e311 PS2, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/488744ac_7484184d PS2, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b380ede9_2e9d46ed PS2, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fcd26dd0_ad4832b0 PS2, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3f10db5b_2ae562ab PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f45e8094_03c0617d PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/74ac93b9_bfea5aa9 PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0be470b0_d81f686d PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1830c304_4c204ece PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/186787a5_8fde6515 PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ba4a7986_b13a66e4 PS2, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1336faa7_d537c54c PS2, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e9cc6352_2f2feee2 PS2, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a86f4d0b_5ec2e333 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b45c3d63_95aacf93 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b8314fe1_cde269a9 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ee460312_b5da22c2 PS2, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa9c4c4e_4c344051 PS2, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0a2f4171_9104aa0f PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9df74ea4_ca9e7eab PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b93f2ff_fbcc5b67 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ca0a3dbd_68af1569 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/211b015d_d31895f0 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e4a1f5c5_9a75c4f6 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/42ff7897_fd75c7f1 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/830f4ad7_8109547f PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b8c223a_1c438e56 PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ba4620b_28d7878a PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ac343b50_98e78896 PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/75805e31_6bba407c PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/50218401_587b5f19 PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5cb226f7_075ca495 PS2, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ff3004e7_ed4ad036 PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd0a0803_857e4fab PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/634e65ef_508639cc PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/16a1190c_7c3ee6c9 PS2, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fe8eb0c3_3e78e3f9 PS2, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6a60f333_68afe68c PS2, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/033829a8_28d52880 PS2, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a27e6507_f5aa40b0 PS2, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/24c01036_9097dd69 PS2, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5e8eac81_d27430c5 PS2, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 14:39:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

[M] Change in libosmocore[master]: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33090 ) Change subject: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API ...................................................................... Patch Set 2: (1 comment) File utils/osmo-auc-gen.c: https://gerrit.osmocom.org/c/libosmocore/+/33090/comment/2c6d3b90_6258c841 PS1, Line 117: /* 3GPP TS 33.102 6.3.7: "The authentication key (K) shall have a length of 128 bits or 256 bits." */ > thanks. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29 Gerrit-Change-Number: 33090 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 14:39:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years

[L] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33094 to look at the new patch set (#2). Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... libosmogsm: Add support for TUAK authentication algorithm The TUAK algorithm is specified in 3GPP TS 35.231, 232 and 233 and intended as an alternative to MILENAGE. It's based around the cryptographic function of KeccakP1600, which is part of SHA-3. This patch adds support for TUAK to the libosmogsm authentication core API via 'struct osmo_auth_impl'. Unit tests covering the test cases from the 3GPP specification are added (and are all passing). Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d --- A .checkpatch.conf M include/osmocom/crypt/auth.h M src/gsm/Makefile.am M src/gsm/auth_core.c A src/gsm/auth_tuak.c A src/gsm/tuak/KeccakP-1600-3gpp.c A src/gsm/tuak/KeccakP-1600-3gpp.h A src/gsm/tuak/tuak.c A src/gsm/tuak/tuak.h M tests/Makefile.am A tests/auth/tuak_test.ok 11 files changed, 878 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/33094/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years

[M] Change in libosmocore[master]: libosmogsm: Support authentication with 256-bit K and/or OP/OPc

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33087 to look at the new patch set (#2). Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... libosmogsm: Support authentication with 256-bit K and/or OP/OPc 3GPP TS 33.102 Section 6.3.7 states that K can be 128 or 256 bits, while our 'struct osmo_sub_auth_data' had a fixed-size 128bit field. This means we cannot use our auth_core for algorithms with larger key sizes, such as TUAK. Let's introduce osmo_sub_auth_data2 for larger (and variable) sized K and OP[c]. K and OP[c] can even have diffeent sizes in TUAK, where OP[c] is always 256bit, but K can bei 128 or 256 bits. So we need separate length fields for K and OP[c]. I'm adding backwards-compatibility API wrappers, so old applications just continue to work as they always did. However, I'm not adding compatibility wrappers for the plug-in API that can be used to register additional authentication implementations at runtime. We don't know of any user of that API outside of libosmocore, so the function signatures of the 'struct osmo_auth_impl' are modified in an incompatible way. Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df --- M include/osmocom/crypt/auth.h M src/gsm/auth_comp128v1.c M src/gsm/auth_comp128v23.c M src/gsm/auth_core.c M src/gsm/auth_milenage.c M src/gsm/auth_xor.c M src/gsm/auth_xor_2g.c M src/gsm/libosmogsm.map 8 files changed, 180 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/33087/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years

[M] Change in libosmocore[master]: libosmogsm: Allow auth API caller to specify RES length

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33091 to look at the new patch set (#2). Change subject: libosmogsm: Allow auth API caller to specify RES length ...................................................................... libosmogsm: Allow auth API caller to specify RES length There are 3G algorithms which support different lengths of RES values (4, 8, 16 byte). For MILENAGE, we never really had to bother, as the 4-byte RES is simply the first 4 bytes of the 8-byte RES. However, for TUAK, the expected RES length is an input parameter to the Keccak crypto functions, so the result of all parameters (including CK, IK, ...) will be completely different for RES length 4 than RES length 8. So let's permit the caller of the osmocom auth API to specify the requested RES length via the osmo_auth_vector.res_len parameter. For backwards compatibility of callers of the old osmo_auth_gen_vec/ osmo_auth_gen_vec_auts API: Always force the res_len to 8 in this case, which was the hard-coded length before this patch. Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef --- M include/osmocom/crypt/auth.h M src/gsm/auth_core.c M src/gsm/auth_milenage.c M tests/osmo-auc-gen/osmo-auc-gen_test.ok M utils/osmo-auc-gen.c 5 files changed, 83 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/33091/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef Gerrit-Change-Number: 33091 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years

Jump to page:

2025

2024

2023

2022

gerrit-log May 2023