Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 )
Change subject: libosmogsm: Add support for TUAK authentication algorithm
......................................................................
Patch Set 5:
(3 comments)
File include/osmocom/crypt/auth.h:
https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa72d751_4543c21f
PS5, Line 36: OSMO_AUTH_ALG_TUAK,
update TODO-RELEASE (new symbols).
File src/gsm/auth_tuak.c:
https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/305fe972_3d40eceb
PS5, Line 45: } else
if {} else {}.
Actually, you can drop the else (early return in if).
File tests/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/30e2d4f4_9d4946f8
PS5, Line 401: auth/milenage_test.ok \
this looks wrong?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d
Gerrit-Change-Number: 33094
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 May 2023 15:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33092 )
Change subject: libosmogsm: Factor out the C2 derivation function
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33092
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4
Gerrit-Change-Number: 33092
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 May 2023 15:22:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33091 )
Change subject: libosmogsm: Allow auth API caller to specify RES length
......................................................................
Patch Set 3:
(2 comments)
File src/gsm/auth_core.c:
https://gerrit.osmocom.org/c/libosmocore/+/33091/comment/c9cd087d_ac271639
PS3, Line 224: if (aud->type == OSMO_AUTH_TYPE_UMTS) {
I think this should go inside auth_data2auth_data2(), since v2 users are expected to set it always.
https://gerrit.osmocom.org/c/libosmocore/+/33091/comment/e4dc52cf_d4044b0a
PS3, Line 301: if (aud->type == OSMO_AUTH_TYPE_UMTS) {
Add to auth_data2auth_data2, you can drop it from here.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33091
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef
Gerrit-Change-Number: 33091
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 May 2023 15:20:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33090 )
Change subject: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33090
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29
Gerrit-Change-Number: 33090
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 May 2023 15:16:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/33094
to look at the new patch set (#5).
Change subject: libosmogsm: Add support for TUAK authentication algorithm
......................................................................
libosmogsm: Add support for TUAK authentication algorithm
The TUAK algorithm is specified in 3GPP TS 35.231, 232 and 233 and
intended as an alternative to MILENAGE. It's based around the
cryptographic function of KeccakP1600, which is part of SHA-3.
This patch adds support for TUAK to the libosmogsm authentication
core API via 'struct osmo_auth_impl'.
Unit tests covering the test cases from the 3GPP specification are added
(and are all passing).
Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d
---
A .checkpatch.conf
M include/osmocom/crypt/auth.h
M src/gsm/Makefile.am
M src/gsm/auth_core.c
A src/gsm/auth_tuak.c
A src/gsm/tuak/KeccakP-1600-3gpp.c
A src/gsm/tuak/KeccakP-1600-3gpp.h
A src/gsm/tuak/tuak.c
A src/gsm/tuak/tuak.h
M tests/Makefile.am
A tests/auth/tuak_test.c
A tests/auth/tuak_test.ok
12 files changed, 1,187 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/33094/5
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d
Gerrit-Change-Number: 33094
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
