Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32403 )
Change subject: Move resource allocation outside of tbf allocation
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32403/comment/0d40371e_07938086
PS2, Line 1150:
> missing " and ", multiple times in this patchset for the same comment
Done
File src/tbf.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/32403/comment/a07e9155_16cd4fc3
PS2, Line 582: #if 0
> why keep this commented out code at all?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2856c946cb62d6e5372a1099b60e5f3456eb8fd4
Gerrit-Change-Number: 32403
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Apr 2023 11:26:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 )
Change subject: Move out of alloc_algo code modifying the data model
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20
Gerrit-Change-Number: 32399
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Apr 2023 11:25:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith, fixeria.
Hello osmith, Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32399
to look at the new patch set (#8).
Change subject: Move out of alloc_algo code modifying the data model
......................................................................
Move out of alloc_algo code modifying the data model
This way the alloc_algo() becomes idempotent, simplifying implementation
of new alloc_algos as well as rolling back if allocation fails (for
instance because some resource is exhausted at the time).
For now the code applying the results is moved to tbf::alloc_algo(), but
it will eventually get out of tbf code, so that the MS object is
responsible for running it. As a result, there's no even need to create
TBF object before trying to allocate resources, which will help furher in
rollback operations described above.
Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20
---
M src/alloc_algo.cpp
M src/alloc_algo.h
M src/gprs_pcu.h
M src/tbf.cpp
M src/tbf.h
M src/tbf_dl.cpp
M src/tbf_dl.h
M src/tbf_ul.cpp
M src/tbf_ul.h
M tests/tbf/TbfTest.err
M tests/ulc/PdchUlcTest.cpp
11 files changed, 393 insertions(+), 375 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/99/32399/8
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32399
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5ffd00f5f80bde4b73b78db44896f65e70e12b20
Gerrit-Change-Number: 32399
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-pcu/+/32403
to look at the new patch set (#3).
Change subject: Move resource allocation outside of tbf allocation
......................................................................
Move resource allocation outside of tbf allocation
This patch finally decouples TBF allocation from resource allocation.
This will allow in the future reserving resources without having to
require a TBF object to exist.
Change-Id: I2856c946cb62d6e5372a1099b60e5f3456eb8fd4
---
M src/gprs_ms.c
M src/tbf.cpp
M src/tbf.h
M src/tbf_dl.cpp
M src/tbf_dl.h
M src/tbf_ul.cpp
M src/tbf_ul.h
M tests/Makefile.am
M tests/alloc/AllocTest.cpp
M tests/alloc/AllocTest.err
M tests/app_info/AppInfoTest.cpp
M tests/app_info/AppInfoTest.err
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
M tests/types/TypesTest.cpp
M tests/types/TypesTest.err
M tests/ulc/PdchUlcTest.cpp
M tests/ulc/PdchUlcTest.err
18 files changed, 25,215 insertions(+), 1,476 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/03/32403/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2856c946cb62d6e5372a1099b60e5f3456eb8fd4
Gerrit-Change-Number: 32403
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset