Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32507 )
Change subject: gmm, rlcmac: Properly handle P-TMSI vs TLLI
......................................................................
Patch Set 3:
(6 comments)
File include/osmocom/gprs/gmm/gmm_prim.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/8925e617_0463120e
PS2, Line 159: none
> not anymore?
Done
File include/osmocom/gprs/rlcmac/rlcmac_prim.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/3ac47cc4_a005f298
PS2, Line 82: none
> not anymore?
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/99e3b6c7_efdae09b
PS2, Line 195: uint32_t old_tlli, uint32_t new_tlli);
> This is one of the reasons why I don't like that there is no generic prim alloc function: once we ha […]
You would break ABI anyway if you add more fields to the struct.
File src/gmm/gmm.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/43c4aee9_2e83c261
PS2, Line 260: goto restart
> If this was not your patch, I would expect you to be the first one to comment here and say that `do […]
I took some code from osmo-sgsn allocating random PTMSI as a base, that's why. I'll rework it.
File src/gmm/gmm_prim.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/3743ee5a_d73dd8f8
PS2, Line 420: gmme = gprs_gmm_gmme_find_or_create_by_ptmsi_imsi(gmm_prim->gmmsm.establish_req.ptmsi,
> no `OSMO_ASSERT` like above?
Done
File tests/gmm/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32507/comment/a34a7e8f_b86289f8
PS2, Line 36: $(NULL)
> " No newline at end of right file. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32507
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I44c95b3bc973b9dfcc79daf6b529fd2826f574e8
Gerrit-Change-Number: 32507
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Apr 2023 12:29:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
