April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: hnbgw_mgw_setup: use mgcp_client_pool_empty()
by pespin 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32208 ) Change subject: hnbgw_mgw_setup: use mgcp_client_pool_empty() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Icf3f3f0524c9d27f645c68851aaf9c6f33842927 Gerrit-Change-Number: 32208 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Apr 2023 14:33:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: msc_mgw_setup: use mgcp_client_pool_empty()
by pespin 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32206 ) Change subject: msc_mgw_setup: use mgcp_client_pool_empty() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I44e7b2723d801ceb03aaa2e5546802b4eb56b3c3 Gerrit-Change-Number: 32206 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Apr 2023 14:33:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: bsc_mgw_setup: use mgcp_client_pool_empty()
by pespin 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32207 ) Change subject: bsc_mgw_setup: use mgcp_client_pool_empty() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3a8418fb5841c71049ec91439143e1fe5553ed40 Gerrit-Change-Number: 32207 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Apr 2023 14:33:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: hnbgw_mgw_setup: use mgcp_client_pool_empty()
by osmith 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32208 to look at the new patch set (#3). Change subject: hnbgw_mgw_setup: use mgcp_client_pool_empty() ...................................................................... hnbgw_mgw_setup: use mgcp_client_pool_empty() Don't fall back to the legacy config if the pool is configured but no connection to any pool member can be established. Depends: osmo-mgw I009483ac9dfd6627e414f14d43b89f40ea4644db Related: OS#5993 Change-Id: Icf3f3f0524c9d27f645c68851aaf9c6f33842927 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw.c 2 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/08/32208/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Icf3f3f0524c9d27f645c68851aaf9c6f33842927 Gerrit-Change-Number: 32208 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: bsc_mgw_setup: use mgcp_client_pool_empty()
by osmith 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32207 to look at the new patch set (#3). Change subject: bsc_mgw_setup: use mgcp_client_pool_empty() ...................................................................... bsc_mgw_setup: use mgcp_client_pool_empty() Don't fall back to the legacy config if the pool is configured but no connection to any pool member can be established. Depends: osmo-mgw I009483ac9dfd6627e414f14d43b89f40ea4644db Related: OS#5993 Change-Id: I3a8418fb5841c71049ec91439143e1fe5553ed40 --- M TODO-RELEASE M src/osmo-bsc/osmo_bsc_main.c 2 files changed, 22 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/32207/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3a8418fb5841c71049ec91439143e1fe5553ed40 Gerrit-Change-Number: 32207 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: msc_mgw_setup: use mgcp_client_pool_empty()
by osmith 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/32206 to look at the new patch set (#4). Change subject: msc_mgw_setup: use mgcp_client_pool_empty() ...................................................................... msc_mgw_setup: use mgcp_client_pool_empty() Don't fall back to the legacy config if the pool is configured but no connection to any pool member can be established. Depends: osmo-mgw I009483ac9dfd6627e414f14d43b89f40ea4644db Related: OS#5993 Change-Id: I44e7b2723d801ceb03aaa2e5546802b4eb56b3c3 --- M TODO-RELEASE M src/osmo-msc/msc_main.c 2 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/32206/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I44e7b2723d801ceb03aaa2e5546802b4eb56b3c3 Gerrit-Change-Number: 32206 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: msc_mgw_setup: use mgcp_client_pool_empty()
by pespin 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32206 ) Change subject: msc_mgw_setup: use mgcp_client_pool_empty() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I44e7b2723d801ceb03aaa2e5546802b4eb56b3c3 Gerrit-Change-Number: 32206 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Apr 2023 14:32:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: msc_mgw_setup: use mgcp_client_pool_empty()
by osmith 04 Apr '23

04 Apr '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32206 ) Change subject: msc_mgw_setup: use mgcp_client_pool_empty() ...................................................................... Patch Set 2: (1 comment) File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/32206/comment/d58c8d84_f0effe15 PS2, Line 565: if (pool_members_initalized) { > Can you perhaps now change this to have the error as early termination? it's way clearer imho since […] agreed, this is more readable. thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I44e7b2723d801ceb03aaa2e5546802b4eb56b3c3 Gerrit-Change-Number: 32206 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Apr 2023 14:08:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: hnbgw_mgw_setup: use mgcp_client_pool_empty()
by osmith 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32208 to look at the new patch set (#2). Change subject: hnbgw_mgw_setup: use mgcp_client_pool_empty() ...................................................................... hnbgw_mgw_setup: use mgcp_client_pool_empty() Don't fall back to the legacy config if the pool is configured but no connection to any pool member can be established. Depends: osmo-mgw I009483ac9dfd6627e414f14d43b89f40ea4644db Related: OS#5993 Change-Id: Icf3f3f0524c9d27f645c68851aaf9c6f33842927 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw.c 2 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/08/32208/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Icf3f3f0524c9d27f645c68851aaf9c6f33842927 Gerrit-Change-Number: 32208 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: bsc_mgw_setup: use mgcp_client_pool_empty()
by osmith 04 Apr '23

04 Apr '23

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/32207 to look at the new patch set (#2). Change subject: bsc_mgw_setup: use mgcp_client_pool_empty() ...................................................................... bsc_mgw_setup: use mgcp_client_pool_empty() Don't fall back to the legacy config if the pool is configured but no connection to any pool member can be established. Depends: osmo-mgw I009483ac9dfd6627e414f14d43b89f40ea4644db Related: OS#5993 Change-Id: I3a8418fb5841c71049ec91439143e1fe5553ed40 --- M TODO-RELEASE M src/osmo-bsc/osmo_bsc_main.c 2 files changed, 22 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/32207/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3a8418fb5841c71049ec91439143e1fe5553ed40 Gerrit-Change-Number: 32207 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0