April 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: bsc: add TC_mscpool_sccp_n_pcstate_detaches_msc
by pespin 05 Apr '23

05 Apr '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32216 ) Change subject: bsc: add TC_mscpool_sccp_n_pcstate_detaches_msc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: you can merge when you fix the expectesd-results.xml reported by fixeria. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1aea4e33230d6a685b72ea5ba20dd9c7d265d44 Gerrit-Change-Number: 32216 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-bts[master]: WIP: Introduce NM FSM for GPRS NSE object
by pespin 05 Apr '23

05 Apr '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32213 ) Change subject: WIP: Introduce NM FSM for GPRS NSE object ...................................................................... Patch Set 1: (1 comment) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32213/comment/5ddbc628_e77407f4 PS1, Line 1467: if (rc < 0) > Maybe check `!= 0` instead? `NM_NACK_OBJINST_UNKN` is not negative. ACK good catch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I01eadc63214a2eb5e1bce455c7e5b62bd41905ea Gerrit-Change-Number: 32213 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: NM: NACK received OML OPSTART if no attributes were set beforehand
by pespin 05 Apr '23

05 Apr '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32212 ) Change subject: NM: NACK received OML OPSTART if no attributes were set beforehand ...................................................................... Patch Set 2: (2 comments) File src/common/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32212/comment/ff0b83d1_8a8f0b85 PS2, Line 139: SITE_MGR > You meant BASEBAND TRANSCEIVER here? […] as per TS 12.21 there may not be, but extensions can still be added. that's the case for ipa in site_mgr (we never implemented them in osmo-bts/bsc oursleves so far afacit). File src/common/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32212/comment/8ed2539b_ffd3562f PS2, Line 103: SITE_MGR > Are there any attributes for it in the OML spec? […] See my other comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I771ecc2f60873a3549e8a07a2e57c7948dfc993e Gerrit-Change-Number: 32212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:21:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: nm: Drop NM_EV_SETATTR_{ACK/NACK}
by pespin 05 Apr '23

05 Apr '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32196 ) Change subject: nm: Drop NM_EV_SETATTR_{ACK/NACK} ...................................................................... Patch Set 3: (3 comments) File src/osmo-bts-lc15/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32196/comment/763dfb56_8f946bcc PS3, Line 1851: rc = 0; > This is weird. […] It follows the logic of "for that object/msg type simply ack it", see below. https://gerrit.osmocom.org/c/osmo-bts/+/32196/comment/8c47833b_6c0857b0 PS3, Line 1854: rc = 0; > So it's fine if we get an unknown/unhandled `foh->msg_type` value? yes, this function is called for several obj_classes, so we only have specific code for those where we need to do something in lower layers, the rest we simply return 0 (ACK it). I know we could list all the messages here and the code could be better, but I cannot simply improve it all in one go, there's a lot of stuff which needs moving, etc, as you can see in this set of patches I'm submitting. I'm doing this in an iterative way since the code paths are a bit complex and used by different objects, different BTS types, etc. File src/osmo-bts-virtual/bts_model.c: https://gerrit.osmocom.org/c/osmo-bts/+/32196/comment/db027969_2217bccc PS3, Line 148: rc = 0; > Are you sure 0 is the right value here? Not `-ENOTSUP`? Yes, it's fine for now, since ideally we should be calling this for more object types. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32196 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I281c07bb5ad88ee03542f092141cebe036d10aee Gerrit-Change-Number: 32196 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:19:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: comment: fix typo 'OSMO_ASCU_'
by pespin 05 Apr '23

05 Apr '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32215 ) Change subject: comment: fix typo 'OSMO_ASCU_' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I1c0f501a7f828499c6112cab8aece20f7c34c118 Gerrit-Change-Number: 32215 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:15:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: add two value_string[]s related to N-PCSTATE
by pespin 05 Apr '23

05 Apr '23

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32214 ) Change subject: add two value_string[]s related to N-PCSTATE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I873ea30e8f64280487769668c748c67ce4ff4023 Gerrit-Change-Number: 32214 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 10:14:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: obs: wireshark: user proper OBS api url
by osmith 05 Apr '23

05 Apr '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32013 ) Change subject: obs: wireshark: user proper OBS api url ...................................................................... obs: wireshark: user proper OBS api url Set the proper https://obs.osmocom.org api URL, not "obs.osmocom.org". The latter only works on jenkins because we have set up an alias there, but not locally without setting up the same alias. Change-Id: I663ba4f137a57890ba9a2079ef3453bb7544de8b --- M scripts/obs/update_obs_wireshark.sh 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/obs/update_obs_wireshark.sh b/scripts/obs/update_obs_wireshark.sh index 3c067cf..ae66aaa 100755 --- a/scripts/obs/update_obs_wireshark.sh +++ b/scripts/obs/update_obs_wireshark.sh @@ -30,7 +30,7 @@ update_obs_project() { cd "$DIR" ./update_obs_project.py \ - --apiurl obs.osmocom.org \ + --apiurl https://obs.osmocom.org \ --docker \ --allow-unknown-package \ --git-skip-checkout \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I663ba4f137a57890ba9a2079ef3453bb7544de8b Gerrit-Change-Number: 32013 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: obs: wireshark: user proper OBS api url
by osmith 05 Apr '23

05 Apr '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32013 ) Change subject: obs: wireshark: user proper OBS api url ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32013 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I663ba4f137a57890ba9a2079ef3453bb7544de8b Gerrit-Change-Number: 32013 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 09:51:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: msc_main: close SMS db on startup error
by osmith 05 Apr '23

05 Apr '23

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32085 ) Change subject: msc_main: close SMS db on startup error ...................................................................... Patch Set 2: (2 comments) File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/9f677332_855f6882 PS2, Line 745: sms_queue_start > BTW, can we move the DB init down below? Not saying this must be done, but I think this would simpli […] I'll leave this as-is because sqlite is on its way out (https://osmocom.org/issues/5559) https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/9a34a5f8_430be071 PS2, Line 832: error_close_sms_db > AFAICS, `db_fini()` can be called at any time, even if the database is not initialized. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9bb799048db5fcdb2a2520107bd75d5f7a865459 Gerrit-Change-Number: 32085 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Apr 2023 09:33:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: msc_main: close SMS db on startup error
by osmith 05 Apr '23

05 Apr '23

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/32085 to look at the new patch set (#3). Change subject: msc_main: close SMS db on startup error ...................................................................... msc_main: close SMS db on startup error When the SMS sqlite db is opened and not closed properly, sqlite will print a trace on the next OsmoMSC startup while restoring the database. This happens when e.g. attempting to bind OsmoMSC on an IP that is not available (yet) and then restarting OsmoMSC. db.c:521 Init database connection to 'sms.db' using SQLite3 lib version 3.34.1 db.c:318 SQLITE3: (283) recovered 37 frames from WAL file /var/lib/osmocom/sms.db-wal backtrace.c:42 backtrace() returned 22 addresses backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0x36a56) [0x7f1518c00a56] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(sqlite3_log+0x9e) [0x7f1518c00b3e] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0x5f4f4) [0x7f1518c294f4] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0x5fbb3) [0x7f1518c29bb3] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0x7ee02) [0x7f1518c48e02] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0x7f908) [0x7f1518c49908] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0xb9a5f) [0x7f1518c83a5f] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0xcddac) [0x7f1518c97dac] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0xcddef) [0x7f1518c97def] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0xf537d) [0x7f1518cbf37d] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0xb479e) [0x7f1518c7e79e] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0xb79b6) [0x7f1518c819b6] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0xb8116) [0x7f1518c82116] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(+0xb853f) [0x7f1518c8253f] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(sqlite3_prepare_v2+0x16) [0x7f1518c826a6] backtrace.c:53 /lib/x86_64-linux-gnu/libsqlite3.so.0(sqlite3_exec+0xb4) [0x7f1518c8fce4] backtrace.c:53 /usr/bin/osmo-msc(+0x1bf13) [0x564f81946f13] backtrace.c:53 /usr/bin/osmo-msc(+0x524c0) [0x564f8197d4c0] backtrace.c:53 /usr/bin/osmo-msc(+0x1324e) [0x564f8193e24e] backtrace.c:53 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xea) [0x7f1518991d0a] backtrace.c:53 /usr/bin/osmo-msc(+0x13fea) [0x564f8193efea] Related: SYS#6360 Change-Id: I9bb799048db5fcdb2a2520107bd75d5f7a865459 --- M src/osmo-msc/msc_main.c 1 file changed, 61 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/85/32085/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9bb799048db5fcdb2a2520107bd75d5f7a865459 Gerrit-Change-Number: 32085 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0